Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Verilog-Perl CPAN distribution.

Report information
The Basics
Id: 47030
Status: resolved
Priority: 0/
Queue: Verilog-Perl

People
Owner: Nobody in particular
Requestors: Marek.Rouchal [...] gmx.net
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 3.210
Fixed in: (no value)



Subject: adapt Verilog::Getopt to recent releases of Getopt::Long
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1245222477-13950-795"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 333
Download (untitled) / with headers
text/plain 333b
Recent versions of Getopt::Long return objects - this causes failures in the test of SystemPerl. The root cause is a if(ref $_[0]) in Verilog::Getopt line 227, which is true for the Getopt::Long::Callback object. It seems to work OK if we test for ref and check whether the reference is an ARRAY. See the attached patch. -Marek
Subject: Verilog-Perl-patch.diff
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1245222477-13950-794"
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/octet-stream; name="Verilog-Perl-patch.diff"
Content-Disposition: inline; filename="Verilog-Perl-patch.diff"
Content-Transfer-Encoding: base64
Content-Length: 513
diff -ruN Verilog-Perl-3.210/Getopt.pm Verilog-Perl-3.210p1/Getopt.pm --- Verilog-Perl-3.210/Getopt.pm 2009-05-19 15:28:31.000000000 +0200 +++ Verilog-Perl-3.210p1/Getopt.pm 2009-06-17 08:57:42.647063000 +0200 @@ -222,7 +222,8 @@ sub depend_files { my $self = shift; if (@_) { - if (ref $_[0]) { + # recent versions of Getopt::Long return objects + if (ref($_[0]) && ref($_[0]) eq 'ARRAY') { $self->{depend_files} = {}; foreach my $fn (@{$_[0]}) { $self->{depend_files}{$fn} = 1;
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-13950-1245240242-493.47030-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 79
Fixed in 3.211 that's being uploaded now. Thanks much for sending in a patch!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.