Skip Menu |
 

This queue is for tickets about the criticism CPAN distribution.

Report information
The Basics
Id: 45907
Status: open
Priority: 0/
Queue: criticism
People
Owner: Nobody in particular
Requestors: DVWRIGHT [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.02
Fixed in: (no value)

History Show all quoted text — Show brief headers
# Sat May 09 18:10:57 2009 DVWRIGHT [...] cpan.org - Ticket created
Subject: 'requires' discrepancy
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 612
Download (untitled) / with headers
text/plain 612b
From the docs: "If you have a separate development environment, you can effectively bypass the criticism pragma by not installing Perl::Critic in the production environment. If Perl::Critic can't be loaded, then criticism just fails silently." From Build.pm: requires => { 'Perl::Critic' => 1.089 }, Am I missing something? If criticism requires Perl::Critic, then how can one install it (criticism), without installing Perl::Critic? Shouldn't the Build/Makefile be changed from requires to 'Suggests' (or something stronger, such as (the non-existant, "Pleeds" =>) :) Thanks, David
# Mon May 11 18:35:15 2009 thaljef [...] cpan.org - Correspondence added
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-4108-1242081315-1277.45907-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 710
Download (untitled) / with headers
text/plain 710b
On Sat May 09 18:10:57 2009, DVWRIGHT wrote: Show quoted text
> Am I missing something? If criticism requires Perl::Critic, then how can > one install it (criticism), without installing Perl::Critic?
Good question. I hadn't really thought about it until now. At the moment, you have a couple options: * If using the cpan(1) utility, use the "force" option to install it without dependencies. * Install manually, using "perl Build.PL; ./Build install" or equivalent. Alternatively, I could modify the build process to ask you if you also want to install Perl-Critic. The default would be "yes" so if you want to do this automatically, you'd need to configure it with your distro-prefs. What do you think of that? -Jeff
# Mon May 11 18:35:16 2009 The RT System itself - Status changed from 'new' to 'open'
# Wed May 13 02:51:54 2009 DVWRIGHT [...] cpan.org - Correspondence added
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-4108-1242081315-1277.45907-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
References: <rt-3.6.HEAD-4108-1242081315-1277.45907-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-4108-1242197514-1651.45907-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1701
Download (untitled) / with headers
text/plain 1.6k
On Mon May 11 18:35:15 2009, THALJEF wrote: Show quoted text
> On Sat May 09 18:10:57 2009, DVWRIGHT wrote: >
> > Am I missing something? If criticism requires Perl::Critic, then how can > > one install it (criticism), without installing Perl::Critic?
> > Good question. I hadn't really thought about it until now. At the > moment, you have a couple options: > > * If using the cpan(1) utility, use the "force" option to install it > without dependencies. > > * Install manually, using "perl Build.PL; ./Build install" or equivalent. > > Alternatively, I could modify the build process to ask you if you also > want to install Perl-Critic. The default would be "yes" so if you want > to do this automatically, you'd need to configure it with your distro-prefs. > > What do you think of that? > > -Jeff
I would rather that the build process was modified to be a 'suggests' with some sort of warning when Perl-Critic is not installed, "NOTICE: Perl-Critic is not installed, this module is disabled", or something to that effect. One downside to this approach is that when one has 'use criticism' in their code and receives no warnings, one may believe 'all's well'. (when in fact in may not be). Maybe for that case there could be a flag of some sort, 'use criticism qw/brutal verbose/'. 'verbose' which would warn 'Perl-Critic not installed', along with the 'normal'/expected code execution. I realize that without Perl-Critic, criticism has no function, but to look at it from another perspective. I think the point is that one doesn't want the overhead (or potential 'style' warnings,...) in a production environment, this is a tool for developers. (not sys admins) Thoughts? Thanks, David
# Wed May 13 03:40:25 2009 jeff [...] imaginative-software.com - Correspondence added
MIME-Version: 1.0 (Apple Message framework v930.3)
X-Spam-Status: No, hits=0.0 required=8.0 tests=
In-Reply-To: <rt-3.6.HEAD-4108-1242197514-1651.45907-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.930.3)
References: <RT-Ticket-45907 [...] rt.cpan.org> <rt-3.6.HEAD-4108-1242081315-1277.45907-5-0 [...] rt.cpan.org> <rt-3.6.HEAD-4108-1242197514-1651.45907-5-0 [...] rt.cpan.org>
Message-ID: <44EB7BF2-F885-4866-905D-EE8143ECAE34 [...] imaginative-software.com>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id CCDAA23C109 for <bug-criticism [...] rt.cpan.org>; Wed, 13 May 2009 03:40:14 -0400 (EDT)
Received: (qmail 11090 invoked by uid 103); 13 May 2009 07:40:14 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 13 May 2009 07:40:14 -0000
Received: from wa-out-1112.google.com (HELO wa-out-1112.google.com) (209.85.146.183) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 13 May 2009 00:40:08 -0700
Received: by wa-out-1112.google.com with SMTP id m16so185986waf.13 for <bug-criticism [...] rt.cpan.org>; Wed, 13 May 2009 00:40:04 -0700 (PDT)
Received: by 10.115.32.8 with SMTP id k8mr602869waj.54.1242200404583; Wed, 13 May 2009 00:40:04 -0700 (PDT)
Received: from ?10.0.1.2? (c-67-160-236-81.hsd1.ca.comcast.net [67.160.236.81]) by mx.google.com with ESMTPS id y25sm3329190pod.1.2009.05.13.00.40.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 13 May 2009 00:40:03 -0700 (PDT)
Delivered-To: cpan-bug+criticism [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #45907] 'requires' discrepancy
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-criticism [...] rt.cpan.org
Date: Wed, 13 May 2009 00:40:01 -0700
X-Spam-Level: *
To: bug-criticism [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
RT-Message-ID: <rt-3.6.HEAD-4108-1242200425-1144.45907-0-0 [...] rt.cpan.org>
Content-Length: 1664
Download (untitled) / with headers
text/plain 1.6k
On May 12, 2009, at 11:51 PM, David Wright via RT wrote: Show quoted text
> I would rather that the build process was modified to be a > 'suggests' with some sort of > warning when Perl-Critic is not installed, "NOTICE: Perl-Critic is > not installed, this module is > disabled", or something to that effect.
Will do. Show quoted text
> One downside to this approach is that when one has 'use criticism' > in their code and receives > no warnings, one may believe 'all's well'. (when in fact in may not > be). > > Maybe for that case there could be a flag of some sort, 'use > criticism qw/brutal verbose/'. > 'verbose' which would warn 'Perl-Critic not installed', along with > the 'normal'/expected code > execution.
Do you really want your users to see this warning every time they run something in production? Show quoted text
> I realize that without Perl-Critic, criticism has no function, but > to look at it from another > perspective. I think the point is that one doesn't want the overhead > (or potential 'style' > warnings,...) in a production environment, this is a tool for > developers. (not sys admins)
Personally, I wouldn't recommend using the criticism pragma at all. The no-op behavior when Perl-Critic is not installed just creates an extra degree of freedom between your development and production environments, which results in another variable in the equation when you're trying to reproduce bugs. As you said, Perl-Critic is a development tool, so it should be run only at development-time. So I'd recommend using Test::Perl::Critic or Test::Perl::Critic::Progressive instead, and make Perl-Critic part of your unit tests. Is that an option for you?
# Wed May 13 04:04:32 2009 DVWRIGHT [...] cpan.org - Correspondence added
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-4108-1242200425-1144.45907-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
References: <RT-Ticket-45907 [...] rt.cpan.org> <rt-3.6.HEAD-4108-1242081315-1277.45907-5-0 [...] rt.cpan.org> <rt-3.6.HEAD-4108-1242197514-1651.45907-5-0 [...] rt.cpan.org> <44EB7BF2-F885-4866-905D-EE8143ECAE34 [...] imaginative-software.com> <rt-3.6.HEAD-4108-1242200425-1144.45907-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-4108-1242201872-1966.45907-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 626
Download (untitled) / with headers
text/plain 626b
Show quoted text
> Do you really want your users to see this warning every time they run > something in production?
Nope. (I was assuming the commenting out 'verbose', but that's not realistic) Show quoted text
> As you said, Perl-Critic is a development tool, so it should be run > only at development-time. > So I'd recommend using Test::Perl::Critic or > Test::Perl::Critic::Progressive instead, and > make Perl-Critic part of your unit tests. Is that an option for you?
Yes, that is a very good suggestion, thanks. I really liked criticism because it was clean, quick and easy. (I didn't want 'another' pref/conf env file to worry about).
# Wed May 13 04:45:12 2009 jeff [...] imaginative-software.com - Correspondence added
MIME-Version: 1.0 (Apple Message framework v930.3)
X-Spam-Status: No, hits=0.0 required=8.0 tests=
In-Reply-To: <rt-3.6.HEAD-4108-1242201872-1966.45907-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.930.3)
References: <RT-Ticket-45907 [...] rt.cpan.org> <rt-3.6.HEAD-4108-1242081315-1277.45907-5-0 [...] rt.cpan.org> <rt-3.6.HEAD-4108-1242197514-1651.45907-5-0 [...] rt.cpan.org> <44EB7BF2-F885-4866-905D-EE8143ECAE34 [...] imaginative-software.com> <rt-3.6.HEAD-4108-1242200425-1144.45907-5-0 [...] rt.cpan.org> <rt-3.6.HEAD-4108-1242201872-1966.45907-5-0 [...] rt.cpan.org>
Message-ID: <A44105FB-C188-46E4-85A5-B5167648E521 [...] imaginative-software.com>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id BC6DE23C109 for <bug-criticism [...] rt.cpan.org>; Wed, 13 May 2009 04:43:00 -0400 (EDT)
Received: (qmail 22097 invoked by uid 103); 13 May 2009 08:42:59 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 13 May 2009 08:42:59 -0000
Received: from mail-pz0-f115.google.com (HELO mail-pz0-f115.google.com) (209.85.222.115) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 13 May 2009 01:42:53 -0700
Received: by pzk13 with SMTP id 13so180473pzk.33 for <bug-criticism [...] rt.cpan.org>; Wed, 13 May 2009 01:42:50 -0700 (PDT)
Received: by 10.142.216.18 with SMTP id o18mr266962wfg.251.1242204170183; Wed, 13 May 2009 01:42:50 -0700 (PDT)
Received: from ?10.0.1.2? (c-67-160-236-81.hsd1.ca.comcast.net [67.160.236.81]) by mx.google.com with ESMTPS id 30sm2066085wfg.10.2009.05.13.01.42.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 13 May 2009 01:42:49 -0700 (PDT)
Delivered-To: cpan-bug+criticism [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #45907] 'requires' discrepancy
Return-Path: <jeff [...] imaginative-software.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-criticism [...] rt.cpan.org
Date: Wed, 13 May 2009 01:42:45 -0700
X-Spam-Level: *
To: bug-criticism [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
RT-Message-ID: <rt-3.6.HEAD-4108-1242204312-747.45907-0-0 [...] rt.cpan.org>
Content-Length: 530
Download (untitled) / with headers
text/plain 530b
On May 13, 2009, at 1:04 AM, David Wright via RT wrote: Show quoted text
> > I really liked criticism because it was clean, quick and easy. (I > didn't want 'another' pref/conf > env file to worry about).
I can appreciate that. Hopefully, we've done a good job of keeping the config language down to a minimum. Also, be sure to take a look at the --profile-prototype option on perlcritic(1). That may save you some typing. Also, the --only switch is useful if you're only going to run a few hand-picked policies. Hope that helps :]

This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.