Skip Menu |
 

This queue is for tickets about the Config-Auto CPAN distribution.

Report information
The Basics
Id: 45863
Status: open
Priority: 0/
Queue: Config-Auto

People
Owner: Nobody in particular
Requestors: MARKSTOS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: 0.29_02



Subject: change to eval_perl implementation is not backcompat
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 589
Download (untitled) / with headers
text/plain 589b
I like the new change from Lyle Hopkins to only load modules if they are needed. Thanks for that. However, the current dev release 0.29_2 quits working for me because of the re-implementation of eval_perl. I had a config file like this: %CFG = ( a => 'b' ); \%CFG; ### The old implementation with "do" ran this in it's own scope, and all was good. The new implementation with eval "foo" runs this in the lexical scope of the subroutine in Config::Auto, and then dies because these are considered global variables. I suggest reverting the old behavior for backcompat. Mark
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-26542-1269270921-1285.45863-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 704
Download (untitled) / with headers
text/plain 704b
On Fri May 08 11:35:42 2009, MARKSTOS wrote: Show quoted text
> I like the new change from Lyle Hopkins to only load modules if they are > needed. Thanks for that. > > However, the current dev release 0.29_2 quits working for me because of > the re-implementation of eval_perl. I had a config file like this: > > %CFG = ( > a => 'b' > ); > > \%CFG; > > ### > > The old implementation with "do" ran this in it's own scope, and all was > good. > > The new implementation with eval "foo" runs this in the lexical scope of > the subroutine in Config::Auto, and then dies because these are > considered global variables. > > I suggest reverting the old behavior for backcompat.
Would you accept a patch for this?
From chris [...] bingosnet.co.uk Mon Mar 29 11: 24:23 2010
CC: undisclosed-recipients: ;
MIME-Version: 1.0
X-Spam-Status: No, score=-10.599 tagged_above=-99.9 required=10 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-26542-1269270921-1078.45863-5-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
References: <RT-Ticket-45863 [...] rt.cpan.org> <rt-3.8.HEAD-26542-1269270921-1078.45863-5-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20100329152425.GA9657 [...] klanker.bingosnet.co.uk>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO"
X-Spam-Score: -10.599
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8A84D240584 for <cpan-bug+Config-Auto [...] hipster.bestpractical.com>; Mon, 29 Mar 2010 11:24:23 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WgwquEIRYtMu for <cpan-bug+Config-Auto [...] hipster.bestpractical.com>; Mon, 29 Mar 2010 11:24:20 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 4FBDC240573 for <bug-Config-Auto [...] rt.cpan.org>; Mon, 29 Mar 2010 11:24:19 -0400 (EDT)
Received: (qmail 20399 invoked by uid 103); 29 Mar 2010 15:24:38 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 29 Mar 2010 15:24:38 -0000
Received: from anchor-post-2.mail.demon.net (HELO anchor-post-2.mail.demon.net) (195.173.77.133) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Mon, 29 Mar 2010 08:24:29 -0700
Received: from kidney-bingos.demon.co.uk ([62.49.18.107] helo=klanker.bingosnet.co.uk) by anchor-post-2.mail.demon.net with esmtp (Exim 4.69) id 1NwGpG-0000Ad-kd for bug-Config-Auto [...] rt.cpan.org; Mon, 29 Mar 2010 15:24:26 +0000
Received: from klanker.bingosnet.co.uk (IDENT:1000 [...] localhost [127.0.0.1]) by klanker.bingosnet.co.uk (8.12.4/8.12.4) with ESMTP id o2TFOQFT009670 for <bug-Config-Auto [...] rt.cpan.org>; Mon, 29 Mar 2010 16:24:26 +0100
Received: (from chris [...] localhost) by klanker.bingosnet.co.uk (8.12.4/8.12.4/Submit) id o2TFOPB4009669 for bug-Config-Auto [...] rt.cpan.org; Mon, 29 Mar 2010 16:24:25 +0100
Delivered-To: cpan-bug+Config-Auto [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #45863] change to eval_perl implementation is not backcompat
User-Agent: Mutt/1.4i
Return-Path: <chris [...] bingosnet.co.uk>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+Config-Auto [...] hipster.bestpractical.com
X-RT-Mail-Extension: config-auto
Date: Mon, 29 Mar 2010 16:24:25 +0100
X-Spam-Level:
To: MARKSTOS via RT <bug-Config-Auto [...] rt.cpan.org>
From: "Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>
RT-Message-ID: <rt-3.8.HEAD-26542-1269876283-1062.45863-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1029
On Mon, Mar 22, 2010 at 11:15:21AM -0400, MARKSTOS via RT wrote: Show quoted text
> Queue: Config-Auto > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=45863 > > > On Fri May 08 11:35:42 2009, MARKSTOS wrote:
> > I like the new change from Lyle Hopkins to only load modules if they are > > needed. Thanks for that. > > > > However, the current dev release 0.29_2 quits working for me because of > > the re-implementation of eval_perl. I had a config file like this: > > > > %CFG = ( > > a => 'b' > > ); > > > > \%CFG; > > > > ### > > > > The old implementation with "do" ran this in it's own scope, and all was > > good. > > > > The new implementation with eval "foo" runs this in the lexical scope of > > the subroutine in Config::Auto, and then dies because these are > > considered global variables. > > > > I suggest reverting the old behavior for backcompat.
> > Would you accept a patch for this? >
Sure. -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================
Content-Type: application/pgp-signature
Content-Disposition: inline
Content-Length: 189
Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.