Skip Menu |
 

This queue is for tickets about the Glib CPAN distribution.

Report information
The Basics
Id: 45685
Status: resolved
Priority: 0/
Queue: Glib

People
Owner: Nobody in particular
Requestors: punya [...] cs.washington.edu
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=DK_SIGNED,SPF_PASS
content-type: text/plain; charset="utf-8"
Message-ID: <51a999440905040117j33b611b6y2f8d307d54c8ef12 [...] mail.gmail.com>
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 4785C63C570 for <bug-Glib [...] rt.cpan.org>; Mon, 4 May 2009 04:17:17 -0400 (EDT)
Received: (qmail 29891 invoked by uid 103); 4 May 2009 08:17:16 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 4 May 2009 08:17:16 -0000
Received: from an-out-0708.google.com (HELO an-out-0708.google.com) (209.85.132.251) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Mon, 04 May 2009 01:17:10 -0700
Received: by an-out-0708.google.com with SMTP id b38so2332004ana.3 for <bug-Glib [...] rt.cpan.org>; Mon, 04 May 2009 01:17:04 -0700 (PDT)
Received: by 10.100.44.4 with SMTP id r4mr12254994anr.157.1241425024504; Mon, 04 May 2009 01:17:04 -0700 (PDT)
Delivered-To: cpan-bug+Glib [...] diesel.bestpractical.com
Subject: Glib::MakeHelper::postamble_docs_full fails to escape / in copyright
Return-Path: <punya.biswal [...] gmail.com>
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; b=xXN01KzANeyMFdus5cGL7PVtpZF3Rv2cTgIdumyoHR+G4URSsq7mf9afBXuwJ4AQmP DMe/VwR7ur96UwtJcm+EhSZqwh+90GYicpNiFnCNVYsZcydYSDbDIiojJcrszGhYcJ4/ b6n5e/WOglHdw6bBOQt6a5AQOq94d6WRytQYE=
X-Original-To: bug-Glib [...] rt.cpan.org
X-Spam-Check-BY: 16.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=tlbUlxKnziMvG2MIZzfzVwqFZ7y0hNS39JHwJc2y6lk=; b=iK8WakLYgu7EFdvFpBl+7D5nUzt+hhY0kcB20RcUarGGfgu/UH8wv4oSUZ4G69Xv1A eNt0BvkHzDMVpYpb6OwqCTgpo0WAeiT8+8Pv1bUDSpzz+UxSCZGNu4dXMopck6lGi07K 1soxRh31N55n9Z6zXnehiD0M0q4w8cKCKf4KQ=
X-Google-Sender-Auth: a81f02b1e62dcc55
Sender: punya.biswal [...] gmail.com
Date: Mon, 4 May 2009 01:17:04 -0700
X-Spam-Level: *
To: bug-Glib [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Punyashloka Biswal <punya [...] cs.washington.edu>
X-RT-Original-Encoding: ISO-8859-1
Content-Length: 797
Download (untitled) / with headers
text/plain 797b
Distribution: Glib-1.221 Perl: 5.10.0 Platform: Linux ubuntu 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux Between Glib-1.220 and Glib-1.221, Glib::MakeHelper::postamble_docs_full switched from braces to forward slashes to quote the copyright string in the command it generates for inclusion in the Makefile. Unfortunately, it doesn't escape forward slashes inside the copyright string, which has the unfortunate consequence that the string literal terminates prematurely. Then perl tries to interpret the remaining text after the forward slash, and fails with an error. I noticed this bug while dealing with the GNU-style copyright for Clutter, which uses the expression "and/or." I imagine lots of similar copyright messages exist in other distributions. Punya
MIME-Version: 1.0
In-Reply-To: <51a999440905040117j33b611b6y2f8d307d54c8ef12 [...] mail.gmail.com>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Charset: utf8
References: <51a999440905040117j33b611b6y2f8d307d54c8ef12 [...] mail.gmail.com>
Content-Type: multipart/mixed; boundary="----------=_1244312834-13950-215"
Message-ID: <rt-3.6.HEAD-13950-1244312834-1435.45685-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
RT-Send-CC: 11285613 [...] nwu.ac.za
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 994
Download (untitled) / with headers
text/plain 994b
On Mon May 04 04:17:34 2009, punya@cs.washington.edu wrote: Show quoted text
> Between Glib-1.220 and Glib-1.221, > Glib::MakeHelper::postamble_docs_full switched from braces to forward > slashes to quote the copyright string in the command it generates for > inclusion in the Makefile. Unfortunately, it doesn't escape forward > slashes inside the copyright string, which has the unfortunate > consequence that the string literal terminates prematurely. Then perl > tries to interpret the remaining text after the forward slash, and > fails with an error. > > I noticed this bug while dealing with the GNU-style copyright for > Clutter, which uses the expression "and/or." I imagine lots of similar > copyright messages exist in other distributions.
Ah, yeah. I introduced this bug while trying to fix a related issue with dmake: <http://bugzilla.gnome.org/show_bug.cgi?id=573099>. Does the attached patch fix the problem? Martin, can you try this patch on MSWin32 with dmake and, if possible, with nmake?
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: multipart/mixed; boundary="----------=_1244312834-13950-214"
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: text/x-diff; name="copyright-quote-slashes.patch"
Content-Disposition: inline; filename="copyright-quote-slashes.patch"
Content-Transfer-Encoding: binary
Content-Length: 421
diff --git a/MakeHelper.pm b/MakeHelper.pm index 015fcb2..568ef93 100644 --- a/MakeHelper.pm +++ b/MakeHelper.pm @@ -362,6 +362,7 @@ sub postamble_docs_full { if ($copyright) { # this text has to be escaped for both make and the shell. $copyright =~ s/\n/\\n/gm; # collapse to one line. + $copyright =~ s|/|\\/|g; # escape slashes for qq// $copyright = "Glib::GenPod::set_copyright(qq/$copyright/);"; }
MIME-Version: 1.0
X-Spam-Status: No, hits=-0.0 required=8.0 tests=SPF_PASS
In-Reply-To: <rt-3.6.HEAD-13950-1244312834-1435.45685-7-0 [...] rt.cpan.org>
X-Mailer: Novell GroupWise Internet Agent 7.0.2 HP
Content-Disposition: inline
Received-SPF: pass (utl-lnx3.nwu.ac.za: domain of 11285613 [...] nwu.ac.za designates 143.160.32.6 as permitted sender) receiver=utl-lnx3.nwu.ac.za; client-ip=143.160.32.6; helo=groupwise.puk.ac.za; envelope-from=11285613 [...] nwu.ac.za; x-software=spfmilter 0.97 http://www.acme.com/software/spfmilter/ with libspf2-1.0.0;
References: <RT-Ticket-45685 [...] rt.cpan.org> <51a999440905040117j33b611b6y2f8d307d54c8ef12 [...] mail.gmail.com> <rt-3.6.HEAD-13950-1244312834-1435.45685-7-0 [...] rt.cpan.org>
Message-ID: <4A3A6676.3D93.006F.0 [...] nwu.ac.za>
Content-Type: text/plain; charset="utf-8"
X-Virus-Scanned: clamav-milter 0.95.1 at utl-lnx3
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id 279F44D81CD for <bug-Glib [...] rt.cpan.org>; Thu, 18 Jun 2009 10:09:26 -0400 (EDT)
Received: (qmail 13520 invoked by uid 103); 18 Jun 2009 14:09:26 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 18 Jun 2009 14:09:26 -0000
Received: from utl-lnx3.nwu.ac.za (HELO utl-lnx3.nwu.ac.za) (143.160.36.166) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Thu, 18 Jun 2009 07:09:19 -0700
Received: from groupwise.puk.ac.za (groupwise.puk.ac.za [143.160.32.6]) by utl-lnx3.nwu.ac.za (8.13.8/8.13.8) with ESMTP id n5IE99Xs030831 for <bug-Glib [...] rt.cpan.org>; Thu, 18 Jun 2009 16:09:10 +0200
Received: from PUKGWIA-MTA by groupwise.puk.ac.za with Novell_GroupWise; Thu, 18 Jun 2009 16:09:09 +0200
Delivered-To: cpan-bug+Glib [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #45685] Glib::MakeHelper::postamble_docs_full fails to escape / in copyright
Return-Path: <Martin.Schlemmer [...] nwu.ac.za>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Glib [...] rt.cpan.org
Date: Thu, 18 Jun 2009 16:08:22 +0200
X-Spam-Level: *
X-Virus-Status: Clean
To: <bug-Glib [...] rt.cpan.org>
Content-Transfer-Encoding: quoted-printable
From: "Martin Schlemmer" <Martin.Schlemmer [...] nwu.ac.za>
RT-Message-ID: <rt-3.6.HEAD-13950-1245334185-229.45685-0-0 [...] rt.cpan.org>
Content-Length: 1631
Download (untitled) / with headers
text/plain 1.5k
Show quoted text
>>> On 6/6/2009 at 8:27 PM, "Torsten Schoenfeld via RT" <bug-Glib@rt.cpan.org>
wrote: <> URL: https://rt.cpan.org/Ticket/Display.html?id=45685 > Show quoted text
> > On Mon May 04 04:17:34 2009, punya@cs.washington.edu wrote:
>> Between Glib-1.220 and Glib-1.221, >> Glib::MakeHelper::postamble_docs_full switched from braces to forward >> slashes to quote the copyright string in the command it generates for >> inclusion in the Makefile. Unfortunately, it doesn't escape forward >> slashes inside the copyright string, which has the unfortunate >> consequence that the string literal terminates prematurely. Then perl >> tries to interpret the remaining text after the forward slash, and >> fails with an error. >> >> I noticed this bug while dealing with the GNU-style copyright for >> Clutter, which uses the expression "and/or." I imagine lots of similar >> copyright messages exist in other distributions.
> > Ah, yeah. I introduced this bug while trying to fix a related issue > with dmake: <http://bugzilla.gnome.org/show_bug.cgi?id=573099>. Does > the attached patch fix the problem? > > Martin, can you try this patch on MSWin32 with dmake and, if possible, > with nmake?
Sorry for taking so long. I tested the patch with dmake, and it works fine. With nmake I have yet to get things to link properly, but I manually copied the DLL and it also work fine. PS: With ExtUtils-MakeMaker-6.52 (ActivePerl 5.10.0.1005) at least it does not seem to build the documentation automatically - I have to issue an: dmake blib\lib\Glib\index.pod to get it to do the right thing. (Same with Gtk2, etc. using the doc stuff) Regards, M
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-13950-1245334185-229.45685-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
References: <RT-Ticket-45685 [...] rt.cpan.org> <51a999440905040117j33b611b6y2f8d307d54c8ef12 [...] mail.gmail.com> <rt-3.6.HEAD-13950-1244312834-1435.45685-7-0 [...] rt.cpan.org> <4A3A6676.3D93.006F.0 [...] nwu.ac.za> <rt-3.6.HEAD-13950-1245334185-229.45685-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-25318-1246727967-1217.45685-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 611
Download (untitled) / with headers
text/plain 611b
On Thu Jun 18 10:09:45 2009, azarah wrote: Show quoted text
> I tested the patch with dmake, and it works fine. With nmake I have > yet to get > things to link properly, but I manually copied the DLL and it also > work fine.
Thanks for testing. I just committed the change. Show quoted text
> PS: With ExtUtils-MakeMaker-6.52 (ActivePerl 5.10.0.1005) at least it > does not seem > to build the documentation automatically - I have to issue an: > > dmake blib\lib\Glib\index.pod > > to get it to do the right thing. (Same with Gtk2, etc. using the doc > stuff)
Filed as a separate bug: <http://bugzilla.gnome.org/show_bug.cgi?id=587760>.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.