Skip Menu |
 

This queue is for tickets about the Sys-Syslog CPAN distribution.

Report information
The Basics
Id: 44410
Status: resolved
Priority: 0/
Queue: Sys-Syslog

People
Owner: Nobody in particular
Requestors: info [...] gknw.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.28



Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 859CC19B809A for <bug-Sys-Syslog [...] rt.cpan.org>; Thu, 19 Mar 2009 02:14:28 -0400 (EDT)
Received: (qmail 11620 invoked by uid 103); 19 Mar 2009 06:14:27 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 19 Mar 2009 06:14:27 -0000
Received: from mx03.dns-factory.at (HELO dns-factory.at) (194.242.35.75) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Wed, 18 Mar 2009 23:14:25 -0700
Received: from [172.17.100.14] gk [...] gknw.de [94.220.57.227] by dns-factory.at with NetMail SMTP Agent $Revision: 8582 $ on Novell NetWare via secured & encrypted transport (TLS); Thu, 19 Mar 2009 01:59:31 +0100
Delivered-To: cpan-bug+Sys-Syslog [...] diesel.bestpractical.com
Subject: Syslog.pm does not match Syslog.xs for LOG_UPTO usage
MIME-Version: 1.0
User-Agent: Thunderbird 2.0.0.19 (X11/20081227)
X-Spam-Status: No, hits=0.0 required=8.0 tests=
Return-Path: <info [...] gknw.de>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Sys-Syslog [...] rt.cpan.org
Date: Thu, 19 Mar 2009 01:59:26 +0100
X-Spam-Level: *
content-type: text/plain; charset="utf-8"
Message-ID: <49C198EE.6050000 [...] gknw.de>
To: bug-Sys-Syslog [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Guenter Knauf <info [...] gknw.de>
X-RT-Original-Encoding: ISO-8859-15
Content-Length: 838
Download (untitled) / with headers
text/plain 838b
Hi, While Syslog.xs has a conditional for LOG_UPTO at line 95ff, Syslog.pm uses it unconditionally at line 98; this renders the whole module useless when the LOG_UPTO macro is not defined in the OS headers: perl -mSys::Syslog -e 'print $Sys::Syslog::VERSION' Your vendor has not defined the Sys::Syslog macro LOG_UPTO at sys:\perl\lib/Sys/Syslog.pm line 98. I think if Syslog.pm requires LOG_UPTO from Syslog.xs then its nonsense to have a conditonal in the xs file which checks for presense of the LOG_UPTO macro - why should I build a module only for having it croak directly when it loads? Then its far better that it breaks at compile time so I know that the module isnt usable at all. Either make compilation break when mandatory system header macros are missing, or rewrite Syslog.pm so that they are not mandatory. Thanks, Guen.
MIME-Version: 1.0 (Apple Message framework v753.1)
X-Spam-Status: No, hits=1.8 required=8.0 tests=MIME_QP_LONG_LINE
In-Reply-To: <rt-3.6.HEAD-10363-1237443280-686.44410-4-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.753.1)
References: <RT-Ticket-44410 [...] rt.cpan.org> <49C198EE.6050000 [...] gknw.de> <rt-3.6.HEAD-10363-1237443280-686.44410-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
Message-ID: <86D47998-5DC1-4970-8C01-2BE10E84BD0B [...] cpan.org>
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 9078463CCA1 for <bug-Sys-Syslog [...] rt.cpan.org>; Thu, 19 Mar 2009 04:01:26 -0400 (EDT)
Received: (qmail 10376 invoked by uid 103); 19 Mar 2009 08:01:25 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 19 Mar 2009 08:01:25 -0000
Received: from smtp1-g21.free.fr (HELO smtp1-g21.free.fr) (212.27.42.1) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Thu, 19 Mar 2009 01:01:22 -0700
Received: from smtp1-g21.free.fr (localhost [127.0.0.1]) by smtp1-g21.free.fr (Postfix) with ESMTP id 6E20394009A for <bug-Sys-Syslog [...] rt.cpan.org>; Thu, 19 Mar 2009 09:01:14 +0100 (CET)
Received: from [192.168.1.100] (ant06-1-82-242-109-222.fbx.proxad.net [82.242.109.222]) by smtp1-g21.free.fr (Postfix) with ESMTP id 73BB1940111 for <bug-Sys-Syslog [...] rt.cpan.org>; Thu, 19 Mar 2009 09:01:12 +0100 (CET)
Delivered-To: cpan-bug+Sys-Syslog [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #44410] Syslog.pm does not match Syslog.xs for LOG_UPTO usage
Return-Path: <saper [...] cpan.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Sys-Syslog [...] rt.cpan.org
Date: Thu, 19 Mar 2009 09:01:10 +0100
X-Spam-Level: *
To: bug-Sys-Syslog [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-25907-1237449692-358.44410-0-0 [...] rt.cpan.org>
Content-Length: 680
Download (untitled) / with headers
text/plain 680b
Guenter Knauf wrote via RT: Show quoted text
> Hi, > While Syslog.xs has a conditional for LOG_UPTO at line 95ff, Syslog.pm > uses it unconditionally at line 98; this renders the whole module > useless when the LOG_UPTO macro is not defined in the OS headers: > perl -mSys::Syslog -e 'print $Sys::Syslog::VERSION' > Your vendor has not defined the Sys::Syslog macro LOG_UPTO at > sys:\perl\lib/Sys/Syslog.pm line 98.
What is your system? I never saw a system where LOG_UPTO() isn't defined, and I never saw such an error in CPAN Testers reports: » http://bbbike.radzeit.de/~slaven/cpantestersmatrix.cgi?dist=Sys- Syslog -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.
MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=
In-Reply-To: <rt-3.6.HEAD-25907-1237449692-358.44410-6-0 [...] rt.cpan.org>
References: <RT-Ticket-44410 [...] rt.cpan.org> <49C198EE.6050000 [...] gknw.de> <rt-3.6.HEAD-10363-1237443280-686.44410-4-0 [...] rt.cpan.org> <86D47998-5DC1-4970-8C01-2BE10E84BD0B [...] cpan.org> <rt-3.6.HEAD-25907-1237449692-358.44410-6-0 [...] rt.cpan.org>
Message-ID: <49C4E9B9.5020905 [...] gknw.de>
Content-Type: text/plain; charset=UTF-8
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 12DB34D80E7 for <bug-Sys-Syslog [...] rt.cpan.org>; Sat, 21 Mar 2009 09:21:17 -0400 (EDT)
Received: (qmail 19736 invoked by uid 103); 21 Mar 2009 13:21:16 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 21 Mar 2009 13:21:16 -0000
Received: from mx03.dns-factory.at (HELO dns-factory.at) (194.242.35.75) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Sat, 21 Mar 2009 06:21:13 -0700
Received: from [172.17.100.14] gk [...] gknw.de [94.220.150.252] by dns-factory.at with NetMail SMTP Agent $Revision: 8582 $ on Novell NetWare via secured & encrypted transport (TLS); Sat, 21 Mar 2009 14:21:00 +0100
Delivered-To: cpan-bug+Sys-Syslog [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #44410] Syslog.pm does not match Syslog.xs for LOG_UPTO usage
User-Agent: Thunderbird 2.0.0.19 (X11/20081227)
Return-Path: <info [...] gknw.de>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Sys-Syslog [...] rt.cpan.org
Date: Sat, 21 Mar 2009 14:20:57 +0100
X-Spam-Level: *
To: bug-Sys-Syslog [...] rt.cpan.org
Content-Transfer-Encoding: 8bit
From: Guenter Knauf <info [...] gknw.de>
RT-Message-ID: <rt-3.6.HEAD-25907-1237641685-1572.44410-0-0 [...] rt.cpan.org>
Content-Length: 1733
Download (untitled) / with headers
text/plain 1.6k
Hi Sébastien, Sébastien Aperghis-Tramoni via RT schrieb: Show quoted text
Show quoted text
> What is your system? I never saw a system where LOG_UPTO() isn't > defined, and I never saw such an error in CPAN Testers reports: > » http://bbbike.radzeit.de/~slaven/cpantestersmatrix.cgi?dist=Sys- > Syslog
The system is Novell NetWare, and LOG_UPTO() is definitely missing in the system headers; however that's not the point: if I would get aware of the fact that LOG_UPTO() is mandatory for Sys::Syslog to get it working already during build stage I would either decide to fix the headers myself and add this macro, or to exclude Sys::Syslog from the build; but now the situation is that I can just build fine but end up with an unusable module, and find this only at testing/usage stage. So I would suggest that you change the check for LOG_UPTO defined in Syslog.xs to something like: #ifndef LOG_UPTO #error LOG_UPTO is mandatory for Sys::Syslog and it doesnt work without! #endif The croak() which is currently in the code would only make sense if I would be able to use other functionality of Sys::Syslog which dont rely on LOG_UPTO, but this is appearently not the case since it croaks already when loading only. Furthermore I guess that same goes for LOG_MASK, so probably best would be something like that directly at the beginning of Syslog.xs: /* LOG_MASK and LOG_UPTO macros are mandatory for this module! */ #if !defined(LOG_UPTO) || !defined(LOG_MASK) #error LOG_MASK and LOG_UPTO are mandatory for Sys::Syslog and this module does not work without these macros defined! #endif Then also the code would be more clean, and free of unnecessary ifdefs in the middle of the code. Guenter.
MIME-Version: 1.0 (Apple Message framework v753.1)
X-Spam-Status: No, hits=0.0 required=8.0 tests=
In-Reply-To: <rt-3.6.HEAD-25907-1237641685-1572.44410-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.753.1)
References: <RT-Ticket-44410 [...] rt.cpan.org> <49C198EE.6050000 [...] gknw.de> <rt-3.6.HEAD-10363-1237443280-686.44410-4-0 [...] rt.cpan.org> <86D47998-5DC1-4970-8C01-2BE10E84BD0B [...] cpan.org> <rt-3.6.HEAD-25907-1237449692-358.44410-6-0 [...] rt.cpan.org> <49C4E9B9.5020905 [...] gknw.de> <rt-3.6.HEAD-25907-1237641685-1572.44410-5-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
Message-ID: <47C38BB4-6465-4A75-AD73-7104FE6345D7 [...] cpan.org>
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by diesel.bestpractical.com (Postfix) with SMTP id B6E804D819F for <bug-Sys-Syslog [...] rt.cpan.org>; Tue, 24 Mar 2009 20:32:22 -0400 (EDT)
Received: (qmail 13433 invoked by uid 103); 25 Mar 2009 00:32:21 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 25 Mar 2009 00:32:21 -0000
Received: from smtp1-g21.free.fr (HELO smtp1-g21.free.fr) (212.27.42.1) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Tue, 24 Mar 2009 17:32:19 -0700
Received: from smtp1-g21.free.fr (localhost [127.0.0.1]) by smtp1-g21.free.fr (Postfix) with ESMTP id 9ED3B940049 for <bug-Sys-Syslog [...] rt.cpan.org>; Wed, 25 Mar 2009 01:32:12 +0100 (CET)
Received: from [192.168.1.100] (ant06-1-82-242-109-222.fbx.proxad.net [82.242.109.222]) by smtp1-g21.free.fr (Postfix) with ESMTP id 5F08F940008 for <bug-Sys-Syslog [...] rt.cpan.org>; Wed, 25 Mar 2009 01:32:09 +0100 (CET)
Delivered-To: cpan-bug+Sys-Syslog [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #44410] Syslog.pm does not match Syslog.xs for LOG_UPTO usage
Return-Path: <saper [...] cpan.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Sys-Syslog [...] rt.cpan.org
Date: Wed, 25 Mar 2009 01:32:06 +0100
X-Spam-Level: *
To: bug-Sys-Syslog [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
RT-Message-ID: <rt-3.6.HEAD-26422-1237941164-597.44410-0-0 [...] rt.cpan.org>
Content-Length: 1086
Hello, Guenter Knauf wrote via RT: Show quoted text
> Sébastien Aperghis-Tramoni via RT schrieb: >
>> What is your system? I never saw a system where LOG_UPTO() isn't >> defined, and I never saw such an error in CPAN Testers reports:
> > The system is Novell NetWare, and LOG_UPTO() is definitely missing in > the system headers; however that's not the point: if I would get aware > of the fact that LOG_UPTO() is mandatory for Sys::Syslog to get it > working already during build stage I would either decide to fix the > headers myself and add this macro, or to exclude Sys::Syslog from the > build; but now the situation is that I can just build fine but end up > with an unusable module, and find this only at testing/usage stage. > [..] > Then also the code would be more clean, and free of unnecessary ifdefs > in the middle of the code.
It's then just simpler to #define the macros if they are not available, and indeed rip off the #ifdef from the main code. » http://svnweb.mongueurs.net/Sys-Syslog/revision/?rev=250 -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.