Skip Menu |
 

This queue is for tickets about the Config-IniFiles CPAN distribution.

Report information
The Basics
Id: 43843
Status: resolved
Priority: 0/
Queue: Config-IniFiles

People
Owner: Nobody in particular
Requestors: franck.mail [...] dthconnex.com
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 2.47
Fixed in: (no value)



Subject: Allow comments on a line that contains parameters
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 338
Download (untitled) / with headers
text/plain 338b
Hi, Would it be possible to allow comments on lines that contains parameters? I mean I like to use such a declaration: param1 = value1 ; param1 must be specified in ns rather than adding all my comments before the section name. This bug has been reported on Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513510 Regards,
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
Message-ID: <rt-3.6.HEAD-2538-1239753576-1275.43843-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
From: cbanker [...] gmail.com
X-RT-Original-Encoding: utf-8
Content-Length: 659
Download (untitled) / with headers
text/plain 659b
I agree that this would be a very useful feature. There don't seem to be any modules on the archive that are able to do both read/write and handle inline comments. Seems like it should be possible to handle inline comments using regex's. On Wed Mar 04 12:58:24 2009, thialme wrote: Show quoted text
> Hi, > > Would it be possible to allow comments on lines that contains > parameters? > > I mean I like to use such a declaration: > > param1 = value1 ; param1 must be specified in ns > > rather than adding all my comments before the section name. > > This bug has been reported on Debian: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513510 > > Regards,
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-26541-1269516676-29.43843-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 129
Download (untitled) / with headers
text/plain 129b
If you're interested in this, please submit a patch with a testcase. It seems like a desirable feature. Regards, -- Shlomi Fish
From franck [...] debian.org Mon Mar 29 03: 44:07 2010
MIME-Version: 1.0
X-Spam-Status: No, score=-10.599 tagged_above=-99.9 required=10 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-26541-1269516677-559.43843-6-0 [...] rt.cpan.org>
X-Spam-Flag: NO
References: <RT-Ticket-43843 [...] rt.cpan.org> <rt-3.8.HEAD-26541-1269516677-559.43843-6-0 [...] rt.cpan.org>
X-Spam-Check: DONE|U 0.500007/N
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <4BB05A26.9090706 [...] debian.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-RT-Original-Encoding: utf-8
X-Spam-Score: -10.599
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 321BB24054B for <cpan-bug+config-inifiles [...] hipster.bestpractical.com>; Mon, 29 Mar 2010 03:44:07 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e22KSvan1Gu1 for <cpan-bug+config-inifiles [...] hipster.bestpractical.com>; Mon, 29 Mar 2010 03:44:04 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id B2A6B240301 for <bug-config-inifiles [...] rt.cpan.org>; Mon, 29 Mar 2010 03:44:03 -0400 (EDT)
Received: (qmail 5841 invoked by uid 103); 29 Mar 2010 07:44:21 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 29 Mar 2010 07:44:21 -0000
Received: from 63.mail-out.ovh.net (HELO 63.mail-out.ovh.net) (91.121.185.56) by 16.mx.develooper.com (qpsmtpd/0.80) with SMTP; Mon, 29 Mar 2010 00:44:15 -0700
Received: (qmail 27485 invoked by uid 503); 29 Mar 2010 07:48:07 -0000
Received: from b6.ovh.net (HELO mail178.ha.ovh.net) (213.186.33.56) by 63.mail-out.ovh.net with SMTP; 29 Mar 2010 07:48:07 -0000
Received: from b0.ovh.net (HELO queueout) (213.186.33.50) by b0.ovh.net with SMTP; 29 Mar 2010 07:44:10 -0000
Received: from unknown (HELO ?192.168.10.141?) (franck?nospam [...] dthconnex.com [...] 217.108.200.193) by ns0.ovh.net with SMTP; 29 Mar 2010 07:44:09 -0000
Delivered-To: cpan-bug+config-inifiles [...] hipster.bestpractical.com
X-Ovh-Local: 213.186.33.20 (ns0.ovh.net)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1.8) Gecko/20100227 Lightning/1.0b1 Thunderbird/3.0.3
Subject: Re: [rt.cpan.org #43843] Allow comments on a line that contains parameters
X-Ovh-Tracer-ID: 6505731138491403854
Return-Path: <franck [...] debian.org>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+config-inifiles [...] hipster.bestpractical.com
X-RT-Mail-Extension: config-inifiles
Date: Mon, 29 Mar 2010 09:43:34 +0200
X-Spam-Level:
X-Ovh-Remote: 217.108.200.193 ()
To: bug-Config-IniFiles [...] rt.cpan.org
Content-Transfer-Encoding: 8bit
From: Franck Joncourt <franck [...] debian.org>
RT-Message-ID: <rt-3.8.HEAD-26545-1269848666-1390.43843-0-0 [...] rt.cpan.org>
Content-Length: 309
Download (untitled) / with headers
text/plain 309b
Le 25/03/2010 12:31, Shlomi Fish via RT a écrit : Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=43843> > > If you're interested in this, please submit a patch with a testcase. It > seems like a desirable feature.
I will try to find the time to do that. But I am not sure when :) Regards, --- Franck
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-26545-1269848666-1390.43843-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
References: <RT-Ticket-43843 [...] rt.cpan.org> <rt-3.8.HEAD-26541-1269516677-559.43843-6-0 [...] rt.cpan.org> <4BB05A26.9090706 [...] debian.org> <rt-3.8.HEAD-26545-1269848666-1390.43843-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-11058-1281792229-682.43843-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 443
Download (untitled) / with headers
text/plain 443b
On Mon Mar 29 03:44:26 2010, franck@debian.org wrote: Show quoted text
> Le 25/03/2010 12:31, Shlomi Fish via RT a écrit :
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=43843> > > > > If you're interested in this, please submit a patch with a testcase. It > > seems like a desirable feature.
> > I will try to find the time to do that. But I am not sure when :) >
Hi! Any news about it? Regards, -- Shlomi Fish Show quoted text
> Regards, > > --- > Franck >
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-19313-1296374546-1189.43843-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 542
Download (untitled) / with headers
text/plain 542b
This issue is now fixed thanks to a patch provided by Peter Xu. Quoting from the Config-IniFiles-2.66 changes: Version 2.66: ( Sat Jan 29 18:28:53 IST 2011 ) ------------------------------------------------- * Add support for the handle_trailing_comment option to support trailing comments at the end of a param=value line. - Fixes https://rt.cpan.org/Public/Bug/Display.html?id=43843 . - Original patch by Peter Xu. - Some comments and corrections of the patch by Shlomi Fish (the current Config-IniFiles maintainer.)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.