Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 40144
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: Nobody in particular
Requestors: dmn [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Spam-Status: No, hits=0.0 required=8.0 tests=
Content-Disposition: inline
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUVTCYYuehuPLEwK"
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 1E7C24D8005 for <bug-Net-SSLeay [...] rt.cpan.org>; Sat, 18 Oct 2008 02:19:47 -0400 (EDT)
Received: (qmail 20677 invoked by uid 103); 18 Oct 2008 06:19:47 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 18 Oct 2008 06:19:47 -0000
Received: from fiona.creditreform.bg (HELO fiona.creditreform.bg) (212.36.1.3) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Oct 2008 23:19:43 -0700
Received: from pc1.creditreform.bg ([192.168.110.32]) by fiona.creditreform.bg with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from <dam [...] modsoftsys.com>) id 1Kr5A1-0006aK-0J for bug-Net-SSLeay [...] rt.cpan.org; Sat, 18 Oct 2008 09:19:37 +0300
Received: from dam by pc1.creditreform.bg with local (Exim 4.69) (envelope-from <dam [...] pc1.creditreform.bg>) id 1Kr5A0-0000q8-Nh for bug-Net-SSLeay [...] rt.cpan.org; Sat, 18 Oct 2008 09:19:36 +0300
Delivered-To: cpan-bug+Net-SSLeay [...] diesel.bestpractical.com
Subject: Failing tests on *BSD; assumption about sockaddr contents
User-Agent: Mutt/1.5.18 (2008-05-17)
Return-Path: <dam [...] modsoftsys.com>
X-Original-To: bug-Net-SSLeay [...] rt.cpan.org
X-Spam-Check-BY: 16.mx.develooper.com
Date: Sat, 18 Oct 2008 09:19:36 +0300
X-Spam-Level: *
Message-Id: <20081018061935.GR8178 [...] pc1.creditreform.bg>
To: bug-Net-SSLeay [...] rt.cpan.org
From: Damyan Ivanov <dmn [...] debian.org>
Content-Length: 0
Content-Description: Digital signature
content-type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline
Content-Length: 197
Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Content-Type: multipart/mixed; boundary="30QY0t6eq0YQtYaq"
Content-Disposition: inline
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: us-ascii
Content-Length: 1062
Hi, A Debian GNU/kFreeBSD porter, Petr Salinger reported the following bug[1] against the Debian package. [1] http://bugs.debian.org/502518 Please Cc 502518@bugs.debian.org, 502518-submitter@bugs.debian.org in replies. --------------------------- the current version fails to build on GNU/kFreeBSD. It is due to failed tests. Unfortunately, tests assume some variant of "struct sockaddr". This variant is not used on BSD* systems. The linux one have at the beginning "short family", but BSD* systems have "char length; char family". It looks like it would be better to use sockaddr_in() for constructing needed parameters. With the patch bellow the test suite passes on GNU/kFreeBSD. It would be nice if you can inform upstream about this problem, there are also needed similar changes in examples. --------------------------- The patch attached addresses "pack vs. sockaddr_in" only for tests. The examples could get a bit of porting effort too. Thanks, dam Debian Perl Group -- dam JabberID: dam@jabber.minus273.org
Content-Type: text/x-diff; charset=us-ascii
content-disposition: attachment; filename="30use-sockaddr_in.patch"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: us-ascii
Content-Length: 1181

Message body is not shown because sender requested not to inline it.

CC: 502518 [...] bugs.debian.org, 502518-submitter [...] bugs.debian.org
MIME-Version: 1.0
X-Spam-Status: No, hits=1.7 required=8.0 tests=RDNS_DYNAMIC,TVD_RCVD_IP
In-Reply-To: <rt-3.6.HEAD-27668-1224310805-780.40144-4-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-40144 [...] rt.cpan.org> <20081018061935.GR8178 [...] pc1.creditreform.bg> <rt-3.6.HEAD-27668-1224310805-780.40144-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id D052B63CE5A for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 22 Oct 2008 03:55:00 -0400 (EDT)
Received: (qmail 693 invoked by uid 103); 22 Oct 2008 07:55:00 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 22 Oct 2008 07:55:00 -0000
Received: from 218-214-125-86.people.net.au (HELO zulu.open.com.au) (218.214.125.86) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Oct 2008 00:54:56 -0700
Received: from localhost (localhost [IPv6:::1]) by zulu.open.com.au (Postfix) with ESMTP id CB99C9B0E6; Wed, 22 Oct 2008 17:54:50 +1000 (EST)
Delivered-To: cpan-bug+Net-SSLeay [...] diesel.bestpractical.com
User-Agent: KMail/1.8.2
Subject: Re: [rt.cpan.org #40144] Failing tests on *BSD; assumption about sockaddr contents
Return-Path: <mikem [...] open.com.au>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Net-SSLeay [...] rt.cpan.org
Date: Wed, 22 Oct 2008 17:54:50 +1000
X-Spam-Level: *
Message-Id: <200810221754.50626.mikem [...] open.com.au>
To: bug-Net-SSLeay [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Mike McCauley <mikem [...] open.com.au>
RT-Message-ID: <rt-3.6.HEAD-27678-1224662123-1225.40144-0-0 [...] rt.cpan.org>
Content-Length: 2210
Download (untitled) / with headers
text/plain 2.1k
Hello, thanks for reporting this. Your patch has been applied to SVN and will appear in the next release. Cheers. On Saturday 18 October 2008 16:20, dmn@debian.org via RT wrote: Show quoted text
> Sat Oct 18 02:20:00 2008: Request 40144 was acted upon. > Transaction: Ticket created by dmn@debian.org > Queue: Net-SSLeay > Subject: Failing tests on *BSD; assumption about sockaddr contents > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dmn@debian.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=40144 > > > > Hi, > > A Debian GNU/kFreeBSD porter, Petr Salinger reported the following > bug[1] against the Debian package. > > [1] http://bugs.debian.org/502518 > > Please Cc 502518@bugs.debian.org, 502518-submitter@bugs.debian.org in > replies. > > --------------------------- > the current version fails to build on GNU/kFreeBSD. > > It is due to failed tests. Unfortunately, tests assume some variant of > "struct sockaddr". This variant is not used on BSD* systems. The linux > one have at the beginning "short family", but BSD* systems have "char > length; char family". > > It looks like it would be better to use sockaddr_in() for constructing > needed parameters. With the patch bellow the test suite passes on > GNU/kFreeBSD. > > It would be nice if you can inform upstream about this problem, there > are also needed similar changes in examples. > --------------------------- > > The patch attached addresses "pack vs. sockaddr_in" only for tests. > The examples could get a bit of porting effort too. > > Thanks, > dam > Debian Perl Group
-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.
MIME-Version: 1.0
In-Reply-To: <20081018061935.GR8178 [...] pc1.creditreform.bg>
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
References: <20081018061935.GR8178 [...] pc1.creditreform.bg>
Message-Id: <rt-3.6.HEAD-11881-1228947041-1328.40144-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1480
Download (untitled) / with headers
text/plain 1.4k
On Sat Oct 18 02:20:00 2008, dmn@debian.org wrote: Show quoted text
> Hi, > > A Debian GNU/kFreeBSD porter, Petr Salinger reported the following > bug[1] against the Debian package. > > [1] http://bugs.debian.org/502518 > > Please Cc 502518@bugs.debian.org, 502518-submitter@bugs.debian.org in > replies. > > --------------------------- > the current version fails to build on GNU/kFreeBSD. > > It is due to failed tests. Unfortunately, tests assume some variant of > "struct sockaddr". This variant is not used on BSD* systems. The linux > one have at the beginning "short family", but BSD* systems have "char > length; char family". > > It looks like it would be better to use sockaddr_in() for constructing > needed parameters. With the patch bellow the test suite passes on > GNU/kFreeBSD. > > It would be nice if you can inform upstream about this problem, there > are also needed similar changes in examples. > --------------------------- > > The patch attached addresses "pack vs. sockaddr_in" only for tests. > The examples could get a bit of porting effort too. >
For everybody's convenience, I uploaded the patch to $CPAN/authors/id/S/SR/SREZIC/patches/Net-SSLeay-1.35-PetrSalinger-01.patch so it is available when using CPAN.pm's distroprefs. E.g. like this: match: distribution: "/Net-SSLeay-1\.35\.tar\.gz" perlconfig: osname: freebsd osvers: "^[789]\." patches: - SREZIC/patches/Net-SSLeay-1.35-PetrSalinger-01.patch ... Regards, Slaven


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.