This queue is for tickets about the CPAN-Checksums CPAN distribution.

Report information
The Basics
Id:
38944
Status:
resolved
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
perl [...] galumph.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_PASS
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Type: multipart/mixed; boundary="------------010502080000070009060600"
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 2377C4D8068 for <bug-CPAN-Checksums@rt.cpan.org>; Wed, 3 Sep 2008 08:31:24 -0400 (EDT)
Received: (qmail 8487 invoked from network); 3 Sep 2008 12:31:24 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 3 Sep 2008 12:31:24 -0000
Received: from pendrell.textdrive.com (HELO pendrell.textdrive.com) (207.7.108.149) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Sep 2008 05:31:21 -0700
Received: from quaquaversal.local (unknown [76.237.205.223]) by pendrell.textdrive.com (Postfix) with ESMTP id 161A6BBA03 for <bug-CPAN-Checksums@rt.cpan.org>; Wed, 3 Sep 2008 12:31:15 +0000 (GMT)
Delivered-To: cpan-bug+CPAN-Checksums@diesel.bestpractical.com
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.14) Gecko/20080421 Thunderbird/2.0.0.14 Mnenhy/0.7.5.0
Subject: Missing binmode on filehandle causes invalid checksums on Windows.
Return-Path: <perl@galumph.com>
X-Original-To: bug-CPAN-Checksums@rt.cpan.org
X-Spam-Check-BY: 16.mx.develooper.com
Date: Wed, 03 Sep 2008 07:31:11 -0500
X-Spam-Level: *
Message-Id: <48BE838F.4050802@galumph.com>
To: bug-CPAN-Checksums@rt.cpan.org
From: Elliot Shank <perl@galumph.com>
Content-Length: 0
content-type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: ISO-8859-1
Content-Length: 31
Patch is against version 2.00.
content-type: text/plain; charset="utf-8"; name="binmode.patch"; x-mac-creator="0"; x-mac-type="0"
content-disposition: inline; filename="binmode.patch"
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: ascii
Content-Length: 370
--- lib/CPAN/Checksums.pm 2008-05-17 00:15:20.000000000 -0500 +++ lib/CPAN/Checksums.pm.fixed 2008-09-03 07:23:41.000000000 -0500 @@ -219,6 +219,7 @@ my($fh) = new IO::File; my $dig = $module->new(@$constructor_args); $fh->open("$abs\0") or die "Couldn't open $abs: $!"; + $fh->binmode(); $dig->addfile($fh); $fh->close; my $digest = $dig->hexdigest;
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
X-Authentication-Warning: k75.linux.bogus: k set sender to andreas.koenig.7os6VVqR@franz.ak.mind.de using -f
In-Reply-To: <rt-3.6.HEAD-12445-1220445097-1994.38944-4-0@rt.cpan.org> (Elliot Shank via's message of "Wed\, 03 Sep 2008 08\:31\:39 -0400")
References: <RT-Ticket-38944@rt.cpan.org> <48BE838F.4050802@galumph.com> <rt-3.6.HEAD-12445-1220445097-1994.38944-4-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 94E0E4D8138 for <bug-CPAN-Checksums@rt.cpan.org>; Wed, 3 Sep 2008 15:34:18 -0400 (EDT)
Received: (qmail 8529 invoked from network); 3 Sep 2008 19:34:17 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 3 Sep 2008 19:34:17 -0000
Received: from franz.ak.mind.de (HELO franz.ak.mind.de) (212.42.235.66) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Sep 2008 12:34:14 -0700
Received: from k75.linux.bogus (localhost.localdomain [127.0.0.1]) by k75.linux.bogus (8.14.3/8.14.3/Debian-1) with ESMTP id m83JY8vH015706 for <bug-CPAN-Checksums@rt.cpan.org>; Wed, 3 Sep 2008 21:34:08 +0200
Received: (from k@localhost) by k75.linux.bogus (8.14.3/8.14.3/Submit) id m83JY8I1015705; Wed, 3 Sep 2008 21:34:08 +0200
Delivered-To: cpan-bug+CPAN-Checksums@diesel.bestpractical.com
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Subject: Re: [rt.cpan.org #38944] Missing binmode on filehandle causes invalid checksums on Windows.
Return-Path: <andreas.koenig.7os6VVqR@franz.ak.mind.de>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CPAN-Checksums@rt.cpan.org
Date: Wed, 03 Sep 2008 21:34:07 +0200
X-Spam-Level: *
Message-Id: <87ej41t45s.fsf@k75.linux.bogus>
To: bug-CPAN-Checksums@rt.cpan.org
From: andreas.koenig.7os6VVqR@franz.ak.mind.de (Andreas J. Koenig)
RT-Message-ID: <rt-3.6.HEAD-12431-1220470644-1225.38944-0-0@rt.cpan.org>
Content-Length: 198
Show quoted text
>>>>> On Wed, 03 Sep 2008 08:31:39 -0400, "Elliot Shank via RT" <bug-CPAN-Checksums@rt.cpan.org> said:
Show quoted text
> + $fh->binmode();
Well spotted, thanks! New release is on the way to CPAN. -- andreas
MIME-Version: 1.0
In-Reply-To: <48BE838F.4050802@galumph.com>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Charset: utf8
References: <48BE838F.4050802@galumph.com>
Content-Type: text/plain
Message-ID: <rt-3.6.HEAD-2295-1253406589-1596.38944-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 81
This was resolved in revision 2.01, 2008-09-03. Just forgot to resolve, doing now


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.