Skip Menu |
 

This queue is for tickets about the TAP-Harness-Archive CPAN distribution.

Report information
The Basics
Id: 37795
Status: resolved
Priority: 0/
Queue: TAP-Harness-Archive

People
Owner: Nobody in particular
Requestors: theckman [...] panix.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 9947D4D8045 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Fri, 18 Jul 2008 21:04:37 -0400 (EDT)
Received: (qmail 6210 invoked from network); 19 Jul 2008 01:04:36 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 19 Jul 2008 01:04:36 -0000
Received: from mail1.panix.com (HELO mail1.panix.com) (166.84.1.72) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jul 2008 18:04:33 -0700
Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by mail1.panix.com (Postfix) with ESMTP id 75F5729416 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Fri, 18 Jul 2008 21:04:28 -0400 (EDT)
Received: from [192.168.1.4] (user-0cdfo61.cable.mindspring.com [24.215.224.193]) by mailbackend.panix.com (Postfix) with ESMTP id 3DEBBE3E2 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Fri, 18 Jul 2008 21:04:28 -0400 (EDT)
Delivered-To: cpan-bug+TAP-Harness-Archive [...] diesel.bestpractical.com
Subject: tests fail under Windows. unable to install
MIME-Version: 1.0
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS
Return-Path: <theckman [...] panix.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-TAP-Harness-Archive [...] rt.cpan.org
Date: Fri, 18 Jul 2008 21:04:25 -0400
X-Spam-Level: *
Message-Id: <48813D99.1070607 [...] panix.com>
content-type: text/plain; charset="utf-8"; format="flowed"
To: bug-TAP-Harness-Archive [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Tim Heckman <theckman [...] panix.com>
X-RT-Original-Encoding: ISO-8859-1
Content-Length: 3246
Download (untitled) / with headers
text/plain 3.1k
During the "make test" part of the install, it seems the tests are unable to delete temp directories after creating them. Not sure why this would be happening, as when I examine the folders in Windows explorer there doesn't seem to be anything strange about them (security options look correct, and I am able to delete them manually without any problem). Output from installation attempt: ----------------------- Show quoted text
cpan> install TAP::Harness::Archive
Running install for module 'TAP::Harness::Archive' Running make for W/WO/WONKO/TAP-Harness-Archive-0.10.tar.gz Has already been unwrapped into directory C:\Perl\cpan\build\TAP-Harness-Archi ve-0.10-klqbbC Has already been made Running make test Microsoft (R) Program Maintenance Utility Version 9.00.21022.08 Copyright (C) Microsoft Corporation. All rights reserved. C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'bl ib\lib', 'blib\arch')" t/*.t t/archive...............1/42 cannot remove directory for C:\DOCUME~1\Tim\LOCALS~ 1\Temp\j9RYhjpvJH: Permission denied at C:\Perl\cpan\build\TAP-Harness-Archive-0 .10-klqbbC\blib\lib/TAP/Harness/Archive.pm line 342 cannot remove directory for C:\DOCUME~1\Tim\LOCALS~1\Temp\6hnRIwwuPI: Permission denied at C:\Perl\cpan\build\TAP-Harness-Archive-0.10-klqbbC\blib\lib/TAP/Harne ss/Archive.pm line 342 t/archive...............ok t/bar...................ok t/extra_files...........1/10 cannot remove directory for C:\DOCUME~1\Tim\LOCALS~ 1\Temp\FdJuCbRkFP: Permission denied at C:\Perl\cpan\build\TAP-Harness-Archive-0 .10-klqbbC\blib\lib/TAP/Harness/Archive.pm line 342 # Failed test 'Archive contains extra file t\extra_files\log1.txt' # at t/extra_files.t line 56. # Failed test 'Archive contains extra file t\extra_files\log2.txt' # at t/extra_files.t line 56. # Failed test 'Archive contains extra file t\extra_files\stuff\svk.info' # at t/extra_files.t line 56. # Looks like you failed 3 tests of 10. t/extra_files........... Dubious, test returned 3 (wstat 768, 0x300) Failed 3/10 subtests t/extra_properties......1/5 cannot remove directory for C:\DOCUME~1\Tim\LOCALS~1 \Temp\nIOIjCIVzE: Permission denied at C:\Perl\cpan\build\TAP-Harness-Archive-0. 10-klqbbC\blib\lib/TAP/Harness/Archive.pm line 342 t/extra_properties......ok t/foo...................ok t/pod-coverage..........Math::BigInt: couldn't load specified math lib(s), fallb ack to Math::BigInt::FastCalc at C:/Perl/lib/Win32API/File.pm line 21 t/pod-coverage..........ok t/pod...................ok Test Summary Report ------------------- t/extra_files.t (Wstat: 768 Tests: 10 Failed: 3) Failed tests: 8-10 Non-zero exit status: 3 Files=7, Tests=64, 2 wallclock secs ( 0.02 usr + 0.05 sys = 0.06 CPU) Result: FAIL Failed 1/7 test programs. 3/64 subtests failed. NMAKE : fatal error U1077: 'C:\Perl\bin\perl.exe' : return code '0xff' Stop. WONKO/TAP-Harness-Archive-0.10.tar.gz nmake test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports WONKO/TAP-Harness-Archive-0.10.tar.gz Running make install make test had returned bad status, won't install without force Failed during this command: WONKO/TAP-Harness-Archive-0.10.tar.gz : make_test NO
MIME-Version: 1.0
X-Spam-Status: No, hits=-6.6 required=8.0 tests=BAYES_00,PERLBUG_CONF,SPF_HELO_PASS,SPF_PASS
Content-Type: text/plain; charset="utf-8"; format="flowed"
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 2B2654D8045 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Fri, 18 Jul 2008 21:10:23 -0400 (EDT)
Received: (qmail 7726 invoked from network); 19 Jul 2008 01:10:22 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 19 Jul 2008 01:10:22 -0000
Received: from mail1.panix.com (HELO mail1.panix.com) (166.84.1.72) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jul 2008 18:10:19 -0700
Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by mail1.panix.com (Postfix) with ESMTP id AB5A129409 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Fri, 18 Jul 2008 21:10:16 -0400 (EDT)
Received: from [192.168.1.4] (user-0cdfo61.cable.mindspring.com [24.215.224.193]) by mailbackend.panix.com (Postfix) with ESMTP id A8516EC1C for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Fri, 18 Jul 2008 21:10:16 -0400 (EDT)
Delivered-To: cpan-bug+TAP-Harness-Archive [...] diesel.bestpractical.com
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
Subject: [rt.cpan.org #37795] perl version
Return-Path: <theckman [...] panix.com>
X-Original-To: bug-TAP-Harness-Archive [...] rt.cpan.org
X-Spam-Check-BY: 16.mx.develooper.com
Date: Fri, 18 Jul 2008 21:10:16 -0400
X-Spam-Level: *
Message-Id: <48813EF8.5040601 [...] panix.com>
To: bug-TAP-Harness-Archive [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Tim Heckman <theckman [...] panix.com>
RT-Message-ID: <rt-3.6.HEAD-25274-1216429835-598.37795-0-0 [...] rt.cpan.org>
Content-Length: 2750
Download (untitled) / with headers
text/plain 2.6k
My perl version information: Summary of my perl5 (revision 5 version 10 subversion 0) configuration: Platform: osname=MSWin32, osvers=5.00, archname=MSWin32-x86-multi-thread uname='' config_args='undef' hint=recommended, useposix=true, d_sigaction=undef useithreads=define, usemultiplicity=define useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=undef, use64bitall=undef, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cl', ccflags ='-nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DUSE_SITECUSTOMIZE -DPRIVLIB_LAST_IN_INC -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX', optimize='-MD -Zi -DNDEBUG -O1', cppflags='-DWIN32' ccversion='15.0.21022', gccversion='', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf -libpath:"C:\Perl\lib\CORE" -machine:x86' libpth=\lib libs= oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib msvcrt.lib perllibs= oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib msvcrt.lib libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl510.lib gnulibc_version='' Dynamic Linking: dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' ' cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug -opt:ref,icf -libpath:"C:\Perl\lib\CORE" -machine:x86' Characteristics of this binary (from libperl): Compile-time options: MULTIPLICITY PERL_DONT_CREATE_GVSV PERL_IMPLICIT_CONTEXT PERL_IMPLICIT_SYS PERL_MALLOC_WRAP PL_OP_SLAB_ALLOC USE_ITHREADS USE_LARGE_FILES USE_PERLIO USE_SITECUSTOMIZE Locally applied patches: ActivePerl Build 1003 [285500] 33741 avoids segfaults invoking S_raise_signal() (on Linux) 33763 Win32 process ids can have more than 16 bits 32809 Load 'loadable object' with non-default file extension 32728 64-bit fix for Time::Local Built under MSWin32 Compiled at May 13 2008 16:52:49 @INC: C:/Perl/site/lib C:/Perl/lib .
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS
Content-Type: text/plain; charset="utf-8"; format="flowed"
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 211B34D80B3 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Sat, 19 Jul 2008 01:23:24 -0400 (EDT)
Received: (qmail 13867 invoked from network); 19 Jul 2008 05:23:23 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 19 Jul 2008 05:23:23 -0000
Received: from mail2.panix.com (HELO mail2.panix.com) (166.84.1.73) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jul 2008 22:23:20 -0700
Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by mail2.panix.com (Postfix) with ESMTP id B1E2334819 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Sat, 19 Jul 2008 01:23:16 -0400 (EDT)
Received: from [192.168.1.4] (user-0cdfo61.cable.mindspring.com [24.215.224.193]) by mailbackend.panix.com (Postfix) with ESMTP id 96C5FDDBB for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Sat, 19 Jul 2008 01:23:16 -0400 (EDT)
Delivered-To: cpan-bug+TAP-Harness-Archive [...] diesel.bestpractical.com
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
Subject: [rt.cpan.org #37795] Fixes for make test problems
Return-Path: <theckman [...] panix.com>
X-Original-To: bug-TAP-Harness-Archive [...] rt.cpan.org
X-Spam-Check-BY: 16.mx.develooper.com
Date: Sat, 19 Jul 2008 01:23:16 -0400
X-Spam-Level: *
Message-Id: <48817A44.5070908 [...] panix.com>
To: bug-TAP-Harness-Archive [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Tim Heckman <theckman [...] panix.com>
RT-Message-ID: <rt-3.6.HEAD-25289-1216445013-742.37795-0-0 [...] rt.cpan.org>
Content-Length: 2069
I figured out how to make the tests pass on windows. One is possibly a bug in Archive.pm. The other was a matter of adjusting the test. 1) In Archive.pm, do the chdir before calling rmtree. *** Archive.pm.orig Fri Jul 04 18:51:09 2008 --- Archive.pm Sat Jul 19 00:02:01 2008 *************** *** 340,345 **** # be nice and clean up - File::Path::rmtree($dir); chdir($cwd) or $class->_croak("Could not return to directory $cwd: $!"); return $aggregator; --- 340,345 ---- # be nice and clean up chdir($cwd) or $class->_croak("Could not return to directory $cwd: $!"); + File::Path::rmtree($dir); return $aggregator; 2) In extra_files.t Windows gives you paths with backslashes, but Archive::Tar returns the paths with forward slashes. Not sure what the best solution is, but this works: *** extra_files.t.orig Fri Jul 04 18:51:09 2008 --- extra_files.t Sat Jul 19 01:16:31 2008 *************** *** 2,6 **** use Test::More; use File::Temp (); ! use File::Spec::Functions qw(catfile catdir file_name_is_absolute); use TAP::Harness::Archive; use Archive::Tar; --- 2,6 ---- use Test::More; use File::Temp (); ! use File::Spec::Functions qw(catfile catdir file_name_is_absolute splitdir); use TAP::Harness::Archive; use Archive::Tar; *************** *** 53,58 **** my $tar = Archive::Tar->new($file); isa_ok($tar, 'Archive::Tar'); ! foreach my $extra_file (@extra_files) { ! ok($tar->contains_file($extra_file), "Archive contains extra file $extra_file"); } --- 53,63 ---- my $tar = Archive::Tar->new($file); isa_ok($tar, 'Archive::Tar'); ! my @contents = $tar->list_files(); ! foreach my $extra_file(@extra_files) { ! # Archive::Tar returns file names with "/" path separator. ! # Passing it through catdir(splitdir()) will give us the ! # correct system path separator (e.g. "\" on Win32). ! my $count = () = grep {catdir(splitdir($_)) eq $extra_file} @contents; ! ok($count == 1 , "Archive contains extra file $extra_file"); } -- tjh
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-25289-1216445013-742.37795-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
References: <48817A44.5070908 [...] panix.com> <rt-3.6.HEAD-25289-1216445013-742.37795-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-25274-1216472927-385.37795-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 175
Download (untitled) / with headers
text/plain 175b
I don't have a Win32 box to test on, but these patches look plausible as they are similar to other tempdir problems I've encountered on Windows when writing tests. Jim Keenan
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-25289-1216445013-742.37795-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
References: <48817A44.5070908 [...] panix.com> <rt-3.6.HEAD-25289-1216445013-742.37795-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-25308-1216478080-595.37795-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 617
Download (untitled) / with headers
text/plain 617b
I manually applied Tim's patches to the latest copy I have of TAP::Harness:Archive in my .cpan/build/ directory on Mac OS X, and all tests continue to pass: $ make test PERL_DL_NONLAZY=1 /usr/local/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/archive.............ok t/bar.................ok t/extra_files.........ok t/extra_properties....ok t/foo.................ok t/pod-coverage........ok t/pod.................ok All tests successful. Files=7, Tests=64, 6 wallclock secs ( 0.13 usr 0.08 sys + 3.28 cusr 1.08 csys = 4.57 CPU) Result: PASS
MIME-Version: 1.0
In-Reply-To: <48813D99.1070607 [...] panix.com>
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
References: <48813D99.1070607 [...] panix.com>
Message-Id: <rt-3.6.HEAD-25289-1216494146-1840.37795-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 244
Download (untitled) / with headers
text/plain 244b
These look good. Applied with some minor tweaks for style. TAP::Harness::Archive 0.11 should be arriving on your local CPAN mirror shortly with the fix. Please update, give it for a spin and let me know if it fixes the problem for you. Thanks!
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-25289-1216494146-1840.37795-6-0 [...] rt.cpan.org>
References: <RT-Ticket-37795 [...] rt.cpan.org> <48813D99.1070607 [...] panix.com> <rt-3.6.HEAD-25289-1216494146-1840.37795-6-0 [...] rt.cpan.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 2BAFE4D80FC for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Mon, 21 Jul 2008 00:40:22 -0400 (EDT)
Received: (qmail 4625 invoked from network); 21 Jul 2008 04:40:22 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 21 Jul 2008 04:40:22 -0000
Received: from mail2.panix.com (HELO mail2.panix.com) (166.84.1.73) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Sun, 20 Jul 2008 21:40:18 -0700
Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by mail2.panix.com (Postfix) with ESMTP id 17CA534806 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Mon, 21 Jul 2008 00:40:14 -0400 (EDT)
Received: from [192.168.1.4] (user-0cdfo61.cable.mindspring.com [24.215.224.193]) by mailbackend.panix.com (Postfix) with ESMTP id F1C011ED3 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Mon, 21 Jul 2008 00:40:13 -0400 (EDT)
Delivered-To: cpan-bug+TAP-Harness-Archive [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #37795] tests fail under Windows. unable to install
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
Return-Path: <theckman [...] panix.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-TAP-Harness-Archive [...] rt.cpan.org
Date: Mon, 21 Jul 2008 00:40:11 -0400
X-Spam-Level: *
Message-Id: <4884132B.10006 [...] panix.com>
To: bug-TAP-Harness-Archive [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Tim Heckman <theckman [...] panix.com>
RT-Message-ID: <rt-3.6.HEAD-23022-1216615263-530.37795-0-0 [...] rt.cpan.org>
Content-Length: 2537
Download (untitled) / with headers
text/plain 2.4k
New breakage in 0.11. archive.t was changed to add a call to rel2abs(). This breaks the test on Windows. ==================== C:\work\TAP-Harness-Archive-0.11-gtImHI>nmake test Microsoft (R) Program Maintenance Utility Version 9.00.21022.08 Copyright (C) Microsoft Corporation. All rights reserved. C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'bl ib\lib', 'blib\arch')" t/*.t t/archive.............1/42 mkdir C:\DOCUME~1\Tim\LOCALS~1\Temp\JVwBZNnK3J\C:\: I nvalid argument; The filename, directory name, or volume label syntax is incorre ct at C:/Perl/site/lib/TAP/Harness.pm line 767 at t/archive.t line 21 # Looks like you planned 42 tests but only ran 2. # Looks like your test died just after 2. t/archive............. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 40/42 subtests t/bar.................ok t/extra_files.........ok t/extra_properties....ok t/foo.................ok t/pod-coverage........skipped: We are not running release tests t/pod.................skipped: We are not running release tests Test Summary Report ------------------- t/archive (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 42 tests but ran 2. Files=7, Tests=22, 2 wallclock secs ( 0.05 usr + 0.01 sys = 0.06 CPU) Result: FAIL Failed 1/7 test programs. 0/22 subtests failed. NMAKE : fatal error U1077: 'C:\Perl\bin\perl.exe' : return code '0xff' Stop. ======================== This can be fixed by removing the rel2abs() call: *** t\archive.t.orig Sat Jul 19 14:58:12 2008 --- t\archive.t Mon Jul 21 00:27:28 2008 *************** *** 13,19 **** # a temp directory to put everything in my $temp_dir = File::Temp->tempdir('tap-archive-XXXXXXXX', CLEANUP => 1); ! my @testfiles = map { rel2abs(catfile('t', $_)) } qw(foo.t bar.t); # first a .tar file $file = catfile($temp_dir, 'archive.tar'); --- 13,19 ---- # a temp directory to put everything in my $temp_dir = File::Temp->tempdir('tap-archive-XXXXXXXX', CLEANUP => 1); ! my @testfiles = map { catfile('t', $_) } qw(foo.t bar.t); # first a .tar file $file = catfile($temp_dir, 'archive.tar'); Michael Peters via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=37795 > > > These look good. Applied with some minor tweaks for style. > TAP::Harness::Archive 0.11 should be arriving on your local CPAN mirror > shortly with the fix. Please update, give it for a spin and let me know > if it fixes the problem for you. > > Thanks! >
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-23022-1216615263-530.37795-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
References: <RT-Ticket-37795 [...] rt.cpan.org> <48813D99.1070607 [...] panix.com> <rt-3.6.HEAD-25289-1216494146-1840.37795-6-0 [...] rt.cpan.org> <4884132B.10006 [...] panix.com> <rt-3.6.HEAD-23022-1216615263-530.37795-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-23010-1216649679-910.37795-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 282
Download (untitled) / with headers
text/plain 282b
On Mon Jul 21 00:41:03 2008, theckman@panix.com wrote: Show quoted text
> New breakage in 0.11. archive.t was changed to add a call to rel2abs(). > This breaks the test on Windows.
Does rel2abs() not work on Windows? Try 0.12 and see if it fixes this issue. Thanks again for testing this out!
MIME-Version: 1.0 (Apple Message framework v753.1)
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-23010-1216649679-910.37795-6-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.753.1)
References: <RT-Ticket-37795 [...] rt.cpan.org> <48813D99.1070607 [...] panix.com> <rt-3.6.HEAD-25289-1216494146-1840.37795-6-0 [...] rt.cpan.org> <4884132B.10006 [...] panix.com> <rt-3.6.HEAD-23022-1216615263-530.37795-6-0 [...] rt.cpan.org> <rt-3.6.HEAD-23010-1216649679-910.37795-6-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 9B1234D8015 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Mon, 21 Jul 2008 11:13:08 -0400 (EDT)
Received: (qmail 16282 invoked from network); 21 Jul 2008 15:13:07 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 21 Jul 2008 15:13:07 -0000
Received: from mail1.panix.com (HELO mail1.panix.com) (166.84.1.72) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jul 2008 08:13:04 -0700
Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by mail1.panix.com (Postfix) with ESMTP id 81B8D29403 for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Mon, 21 Jul 2008 11:12:59 -0400 (EDT)
Received: from [192.168.1.137] (user-0cdfo61.cable.mindspring.com [24.215.224.193]) by mailbackend.panix.com (Postfix) with ESMTP id 80F94DDBB for <bug-TAP-Harness-Archive [...] rt.cpan.org>; Mon, 21 Jul 2008 11:12:59 -0400 (EDT)
Delivered-To: cpan-bug+TAP-Harness-Archive [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #37795] tests fail under Windows. unable to install
Return-Path: <theckman [...] panix.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-TAP-Harness-Archive [...] rt.cpan.org
Date: Mon, 21 Jul 2008 11:12:53 -0400
X-Spam-Level: *
Message-Id: <A5A34BF9-3C61-49CE-8409-2ED43921CFED [...] panix.com>
To: bug-TAP-Harness-Archive [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Tim Heckman <theckman [...] panix.com>
RT-Message-ID: <rt-3.6.HEAD-23017-1216653206-1309.37795-0-0 [...] rt.cpan.org>
Content-Length: 756
Download (untitled) / with headers
text/plain 756b
rel2abs() works, but I think what happens is that in Harness.pm around line 762 it concatenates C:\$temporary_dir to the path portion of the file names passed in, which are absolute when you use rel2abs in the test script, so you get C:\$temp_dir\C:\$build_dir\t\ and it blows up when you try to call mkpath() with this. On Jul 21, 2008, at 10:14 AM, Michael Peters via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=37795 > > > On Mon Jul 21 00:41:03 2008, theckman@panix.com wrote:
>> New breakage in 0.11. archive.t was changed to add a call to >> rel2abs(). >> This breaks the test on Windows.
> > Does rel2abs() not work on Windows? > > Try 0.12 and see if it fixes this issue. > > Thanks again for testing this out! > > >
MIME-Version: 1.0
In-Reply-To: <48813D99.1070607 [...] panix.com>
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
References: <48813D99.1070607 [...] panix.com>
Message-Id: <rt-3.6.HEAD-23596-1217078754-1520.37795-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 13
Fixed in 0.12


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.