Skip Menu |
 

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 35925
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: Nobody in particular
Requestors: dave.s.doyle [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 4.30
Fixed in: (no value)

Attachments


Subject: CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1210911684-19854-2"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 722
Download (untitled) / with headers
text/plain 722b
I noticed this in my error logs when using CGI::Session in CGI::Application. When I've passed a DBI object to CGI::Session via CGI::Application::Plugin::Session and the request is ending, the DBI object is being destroyed before the Session. CGI::Session::Driver::DBI::DESTROY does a "ping" on the DBH so it can do a $self->set_error() stating that the handle was destroyed. However, because the handle is already gone the ->ping produces a "Can't call method ping on undefined value". If you change the if statement to include a check if $self->{Handle} is defined as well as if ->ping works, no more warning. Not a big deal, but it's cluttering my logs. :) Patch enclosed. Thanks for your time and a great module.
Subject: CGI-Session-Driver-DBI_DESTROY-patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1210911684-19854-1"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/octet-stream; name="CGI-Session-Driver-DBI_DESTROY-patch"
Content-Disposition: inline; filename="CGI-Session-Driver-DBI_DESTROY-patch"
Content-Transfer-Encoding: base64
Content-Length: 479
Download CGI-Session-Driver-DBI_DESTROY-patch
application/octet-stream 479b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-19854-1210911691-329.35925-4-0 [...] rt.cpan.org>
X-Mailer: Evolution 2.22.1
References: <RT-Ticket-35925 [...] rt.cpan.org> <rt-3.6.HEAD-19854-1210911691-329.35925-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset=utf-8
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 3364E4D8015 for <bug-CGI-Session [...] rt.cpan.org>; Fri, 16 May 2008 02:09:08 -0400 (EDT)
Received: (qmail 7041 invoked from network); 16 May 2008 06:09:08 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 16 May 2008 06:09:08 -0000
Received: from hosted01.westnet.com.au (HELO hosted01.westnet.com.au) (203.10.1.211) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 May 2008 23:09:02 -0700
Received: from hosted01.westnet.com.au (hosted01.westnet.com.au [127.0.0.1]) by hosted01.westnet.com.au (Postfix) with SMTP id D0EC73D9580 for <bug-CGI-Session [...] rt.cpan.org>; Fri, 16 May 2008 14:08:51 +0800 (WST)
Received: from [192.168.100.4] (dsl-58-6-178-121.nsw.westnet.com.au [58.6.178.121]) by hosted01.westnet.com.au (Postfix) with ESMTP id EB2BE3DA1C8 for <bug-CGI-Session [...] rt.cpan.org>; Fri, 16 May 2008 14:08:10 +0800 (WST)
Delivered-To: cpan-bug+CGI-Session [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
X-PMX-Branch: TNG-Outgoing
Return-Path: <ron [...] savage.net.au>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CGI-Session [...] rt.cpan.org
Date: Fri, 16 May 2008 16:07:22 +1000
X-Spam-Level: *
Message-Id: <1210918042.5073.61.camel [...] zoe.savage.net.au>
To: bug-CGI-Session [...] rt.cpan.org
Content-Transfer-Encoding: 8bit
From: Ron Savage <ron [...] savage.net.au>
RT-Message-ID: <rt-3.6.HEAD-19861-1210918155-1574.35925-0-0 [...] rt.cpan.org>
Content-Length: 368
Download (untitled) / with headers
text/plain 368b
Hi Show quoted text
> Not a big deal, but it's cluttering my logs. :)
Reason enough to shake our tree. Show quoted text
> Patch enclosed.
Thanx for the patch. I'll apply it to SVN tonight, but I can't say how long before another version of CGI::Session is released. Show quoted text
> Thanks for your time and a great module.
$many x $thanx; -- Ron Savage ron@savage.net.au http://savage.net.au/index.html
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-19854-1210911691-329.35925-4-0 [...] rt.cpan.org>
X-Mailer: Evolution 2.22.1
References: <RT-Ticket-35925 [...] rt.cpan.org> <rt-3.6.HEAD-19854-1210911691-329.35925-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 98C3F4D8046 for <bug-CGI-Session [...] rt.cpan.org>; Fri, 16 May 2008 02:39:25 -0400 (EDT)
Received: (qmail 17044 invoked from network); 16 May 2008 06:39:24 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 16 May 2008 06:39:24 -0000
Received: from hosted01.westnet.com.au (HELO hosted01.westnet.com.au) (203.10.1.211) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 May 2008 23:39:22 -0700
Received: from hosted01.westnet.com.au (hosted01.westnet.com.au [127.0.0.1]) by hosted01.westnet.com.au (Postfix) with SMTP id 1C5633D84D5 for <bug-CGI-Session [...] rt.cpan.org>; Fri, 16 May 2008 14:39:15 +0800 (WST)
Received: from [192.168.100.4] (dsl-58-6-178-121.nsw.westnet.com.au [58.6.178.121]) by hosted01.westnet.com.au (Postfix) with ESMTP id 6C0D03D9B2B for <bug-CGI-Session [...] rt.cpan.org>; Fri, 16 May 2008 14:39:08 +0800 (WST)
Delivered-To: cpan-bug+CGI-Session [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
X-PMX-Branch: TNG-Outgoing
Return-Path: <ron [...] savage.net.au>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CGI-Session [...] rt.cpan.org
Date: Fri, 16 May 2008 16:38:20 +1000
X-Spam-Level: *
Message-Id: <1210919900.5073.63.camel [...] zoe.savage.net.au>
To: bug-CGI-Session [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Ron Savage <ron [...] savage.net.au>
RT-Message-ID: <rt-3.6.HEAD-19854-1210919982-1189.35925-0-0 [...] rt.cpan.org>
Content-Length: 94
Hi Folks Updated in svn. -- Ron Savage ron@savage.net.au http://savage.net.au/index.html
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-19854-1210919982-1189.35925-5-0 [...] rt.cpan.org>
X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.9; i486-pc-linux-gnu)
References: <RT-Ticket-35925 [...] rt.cpan.org> <rt-3.6.HEAD-19854-1210911691-329.35925-4-0 [...] rt.cpan.org> <1210919900.5073.63.camel [...] zoe.savage.net.au> <rt-3.6.HEAD-19854-1210919982-1189.35925-5-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id AF39E4D8098 for <bug-CGI-Session [...] rt.cpan.org>; Tue, 27 May 2008 13:10:57 -0400 (EDT)
Received: (qmail 1039 invoked from network); 27 May 2008 17:10:56 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 27 May 2008 17:10:56 -0000
Received: from tanagra.summersault.com (HELO tanagra.summersault.com) (12.161.105.149) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with SMTP; Tue, 27 May 2008 10:10:52 -0700
Received: (qmail 22135 invoked from network); 27 May 2008 13:10:47 -0400
Received: from simba.summersault.com (HELO localhost) (192.168.97.182) by tanagra.summersault.com with SMTP; 27 May 2008 13:10:47 -0400
Delivered-To: cpan-bug+CGI-Session [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CGI-Session [...] rt.cpan.org
Date: Tue, 27 May 2008 13:10:47 -0400
X-Spam-Level: *
Message-Id: <20080527131047.4308f14d [...] summersault.com>
To: bug-CGI-Session [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
RT-Message-ID: <rt-3.6.HEAD-32634-1211908265-1811.35925-0-0 [...] rt.cpan.org>
Content-Length: 100
Download (untitled) / with headers
text/plain 100b
Show quoted text
> Hi Folks > > Updated in svn.
Thanks, Ron. Shall I go ahead with another release then? Mark
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-32634-1211908265-1811.35925-5-0 [...] rt.cpan.org>
X-Mailer: Evolution 2.22.1
References: <RT-Ticket-35925 [...] rt.cpan.org> <rt-3.6.HEAD-19854-1210911691-329.35925-4-0 [...] rt.cpan.org> <1210919900.5073.63.camel [...] zoe.savage.net.au> <rt-3.6.HEAD-19854-1210919982-1189.35925-5-0 [...] rt.cpan.org> <20080527131047.4308f14d [...] summersault.com> <rt-3.6.HEAD-32634-1211908265-1811.35925-5-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 60E914D8005 for <bug-CGI-Session [...] rt.cpan.org>; Tue, 27 May 2008 20:36:31 -0400 (EDT)
Received: (qmail 31876 invoked from network); 28 May 2008 00:36:30 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 28 May 2008 00:36:30 -0000
Received: from hosted03.westnet.com.au (HELO hosted03.westnet.com.au) (203.10.1.215) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 May 2008 17:36:22 -0700
Received: from hosted03.westnet.com.au (hosted03.westnet.com.au [127.0.0.1]) by hosted03.westnet.com.au (Postfix) with SMTP id 6E6FD309616 for <bug-CGI-Session [...] rt.cpan.org>; Wed, 28 May 2008 08:36:14 +0800 (WST)
Received: from [192.168.100.4] (dsl-58-6-178-121.nsw.westnet.com.au [58.6.178.121]) by hosted03.westnet.com.au (Postfix) with ESMTP id 16E3830935A for <bug-CGI-Session [...] rt.cpan.org>; Wed, 28 May 2008 08:36:12 +0800 (WST)
Delivered-To: cpan-bug+CGI-Session [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
X-PMX-Branch: TNG-Outgoing
Return-Path: <ron [...] savage.net.au>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-CGI-Session [...] rt.cpan.org
Date: Wed, 28 May 2008 10:37:05 +1000
X-Spam-Level: *
Message-Id: <1211935025.5073.262.camel [...] zoe.savage.net.au>
To: bug-CGI-Session [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Ron Savage <ron [...] savage.net.au>
RT-Message-ID: <rt-3.6.HEAD-32632-1211935010-899.35925-0-0 [...] rt.cpan.org>
Content-Length: 438
Download (untitled) / with headers
text/plain 438b
Hi Mark On Tue, 2008-05-27 at 13:11 -0400, mark@summersault.com via RT wrote: Show quoted text
> Queue: CGI-Session > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35925 > >
> > Hi Folks > > > > Updated in svn.
> > Thanks, Ron. Shall I go ahead with another release then?
Please wait a day or so. I'll have a look at the other email and doc implications, and let you know. -- Ron Savage ron@savage.net.au http://savage.net.au/index.html
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-19861-1210918155-1574.35925-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
References: <RT-Ticket-35925 [...] rt.cpan.org> <rt-3.6.HEAD-19854-1210911691-329.35925-4-0 [...] rt.cpan.org> <1210918042.5073.61.camel [...] zoe.savage.net.au> <rt-3.6.HEAD-19861-1210918155-1574.35925-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-22481-1214497253-79.35925-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
From: dave.s.doyle [...] gmail.com
X-RT-Original-Encoding: utf-8
Content-Length: 220
Download (untitled) / with headers
text/plain 220b
Thanks again for the change. This is fixed in 4.31/4.32 so you you can probably mark this as resolved. ;) Thanks for my first ever patch (small though it may be) to a CPAN module and both of you responding so quick! D
MIME-Version: 1.0
X-Mailer: MIME-tools 5.426 (Entity 5.426)
Content-Disposition: inline
Charset: utf8
Message-Id: <rt-3.6.HEAD-11893-1225509491-440.35925-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 42
The reporter said this was fixed in 4.32.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.