Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 35585
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: gam3-cpan [...] gam3.net
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.2807
Fixed in: 0.2808



Subject: testpodcoverage does not test the correct code
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1209745811-32366-18"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 422
Download (untitled) / with headers
text/plain 422b
Test::Pod::Coverage::all_pod_coverage_ok() uses @INC to load the modules that it is testing. Currently Module::Build does not set @INC to include the blib/lib directory, so only installed versions of the module being tested are checked. This patch set @INC so that all modules in 'libdoc_dirs()' be tested. This might be more of a bug in Test::Pod::Coverage as it look for modules in blib/ even in blib/ is not in @INC.
Subject: patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1209745359-32379-16"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/octet-stream; name="patch"
Content-Disposition: inline; filename="patch"
Content-Transfer-Encoding: base64
Content-Length: 412
Download patch
application/octet-stream 412b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-32366-1209745819-1901.35585-4-0 [...] rt.cpan.org>
References: <RT-Ticket-35585 [...] rt.cpan.org> <rt-3.6.HEAD-32366-1209745819-1901.35585-4-0 [...] rt.cpan.org>
X-Pobox-Relay-Id: C08EE1D2-18A0-11DD-B39D-80001473D85F-02258300!a-sasl-fastnet.pobox.com
Content-Type: text/plain; charset=UTF-8; format=flowed
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 74B594D80BB for <bug-Module-Build [...] rt.cpan.org>; Fri, 2 May 2008 19:37:47 -0400 (EDT)
Received: (qmail 15799 invoked from network); 2 May 2008 23:37:46 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 2 May 2008 23:37:46 -0000
Received: from a-sasl-fastnet.sasl.smtp.pobox.com (HELO sasl.smtp.pobox.com) (207.106.133.19) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 May 2008 16:37:42 -0700
Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 870C0487A for <bug-Module-Build [...] rt.cpan.org>; Fri, 2 May 2008 19:37:39 -0400 (EDT)
Received: from windhund.schwern.org (unknown [64.122.42.219]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 2B6A84879 for <bug-Module-Build [...] rt.cpan.org>; Fri, 2 May 2008 19:37:38 -0400 (EDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
Return-Path: <schwern [...] pobox.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Fri, 02 May 2008 16:37:25 -0700
X-Spam-Level: *
Message-Id: <481BA5B5.6060307 [...] pobox.com>
To: bug-Module-Build [...] rt.cpan.org
X-Enigmail-Version: 0.95.6
Content-Transfer-Encoding: 7bit
From: Michael G Schwern <schwern [...] pobox.com>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-32349-1209771472-1309.35585-0-0 [...] rt.cpan.org>
Content-Length: 960
Download (untitled) / with headers
text/plain 960b
http://gam3.myopenid.com/ via RT wrote: Show quoted text
> Test::Pod::Coverage::all_pod_coverage_ok() uses @INC to load the modules > that it is testing. Currently Module::Build does not set @INC to > include the blib/lib directory, so only installed versions of the module > being tested are checked.
Are you sure? That would be a major bug if it were true. A simple test shows that blib/lib is in there. Here's one I tried with one of my simple Module::Build based distributions using MB 0.2808. $ pwd /Users/schwern/devel/Gravatar-URL $ cat t/inc.t #!/usr/bin/perl -w print STDERR map {"# $_\n"} grep /blib/, @INC; $ ./Build test t/inc........# /Users/schwern/devel/Gravatar-URL/blib/lib # /Users/schwern/devel/Gravatar-URL/blib/arch ... How did you determine that blib isn't showing up in @INC? -- 164. There is no such thing as a were-virgin. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.5 required=8.0 tests=BAYES_00,RDNS_DYNAMIC,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-32349-1209771472-1309.35585-6-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-35585 [...] rt.cpan.org> <rt-3.6.HEAD-32366-1209745819-1901.35585-4-0 [...] rt.cpan.org> <481BA5B5.6060307 [...] pobox.com> <rt-3.6.HEAD-32349-1209771472-1309.35585-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy"
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id D5C644D8045 for <bug-Module-Build [...] rt.cpan.org>; Fri, 2 May 2008 23:14:06 -0400 (EDT)
Received: (qmail 21746 invoked from network); 3 May 2008 03:14:05 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 3 May 2008 03:14:05 -0000
Received: from adsl-75-32-150-206.dsl.pltn13.sbcglobal.net (HELO olympus.sehda.com) (75.32.150.206) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 May 2008 20:14:01 -0700
Received: from harpo.ny.gam3.net (cpe-72-228-92-12.twcny.res.rr.com [72.228.92.12]) by olympus.sehda.com (8.13.8/8.13.8) with SMTP id m433DuRm018782 for <bug-Module-Build [...] rt.cpan.org>; Fri, 2 May 2008 20:13:57 -0700
Received: (qmail 27078 invoked by uid 1210); 2 May 2008 23:13:55 -0400
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Return-Path: <gam3 [...] gam3.net>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Fri, 2 May 2008 23:13:55 -0400
X-Spam-Level: *
Message-Id: <20080503031355.GA25472 [...] gam3.net>
To: Michael G Schwern via RT <bug-Module-Build [...] rt.cpan.org>
From: "G. Allen Morris III" <gam3 [...] gam3.net>
RT-Message-ID: <rt-3.6.HEAD-32376-1209784453-638.35585-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: us-ascii
X-RT-Original-Encoding: utf-8
Content-Length: 900
Download (untitled) / with headers
text/plain 900b
On Fri, May 02, 2008 at 07:37:57PM -0400, Michael G Schwern via RT wrote: Show quoted text
... Show quoted text
> Are you sure? That would be a major bug if it were true.
I don't think that many people are using 'Build testpodcoverage'. Show quoted text
> A simple test shows that blib/lib is in there. Here's one I tried with one of > my simple Module::Build based distributions using MB 0.2808. > > $ pwd > /Users/schwern/devel/Gravatar-URL > > $ cat t/inc.t > #!/usr/bin/perl -w > > print STDERR map {"# $_\n"} grep /blib/, @INC; > > $ ./Build test > t/inc........# /Users/schwern/devel/Gravatar-URL/blib/lib > # /Users/schwern/devel/Gravatar-URL/blib/arch
'Build test' sets @INC correctly; it is 'Build testpodcoverage' that does not. Show quoted text
> ... > > How did you determine that blib isn't showing up in @INC?
I printed @INC in the source code for the testpodcoverage method.
Content-Description: Digital signature
content-type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline
Content-Length: 242
Download signature.asc
application/pgp-signature 242b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-32376-1209784453-638.35585-5-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-35585 [...] rt.cpan.org> <20080503031355.GA25472 [...] gam3.net> <rt-3.6.HEAD-32376-1209784453-638.35585-5-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: iso-8859-1
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 0CB464D80BB for <bug-Module-Build [...] rt.cpan.org>; Sat, 3 May 2008 01:07:28 -0400 (EDT)
Received: (qmail 22972 invoked from network); 3 May 2008 05:07:27 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 3 May 2008 05:07:27 -0000
Received: from rv-out-0506.google.com (HELO rv-out-0506.google.com) (209.85.198.225) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 May 2008 22:07:25 -0700
Received: by rv-out-0506.google.com with SMTP id g37so877431rvb.33 for <bug-Module-Build [...] rt.cpan.org>; Fri, 02 May 2008 22:07:22 -0700 (PDT)
Received: by 10.140.164.6 with SMTP id m6mr1698391rve.210.1209791242005; Fri, 02 May 2008 22:07:22 -0700 (PDT)
Received: from gungnir.scratchcomputing.com ( [71.111.48.138]) by mx.google.com with ESMTPS id b39sm4788416rvf.8.2008.05.02.22.07.20 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 02 May 2008 22:07:21 -0700 (PDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
User-Agent: KMail/1.9.9
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id:from; b=EqVk8kcHtJCRRP3aQTTAZCWLXpLianh/FNxe7pv+cBsKQ1VoJYWpFSLhu6/i/14XFvPtPzCVt08LbGE6q7FR74Qrm8AJZjm2g6eVcIfKoWU1+TNhGLtllkW9NyaXKDX2shz5z6KE31DNMJ2gTc8Jf84nYO0vX3yUtNr26fPMopw=
Return-Path: <scratchcomputing [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id:from; bh=Ygeu0gie6HWbeL6JgePPgnRTQwAOSZeD3MR0r+5vBoU=; b=J+M0NkybMNq6j/UZbfC7qypaB9TiKF4fjpYtgBdHPiDd+88/bX5UpChzjlKnzpy0dNVY/o6fx0jmiwSN5oE76f34K8F36+0bdx801CEAxl6s4ahyXzFKe89xAh9entAr/6rJmANPVjditS9emxVvNQC7HTWhnre+SnJI90ChK/g=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Fri, 2 May 2008 22:07:18 -0700
X-Spam-Level: *
Message-Id: <200805022207.18191.ewilhelm [...] cpan.org>
To: bug-Module-Build [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Eric Wilhelm <scratchcomputing [...] gmail.com>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-32366-1209791280-1538.35585-0-0 [...] rt.cpan.org>
Content-Length: 474
Download (untitled) / with headers
text/plain 474b
# from gam3@gam3.net via RT # on Friday 02 May 2008: Show quoted text
>> How did you determine that blib isn't showing up in @INC?
> >I printed @INC in the source code for the testpodcoverage method.
The code and changelog says that I determined this was a pre-v1.09 Test::Pod::Coverage bug and there is a work-around is in M::B 0.2808. http://www.nntp.perl.org/group/perl.module.build/2007/01/msg469.html http://www.nntp.perl.org/group/perl.module.build/2007/04/msg605.html --Eric
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.5 required=8.0 tests=BAYES_00,RDNS_DYNAMIC,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-32366-1209791280-1538.35585-6-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-35585 [...] rt.cpan.org> <20080503031355.GA25472 [...] gam3.net> <rt-3.6.HEAD-32376-1209784453-638.35585-5-0 [...] rt.cpan.org> <200805022207.18191.ewilhelm [...] cpan.org> <rt-3.6.HEAD-32366-1209791280-1538.35585-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X"
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id D7C634D8048 for <bug-Module-Build [...] rt.cpan.org>; Sat, 3 May 2008 06:57:18 -0400 (EDT)
Received: (qmail 12255 invoked from network); 3 May 2008 10:57:17 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 3 May 2008 10:57:17 -0000
Received: from adsl-75-32-150-206.dsl.pltn13.sbcglobal.net (HELO olympus.sehda.com) (75.32.150.206) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 May 2008 03:57:14 -0700
Received: from harpo.ny.gam3.net (cpe-72-228-92-12.twcny.res.rr.com [72.228.92.12]) by olympus.sehda.com (8.13.8/8.13.8) with SMTP id m43AvAn1001972 for <bug-Module-Build [...] rt.cpan.org>; Sat, 3 May 2008 03:57:10 -0700
Received: (qmail 11182 invoked by uid 1210); 3 May 2008 06:57:09 -0400
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Return-Path: <gam3 [...] gam3.net>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Sat, 3 May 2008 06:57:09 -0400
X-Spam-Level: *
Message-Id: <20080503105709.GA9430 [...] gam3.net>
To: Eric Wilhelm via RT <bug-Module-Build [...] rt.cpan.org>
From: "G. Allen Morris III" <gam3 [...] gam3.net>
RT-Message-ID: <rt-3.6.HEAD-32379-1209812253-1363.35585-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: us-ascii
X-RT-Original-Encoding: utf-8
Content-Length: 592
Download (untitled) / with headers
text/plain 592b
Eric, On Sat, May 03, 2008 at 01:08:09AM -0400, Eric Wilhelm via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=35585 > > > The code and changelog says that I determined this was a pre-v1.09 > Test::Pod::Coverage bug and there is a work-around is in M::B 0.2808.
Thank you for the information. It still seems to me that Module-Build should be telling Test::Pod::Coverage what to test, and not just use the defaults. Allen Show quoted text
Content-Description: Digital signature
content-type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline
Content-Length: 242
Download signature.asc
application/pgp-signature 242b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-32376-1209784453-638.35585-5-0 [...] rt.cpan.org>
References: <RT-Ticket-35585 [...] rt.cpan.org> <rt-3.6.HEAD-32366-1209745819-1901.35585-4-0 [...] rt.cpan.org> <481BA5B5.6060307 [...] pobox.com> <rt-3.6.HEAD-32349-1209771472-1309.35585-6-0 [...] rt.cpan.org> <20080503031355.GA25472 [...] gam3.net> <rt-3.6.HEAD-32376-1209784453-638.35585-5-0 [...] rt.cpan.org>
X-Pobox-Relay-Id: 9BBBF644-19A7-11DD-B749-80001473D85F-02258300!a-sasl-fastnet.pobox.com
Content-Type: text/plain; charset=UTF-8; format=flowed
X-RT-Original-Encoding: utf-8
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id A576A4D80E2 for <bug-Module-Build [...] rt.cpan.org>; Sun, 4 May 2008 02:59:23 -0400 (EDT)
Received: (qmail 12559 invoked from network); 4 May 2008 06:59:22 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 4 May 2008 06:59:22 -0000
Received: from a-sasl-fastnet.sasl.smtp.pobox.com (HELO sasl.smtp.pobox.com) (207.106.133.19) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 May 2008 23:59:18 -0700
Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 64A143A5C for <bug-Module-Build [...] rt.cpan.org>; Sun, 4 May 2008 02:59:15 -0400 (EDT)
Received: from windhund.schwern.org (069-064-236-003.pdx.net [69.64.236.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id F205E3A5B for <bug-Module-Build [...] rt.cpan.org>; Sun, 4 May 2008 02:59:14 -0400 (EDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
Return-Path: <schwern [...] pobox.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Sat, 03 May 2008 23:58:56 -0700
X-Spam-Level: *
Message-Id: <481D5EB0.8030907 [...] pobox.com>
To: bug-Module-Build [...] rt.cpan.org
X-Enigmail-Version: 0.95.6
Content-Transfer-Encoding: 8bit
From: Michael G Schwern <schwern [...] pobox.com>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-32379-1209884374-559.35585-0-0 [...] rt.cpan.org>
Content-Length: 451
Download (untitled) / with headers
text/plain 451b
gam3@gam3.net via RT wrote: Show quoted text
>> Are you sure? That would be a major bug if it were true.
> > I don't think that many people are using 'Build testpodcoverage'.
Sorry, I didn't realize this applied to the testpodcoverage target. -- 184. When operating a military vehicle I may *not* attempt something “I saw in a cartoon”. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/
MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-32379-1209812253-1363.35585-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Charset: utf8
References: <RT-Ticket-35585 [...] rt.cpan.org> <20080503031355.GA25472 [...] gam3.net> <rt-3.6.HEAD-32376-1209784453-638.35585-5-0 [...] rt.cpan.org> <200805022207.18191.ewilhelm [...] cpan.org> <rt-3.6.HEAD-32366-1209791280-1538.35585-6-0 [...] rt.cpan.org> <20080503105709.GA9430 [...] gam3.net> <rt-3.6.HEAD-32379-1209812253-1363.35585-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-30967-1210172029-280.35585-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
From: kwilliams [...] cpan.org
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 314
Download (untitled) / with headers
text/plain 314b
On Sat May 03 06:57:33 2008, gam3@gam3.net wrote: Show quoted text
> It still seems to me that Module-Build should be telling > Test::Pod::Coverage what to test, and not just use the defaults.
Not sure what you mean by that - as Eric said, blib/lib has been added at the front of @INC, which ought to solve the problem. -Ken
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.5 required=8.0 tests=BAYES_00,RDNS_DYNAMIC,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-30967-1210172029-280.35585-6-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-35585 [...] rt.cpan.org> <20080503031355.GA25472 [...] gam3.net> <rt-3.6.HEAD-32376-1209784453-638.35585-5-0 [...] rt.cpan.org> <200805022207.18191.ewilhelm [...] cpan.org> <rt-3.6.HEAD-32366-1209791280-1538.35585-6-0 [...] rt.cpan.org> <20080503105709.GA9430 [...] gam3.net> <rt-3.6.HEAD-32379-1209812253-1363.35585-6-0 [...] rt.cpan.org> <rt-3.6.HEAD-30967-1210172029-280.35585-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT"
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id C96EC4D8071 for <bug-Module-Build [...] rt.cpan.org>; Wed, 7 May 2008 11:21:03 -0400 (EDT)
Received: (qmail 2295 invoked from network); 7 May 2008 15:21:02 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 May 2008 15:21:02 -0000
Received: from adsl-75-32-150-206.dsl.pltn13.sbcglobal.net (HELO olympus.sehda.com) (75.32.150.206) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 May 2008 08:20:59 -0700
Received: from harpo.ny.gam3.net (cpe-72-228-92-12.twcny.res.rr.com [72.228.92.12]) by olympus.sehda.com (8.13.8/8.13.8) with SMTP id m47FKtUQ016337 for <bug-Module-Build [...] rt.cpan.org>; Wed, 7 May 2008 08:20:56 -0700
Received: (qmail 19594 invoked by uid 1210); 7 May 2008 11:20:54 -0400
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Return-Path: <gam3 [...] gam3.net>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Wed, 7 May 2008 11:20:54 -0400
X-Spam-Level: *
Message-Id: <20080507152054.GA12398 [...] gam3.net>
To: Ken Williams via RT <bug-Module-Build [...] rt.cpan.org>
From: "G. Allen Morris III" <gam3 [...] gam3.net>
RT-Message-ID: <rt-3.6.HEAD-25343-1210173670-954.35585-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: us-ascii
X-RT-Original-Encoding: utf-8
Content-Length: 821
Download (untitled) / with headers
text/plain 821b
On Wed, May 07, 2008 at 10:53:53AM -0400, Ken Williams via RT wrote: Show quoted text
> > Not sure what you mean by that - as Eric said, blib/lib has been added at the front of @INC, > which ought to solve the problem.
From the Test::Pod::Coverage man page all_modules( [@dirs] ) Returns a list of all modules in $dir and in directories below. If no directories are passed, it defaults to blib if blib exists, or lib if not. I guess I would say that 'Build testpodcoverage' should be the same as 'Build test --test_files t/podc.t' where t/podc.t looks like: use Test::More; eval "use Test::Pod::Coverage"; plan skip_all => "Test::Pod::Coverage required for testing pod coverage" if $@; all_pod_coverage_ok(); And as ACTION_test sets @INC, I think that ACTION_testpodcoverage should do the same.
Content-Description: Digital signature
content-type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline
Content-Length: 242
Download signature.asc
application/pgp-signature 242b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-25343-1210173670-954.35585-5-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-35585 [...] rt.cpan.org> <20080507152054.GA12398 [...] gam3.net> <rt-3.6.HEAD-25343-1210173670-954.35585-5-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: iso-8859-1
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 19BBE4D80D3 for <bug-Module-Build [...] rt.cpan.org>; Wed, 7 May 2008 11:47:07 -0400 (EDT)
Received: (qmail 12131 invoked from network); 7 May 2008 15:47:06 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 May 2008 15:47:06 -0000
Received: from wr-out-0506.google.com (HELO wr-out-0506.google.com) (64.233.184.224) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 May 2008 08:47:03 -0700
Received: by wr-out-0506.google.com with SMTP id 67so183280wri.3 for <bug-Module-Build [...] rt.cpan.org>; Wed, 07 May 2008 08:47:00 -0700 (PDT)
Received: by 10.114.123.19 with SMTP id v19mr2033548wac.168.1210175220239; Wed, 07 May 2008 08:47:00 -0700 (PDT)
Received: from gungnir.scratchcomputing.com ( [71.111.48.138]) by mx.google.com with ESMTPS id a8sm4376836poa.12.2008.05.07.08.46.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 07 May 2008 08:46:59 -0700 (PDT)
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
User-Agent: KMail/1.9.9
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id:from; b=dZhAFCx34wxVGIOcXxPqxwkQJ/spzUCL+7PwZRGoHB8hkxQvEKTNfdqeGS16ZonUPKAg70E6m3Eun+FpIlb1iFJDiuaAdo3OoPyL2Uc5I+O+w1xXf8rB2+7fESZYHnxrbxWRrKxwuix2WfXFzE73Dq9ZsPlt+TAJFXqu7/3bybI=
Return-Path: <scratchcomputing [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id:from; bh=sTe3vzl1TJMn/SQORZmn+dWxtde+nCW3xnCx/LIUQbA=; b=SVJ9ctjbY+23ZHdpMYy95+ROnkFOGn54vbcjjOztDkB202tvkDsxta2qBDvjulqe/pdkqKyEEKgKPw1zizzGT3iqPOoBv5227S/90RpxafO/UJFStKcP86tT0l7DMtr8kP43wli0K33Txw67kBR/NQAhis2LTOVU87/NK2+iP9E=
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Wed, 7 May 2008 08:46:56 -0700
X-Spam-Level: *
Message-Id: <200805070846.56889.ewilhelm [...] cpan.org>
To: bug-Module-Build [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Eric Wilhelm <scratchcomputing [...] gmail.com>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-30967-1210175231-1532.35585-0-0 [...] rt.cpan.org>
Content-Length: 345
Download (untitled) / with headers
text/plain 345b
# from gam3@gam3.net via RT # on Wednesday 07 May 2008: Show quoted text
>And as ACTION_test sets @INC, I think that ACTION_testpodcoverage > should do the same.
It does. And has been this way for over a year now. http://search.cpan.org/src/KWILLIAMS/Module-Build-0.2808/lib/Module/Build/Base.pm Am I missing something or are you running old code? --Eric
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.5 required=8.0 tests=BAYES_00,RDNS_DYNAMIC,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-30967-1210175231-1532.35585-6-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-35585 [...] rt.cpan.org> <20080507152054.GA12398 [...] gam3.net> <rt-3.6.HEAD-25343-1210173670-954.35585-5-0 [...] rt.cpan.org> <200805070846.56889.ewilhelm [...] cpan.org> <rt-3.6.HEAD-30967-1210175231-1532.35585-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V"
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 1053B4D80E7 for <bug-Module-Build [...] rt.cpan.org>; Wed, 7 May 2008 12:04:25 -0400 (EDT)
Received: (qmail 19697 invoked from network); 7 May 2008 16:04:25 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 7 May 2008 16:04:25 -0000
Received: from adsl-75-32-150-206.dsl.pltn13.sbcglobal.net (HELO olympus.sehda.com) (75.32.150.206) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 May 2008 09:04:23 -0700
Received: from harpo.ny.gam3.net (cpe-72-228-92-12.twcny.res.rr.com [72.228.92.12]) by olympus.sehda.com (8.13.8/8.13.8) with SMTP id m47G4KRk022049 for <bug-Module-Build [...] rt.cpan.org>; Wed, 7 May 2008 09:04:20 -0700
Received: (qmail 2021 invoked by uid 1210); 7 May 2008 12:04:19 -0400
Delivered-To: cpan-bug+Module-Build [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35585] testpodcoverage does not test the correct code
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Return-Path: <gam3 [...] gam3.net>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Module-Build [...] rt.cpan.org
Date: Wed, 7 May 2008 12:04:19 -0400
X-Spam-Level: *
Message-Id: <20080507160419.GA560 [...] gam3.net>
To: Eric Wilhelm via RT <bug-Module-Build [...] rt.cpan.org>
From: "G. Allen Morris III" <gam3 [...] gam3.net>
RT-Message-ID: <rt-3.6.HEAD-25333-1210176272-1908.35585-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: us-ascii
X-RT-Original-Encoding: utf-8
Content-Length: 285
Download (untitled) / with headers
text/plain 285b
On Wed, May 07, 2008 at 11:47:12AM -0400, Eric Wilhelm via RT wrote: Show quoted text
> > Am I missing something or are you running old code?
As I stated in the original post; I am running 0.2807. And it does seem that it is fixed in 0.2808. Thanks Eric. Sorry for all the confusion. Show quoted text
> > --Eric
Content-Description: Digital signature
content-type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline
Content-Length: 242
Download signature.asc
application/pgp-signature 242b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Charset: utf8
Message-Id: <rt-3.6.HEAD-30967-1210176628-915.35585-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 504
Download (untitled) / with headers
text/plain 504b
On Fri May 02 12:30:18 2008, http://gam3.myopenid.com/ wrote: Show quoted text
> Test::Pod::Coverage::all_pod_coverage_ok() uses @INC to load the modules > that it is testing. Currently Module::Build does not set @INC to > include the blib/lib directory, so only installed versions of the module > being tested are checked. > > This patch set @INC so that all modules in 'libdoc_dirs()' be tested. > > This might be more of a bug in Test::Pod::Coverage as it look for > modules in blib/ even in blib/ is not in @INC.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.