Skip Menu |
 

This queue is for tickets about the Net-Clickatell CPAN distribution.

Report information
The Basics
Id: 35249
Status: resolved
Priority: 0/
Queue: Net-Clickatell

People
Owner: MOBILEART [...] cpan.org
Requestors: perl [...] abc-rallying.co.uk
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.10
Fixed in: (no value)



Subject: UseSSL bug during initialisation
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1208761658-9073-8"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 716
Download (untitled) / with headers
text/plain 716b
I have been looking at using your perl module Net::Clickatell 0.10. I wrote some module tests to check the functionality and I noticed a couple of bugs. In 'new' the BASE_URL is always set to https even if UseSSL is set to zero. The condition 'if (exists $args{UseSSL})' should read 'if ($args{UseSSL})'. sendSIWAPPush uses a routine 'getTime' which is not defined. sendMMNotification defines a variable $tranid which is never used. I have attached the module test file which shows the BASE_URL bug, feel free to include the tests with the module distribution if you wish. You need to have Test::MockModule installed to complete all of the tests. I am running it on Activestate perl 5.8.8 817 under windows XP.
Subject: 01netClickatell.t
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1208761565-9073-7"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/octet-stream; name="01netClickatell.t"
Content-Disposition: inline; filename="01netClickatell.t"
Content-Transfer-Encoding: base64
Content-Length: 18100
Download 01netClickatell.t
text/x-perl 17.6k

Message body is not shown because it is too large.

MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
Message-Id: <rt-3.6.HEAD-9073-1208788853-468.35249-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1208788853-9073-13"
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 53
Have made the changes. Attached is the new package.
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1208788795-9088-1"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/x-compressed; name="Net-Clickatell-0.20.tgz"
Content-Disposition: inline; filename="Net-Clickatell-0.20.tgz"
Content-Transfer-Encoding: base64
Content-Length: 5114
Download Net-Clickatell-0.20.tgz
application/x-compressed 4.9k

Message body not shown because it is not plain text.

MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-9073-1208788853-468.35249-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Charset: utf8
References: <rt-3.6.HEAD-9073-1208788853-468.35249-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-9083-1208851124-1582.35249-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 296
Download (untitled) / with headers
text/plain 296b
On Mon Apr 21 10:40:53 2008, MOBILEART wrote: Show quoted text
> Have made the changes. > > Attached is the new package.
Thanks for the quick response. it has been fixed when the baseUrl has been supplied (line 208) but there is still a path through the code where the bug can show up (line 200) thanks, Ian
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Charset: utf8
Message-Id: <rt-3.6.HEAD-9083-1208858182-772.35249-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 61
Please test it again. Let me know whether it works. Thanks.
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-9083-1208858182-772.35249-6-0 [...] rt.cpan.org>
X-Mailer: livemail.co.uk Webmail
References: <RT-Ticket-35249 [...] rt.cpan.org> <rt-3.6.HEAD-9083-1208858182-772.35249-6-0 [...] rt.cpan.org>
X-Virus-Checked: Checked by ClamAV on 16.mx.develooper.com
Content-Type: multipart/mixed; boundary="=_92d0c74ce21bb45636f526df694a86ed"
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 5E07B4D80EC for <bug-Net-Clickatell [...] rt.cpan.org>; Tue, 22 Apr 2008 09:33:20 -0400 (EDT)
Received: (qmail 24750 invoked from network); 22 Apr 2008 13:33:19 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 22 Apr 2008 13:33:19 -0000
Received: from smtp-out-68.livemail.co.uk (HELO smtp-out-68.livemail.co.uk) (213.171.216.68) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Apr 2008 06:33:11 -0700
Received: from webmail.abc-rallying.co.uk (mail213-171-216-230.livemail.co.uk [213.171.216.230]) by smtp-out-68.livemail.co.uk (Postfix) with SMTP id 9E53445EF3A; Tue, 22 Apr 2008 14:33:05 +0100 (BST)
Delivered-To: cpan-bug+Net-Clickatell [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35249] UseSSL bug during initialisation
Return-Path: <ian [...] abc-rallying.co.uk>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Net-Clickatell [...] rt.cpan.org
Date: Tue, 22 Apr 2008 14:33:05 +0100
X-Spam-Level: *
Message-Id: <jzqaz5.ce8dem [...] webmail.abc-rallying.co.uk>
To: bug-Net-Clickatell [...] rt.cpan.org
From: "Ian Clark" <ian [...] abc-rallying.co.uk>
RT-Message-ID: <rt-3.6.HEAD-9095-1208871212-841.35249-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: iso-8859-1
X-RT-Original-Encoding: utf-8
Content-Length: 357
Download (untitled) / with headers
text/plain 357b
"Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > Please test it again. Let me know whether it works. > > Thanks. > >
I have tried it against 0.20 and it still fails when UseSSL=>0, and BaseURL is not set. I have attached a small test script which shows the bug. Ian
Content-Type: application/octet-stream
content-disposition: attachment; filename="use_ssl.pl"
Content-Transfer-Encoding: base64
Content-Length: 2119
Download use_ssl.pl
text/x-perl 2k

Message body is not shown because sender requested not to inline it.

MIME-Version: 1.0
In-Reply-To: <rt-3.6.HEAD-9095-1208871212-841.35249-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
References: <RT-Ticket-35249 [...] rt.cpan.org> <rt-3.6.HEAD-9083-1208858182-772.35249-6-0 [...] rt.cpan.org> <jzqaz5.ce8dem [...] webmail.abc-rallying.co.uk> <rt-3.6.HEAD-9095-1208871212-841.35249-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-9093-1208913432-586.35249-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1208913432-9093-10"
From: MOBILEART [...] cpan.org
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 665
Download (untitled) / with headers
text/plain 665b
Sorry, I have attached the new version, some how you didn't get it. Alternatively, you can get it at: http://www.artofmobile.com/Net-Clickatell-0.21.tgz Please test it again. Let me know whether it works. Thanks. On Tue Apr 22 09:33:32 2008, ian@abc-rallying.co.uk wrote: Show quoted text
> "Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: >
> > > > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > > > Please test it again. Let me know whether it works. > > > > Thanks. > > > >
> > I have tried it against 0.20 and it still fails when UseSSL=>0, and > BaseURL is > not set. I have attached a small test script which shows the bug. > > Ian >
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1208913421-9073-38"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Charset: utf8
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: application/x-compressed; name="Net-Clickatell-0.21.tgz"
Content-Disposition: inline; filename="Net-Clickatell-0.21.tgz"
Content-Transfer-Encoding: base64
Content-Length: 5124
Download Net-Clickatell-0.21.tgz
application/x-compressed 5k

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-9093-1208913432-586.35249-6-0 [...] rt.cpan.org>
X-Mailer: livemail.co.uk Webmail
References: <RT-Ticket-35249 [...] rt.cpan.org> <rt-3.6.HEAD-9083-1208858182-772.35249-6-0 [...] rt.cpan.org> <jzqaz5.ce8dem [...] webmail.abc-rallying.co.uk> <rt-3.6.HEAD-9095-1208871212-841.35249-6-0 [...] rt.cpan.org> <rt-3.6.HEAD-9093-1208913432-586.35249-6-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: iso-8859-1
Received: from x1.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 31FDD4D807A for <bug-Net-Clickatell [...] rt.cpan.org>; Wed, 23 Apr 2008 03:30:38 -0400 (EDT)
Received: (qmail 24833 invoked from network); 23 Apr 2008 07:30:37 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 23 Apr 2008 07:30:37 -0000
Received: from smtp-out-68.livemail.co.uk (HELO smtp-out-68.livemail.co.uk) (213.171.216.68) by 16.mx.develooper.com (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Apr 2008 00:30:32 -0700
Received: from webmail.abc-rallying.co.uk (mail213-171-216-230.livemail.co.uk [213.171.216.230]) by smtp-out-68.livemail.co.uk (Postfix) with SMTP id 9378045EF26 for <bug-Net-Clickatell [...] rt.cpan.org>; Wed, 23 Apr 2008 08:30:27 +0100 (BST)
Delivered-To: cpan-bug+Net-Clickatell [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #35249] UseSSL bug during initialisation
Return-Path: <ian [...] abc-rallying.co.uk>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: bug-Net-Clickatell [...] rt.cpan.org
Date: Wed, 23 Apr 2008 08:30:27 +0100
X-Spam-Level: *
Message-Id: <jzrour.xpbijw [...] webmail.abc-rallying.co.uk>
To: bug-Net-Clickatell [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: "Ian Clark" <ian [...] abc-rallying.co.uk>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-9088-1208935851-1297.35249-0-0 [...] rt.cpan.org>
Content-Length: 937
Download (untitled) / with headers
text/plain 937b
Yes, that worked fine. Thanks for fixing it so quickly. Cheers, Ian "Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > Sorry, I have attached the new version, some how you didn't get it. > Alternatively, you can get it at: > > http://www.artofmobile.com/Net-Clickatell-0.21.tgz > > Please test it again. Let me know whether it works. > > > Thanks. > > On Tue Apr 22 09:33:32 2008, ian@abc-rallying.co.uk wrote:
> > "Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: > >
> > > > > > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > > > > > Please test it again. Let me know whether it works. > > > > > > Thanks. > > > > > >
> > > > I have tried it against 0.20 and it still fails when UseSSL=>0, and > > BaseURL is > > not set. I have attached a small test script which shows the bug. > > > > Ian > >
> > > >
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Charset: utf8
Message-Id: <rt-3.6.HEAD-9077-1209347624-902.35249-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 67
Problem resolved in version 0.2.1. A new version-- 0.3 is released.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.