Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the PPI CPAN distribution.

Report information
The Basics
Id: 31563
Status: resolved
Priority: 0/
Queue: PPI

People
Owner: Nobody in particular
Requestors: TELS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.201
Fixed in: (no value)



Subject: documentation of "delete" method is wrong
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Type: text/plain
Charset: utf8
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 566
Download (untitled) / with headers
text/plain 566b
remove The documentation of "delete" is wrong, it contains a copy&paste version from the "remove" method: delete For a given "PPI::Element", the "remove" method will remove it from its parent, immediately deleting the "Element" and all of its children (if it has any). Returns true if the "Element" was successfully deleted, or "undef" if an error occurs while trying to remove the "Ele‐ ment". Also, the documentation could make more clear what the actual difference between "remove" and "delete" is, if there is any.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Charset: utf8
Message-Id: <rt-3.6.HEAD-8750-1197740037-1577.31563-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 918
Download (untitled) / with headers
text/plain 918b
On Sat Dec 15 12:19:53 2007, TELS wrote: Show quoted text
> remove > The documentation of "delete" is wrong, it contains a copy&paste version > from the "remove" method: > > delete > > For a given "PPI::Element", the "remove" method will remove it > from its parent, immediately deleting the "Element" and all > of its children (if it has any). > > Returns true if the "Element" was successfully deleted, or > "undef" if an error occurs while trying to remove the "Ele‐ > ment". > > Also, the documentation could make more clear what the actual difference > between "remove" and "delete" is, if there is any.
Hmm, the only difference is that "delete" additionally calls DESTROY explicitly. I suspect this was originally intended to get around memory cycles, but I *think* this is no longer a problem due to the current %_PARENT implementation, but I'm not entirely sure. Adam? Chris
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-29948-1415798241-306.31563-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 62
This was fixed at some point in the past, so i'm closing this.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.