Skip Menu |
 

This queue is for tickets about the JavaScript CPAN distribution.

Report information
The Basics
Id: 30828
Status: open
Priority: 0/
Queue: JavaScript

People
Owner: Nobody in particular
Requestors: ntyni [...] iki.fi
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.04
Fixed in: (no value)



Subject: Test failure on 32-bit architectures
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1088
Hi, the recently released JavaScript-1.04 (thanks!) is failing tests on Debian on all 32-bit architectures, including x86. The 64-bit architectures (amd64, ia64 and alpha) are OK. The test failure is actually two missing OKs from t/20-bind-class.t, tests 9 and 10 (the "Check multiple instance methods" block). There are no test failures because there's no check for $@ after the $cx1->eval() call. I added such a check, and the error string is 'o.fone is not a function at Foo line 103 in 1'. Debian currently has JS_VERSION 170. I haven't tried with other libmozjs versions yet. This is perfectly reproducible for me, and I have both 64-bit and a 32-bit installations so it's easy for me to debug this. I don't understand much about the libmozjs internals, though. So far I have found out that the corresponding js_Invoke() gets called with different arguments, but I have no idea yet what's happening. Are the tests working for you on a 32-bit host? For the record, we're tracking this as Debian bug #451774, http://bugs.debian.org/451774 . Cheers, -- Niko Tyni ntyni@iki.fi
MIME-Version: 1.0 (Apple Message framework v915)
X-Spam-Status: No, hits=-3.6 required=8.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
In-Reply-To: <rt-3.6.HEAD-3898-1195416193-1113.30828-4-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.915)
References: <RT-Ticket-30828 [...] rt.cpan.org> <rt-3.6.HEAD-3898-1195416193-1113.30828-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
X-RT-Original-Encoding: US-ASCII
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id C6D2B4D8044 for <bug-JavaScript [...] rt.cpan.org>; Sun, 18 Nov 2007 15:16:19 -0500 (EST)
Received: (qmail 3577 invoked by alias); 18 Nov 2007 20:16:18 -0000
Received: from s87.loopia.se (HELO s87.loopia.se) (194.9.94.112) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sun, 18 Nov 2007 12:16:03 -0800
Received: (qmail 16175 invoked from network); 18 Nov 2007 20:15:55 -0000
Received: from s34.loopia.se (HELO s19.loopia.se) ([194.9.94.70]) (envelope-sender <claes [...] versed.se>) by s87.loopia.se (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for <bug-JavaScript [...] rt.cpan.org>; 18 Nov 2007 20:15:55 -0000
Received: (qmail 30667 invoked from network); 18 Nov 2007 20:15:56 -0000
Received: from c-46f8e253.06-12-73746f15.cust.bredbandsbolaget.se (HELO [192.168.0.128]) (claes [...] versed.se [...] [83.226.248.70]) (envelope-sender <claes [...] versed.se>) by s19.loopia.se (qmail-ldap-1.03) with AES128-SHA encrypted SMTP for <bug-JavaScript [...] rt.cpan.org>; 18 Nov 2007 20:15:56 -0000
Delivered-To: cpan-bug+javascript [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #30828] Test failure on 32-bit architectures
Return-Path: <claes [...] versed.se>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-JavaScript [...] rt.cpan.org
Date: Sun, 18 Nov 2007 21:15:55 +0100
Message-Id: <BEBF32E4-6821-43BB-8FE1-DF997396B53C [...] versed.se>
To: bug-JavaScript [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Claes Jakobsson <claes [...] versed.se>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-3953-1195416989-1168.30828-0-0 [...] rt.cpan.org>
Content-Length: 1496
Download (untitled) / with headers
text/plain 1.4k
Hi, On 18 nov 2007, at 21.03, ntyni@iki.fi via RT wrote: Show quoted text
> the recently released JavaScript-1.04 (thanks!) is failing tests on > Debian on all 32-bit architectures, including x86. The 64-bit > architectures (amd64, ia64 and alpha) are OK. > > The test failure is actually two missing OKs from t/20-bind-class.t, > tests 9 and 10 (the "Check multiple instance methods" block). There > are > no test failures because there's no check for $@ after the $cx1-
> >eval()
> call. > > I added such a check, and the error string is 'o.fone is not a > function > at Foo line 103 in 1'. > > Debian currently has JS_VERSION 170. I haven't tried with other > libmozjs > versions yet. > > This is perfectly reproducible for me, and I have both 64-bit and a > 32-bit installations so it's easy for me to debug this. I don't > understand much about the libmozjs internals, though. So far I have > found out that the corresponding js_Invoke() gets called with > different > arguments, but I have no idea yet what's happening. > > Are the tests working for you on a 32-bit host?
Hm... I'm developing on Mac OS X 10.5.1 (Darwin 9.1.0) on a Core Duo (32- bit) and there are no problems with those tests there against both a 1.7 and 1.6 release of SM. I also ran the tests for 1.04 on my Debian 4.0 box (Linux sovereign 2.6.8-3-686 #1 Tue Dec 5 21:26:38 UTC 2006 i686 GNU/Linux) which is a 32-bit celeron with a 1.7 release of SM built from source an they all passed. this is truly odd /claes
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-3953-1195416989-1168.30828-6-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-30828 [...] rt.cpan.org> <rt-3.6.HEAD-3898-1195416193-1113.30828-4-0 [...] rt.cpan.org> <BEBF32E4-6821-43BB-8FE1-DF997396B53C [...] versed.se> <rt-3.6.HEAD-3953-1195416989-1168.30828-6-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: us-ascii
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id D0BC34D8044 for <bug-JavaScript [...] rt.cpan.org>; Sun, 18 Nov 2007 16:12:14 -0500 (EST)
Received: (qmail 18556 invoked by alias); 18 Nov 2007 21:12:13 -0000
Received: from sender-01.it.helsinki.fi (HELO sender-01.it.helsinki.fi) (128.214.205.139) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sun, 18 Nov 2007 13:12:11 -0800
Received: from rispa.it.helsinki.fi (hy-ovpn1-102.vpn.helsinki.fi [128.214.182.230]) by sender-01.it.helsinki.fi (8.13.8/8.13.8) with ESMTP id lAILC5Kc000678 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for <bug-JavaScript [...] rt.cpan.org>; Sun, 18 Nov 2007 23:12:05 +0200
Received: from niko by rispa.it.helsinki.fi with local (Exim 4.63) (envelope-from <ntyni [...] cc.helsinki.fi>) id 1ItrQu-0003x7-4s for bug-JavaScript [...] rt.cpan.org; Sun, 18 Nov 2007 23:12:00 +0200
Delivered-To: cpan-bug+javascript [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #30828] Test failure on 32-bit architectures
User-Agent: Mutt/1.5.13 (2006-08-11)
Return-Path: <ntyni [...] cc.helsinki.fi>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-JavaScript [...] rt.cpan.org
Date: Sun, 18 Nov 2007 23:12:00 +0200
Message-Id: <20071118211200.GA15186 [...] rispa.it.helsinki.fi>
To: Claes Jakobsson via RT <bug-JavaScript [...] rt.cpan.org>
From: Niko Tyni <ntyni [...] iki.fi>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-3948-1195420341-18.30828-0-0 [...] rt.cpan.org>
Content-Length: 670
Download (untitled) / with headers
text/plain 670b
On Sun, Nov 18, 2007 at 03:16:31PM -0500, Claes Jakobsson via RT wrote: Show quoted text
> I'm developing on Mac OS X 10.5.1 (Darwin 9.1.0) on a Core Duo (32- > bit) and there are no problems with those tests there against both a > 1.7 and 1.6 release of SM. > > I also ran the tests for 1.04 on my Debian 4.0 box (Linux sovereign > 2.6.8-3-686 #1 Tue Dec 5 21:26:38 UTC 2006 i686 GNU/Linux) which is a > 32-bit celeron with a 1.7 release of SM built from source an they all > passed.
FWIW, we're building with JS_THREADSAFE=1 JS_ENABLE_E4X=1 JS_UTF8=0 since that seems to be what the libmozjs package was compiled with. Does that match your configuration? Cheers, -- Niko
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-3953-1195416989-1168.30828-6-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-30828 [...] rt.cpan.org> <rt-3.6.HEAD-3898-1195416193-1113.30828-4-0 [...] rt.cpan.org> <BEBF32E4-6821-43BB-8FE1-DF997396B53C [...] versed.se> <rt-3.6.HEAD-3953-1195416989-1168.30828-6-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: us-ascii
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 6FBB74D8155 for <bug-JavaScript [...] rt.cpan.org>; Mon, 19 Nov 2007 15:43:03 -0500 (EST)
Received: (qmail 20326 invoked by alias); 19 Nov 2007 20:43:03 -0000
Received: from sender-02.it.helsinki.fi (HELO sender-02.it.helsinki.fi) (128.214.205.137) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 19 Nov 2007 12:42:52 -0800
Received: from rispa.it.helsinki.fi (hy-ovpn2-111.vpn.helsinki.fi [128.214.177.239]) by sender-02.it.helsinki.fi (8.13.8/8.13.8) with ESMTP id lAJKgjww010707 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for <bug-JavaScript [...] rt.cpan.org>; Mon, 19 Nov 2007 22:42:46 +0200
Received: from niko by rispa.it.helsinki.fi with local (Exim 4.63) (envelope-from <ntyni [...] cc.helsinki.fi>) id 1IuDS4-0005ba-FO for bug-JavaScript [...] rt.cpan.org; Mon, 19 Nov 2007 22:42:40 +0200
Delivered-To: cpan-bug+javascript [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #30828] Test failure on 32-bit architectures
User-Agent: Mutt/1.5.13 (2006-08-11)
Return-Path: <ntyni [...] cc.helsinki.fi>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-JavaScript [...] rt.cpan.org
Date: Mon, 19 Nov 2007 22:42:40 +0200
Message-Id: <20071119204240.GA21473 [...] rispa.it.helsinki.fi>
To: Claes Jakobsson via RT <bug-JavaScript [...] rt.cpan.org>
From: Niko Tyni <ntyni [...] iki.fi>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-3957-1195505009-600.30828-0-0 [...] rt.cpan.org>
Content-Length: 577
Download (untitled) / with headers
text/plain 577b
On Sun, Nov 18, 2007 at 03:16:31PM -0500, Claes Jakobsson via RT wrote: Show quoted text
> > Are the tests working for you on a 32-bit host?
Show quoted text
> this is truly odd
Update: the difference is that the Debian libmozjs.so is compiled with MOZILLA_1_8_BRANCH. I can reproduce the problem with stock js-1.7.0.tar.gz and % make -f Makefile.ref JS_THREADSAFE=1 XCFLAGS=-DMOZILLA_1_8_BRANCH=1 The tests succeed when building JavaScript 1.04 with -DMOZILLA_1_8_BRANCH=1, which changes some things in <mozjs/jsapi.h>. Now we should just come up with a clean way to integrate this... Cheers, -- Niko
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <20071119204240.GA21473 [...] rispa.it.helsinki.fi>
Content-Disposition: inline
References: <RT-Ticket-30828 [...] rt.cpan.org> <rt-3.6.HEAD-3898-1195416193-1113.30828-4-0 [...] rt.cpan.org> <BEBF32E4-6821-43BB-8FE1-DF997396B53C [...] versed.se> <rt-3.6.HEAD-3953-1195416989-1168.30828-6-0 [...] rt.cpan.org> <20071119204240.GA21473 [...] rispa.it.helsinki.fi>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: us-ascii
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 748644D80BD for <bug-JavaScript [...] rt.cpan.org>; Tue, 20 Nov 2007 08:13:49 -0500 (EST)
Received: (qmail 15676 invoked by alias); 20 Nov 2007 13:13:49 -0000
Received: from sender-02.it.helsinki.fi (HELO sender-02.it.helsinki.fi) (128.214.205.137) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 20 Nov 2007 05:13:40 -0800
Received: from rispa.it.helsinki.fi (hy-ovpn2-47.vpn.helsinki.fi [128.214.177.175]) by sender-02.it.helsinki.fi (8.13.8/8.13.8) with ESMTP id lAKDDYvA009654 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for <bug-JavaScript [...] rt.cpan.org>; Tue, 20 Nov 2007 15:13:34 +0200
Received: from niko by rispa.it.helsinki.fi with local (Exim 4.63) (envelope-from <ntyni [...] cc.helsinki.fi>) id 1IuSuu-0007h6-QY for bug-JavaScript [...] rt.cpan.org; Tue, 20 Nov 2007 15:13:28 +0200
Delivered-To: cpan-bug+javascript [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #30828] Test failure on 32-bit architectures
User-Agent: Mutt/1.5.13 (2006-08-11)
Return-Path: <ntyni [...] cc.helsinki.fi>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-JavaScript [...] rt.cpan.org
Date: Tue, 20 Nov 2007 15:13:28 +0200
Message-Id: <20071120131328.GA29509 [...] rispa.it.helsinki.fi>
To: Claes Jakobsson via RT <bug-JavaScript [...] rt.cpan.org>
From: Niko Tyni <ntyni [...] iki.fi>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-3929-1195564440-1463.30828-0-0 [...] rt.cpan.org>
Content-Length: 337
Download (untitled) / with headers
text/plain 337b
On Mon, Nov 19, 2007 at 10:42:40PM +0200, Niko Tyni wrote: Show quoted text
> The tests succeed when building JavaScript 1.04 with > -DMOZILLA_1_8_BRANCH=1, which changes some things in <mozjs/jsapi.h>. > > Now we should just come up with a clean way to integrate this...
See also Debian bug #441059, http://bugs.debian.org/441059 . Cheers, -- Niko
MIME-Version: 1.0 (Apple Message framework v915)
X-Spam-Status: No, hits=-3.6 required=8.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
In-Reply-To: <rt-3.6.HEAD-3929-1195564440-1463.30828-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.915)
References: <RT-Ticket-30828 [...] rt.cpan.org> <rt-3.6.HEAD-3898-1195416193-1113.30828-4-0 [...] rt.cpan.org> <BEBF32E4-6821-43BB-8FE1-DF997396B53C [...] versed.se> <rt-3.6.HEAD-3953-1195416989-1168.30828-6-0 [...] rt.cpan.org> <20071119204240.GA21473 [...] rispa.it.helsinki.fi> <20071120131328.GA29509 [...] rispa.it.helsinki.fi> <rt-3.6.HEAD-3929-1195564440-1463.30828-5-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"; delsp="yes"; format="flowed"
X-RT-Original-Encoding: US-ASCII
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 70DDF4D80B3 for <bug-JavaScript [...] rt.cpan.org>; Tue, 20 Nov 2007 08:21:11 -0500 (EST)
Received: (qmail 17590 invoked by alias); 20 Nov 2007 13:21:10 -0000
Received: from s87.loopia.se (HELO s87.loopia.se) (194.9.94.112) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 20 Nov 2007 05:20:55 -0800
Received: (qmail 51982 invoked from network); 20 Nov 2007 13:20:49 -0000
Received: from s34.loopia.se (HELO s24.loopia.se) ([194.9.94.70]) (envelope-sender <claes [...] versed.se>) by s87.loopia.se (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for <bug-JavaScript [...] rt.cpan.org>; 20 Nov 2007 13:20:49 -0000
Received: (qmail 52038 invoked from network); 20 Nov 2007 13:20:49 -0000
Received: from c-46f8e253.06-12-73746f15.cust.bredbandsbolaget.se (HELO [192.168.0.128]) (claes [...] versed.se [...] [83.226.248.70]) (envelope-sender <claes [...] versed.se>) by s24.loopia.se (qmail-ldap-1.03) with AES128-SHA encrypted SMTP for <bug-JavaScript [...] rt.cpan.org>; 20 Nov 2007 13:20:49 -0000
Delivered-To: cpan-bug+javascript [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #30828] Test failure on 32-bit architectures
Return-Path: <claes [...] versed.se>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-JavaScript [...] rt.cpan.org
Date: Tue, 20 Nov 2007 14:20:49 +0100
Message-Id: <5038AE08-BEE1-4F6C-945A-4A0B9117A7B8 [...] versed.se>
To: bug-JavaScript [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Claes Jakobsson <claes [...] versed.se>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-3953-1195564880-1985.30828-0-0 [...] rt.cpan.org>
Content-Length: 995
Download (untitled) / with headers
text/plain 995b
Hm.. I think the sensible thing would be to interact with pkg-config on platforms that has it. The whole Makefile.PL and build process in JavaScript.pm needs a lot of fixing. As of 1.1 I'm actually thinking of bundling JS 1.7 (or later) and use that as default unless otherwise specified. Do you want commit-bit and fix all debian issues? I think checking if / etc/debian_version exists would be a good entry point for debian configuration things in Makefile.pl Cheers, Claes On 20 nov 2007, at 14.14, ntyni@iki.fi via RT wrote: Show quoted text
> > Queue: JavaScript > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=30828 > > > On Mon, Nov 19, 2007 at 10:42:40PM +0200, Niko Tyni wrote: >
>> The tests succeed when building JavaScript 1.04 with >> -DMOZILLA_1_8_BRANCH=1, which changes some things in <mozjs/jsapi.h>. >> >> Now we should just come up with a clean way to integrate this...
> > See also Debian bug #441059, http://bugs.debian.org/441059 . > > Cheers, > -- > Niko >
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-3953-1195564880-1985.30828-6-0 [...] rt.cpan.org>
Content-Disposition: inline
References: <RT-Ticket-30828 [...] rt.cpan.org> <rt-3.6.HEAD-3898-1195416193-1113.30828-4-0 [...] rt.cpan.org> <BEBF32E4-6821-43BB-8FE1-DF997396B53C [...] versed.se> <rt-3.6.HEAD-3953-1195416989-1168.30828-6-0 [...] rt.cpan.org> <20071119204240.GA21473 [...] rispa.it.helsinki.fi> <20071120131328.GA29509 [...] rispa.it.helsinki.fi> <rt-3.6.HEAD-3929-1195564440-1463.30828-5-0 [...] rt.cpan.org> <5038AE08-BEE1-4F6C-945A-4A0B9117A7B8 [...] versed.se> <rt-3.6.HEAD-3953-1195564880-1985.30828-6-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: us-ascii
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id E46D64D806F for <bug-JavaScript [...] rt.cpan.org>; Thu, 22 Nov 2007 06:03:31 -0500 (EST)
Received: (qmail 13435 invoked by alias); 22 Nov 2007 11:03:30 -0000
Received: from sender-01.it.helsinki.fi (HELO sender-01.it.helsinki.fi) (128.214.205.139) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 22 Nov 2007 03:03:11 -0800
Received: from rispa.it.helsinki.fi (hy-ovpn2-120.vpn.helsinki.fi [128.214.177.248]) by sender-01.it.helsinki.fi (8.13.8/8.13.8) with ESMTP id lAMB35Os021955 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for <bug-JavaScript [...] rt.cpan.org>; Thu, 22 Nov 2007 13:03:05 +0200
Received: from niko by rispa.it.helsinki.fi with local (Exim 4.63) (envelope-from <ntyni [...] cc.helsinki.fi>) id 1Iv9pg-0002Tq-TK for bug-JavaScript [...] rt.cpan.org; Thu, 22 Nov 2007 13:02:57 +0200
Delivered-To: cpan-bug+javascript [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #30828] Test failure on 32-bit architectures
User-Agent: Mutt/1.5.13 (2006-08-11)
Return-Path: <ntyni [...] cc.helsinki.fi>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-JavaScript [...] rt.cpan.org
Date: Thu, 22 Nov 2007 13:02:56 +0200
Message-Id: <20071122110256.GA9070 [...] rispa.it.helsinki.fi>
To: Claes Jakobsson via RT <bug-JavaScript [...] rt.cpan.org>
From: Niko Tyni <ntyni [...] iki.fi>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-3914-1195729435-1136.30828-0-0 [...] rt.cpan.org>
Content-Length: 1469
Download (untitled) / with headers
text/plain 1.4k
On Tue, Nov 20, 2007 at 08:21:22AM -0500, Claes Jakobsson via RT wrote: Show quoted text
> I think the sensible thing would be to interact with pkg-config on > platforms that has it.
Yeah, at least for finding out the headers and the library paths. There's JS_THREADSAFE in there on Debian, but no information about the other ABI things (JS_UTF8, MOZILLA_1_8_BRANCH). I would assume that writing a small C program (autoconf?) to detect the library ABI things automatically would not be very hard. Of course testing it on the possible OS and mozjs version combinations is the hard part... Show quoted text
> The whole Makefile.PL and build process in JavaScript.pm needs a lot > of fixing. As of > 1.1 I'm actually thinking of bundling JS 1.7 (or later) and use that > as default unless > otherwise specified.
The bundling sounds overkill to me, but if it's going to reduce your support requests... Maybe just state 1.7 is the only one supported? Show quoted text
> Do you want commit-bit and fix all debian issues?
Thanks, but I'm not sure I want to get that involved, given that I'm not actually using the module myself for anything real. I'm happy to test out things, though, if you like. Show quoted text
> I think checking if /etc/debian_version exists > would be a good entry point for debian configuration things in > Makefile.pl
I'm not sure if derivatives like Ubuntu have it... In general testing for features and not versions is the way to go, but that makes for more work again, of course. Cheers, -- Niko


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.