This queue is for tickets about the Business-Hours CPAN distribution.

Report information
The Basics
Id:
2959
Status:
resolved
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
brooksch [...] mac.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Return-Path: <brooksch@mac.com>
Delivered-To: cpan-bug+business-hours@pallas.eruditorum.org
Received: from smtpout.mac.com (A17-250-248-86.apple.com [17.250.248.86]) by pallas.eruditorum.org (Postfix) with ESMTP id 143761122A for <bug-business-hours@rt.cpan.org>; Tue, 15 Jul 2003 10:29:23 -0400 (EDT)
Received: from mac.com (smtpin07-en2 [10.13.10.152]) by smtpout.mac.com (Xserve/MantshX 2.0) with ESMTP id h6FETMCR012412 for <bug-business-hours@rt.cpan.org>; Tue, 15 Jul 2003 07:29:22 -0700 (PDT)
Received: from mac.com (cpe-203-45-216-56.qld.bigpond.net.au [203.45.216.56]) (authenticated bits=0) by mac.com (Xserve/8.12.9/MantshX 2.0) with ESMTP id h6FETI9d007731 for <bug-business-hours@rt.cpan.org>; Tue, 15 Jul 2003 07:29:20 -0700 (PDT)
Date: Wed, 16 Jul 2003 00:30:12 +1000
MIME-Version: 1.0 (Apple Message framework v552)
Content-Type: text/plain; delsp=yes; charset=US-ASCII; format=flowed
Subject: Business::Hours 0.05 make test failures on Solaris 5.8/Perl 5.8.0
From: Brook Schofield <brooksch@mac.com>
To: bug-business-hours@rt.cpan.org
Content-Transfer-Encoding: 7bit
Message-Id: <D7CAAAC4-B6D0-11D7-8F61-000A278288A2@mac.com>
X-Mailer: Apple Mail (2.552)
X-RT-Original-Encoding: us-ascii
Content-Length: 4755
% uname -a SunOS balius 5.8 Generic_108528-13 sun4u sparc SUNW,Sun-Blade-100 % perl -V Summary of my perl5 (revision 5.0 version 8 subversion 0) configuration: Platform: osname=solaris, osvers=2.8, archname=sun4-solaris uname='sunos balius 5.8 generic_108528-13 sun4u sparc sunw,sun-blade-100 ' config_args='-Dcc=gcc -B/usr/ccs/bin/' hint=recommended, useposix=true, d_sigaction=define usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef useperlio=define d_sfio=undef uselargefiles=define usesocks=undef use64bitint=undef use64bitall=undef uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='gcc -B/usr/ccs/bin/', ccflags ='-fno-strict-aliasing -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O', cppflags='-fno-strict-aliasing' ccversion='', gccversion='3.2', gccosandvers='solaris2.8' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=4321 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='gcc -B/usr/ccs/bin/', ldflags =' -L/usr/local/lib ' libpth=/usr/local/lib /usr/lib /usr/ccs/lib libs=-lsocket -lnsl -ldl -lm -lc perllibs=-lsocket -lnsl -ldl -lm -lc libc=/lib/libc.so, so=so, useshrplib=false, libperl=libperl.a gnulibc_version='' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' ' cccdlflags='-fPIC', lddlflags='-G -L/usr/local/lib' Characteristics of this binary (from libperl): Compile-time options: USE_LARGE_FILES Built under solaris Compiled at Nov 28 2002 09:45:59 @INC: /usr/local/lib/perl5/5.8.0/sun4-solaris /usr/local/lib/perl5/5.8.0 /usr/local/lib/perl5/site_perl/5.8.0/sun4-solaris /usr/local/lib/perl5/site_perl/5.8.0 /usr/local/lib/perl5/site_perl Installation output from perl -MCPAN -e shell Running make for J/JE/JESSE/Business-Hours-0.05.tar.gz Checksum for /export/home/its/s228969/.cpan/sources/authors/id/J/JE/JESSE/Business- Hours-0.05.tar.gz ok x Business-Hours-0.05, 0 bytes, 0 tape blocks x Business-Hours-0.05/Todo, 43 bytes, 1 tape blocks x Business-Hours-0.05/Makefile.PL, 1417 bytes, 3 tape blocks x Business-Hours-0.05/Changes, 276 bytes, 1 tape blocks x Business-Hours-0.05/README, 2426 bytes, 5 tape blocks x Business-Hours-0.05/t, 0 bytes, 0 tape blocks x Business-Hours-0.05/t/embedded-Business-Hours.t, 2574 bytes, 6 tape blocks x Business-Hours-0.05/LICENSE, 20545 bytes, 41 tape blocks x Business-Hours-0.05/MANIFEST, 99 bytes, 1 tape blocks x Business-Hours-0.05/lib, 0 bytes, 0 tape blocks x Business-Hours-0.05/lib/Business, 0 bytes, 0 tape blocks x Business-Hours-0.05/lib/Business/Hours.pm, 12969 bytes, 26 tape blocks Removing previously used /export/home/its/s228969/.cpan/build/Business-Hours-0.05 CPAN.pm: Going to build J/JE/JESSE/Business-Hours-0.05.tar.gz Checking if your kit is complete... Looks good Writing Makefile for Business::Hours cp lib/Business/Hours.pm blib/lib/Business/Hours.pm Manifying blib/man3/Business::Hours.3 /usr/local/bin/make -- OK Running make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/embedded-Business-Hours....NOK 4# Failed test (lib/Business/Hours.pm at line 199) # got: '162001' # expected: '162000' t/embedded-Business-Hours....NOK 6# Failed test (lib/Business/Hours.pm at line 386) # got: '82800' # expected: '72000' t/embedded-Business-Hours....NOK 8# Failed test (lib/Business/Hours.pm at line 393) # got: '10' # expected: '9' t/embedded-Business-Hours....ok 13/0# Looks like you failed 3 tests of 13. t/embedded-Business-Hours....dubious Test returned status 3 (wstat 768, 0x300) DIED. FAILED tests 4, 6, 8 Failed 3/13 tests, 76.92% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------ ------- t/embedded-Business-Hours.t 3 768 13 3 23.08% 4 6 8 Failed 1/1 test scripts, 0.00% okay. 3/13 subtests failed, 76.92% okay. make: *** [test_dynamic] Error 2 /usr/local/bin/make test -- NOT OK Running make install Installing /usr/local/lib/perl5/site_perl/5.8.0/Business/Hours.pm Installing /usr/local/man/man3/Business::Hours.3 Writing /usr/local/lib/perl5/site_perl/5.8.0/sun4-solaris/auto/Business/Hours/ .packlist Appending installation info to /usr/local/lib/perl5/5.8.0/sun4-solaris/perllocal.pod /usr/local/bin/make install UNINST=1 -- OK
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.405 (Entity 5.404)
X-RT-Original-Encoding: iso-8859-1
Content-Length: 45
Should be fixed in 0.06, which is in cpan now
Return-Path: <brooksch@mac.com>
Delivered-To: cpan-bug+business-hours@pallas.eruditorum.org
Received: from smtpout.mac.com (smtpout.mac.com [17.250.248.89]) by pallas.eruditorum.org (Postfix) with ESMTP id 1C79611237 for <bug-business-hours@rt.cpan.org>; Tue, 29 Jul 2003 10:55:12 -0400 (EDT)
Received: from mac.com (smtpin08-en2 [10.13.10.153]) by smtpout.mac.com (Xserve/MantshX 2.0) with ESMTP id h6TEtAcx000674; Tue, 29 Jul 2003 07:55:10 -0700 (PDT)
Received: from mac.com (cpe-203-45-216-56.qld.bigpond.net.au [203.45.216.56]) (authenticated bits=0) by mac.com (Xserve/8.12.9/MantshX 2.0) with ESMTP id h6TEt6Nr008983; Tue, 29 Jul 2003 07:55:08 -0700 (PDT)
Date: Wed, 30 Jul 2003 00:56:15 +1000
Subject: Re: [cpan #2959] Business::Hours 0.05 make test failures in +10GMT
Content-Type: multipart/mixed; boundary=Apple-Mail-5--421003336
MIME-Version: 1.0 (Apple Message framework v552)
CC: jesse@bestpractical.com
To: bug-business-hours@rt.cpan.org
From: Brook Schofield <brooksch@mac.com>
In-Reply-To: <rt-2959-8678.10.3704127934015@cpan.org>
Message-Id: <CD4F82D6-C1D4-11D7-8167-000A278288A2@mac.com>
X-Mailer: Apple Mail (2.552)
RT-Send-Cc:
Content-Length: 0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; delsp=yes; charset=US-ASCII; format=flowed
X-RT-Original-Encoding: iso-8859-1
Content-Length: 2252
On Saturday, July 19, 2003, at 10:01 AM, via RT wrote:
Show quoted text
> Full context and any attached attachments can be found at: > <URL: http://rt.cpan.org/NoAuth/Bug.html?id=2959 > > > Should be fixed in 0.06, which is in cpan now
Not quite! There were still problems with test 4 & 6: t/embedded-Business-Hours....NOK 4# Failed test (lib/Business/Hours.pm at line 199) # got: '162001' # expected: '162000' t/embedded-Business-Hours....NOK 6# Failed test (lib/Business/Hours.pm at line 399) # got: '86400' # expected: '0' I tracked down where the extra second is coming from - I think. So I added an additional 22 tests (included in the patch) and it actually appears that the tests were wrong. Not the code. Because localtime of '0' is actually 10am in Australia rather than midnight UTC or close of business in the US the calculation of time is off. The tests I've added seem to do a better job of replacing test #4 on line 199. Change at your discretion. For the test on line 399 (Now on line 422). I have really no idea. Probably still a timezone problem. Remember that 0 seconds since the epoch is a business second in Australia: % perl -e 'print scalar localtime(0);' Thu Jan 1 10:00:00 1970 So I haven't figured that one out yet. But one problem less for Ozzie RTIR users. The remaining error is included below - any hints? -Brook # make test cp lib/Business/Hours.pm blib/lib/Business/Hours.pm PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/embedded-Business-Hours....# Failed test (lib/Business/Hours.pm at line 422) # got: '86400' # expected: '0' t/embedded-Business-Hours....ok 51/0# Looks like you failed 1 tests of 51. t/embedded-Business-Hours....dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 44 Failed 1/51 tests, 98.04% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------ ------- t/embedded-Business-Hours.t 1 256 51 1 1.96% 44 Failed 1/1 test scripts, 0.00% okay. 1/51 subtests failed, 98.04% okay. make: *** [test_dynamic] Error 2
Content-Disposition: attachment; filename=bh_005.patch
Content-Transfer-Encoding: 7bit
Content-Type: application/octet-stream; x-unix-mode=0644; name="bh_005.patch"
Content-Length: 2106

Message body is not shown because sender requested not to inline it.

Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII; format=flowed
X-RT-Original-Encoding: iso-8859-1
Content-Length: 1


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.