Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Storable CPAN distribution.

Report information
The Basics
Id: 28537
Status: open
Priority: 0/
Queue: Storable

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.16
Fixed in: (no value)



Subject: PATCH for croak.t test failure
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1185700215-28249-17"
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 269
Download (untitled) / with headers
text/plain 269b
The attached patch solves a possible failure in the croak.t test. It seems that in some version Config.pm pre-loads Carp.pm, causing the test to fail. The patch just makes sure that Config.pm is only loaded when building Storable within core perl. Regards, Slaven
Subject: Storable-croak.t.patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1185700210-28249-16"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Type: application/octet-stream; name="Storable-croak.t.patch"
Content-Disposition: inline; filename="Storable-croak.t.patch"
Content-Transfer-Encoding: base64
Content-Length: 2594
# # # To apply this patch: # STEP 1: Chdir to the source directory. # STEP 2: Run the 'applypatch' program with this patch file as input. # # If you do not have 'applypatch', it is part of the 'makepatch' package # that you can fetch from the Comprehensive Perl Archive Network: # http://www.perl.com/CPAN/authors/Johan_Vromans/makepatch-x.y.tar.gz # In the above URL, 'x' should be 2 or higher. # # To apply this patch without the use of 'applypatch': # STEP 1: Chdir to the source directory. # STEP 2: Run the 'patch' program with this file as input. # #### End of Preamble #### #### Patch data follows #### diff -up 'build/Storable-2.16-0XWdnJ/t/croak.t' 'new.build/Storable-2.16-MSm6we/t/croak.t' Index: ./t/croak.t --- ./t/croak.t Fri Aug 16 21:15:56 2002 +++ ./t/croak.t Sun Jul 29 10:27:02 2007 @@ -10,10 +10,13 @@ sub BEGIN { chdir('t') if -d 't'; @INC = ('.', '../lib'); } - require Config; import Config; - if ($ENV{PERL_CORE} and $Config{'extensions'} !~ /\bStorable\b/) { - print "1..0 # Skip: Storable was not built\n"; - exit 0; + if ($ENV{PERL_CORE}) { + require Config; import Config; + %Config=%Config if 0; # cease -w + if ($Config{'extensions'} !~ /\bStorable\b/) { + print "1..0 # Skip: Storable was not built\n"; + exit 0; + } } } #### End of Patch data #### #### ApplyPatch data follows #### # Data version : 1.0 # Date generated : Sun Jul 29 11:07:01 2007 # Generated by : makepatch 2.03 # Recurse directories : Yes # Excluded files : (\A|/).*\~\Z # (\A|/).*\.a\Z # (\A|/).*\.bak\Z # (\A|/).*\.BAK\Z # (\A|/).*\.elc\Z # (\A|/).*\.exe\Z # (\A|/).*\.gz\Z # (\A|/).*\.ln\Z # (\A|/).*\.o\Z # (\A|/).*\.obj\Z # (\A|/).*\.olb\Z # (\A|/).*\.old\Z # (\A|/).*\.orig\Z # (\A|/).*\.rej\Z # (\A|/).*\.so\Z # (\A|/).*\.Z\Z # (\A|/)\.del\-.*\Z # (\A|/)\.make\.state\Z # (\A|/)\.nse_depinfo\Z # (\A|/)core\Z # (\A|/)tags\Z # (\A|/)TAGS\Z # p 't/croak.t' 997 1185697622 0100555 #### End of ApplyPatch data #### #### End of Patch kit [created: Sun Jul 29 11:07:01 2007] #### #### Patch checksum: 56 1936 53231 #### #### Checksum: 74 2560 39223 ####
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,DKIM_POLICY_SIGNSOME,DK_POLICY_SIGNSOME,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-28249-1185700244-992.28537-4-0 [...] rt.cpan.org>
Content-Disposition: inline
Received-SPF: pass (x1.develooper.com: local policy)
References: <RT-Ticket-28537 [...] rt.cpan.org> <rt-3.6.HEAD-28249-1185700244-992.28537-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: us-ascii
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 3A8874D809A for <bug-Storable [...] rt.cpan.org>; Sun, 29 Jul 2007 09:46:17 -0400 (EDT)
Received: (qmail 29969 invoked by alias); 29 Jul 2007 13:46:16 -0000
Received: from fugue.toroid.org (HELO fugue.toroid.org) (85.10.196.113) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sun, 29 Jul 2007 06:46:04 -0700
Received: from penne (localhost [127.0.0.1]) by fugue.toroid.org (Postfix) with ESMTP id 6630D147E3 for <bug-Storable [...] rt.cpan.org>; Sun, 29 Jul 2007 15:45:58 +0200 (CEST)
Received: by penne (Postfix, from userid 1000) id 95124ADC4B0; Sun, 29 Jul 2007 19:15:57 +0530 (IST)
Delivered-To: cpan-bug+storable [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #28537] PATCH for croak.t test failure
Return-Path: <ams [...] toroid.org>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-Storable [...] rt.cpan.org
Date: Sun, 29 Jul 2007 19:15:57 +0530
Message-Id: <20070729134557.GA6120 [...] toroid.org>
To: Slaven_Rezic via RT <bug-Storable [...] rt.cpan.org>
From: Abhijit Menon-Sen <ams [...] toroid.org>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-32143-1185716782-1288.28537-0-0 [...] rt.cpan.org>
Content-Length: 355
Download (untitled) / with headers
text/plain 355b
At 2007-07-29 05:10:46 -0400, bug-Storable@rt.cpan.org wrote: Show quoted text
> > The attached patch solves a possible failure in the croak.t test. It > seems that in some version Config.pm pre-loads Carp.pm, causing the > test to fail. The patch just makes sure that Config.pm is only loaded > when building Storable within core perl.
Thanks, applied. (#31664) -- ams


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.