Skip Menu |
 

This queue is for tickets about the Net-FTPServer CPAN distribution.

Report information
The Basics
Id: 27640
Status: resolved
Priority: 0/
Queue: Net-FTPServer

People
Owner: ryochin [...] cpan.org
Requestors: asw [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.122
Fixed in: (no value)



Subject: MLST is broken
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1182254563-32639-1"
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 166
Download (untitled) / with headers
text/plain 166b
MLST commands do not work. in FTPServer.pm, _MLST_command(), dir() is called on a filehandle object. $self->{cwd} is a dir handle. attached patch fixes the problem.
Subject: mlst_patch.txt
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1182254562-32639-0"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Type: text/plain; charset="utf-8"; name="mlst_patch.txt"
Content-Disposition: inline; filename="mlst_patch.txt"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: ascii
Content-Length: 451
Download mlst_patch.txt
text/plain 451b
--- FTPServer.pm 2007-06-19 12:59:47.610741000 +0100 +++ FTPServer.pm.hack 2007-06-19 12:59:09.967037000 +0100 @@ -6741,8 +6741,8 @@ # If not file name is given, then we need to return # status on the current directory. Else we return # status on the file or directory name given. - my $fileh = $self->{cwd}; - my $dirh = $fileh->dir; + my $dirh = $self->{cwd}; + my $fileh; my $filename = "."; if ($rest ne "")
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Message-Id: <rt-3.6.HEAD-32644-1182259170-1103.27640-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf8"
Content-Transfer-Encoding: binary
From: RWMJ [...] cpan.org
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 299
Download (untitled) / with headers
text/plain 299b
On Tue Jun 19 08:02:46 2007, ASW wrote: Show quoted text
> MLST commands do not work. > in FTPServer.pm, _MLST_command(), dir() is called on a filehandle > object. $self->{cwd} is a dir handle. > attached patch fixes the problem.
I have posted this to the Net::FTPServer mailing list for review and comment. Rich.
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VERIFIED,DK_POLICY_SIGNSOME,DK_SIGNED,SPF_PASS
In-Reply-To: <rt-3.6.HEAD-32644-1182259170-1103.27640-6-0 [...] rt.cpan.org>
Content-Disposition: inline
Received-SPF: pass (x1.develooper.com: domain of sobakasu [...] gmail.com designates 209.85.146.181 as permitted sender)
References: <RT-Ticket-27640 [...] rt.cpan.org> <rt-3.6.HEAD-32644-1182259170-1103.27640-6-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
X-RT-Original-Encoding: ISO-8859-1
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id E32794D815A for <bug-Net-FTPServer [...] rt.cpan.org>; Tue, 19 Jun 2007 10:35:47 -0400 (EDT)
Received: (qmail 12263 invoked by alias); 19 Jun 2007 14:35:47 -0000
Received: from wa-out-1112.google.com (HELO wa-out-1112.google.com) (209.85.146.181) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 19 Jun 2007 07:35:40 -0700
Received: by wa-out-1112.google.com with SMTP id m28so2693398wag for <bug-Net-FTPServer [...] rt.cpan.org>; Tue, 19 Jun 2007 07:35:36 -0700 (PDT)
Received: by 10.114.159.1 with SMTP id h1mr7410263wae.1182263736268; Tue, 19 Jun 2007 07:35:36 -0700 (PDT)
Received: by 10.141.43.7 with HTTP; Tue, 19 Jun 2007 07:35:36 -0700 (PDT)
Delivered-To: cpan-bug+net-ftpserver [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #27640] MLST is broken
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=R5kppCPlNWvergogWXkbFARINNYjnzJo6BVqOz3u7SvEDcqAsZveSjWge1R2nD0gh4msPjJQ+a2UXjrha2dsGDokTOafHncoQlXJ+oRSgHUQDFKvhv01+/FlYpnWdbWLo5MJNTqGYTeklTci+/vpisXU2D75EiaI2t77ArJLNWo=
Return-Path: <sobakasu [...] gmail.com>
Dkim-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JGcjec+LZ7C5jEC5651l7gaw9uorhsWWg2QnfwMjM1XlAV5ehATv7IWXWLno1zZZWvzDb+AaAoOYTPLl+2YcezZhtaT0v/Gzt1AlRei0TxjF+FWKH/n/AqFzKaAvvNFG70Qba04UfoV3spnxnJoua8e4STWigX8hs5sxM6eEGhw=
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-Net-FTPServer [...] rt.cpan.org
Date: Tue, 19 Jun 2007 15:35:36 +0100
Message-Id: <af0c6e840706190735t17c79ec2u8537766813a20091 [...] mail.gmail.com>
To: bug-Net-FTPServer [...] rt.cpan.org
Content-Transfer-Encoding: 7bit
From: Andrew <sobakasu [...] gmail.com>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-32653-1182263753-215.27640-0-0 [...] rt.cpan.org>
Content-Length: 640
Download (untitled) / with headers
text/plain 640b
thanks. re-reading my bug report, it doesn't make much sense. The current code treats $self->{cwd} as a filehandle, but it is a dirhandle. hopefully it's clear from the patch what i'm talking about. On 6/19/07, via RT <bug-Net-FTPServer@rt.cpan.org> wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=27640 > > > On Tue Jun 19 08:02:46 2007, ASW wrote:
> > MLST commands do not work. > > in FTPServer.pm, _MLST_command(), dir() is called on a filehandle > > object. $self->{cwd} is a dir handle. > > attached patch fixes the problem.
> > I have posted this to the Net::FTPServer mailing list for review and > comment. > > Rich. >
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-1365-1352783752-813.27640-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 126
Download (untitled) / with headers
text/plain 126b


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.