Skip Menu |
 

This queue is for tickets about the XML-RSS CPAN distribution.

Report information
The Basics
Id: 27198
Status: resolved
Priority: 0/
Queue: XML-RSS

People
Owner: SHLOMIF [...] cpan.org
Requestors: simonw [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.10
  • 0.2
  • 0.3
  • 0.4
  • 0.5
  • 0.6
  • 0.7
  • 0.8
  • 0.9
  • 0.95
  • 0.96
  • 0.97
  • 0.98_01
  • 0.98_02
  • 0.98_03
  • 0.98_04
  • 0.98_05
  • 1.00
  • 1.01
  • 1.02
  • 1.03
  • 1.04
  • 1.05
  • 1.10
  • 1.11
  • 1.12
  • 1.20
  • 1.21
  • 1.22
Fixed in: (no value)

Attachments
xml_rss_private_output_base_modules.patch



MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1179587210-31189-11"
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 451
Download (untitled) / with headers
text/plain 451b
I was unable to add a media:thumbnail element to an RSS feed. This patch makes $rss->add_module( prefix => 'media', uri => 'http://search.yahoo.com/mrss/' ); my %item = get_item; $item{media} => { thumbnail => { uri => $uri, width => $width, height => $height, }}; work as expected. The code is largely stolen off the output_enclosure method and you may want to refactor it out into a utility method. Thanks, Simon
Subject: xml_rss_private_output_base_modules.patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1179587209-31189-10"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Type: text/x-patch; name="xml_rss_private_output_base_modules.patch"
Content-Disposition: inline; filename="xml_rss_private_output_base_modules.patch"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: ascii
Content-Length: 639
--- Base.pm Sat Feb 24 11:39:35 2007 +++ /usr/local/lib/perl5/site_perl/5.8.8/XML/RSS/Private/Output/Base.pm Sat May 19 15:58:19 2007 @@ -86,7 +86,17 @@ sub _out_tag { my ($self, $tag, $inner) = @_; - return $self->_out("<$tag>" . $self->_encode($inner) . "</$tag>\n"); + if (ref($inner) eq 'HASH') { + return $self->_out( + "<$tag " . + join(' ', + map { "$_=\"" . $self->_encode($inner->{$_}) . '"' } keys(%$inner) + ) . + " />\n" + ); + } else { + return $self->_out("<$tag>" . $self->_encode($inner) . "</$tag>\n"); + } } sub _out_ns_tag {
MIME-Version: 1.0
Subject: This is a duplicate of #25336 which was resolved.
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Message-Id: <rt-3.6.HEAD-14648-1187807157-1436.27198-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 155
Download (untitled) / with headers
text/plain 155b
Duplicate of: http://rt.cpan.org/Public/Bug/Display.html?id=25336 Which was resolved. Next time, please add a regression test for the desired behaviour.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.