Skip Menu |
 

This queue is for tickets about the AxKit2 CPAN distribution.

Report information
The Basics
Id: 24656
Status: new
Priority: 0/
Queue: AxKit2

People
Owner: Nobody in particular
Requestors: yanick+cpan [...] babyl.dyndns.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.1
Fixed in: (no value)



Subject: Console command LEAKs fails without output if Devel::GC::Helper not installed
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1170044306-30285-6"
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 317
Download (untitled) / with headers
text/plain 317b
If LEAKS is called from within the console and Devel::GC::Helper is not installed, the command silently fails (although the logs will reveal that the forked child died because of the missing module). I'm attaching a small patch that wraps the require inside an eval, and warns the user if D::GC::H is not installed.
Subject: console.patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1170044306-30285-5"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Type: application/octet-stream; name="console.patch"
Content-Disposition: inline; filename="console.patch"
Content-Transfer-Encoding: base64
Content-Length: 543
Download console.patch
text/x-diff 543b
=== lib/AxKit2/Console.pm ================================================================== --- lib/AxKit2/Console.pm (revision 766) +++ lib/AxKit2/Console.pm (local) @@ -287,7 +287,10 @@ die "Can't fork" unless defined $pid; return if $pid; - require Devel::GC::Helper; + eval { require Devel::GC::Helper } or + exit $self->write( "you need Devel::GC::Helper to be installed " + ."to run this command" ); + if ($dump) { require Data::Dumper; $Data::Dumper::Terse = 1;


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.