Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 24618
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: smueller [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.01
Fixed in: (no value)



Subject: Capture variable used outside conditional (Wrong)
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 386
Download (untitled) / with headers
text/plain 386b
Hi, If you run PAR.pm through Perl::Critic, you get: Capture variable used outside conditional at line 555, column 18. See page 253 of PBP. Severity: 3 0555: CORE::exit($1) if ($@ =~/^_TK_EXIT_\((\d+)\)/); Now, the $1 is *not* used outside a conditional. Keep up the good work! Steffen P.S.: I used the online-validator at perlcritic.com. I suppose it's version 1.01.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Message-Id: <rt-3.6.HEAD-25781-1169862410-428.24618-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 501
Download (untitled) / with headers
text/plain 501b
On Fri Jan 26 18:15:30 2007, SMUELLER wrote: Show quoted text
> If you run PAR.pm through Perl::Critic, you get: > > > Capture variable used outside conditional at line 555, column 18. See > page 253 of PBP. Severity: 3 > > 0555: CORE::exit($1) if ($@ =~/^_TK_EXIT_\((\d+)\)/); > > > Now, the $1 is *not* used outside a conditional.
Yeah, we're not handling postfix control structures yet in the policy. I think we may have more bug reports against that one policy than any other now! -- Chris Dolan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.