Skip Menu |
 

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 22849
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: Nobody in particular
Requestors: fenlisesi [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: notabug: update load.t for 'Too many args'
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1162835470-21875-2"
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 99
the attached patch to t/load.t is due to the new warning 'Too many arguments'. Cheers. --Ali Isik
Subject: load-2006-11-04.t.patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1162835470-21875-1"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Type: text/x-patch; name="load-2006-11-04.t.patch"
Content-Disposition: inline; filename="load-2006-11-04.t.patch"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: ascii
Content-Length: 641
--- load-original.t 2006-11-04 20:45:06.000000000 +0200 +++ load-edited.t 2006-11-06 19:40:11.000000000 +0200 @@ -12,7 +12,7 @@ use CGI::Session; { my $s = CGI::Session->load('Driver:file;serial:FreezeThaw',undef, Directory=> 'wrong' ); is($s,undef, "undefined session is created with wrong number of args to load"); - like(CGI::Session->errstr, qr/invalid number/, "expected error is returned for wrong number of args"); + like(CGI::Session->errstr, qr/Too many/, "expected error is returned for too many args"); unlike(CGI::Session->errstr, qr/new/, "don't mention new() in error when load() fails directly."); } {
MIME-Version: 1.0
X-Spam-Status: No, hits=-1.2 required=8.0 tests=BAYES_00,SPF_SOFTFAIL
In-Reply-To: <rt-3.6.HEAD-21875-1162835472-109.22849-4-0 [...] rt.cpan.org>
Received-SPF: softfail (x1.develooper.com: transitioning domain of mark [...] summersault.com does not designate 12.161.104.4 as permitted sender)
References: <RT-Ticket-22849 [...] rt.cpan.org> <rt-3.6.HEAD-21875-1162835472-109.22849-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: ISO-8859-1
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 738054D80AA for <bug-CGI-Session [...] rt.cpan.org>; Mon, 6 Nov 2006 13:16:34 -0500 (EST)
Received: (qmail 14418 invoked by alias); 6 Nov 2006 18:16:33 -0000
Received: from mail.parallax.ws (HELO mail.parallax.ws) (12.161.104.4) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 06 Nov 2006 10:16:27 -0800
Received: (qmail 97836 invoked by uid 89); 6 Nov 2006 18:15:26 -0000
Received: by simscan 1.2.0 ppid: 97812, pid: 97814, t: 3.0072s scanners: clamav: 0.87/m:34/d:1109 spam: 3.1.0
Received: from unknown (HELO ?12.161.105.182?) (12.161.105.182) by 0 with SMTP; 6 Nov 2006 18:15:23 -0000
Delivered-To: cpan-bug+cgi-session [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #22849] notabug: update load.t for 'Too many args'
User-Agent: Thunderbird 1.5.0.7 (X11/20060921)
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-CGI-Session [...] rt.cpan.org
X-Old-Spam-Status: No, score=0.0 required=4.8 tests=AWL autolearn=disabled version=3.1.0
Date: Mon, 06 Nov 2006 13:13:30 -0500
X-Spam-Level:
Message-Id: <454F7B4A.20406 [...] summersault.com>
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on ns1.parallax.ws
To: bug-CGI-Session [...] rt.cpan.org
X-Enigmail-Version: 0.94.1.0
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-21907-1162837007-1911.22849-0-0 [...] rt.cpan.org>
Content-Length: 578
Download (untitled) / with headers
text/plain 578b
Ali ISIK via RT wrote: Show quoted text
> Mon Nov 06 12:51:12 2006: Request 22849 was acted upon. > Transaction: Ticket created by fenlisesi@gmail.com > Queue: CGI-Session > Subject: notabug: update load.t for 'Too many args' > Broken in: (no value) > Severity: Normal > Owner: Nobody > Requestors: fenlisesi@gmail.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=22849 > > > > the attached patch to t/load.t is due to the new warning 'Too many > arguments'. Cheers.
Applied cleanly and passed tests. Committed. Thanks. Mark


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.