Skip Menu |
 

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 21779
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: Nobody in particular
Requestors: fenlisesi [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 4.13
Fixed in: (no value)



Subject: minor change to import.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 980
Download (untitled) / with headers
text/plain 980b
I would like to suggest a patch like the following, in case -ip_match is not the last arg to the use statement: --- Session-original.pm 2006-04-12 19:59:41.000000000 +0300 +++ Session-edited.pm 2006-09-29 20:05:53.000000000 +0300 @@ -17,11 +17,16 @@ sub STATUS_EXPIRED () { 8 } # denotes session that was expired. sub import { - my $class = shift; - @_ or return; + my ($class, @args) = @_; + + return unless @args; - for(@_) { - $CGI::Session::IP_MATCH = ( $_ eq '-ip_match' ); + ARG: + foreach my $arg (@args) { + if ($arg eq '-ip_match') { + $CGI::Session::IP_MATCH = 1; + last ARG; + } } } -------------------------------------- $CGI::Session::VERSION = '4.13'; This is perl, v5.8.8 built for i686-linux-thread-multi Linux version 2.6.11.4-21.14-default (geeko@buildhost) (gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)) #1 Thu Aug 24 09:51:41 UTC 2006 Thanks for all the good stuff.
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00
In-Reply-To: <rt-3.6.HEAD-8298-1159550452-1069.21779-4-0 [...] rt.cpan.org>
Received-SPF: neutral (x1.develooper.com: local policy)
References: <RT-Ticket-21779 [...] rt.cpan.org> <rt-3.6.HEAD-8298-1159550452-1069.21779-4-0 [...] rt.cpan.org>
Content-Type: text/plain; charset=utf-8
X-RT-Original-Encoding: utf-8
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 2D8294D80BE for <bug-CGI-Session [...] rt.cpan.org>; Fri, 29 Sep 2006 13:29:40 -0400 (EDT)
Received: (qmail 1353 invoked by alias); 29 Sep 2006 17:29:40 -0000
Received: from mail.parallax.ws (HELO mail.parallax.ws) (12.161.104.4) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 29 Sep 2006 10:29:38 -0700
Received: (qmail 73165 invoked by uid 89); 29 Sep 2006 17:29:32 -0000
Received: by simscan 1.2.0 ppid: 73135, pid: 73137, t: 2.3398s scanners: clamav: 0.87/m:34/d:1109 spam: 3.1.0
Received: from unknown (HELO ?12.161.105.182?) (12.161.105.182) by 0 with SMTP; 29 Sep 2006 17:29:30 -0000
Delivered-To: cpan-bug+cgi-session [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #21779] minor change to import.
User-Agent: Thunderbird 1.5 (X11/20060405)
Return-Path: <mark [...] summersault.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: bug-CGI-Session [...] rt.cpan.org
X-Old-Spam-Status: No, score=0.0 required=5.0 tests=AWL autolearn=disabled version=3.1.0
Date: Fri, 29 Sep 2006 13:27:59 -0400
X-Spam-Level:
Message-Id: <451D579F.9070909 [...] summersault.com>
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on ns1.parallax.ws
To: bug-CGI-Session [...] rt.cpan.org
X-Enigmail-Version: 0.94.1.0
Content-Transfer-Encoding: 7bit
From: Mark Stosberg <mark [...] summersault.com>
X-RT-Original-Encoding: utf-8
RT-Message-ID: <rt-3.6.HEAD-8322-1159550986-1965.21779-0-0 [...] rt.cpan.org>
Content-Length: 190
Download (untitled) / with headers
text/plain 190b
Show quoted text
> > I would like to suggest a patch like the following, in case -ip_match is > not the last arg to the use statement:
Thanks. This has been applied in our source control system. Mark


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.