| MIME-Version: | 1.0 |
| X-Spam-Status: | No, hits=-2.6 required=8.0 tests=BAYES_00 |
| Received-SPF: | pass (x1.develooper.com: local policy) |
| X-Virus-Checked: | Checked |
| Content-Type: | multipart/signed; protocol="application/x-pkcs7-signature"; micalg=sha1; boundary="------------ms090605070805060909020701" |
| X-Virus-Scanned: | by amavis at cms.hu-berlin.de |
| Received: | from la.mx.develooper.com (ss1.fabel.dk [63.251.223.179]) by diesel.bestpractical.com (Postfix) with SMTP id E79DB4D80AD for <bug-Workflow [...] rt.cpan.org>; Mon, 21 Aug 2006 04:05:30 -0400 (EDT) |
| Received: | (qmail 14813 invoked by alias); 21 Aug 2006 08:05:28 -0000 |
| Received: | from suncom4.cms.hu-berlin.de (HELO suncom4.cms.hu-berlin.de) (141.20.1.74) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 21 Aug 2006 01:05:25 -0700 |
| Received: | from localhost (localhost [127.0.0.1]) by suncom4.cms.hu-berlin.de (8.13.7/8.13.7) with ESMTP id k7L85FSH020252 for <bug-Workflow [...] rt.cpan.org>; Mon, 21 Aug 2006 10:05:15 +0200 (CEST) |
| Received: | from suncom4.cms.hu-berlin.de ([127.0.0.1]) by localhost (suncom4.cms.hu-berlin.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yReSLQ7itnEx for <bug-Workflow [...] rt.cpan.org>; Mon, 21 Aug 2006 10:05:13 +0200 (CEST) |
| Received: | from [141.20.3.34] (bellus.rz.hu-berlin.de [141.20.3.34]) by suncom4.cms.hu-berlin.de (8.13.7/8.13.7) with ESMTP id k7L859H1020187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for <bug-Workflow [...] rt.cpan.org>; Mon, 21 Aug 2006 10:05:09 +0200 (CEST) |
| Delivered-To: | cpan-bug+workflow [...] diesel.bestpractical.com |
| User-Agent: | Thunderbird 1.5.0.4 (X11/20060516) |
| Subject: | Wrong documentation of Condition configuration |
| Return-Path: | <michael.bell [...] cms.hu-berlin.de> |
| X-Original-To: | bug-Workflow [...] rt.cpan.org |
| X-Spam-Check-BY: | la.mx.develooper.com |
| Date: | Mon, 21 Aug 2006 10:05:16 +0200 |
| Message-Id: | <44E9693C.6090204 [...] cms.hu-berlin.de> |
| To: | bug-Workflow [...] rt.cpan.org |
| From: | Michael Bell <michael.bell [...] cms.hu-berlin.de> |
| Content-Length: | 0 |
| Content-Description: | S/MIME Cryptographic Signature |
| content-type: | application/x-pkcs7-signature; name="smime.p7s" |
| content-disposition: | attachment; filename="smime.p7s" |
| Content-Transfer-Encoding: | base64 |
| Content-Length: | 7983 |
Message body not shown because it is not plain text.
| Content-Type: | multipart/mixed; boundary="------------090306020701040108040305" |
| Content-Length: | 0 |
| content-type: | text/plain; charset="utf-8"; format="flowed" |
| Content-Transfer-Encoding: | 7bit |
| X-RT-Original-Encoding: | ISO-8859-15 |
| Content-Length: | 900 |
Hi,
Workflow 0.22
Perl 5.8.8
The documentation of the condition configuration contains a small bug.
Conditions are checked by the module Workflow::State. This requires that
the state configuration includes a reference to the condition. If the
reference to the condition only exists in the full action specification
(perhaps in a separate file) then the condition will be ignored.
The issue is non-critical because only the documentation has a bug
(nevertheless it costs some time to find the problem ;) ).
Best regards
Michael
--
Show quoted text
_______________________________________________________________
Michael Bell Humboldt-Universitaet zu Berlin
Tel.: +49 (0)30-2093 2482 ZE Computer- und Medienservice
Fax: +49 (0)30-2093 2704 Unter den Linden 6
michael.bell@cms.hu-berlin.de D-10099 Berlin
_______________________________________________________________
| content-type: | text/x-patch; name="Condition.pm.diff" |
| content-disposition: | inline; filename="Condition.pm.diff" |
| Content-Transfer-Encoding: | 7bit |
| X-RT-Original-Encoding: | ascii |
| Content-Length: | 1164 |
--- Condition.pm.org 2006-08-21 09:51:43.000000000 +0200
+++ Condition.pm 2006-08-21 09:57:00.000000000 +0200
@@ -45,13 +45,17 @@
</condition>
...
- # Reference the condition in an action...
- <actions>
- <action name="MyAction" class="My::Action">
- ...
- <condition name="IsAdminUser" />
- </action>
- ...
+ # Reference the condition in an action of the state/workflow definition...
+ <workflow>
+ <state>
+ ...
+ <action name="MyAction">
+ ...
+ <condition name="IsAdminUser" />
+ </action>
+ </state>
+ ...
+ </workflow>
# Then implement the condition
@@ -94,6 +98,13 @@
the available actions she might get a different answer than user B
since they determine separate contexts.
+B<NOTE>: The condition is enforced by Workflow::State. This means that
+the condition name must be visible inside of the state definition. If
+you specify the reference to the condition only inside of the full
+action specification in a seperate file then nothing will happen. The
+reference to the condition must be defined inside of the state/workflow
+specification.
+
=head1 SUBCLASSING
=head2 Strategy