Skip Menu |
 

This queue is for tickets about the Net-Telnet CPAN distribution.

Report information
The Basics
Id: 204
Status: resolved
Priority: 0/
Queue: Net-Telnet

People
Owner: Nobody in particular
Requestors: tleete [...] mountain.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 3.03

Attachments


MIME-Version: 1.0
X-Mailer: MIME-tools 5.405 (Entity 5.404)
Subject: [Patch] test 3 failure
Content-Type: multipart/mixed; boundary="----------=_1011925913-12357-0"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 189
Download (untitled) / with headers
text/plain 189b
Hello, I had test failures with Net::Telnet. Found what I'm pretty sure is an error in test three. If tests 1 and 2 succeed, select should have found one live handle. Patch attached. Tom
Content-Type: application/octet-stream; name="Net-Telnet-test3.patch"
Content-Disposition: inline; filename="Net-Telnet-test3.patch"
Content-Transfer-Encoding: base64
Content-Length: 333
--- Net-Telnet-3.02/t/select.t.orig Thu Jun 10 10:25:52 1999 +++ Net-Telnet-3.02/t/select.t Thu Jan 24 04:37:39 2002 @@ -22,7 +22,7 @@ test ($@ eq ""); ## Did select() return a correct value? - test (defined($nfound) and $nfound == 0); + test (defined($nfound) and $nfound == 1); exit; } # end main program
MIME-Version: 1.0
X-Mailer: MIME-tools 5.405 (Entity 5.404)
From: clintdw [...] netcom.com
Content-Type: multipart/mixed; boundary="----------=_1024358865-24290-0"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 855
Download (untitled) / with headers
text/plain 855b
The results for test 3 is different between linux kernel 2.2.x and 2.4.x. On linux 2.2.x kernels, test 3 passes. On 2.2.4, it fails. The test checks to see if a newly created socket has anything to read, with the expected results being "no." I think the 2.2 kernel is doing the right thing and the 2.4 kernel is not. However, I think test 3 could be updated to actually do a bind() and listen() after socket(). After that, the test passes on both 2.2.x and 2.4.x kernels. It isn't really clear to me that one can call select() on a generic socket without turning it into a server socket or client socket. [guest - Thu Jan 24 21:31:53 2002]: Show quoted text
> Hello, > I had test failures with Net::Telnet. Found what I'm pretty sure is an > error in test three. > > If tests 1 and 2 succeed, select should have found one live handle. > Patch attached. > > Tom
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.