Skip Menu |
 

This queue is for tickets about the GDGraph CPAN distribution.

Maintainer(s)' notes

There are plenty of good ideas of what people can do published here on the queue. Turning a patch from the tracker into a pull request is not one of them. In order to get maintainers' attention way more quickier, PR should have at least a sample included. We know it's hard to test images generating software, but it doesn't mean we can not test numbers produced by intermediate algorithms used to generate these images, so either a test or a sample.

Report information
The Basics
Id: 203
Status: resolved
Priority: 0/
Queue: GDGraph

People
Owner: mverb [...] cpan.org
Requestors: ben_tilly [...] operamail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.33
Fixed in: (no value)



MIME-Version: 1.0
X-Mailer: MIME-tools 5.405 (Entity 5.404)
Subject: two_axis graphs ranges poorly chosen
Content-Type: multipart/mixed; boundary="----------=_1011925347-24952-0"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 305
Download (untitled) / with headers
text/plain 305b
When you let GD::Graph dynamically pick ranges for a 2-axis graph, you can get a very large number of ticks and a range choice that makes rather little sense. If you go to http://www.perlmonks.org/index.pl?node_id=138068 and hit "d/l code" at the bottom of the page you will find a patch that fixes this.
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
MIME-Version: 1.0
X-Mailer: MIME-tools 5.405 (Entity 5.404)
Content-Type: multipart/mixed; boundary="----------=_1024646363-29248-0"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 572
Download (untitled) / with headers
text/plain 572b
I applied the patch, manually, since some other changes had gone in in the meantime, but I reverted it again. The patch changed the behaviour of GD::Graph too much, with respect to the standard samples distributed with the source distribution, and in my opinion, not for the better. I am not entirely certain what the problem is this patch tried to resolve, so maybe you could help me with a small example program that shows the problem. I can then review the patch again, with that in mind, or try to come up with another way to solve the problem. Sorry, Martien
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.405 (Entity 5.404)
X-RT-Original-Encoding: iso-8859-1
Content-Length: 313
Download (untitled) / with headers
text/plain 313b
Manually applied patch to latest version again, now better understanding the problem. Apologies for letting it lie around so long. Automatic ticks for axes much, much better chosen now. min/max values also much better determined. Many thanks and apologies again. Martien Changes will appear in release 1.40.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.