Skip Menu |
 

This queue is for tickets about the Catalyst-Action-RenderView CPAN distribution.

Report information
The Basics
Id: 20239
Status: resolved
Priority: 0/
Queue: Catalyst-Action-RenderView

People
Owner: Nobody in particular
Requestors: scottk [...] mandriva.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: 0.04



Subject: Syntax error on line 15 of RenderView.pm v0.03
MIME-Version: 1.0
X-Mailer: MIME-tools 5.418 (Entity 5.418)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1151848856-15604-1"
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 152
Download (untitled) / with headers
text/plain 152b
There seems to be a syntax error on line 15 of RenderView.pm of Catalyst-Action-RenderView-0.03. If (I doubt it) you should need it, see attached patch.
Subject: CARV.patch
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1151848856-15604-0"
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Length: 0
Content-Type: text/plain; charset="utf8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Type: text/x-patch; name="CARV.patch"
Content-Disposition: inline; filename="CARV.patch"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: ascii
Content-Length: 417
Download CARV.patch
text/x-diff 417b
--- lib/Catalyst/Action/RenderView.pm.fixsyntax 2006-07-02 03:56:29.000000000 -0600 +++ lib/Catalyst/Action/RenderView.pm 2006-07-02 07:56:08.000000000 -0600 @@ -12,7 +12,7 @@ foreach my $item (keys %{$c->stash}) { undef $item->{result_source} if $item->isa('DBIx::Class::ResultSet') || - if $item->isa('DBIx::Class::Row'); + $item->isa('DBIx::Class::Row'); } die "forced debug" }
MIME-Version: 1.0
Subject: Corrected patch for syntax error on line 15 of RenderView.pm v0.03
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Message-Id: <rt-3.5.HEAD-15596-1151849659-139.20239-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf8"
Content-Transfer-Encoding: binary
From: scottk [...] mandriva.org
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 524
Download (untitled) / with headers
text/plain 524b
Oops! Bad patch, maybe this is what you intended: --- RenderView.pm.fixsyntax 2006-07-02 03:56:29.000000000 -0600 +++ RenderView.pm 2006-07-02 07:56:08.000000000 -0600 @@ -12,7 +12,7 @@ foreach my $item (keys %{$c->stash}) { undef $item->{result_source} - if $item->isa('DBIx::Class::ResultSet') || - if $item->isa('DBIx::Class::Row'); + if $item->isa('DBIx::Class::ResultSet') or + $item->isa('DBIx::Class::Row'); } die "forced debug" }
X-Scanned-BY: AMaViS-ng at bestpractical
MIME-Version: 1.0
X-Spam-Status: No, hits=-2.3 required=8.0 tests=BAYES_00,DK_SIGNED,DK_VERIFIED,DNS_FROM_RFC_ABUSE,HTML_50_60,HTML_MESSAGE,SPF_PASS
In-Reply-To: <rt-3.5.HEAD-15596-1151849659-139.20239-5-0 [...] rt.cpan.org>
Received-SPF: pass (x1.develooper.com: domain of marcus.ramberg [...] gmail.com designates 64.233.182.186 as permitted sender)
References: <RT-Ticket-20239 [...] rt.cpan.org> <rt-3.5.HEAD-15596-1151849659-139.20239-5-0 [...] rt.cpan.org>
Content-Type: multipart/alternative; boundary="----=_Part_27346_8409328.1151927977522"
Received: from localhost (diesel.bestpractical.com [127.0.0.1]) by diesel.bestpractical.com (Postfix) with ESMTP id 6A7694D8109 for <cpan-bug+catalyst-action-renderview [...] diesel.bestpractical.com>; Mon, 3 Jul 2006 07:59:46 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 123E44D80D5 for <bug-Catalyst-Action-RenderView [...] rt.cpan.org>; Mon, 3 Jul 2006 07:59:45 -0400 (EDT)
Received: (qmail 9244 invoked by alias); 3 Jul 2006 11:59:45 -0000
Received: from nf-out-0910.google.com (HELO nf-out-0910.google.com) (64.233.182.186) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Mon, 03 Jul 2006 04:59:43 -0700
Received: by nf-out-0910.google.com with SMTP id l35so709075nfa for <bug-Catalyst-Action-RenderView [...] rt.cpan.org>; Mon, 03 Jul 2006 04:59:37 -0700 (PDT)
Received: by 10.78.156.6 with SMTP id d6mr876073hue; Mon, 03 Jul 2006 04:59:37 -0700 (PDT)
Received: by 10.78.56.1 with HTTP; Mon, 3 Jul 2006 04:59:37 -0700 (PDT)
Delivered-To: cpan-bug+catalyst-action-renderview [...] diesel.bestpractical.com
Subject: Re: [rt.cpan.org #20239] Corrected patch for syntax error on line 15 of RenderView.pm v0.03
Domainkey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=nsgJ29Ez+XqWt1hi4LhCo3eWmxRDqOyAG+IVnEQtvRNKI7np7N+pnHdlw82lO2qok7ZlI+GUwJawJzUxK3BWCbXck3E4A9HalbpCJVT+m401SnGgmtZ83VsxE9YK4ue7YJp5AUfji+n7rtPImJYtyI86sgHOki5Oo36ppAaXqwk=
Return-Path: <marcus.ramberg [...] gmail.com>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+catalyst-action-renderview [...] diesel.bestpractical.com
Date: Mon, 3 Jul 2006 13:59:37 +0200
Message-Id: <825a03c0607030459s4aa1782fi7987b235442ee81c [...] mail.gmail.com>
To: bug-Catalyst-Action-RenderView [...] rt.cpan.org
From: "Marcus Ramberg" <marcus.ramberg [...] gmail.com>
RT-Message-ID: <rt-3.5.HEAD-31645-1151927994-1245.20239-0-0 [...] rt.cpan.org>
Content-Length: 0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: ISO-8859-1
X-RT-Original-Encoding: utf-8
Content-Length: 830
Download (untitled) / with headers
text/plain 830b
never intended that to go out at all... :( Marcus On 7/2/06, Guest via RT <bug-Catalyst-Action-RenderView@rt.cpan.org> wrote: Show quoted text
> > > Queue: Catalyst-Action-RenderView > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=20239 > > > Oops! Bad patch, maybe this is what you intended: > --- RenderView.pm.fixsyntax 2006-07-02 03:56:29.000000000 -0600 > +++ RenderView.pm 2006-07-02 07:56:08.000000000 -0600 > @@ -12,7 +12,7 @@ > foreach my $item (keys %{$c->stash}) { > undef $item->{result_source} > - if $item->isa('DBIx::Class::ResultSet') || > - if $item->isa('DBIx::Class::Row'); > + if $item->isa('DBIx::Class::ResultSet') or > + $item->isa('DBIx::Class::Row'); > } > die "forced debug" > } > >
-- With regards Marcus Ramberg
Content-Type: text/html; charset=ISO-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: ISO-8859-1
X-RT-Original-Encoding: ISO-8859-1
Content-Length: 1736


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.