Skip Menu |
 

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 19754
Status: new
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: schwern [...] pobox.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



X-Scanned-BY: AMaViS-ng at bestpractical
CC: makemaker [...] perl.org, bug-ExtUtils-MakeMaker [...] rt.cpan.org
MIME-Version: 1.0
In-Reply-To: <80D2D3DB17CD2E498E04171C2C95129267985F [...] wcl-exc.wcl.local>
X-Spam-Status: No, hits=-2.6 required=8.0 tests=BAYES_00,DK_SIGNED,DK_VERIFIED,HTML_MESSAGE,SPF_PASS
Received-SPF: pass (x1.develooper.com: domain of schwern [...] gmail.com designates 64.233.162.195 as permitted sender)
References: <80D2D3DB17CD2E498E04171C2C95129267985F [...] wcl-exc.wcl.local>
Content-Type: multipart/alternative; boundary="----=_Part_53043_19571449.1149638059286"
Reply-To: schwern [...] pobox.com
Received: from localhost (localhost.localdomain [127.0.0.1]) by diesel.bestpractical.com (Postfix) with ESMTP id 7A7584D80A0 for <cpan-bug+extutils-makemaker [...] diesel.bestpractical.com>; Tue, 6 Jun 2006 19:54:36 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [63.251.223.170]) by diesel.bestpractical.com (Postfix) with SMTP id 2AE534D809F for <bug-ExtUtils-MakeMaker [...] rt.cpan.org>; Tue, 6 Jun 2006 19:54:36 -0400 (EDT)
Received: (qmail 18972 invoked by alias); 6 Jun 2006 23:54:35 -0000
Received: from nz-out-0102.google.com (HELO nz-out-0102.google.com) (64.233.162.195) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 06 Jun 2006 16:54:25 -0700
Received: by nz-out-0102.google.com with SMTP id f1so42643nzc for <bug-ExtUtils-MakeMaker [...] rt.cpan.org>; Tue, 06 Jun 2006 16:54:19 -0700 (PDT)
Received: by 10.64.24.20 with SMTP id 20mr70885qbx; Tue, 06 Jun 2006 16:54:19 -0700 (PDT)
Received: by 10.65.194.1 with HTTP; Tue, 6 Jun 2006 16:54:19 -0700 (PDT)
Delivered-To: cpan-bug+extutils-makemaker [...] diesel.bestpractical.com
Subject: Re: MakeMaker on Cygwin when environment variables end in backslash
Return-Path: <schwern [...] gmail.com>
Domainkey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=WB+0v/TbE8TxWqvMjTwUhlfqx9ISY4QaiAbIKbRlDiUWkYkCVex1+J/3xeVcEMHRvOflnTWmMfFva+ERW7NZEkQk9HoOB4/YgTwJ2ukuD5IPwkv0ihMQj19nvzNlJR0sI9JP4DZP7hsiBvfF6am0dDOdRuOP0iTA+IZ9mAsq8Zs=
X-Original-To: cpan-bug+extutils-makemaker [...] diesel.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Date: Tue, 6 Jun 2006 16:54:19 -0700
Message-Id: <313c1d130606061654q667be5fdh67ca5cfcd16fb377 [...] mail.gmail.com>
To: "Ed Avis" <eda [...] waniasset.com>
From: "Michael G Schwern" <schwern [...] gmail.com>
Content-Length: 0
content-type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: ISO-8859-1
Content-Length: 1029
On 6/6/06, Ed Avis <eda@waniasset.com> wrote: Show quoted text
> This is harmless to Windows programs but when using MakeMaker under > Cygwin, the trailing backslash causes errors a bit like this: > > % make subdirs > cd C && make -f Makefile all LIB="C:\Program Files\Microsoft Visual Studio > .NET 2003\SDK\v1.1\Lib\" LIBPERL_A="libperl.a" LINKTYPE="dynamic" > PREFIX="" OPTIMIZE="" PASTHRU_DEFINE="" PASTHRU_INC="" > /bin/sh: -c: line 0: unexpected EOF while looking for matching `"' > /bin/sh: -c: line 1: syntax error: unexpected end of file > make: *** [subdirs] Error 2 > > The backslash at the end of the double-quoted string confuses sh. This > could be fixed by putting a substitution in the Makefile:
There's already a method in MakeMaker for quoting, quote_literal(). Trouble is it was introduced late in the game and there's lots of places which do not use it. This is one of them. The code which generates the above is, I think, ExtUtils::MM_Unix->pasthru() and it does not use quote_literal(). It should. Patches welcome.
Content-Type: text/html; charset=ISO-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: ISO-8859-1
Content-Length: 1403


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.