Bug #1878 for Apache-Session: elimination of AutoCommit warning

# Mon Dec 16 11:44:28 2002 Guest - Ticket created

MIME-Version:	1.0
X-Mailer:	MIME-tools 5.405 (Entity 5.404)
Subject:	elimination of AutoCommit warning
Content-Type:	multipart/mixed; boundary="----------=_1040057068-27394-0"
Content-Length:	0

Content-Type:	text/plain
Content-Disposition:	inline
Content-Transfer-Encoding:	binary
X-RT-Original-Encoding:	iso-8859-1
Content-Length:	508

Download (untitled) / with headers
text/plain 508b

Apache::Session 1.54 perl: 5.8.0 or 5.6.1 uname -a: Linux wasabi.rp.lan 2.4.7-10smp #1 SMP Thu Sep 6 17:09:31 EDT 2001 i686 unknown (but will affect all o/s) Apache::Session::Store::Postgres.pm assumes that the $dbh created has AutoCommit to Off and therefore blithely calls {$self->{dbh}->commit without checking for AutoCommit which triggers the warning: commit ineffective with AutoCommit enabled at /opt/projects/sitegroup/oxford/5.8.0/Apache/Session/Store/Postgres.pm line 93. patch supplied Marcus

Content-Type:	application/octet-stream; name="Postgres.pm.patch"
Content-Disposition:	inline; filename="Postgres.pm.patch"
Content-Transfer-Encoding:	base64
Content-Length:	303

Download Postgres.pm.patch
text/x-diff 303b

--- Postgres.pm 2002-12-16 16:26:41.000000000 +0000 +++ Postgres.pm.modified 2002-12-16 16:33:02.000000000 +0000 @@ -89,7 +89,7 @@ sub DESTROY { my $self = shift; - if ($self->{commit}) { + if ($self->{commit} && ! $self->{dbh}->{AutoCommit}) { $self->{dbh}->commit; }

# Mon Dec 16 12:39:03 2002 JBAKER [...] cpan.org - Status changed from 'new' to 'resolved'

# Mon Dec 16 12:39:03 2002 JBAKER [...] cpan.org - Correspondence added

Content-Type:	text/plain
Content-Disposition:	inline
Content-Transfer-Encoding:	binary
MIME-Version:	1.0
X-Mailer:	MIME-tools 5.405 (Entity 5.404)
X-RT-Original-Encoding:	iso-8859-1
Content-Length:	166

Download (untitled) / with headers
text/plain 166b

The Postgres storage module depends on transactional behavior. If a DBH is passed in with AutoCommit, the module will misbehave. Resolved: not accepting this patch.

# Tue Dec 17 04:49:23 2002 Guest - Correspondence added

Content-Type:	text/plain
Content-Disposition:	inline
Content-Transfer-Encoding:	binary
MIME-Version:	1.0
X-Mailer:	MIME-tools 5.405 (Entity 5.404)
X-RT-Original-Encoding:	iso-8859-1
Content-Length:	431

Download (untitled) / with headers
text/plain 431b

[JBAKER - Mon Dec 16 12:39:03 2002]: Show quoted text

> The Postgres storage module depends on transactional behavior. If a DBH > is passed in with AutoCommit, the module will misbehave. > > Resolved: not accepting this patch.

In that case, I suggest that if a $dbh is supplied with AutoCommit to 1, that it gets explicitly set to 0 if the module will misbehave otherwise. Couldn't find this in the docs but maybe I missed it. Cheers, Marcus

# Tue Dec 17 04:49:23 2002 The RT System itself - Status changed from 'resolved' to 'open'

# Wed Dec 18 11:33:16 2002 Guest - Correspondence added

Content-Type:	text/plain
Content-Disposition:	inline
Content-Transfer-Encoding:	binary
MIME-Version:	1.0
X-Mailer:	MIME-tools 5.405 (Entity 5.404)
X-RT-Original-Encoding:	iso-8859-1
Content-Length:	837

Download (untitled) / with headers
text/plain 837b

In fact, the patch does apply! It is a system requirement to have AutoCommit set to 1 in our $dbh to avoid Postgres leaving processes 'idle in transaction' (very bad) So the dbh handle in our environment *must* be on. In Apache::Session::Postgres man page, it states the Commit option is required during the tie. (NB. it doesn't say it must be set to 1, but it must be present). If we set this to 0, we don't get AutoCommit behaviour, if we set it to 1, everything works perfectly except for the zillions of error lines in the error log. So, if you apply the patch, your module will function identically as before with the exception that it won't try to do a $dbh->commit if AutoCommit is on (which prompts the warnings). Until then we are having to override this method to bypass the problem (not nice) Best Regards, Marcus