Skip Menu |
 

This queue is for tickets about the HTTP-Proxy CPAN distribution.

Report information
The Basics
Id: 14548
Status: resolved
Priority: 0/
Queue: HTTP-Proxy

People
Owner: book [...] cpan.org
Requestors: corion [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.21



Return-Path: <corion [...] cpan.org>
X-Original-To: bug-HTTP-Proxy [...] rt.cpan.org
Delivered-To: cpan-bug+http-proxy [...] diesel.bestpractical.com
Received: from la.mx.develooper.com (ss1.fabel.dk [63.251.223.179]) by diesel.bestpractical.com (Postfix) with SMTP id 11FB84D80BA for <bug-HTTP-Proxy [...] rt.cpan.org>; Sun, 11 Sep 2005 13:57:16 -0400 (EDT)
Received: (qmail 19345 invoked by alias); 11 Sep 2005 17:57:07 -0000
X-Spam-Check-BY: la.mx.develooper.com
Received-SPF: neutral (x1.develooper.com: local policy)
Received: from natnoddy.rzone.de (HELO natnoddy.rzone.de) (81.169.145.166) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sun, 11 Sep 2005 10:57:01 -0700
Received: from aliens (p54B01908.dip0.t-ipconnect.de [84.176.25.8]) by post.webmailer.de (8.13.1/8.13.1) with ESMTP id j8BHusmQ011977 for <bug-HTTP-Proxy [...] rt.cpan.org>; Sun, 11 Sep 2005 19:56:55 +0200 (MEST)
Received: from [192.168.1.19] (helo=[192.168.1.19]) by aliens with esmtp (Exim 3.35 #1 (Debian)) id 1EEWQ1-0008Bf-00 for <bug-HTTP-Proxy [...] rt.cpan.org>; Sun, 11 Sep 2005 20:19:09 +0200
Message-ID: <4324735A.1020504 [...] cpan.org>
Date: Sun, 11 Sep 2005 20:11:38 +0200
From: Max Maischein <corion [...] cpan.org>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: bug-HTTP-Proxy [...] rt.cpan.org
Subject: Bug in HTTP::Proxy::BodyFilter::save v0.16
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-RT-Original-Encoding: iso-8859-1
Content-Length: 737
Download (untitled) / with headers
text/plain 737b
Hello Philippe, HTTP::Proxy::BodyFilter::save has a bug in its parameter validation - it doesn't accept any C<filename> parameter, because the check is reversed: croak "filename must be a code reference" if defined $args{filename} && UNIVERSAL::isa($args{filename}, 'CODE'); should be croak "filename must be a code reference" if defined $args{filename} && ! UNIVERSAL::isa($args{filename}, 'CODE'); The attached test file replicates the bug and tests that it goes away :) Another documentation nitpick is that the documentation for HTTP::Proxy::BodyFilter::save doesn't tell that the default mime_type is "text/*" and you need to override that for other formats. Thanks for writing HTTP::Proxy, -max
MIME-Version: 1.0
In-Reply-To: <4324735A.1020504 [...] cpan.org>
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Message-Id: <rt-3.5.HEAD-6804-1142930980-650.14548-0-0 [...] rt.cpan.org>
References: <4324735A.1020504 [...] cpan.org>
Content-Type: text/plain; charset="utf8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 671
Download (untitled) / with headers
text/plain 671b
Sorry to reply so late to your bug request. On Sun Sep 11 13:57:23 2005, CORION wrote: Show quoted text
> Hello Philippe, > > HTTP::Proxy::BodyFilter::save has a bug in its parameter validation - it > doesn't accept any C<filename> parameter, because the check is reversed: > > croak "filename must be a code reference" > if defined $args{filename} && UNIVERSAL::isa($args{filename}, > 'CODE'); > > should be > > croak "filename must be a code reference" > if defined $args{filename} && ! UNIVERSAL::isa($args{filename}, > 'CODE'); > > The attached test file replicates the bug and tests that it goes away :)
I couldn't find the "attached file" in RT.
MIME-Version: 1.0
In-Reply-To: <rt-3.5.HEAD-6804-1142930980-650.14548-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.418 (Entity 5.418)
Content-Disposition: inline
Charset: utf8
References: <4324735A.1020504 [...] cpan.org> <rt-3.5.HEAD-6804-1142930980-650.14548-0-0 [...] rt.cpan.org>
Message-Id: <rt-3.6.HEAD-9088-1208737547-647.14548-0-0 [...] rt.cpan.org>
Content-Type: text/plain
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Original-Encoding: utf-8
Content-Length: 340
Download (untitled) / with headers
text/plain 340b
On Tue Mar 21 03:49:40 2006, guest wrote: Show quoted text
> Sorry to reply so late to your bug request. > > On Sun Sep 11 13:57:23 2005, CORION wrote:
> > Hello Philippe, > > > > HTTP::Proxy::BodyFilter::save has a bug in its parameter validation
- it Show quoted text
> > doesn't accept any C<filename> parameter, because the check is reversed:
Fixed in 0.21. -- BooK


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.