Skip Menu |
 

This queue is for tickets about the File-Finder CPAN distribution.

Report information
The Basics
Id: 13993
Status: open
Priority: 0/
Queue: File-Finder

People
Owner: MERLYN [...] cpan.org
Requestors: CHORNY [...] cpan.org
tshinnic [...] io.com
Cc: PLICEASE [...] cpan.org
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.53
Fixed in: (no value)

Attachments


MIME-Version: 1.0
X-Mailer: MIME-tools 5.415 (Entity 5.415)
Subject: Cannot install under Win32 Perl (ActiveState)
Content-Type: multipart/mixed; boundary="----------=_1123018341-12840-0"
Content-Length: 0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: iso-8859-1
Content-Length: 1058
File::Finder will not install under ActiveState Win32 Perl due to unguarded reliance on 'get(pw|gr)ent' APIs. The tests fail trying to test the File::Finder::Steps features. FF::Steps tries to initialize itself with values from getpwent and getgrent upon any use of the methods user(), nouser(), group(), nogroup(), and ls(). These two APIs are not available under Win32 Perls. This may be why ActiveState has a ppm only for release 0.01. You would know better which way of testing for Win32 Perls is best. The included tar.gz file shows fixes using testing of $Config::Config{d_xxxxxx} and also testing against $^O . The included patches use $^O as better due to not dragging in Config. They are workaround quality only, and you can undoubtedly come up with better. Patches are needed in both the Steps.pm module and the test 05-steps.t s for Steps features. With these workaround patches File-Finder will install under Win32 Perl. You may want to also add a note to the pod saying that the above-named Steps methods are not available under Win32.
Content-Type: application/x-gzip-compressed; name="file-finder-0.53.win32.patch.tar.gz"
Content-Disposition: inline; filename="file-finder-0.53.win32.patch.tar.gz"
Content-Transfer-Encoding: base64
Content-Length: 8834
Download file-finder-0.53.win32.patch.tar.gz
application/x-gzip-compressed 8.6k

Message body not shown because it is not plain text.

MIME-Version: 1.0
Subject: Cannot install under Win32 Perl
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Message-ID: <rt-3.8.HEAD-26544-1269970118-1444.13993-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 1407
Download (untitled) / with headers
text/plain 1.3k
On Tue Aug 02 17:32:21 2005, guest wrote: Show quoted text
> File::Finder will not install under ActiveState Win32 Perl due to > unguarded reliance on 'get(pw|gr)ent' APIs. The tests fail trying > to test the File::Finder::Steps features. > > FF::Steps tries to initialize itself with values from getpwent and > getgrent upon any use of the methods user(), nouser(), group(), > nogroup(), and ls(). These two APIs are not available under Win32 > Perls. This may be why ActiveState has a ppm only for release > 0.01. > > You would know better which way of testing for Win32 Perls is best. > The included tar.gz file shows fixes using testing of > $Config::Config{d_xxxxxx} and also testing against $^O . The > included patches use $^O as better due to not dragging in Config. > They are workaround quality only, and you can undoubtedly come up > with better. > > Patches are needed in both the Steps.pm module and the test 05-steps.t > s for Steps features. With these workaround patches File-Finder > will install under Win32 Perl. > > You may want to also add a note to the pod saying that the above-named > Steps methods are not available under Win32.
This applies to Strawberry, too, btw, so bumping. (File::Finder is used by Test::Fixme, which I would like to be able to use in the Perl::Dist::* modules as a test without having to force File::Finder's installation.)
From merlyn [...] stonehenge.com Tue Mar 30 14: 53:28 2010
CC: undisclosed-recipients:;
MIME-Version: 1.0
X-Spam-Status: No, score=-8.253 tagged_above=-99.9 required=10 tests=[AWL=1.653, BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8, SPF_FAIL=0.693] autolearn=ham
In-Reply-To: <rt-3.8.HEAD-26544-1269970118-771.13993-5-0 [...] rt.cpan.org> (Curtis Jewell via's message of "Tue, 30 Mar 2010 13:28:38 -0400")
X-Spam-Flag: NO
References: <RT-Ticket-13993 [...] rt.cpan.org> <rt-3.8.HEAD-26544-1269970118-771.13993-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <86ljd9zlnj.fsf [...] red.stonehenge.com>
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -8.253
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 588942402F5 for <cpan-bug+File-Finder [...] hipster.bestpractical.com>; Tue, 30 Mar 2010 14:53:28 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j0FQ9dDOK7oS for <cpan-bug+File-Finder [...] hipster.bestpractical.com>; Tue, 30 Mar 2010 14:53:14 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id 5FD57240582 for <bug-File-Finder [...] rt.cpan.org>; Tue, 30 Mar 2010 14:53:10 -0400 (EDT)
Received: (qmail 29980 invoked by uid 103); 30 Mar 2010 18:53:29 -0000
Received: from x16.dev (10.0.100.26) by x1.dev with QMQP; 30 Mar 2010 18:53:29 -0000
Received: from red.stonehenge.com (HELO red.stonehenge.com) (208.79.95.2) by 16.mx.develooper.com (qpsmtpd/0.80) with ESMTP; Tue, 30 Mar 2010 11:53:23 -0700
Received: by red.stonehenge.com (Postfix, from userid 1001) id C854938C3; Tue, 30 Mar 2010 11:53:20 -0700 (PDT)
Delivered-To: cpan-bug+File-Finder [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #13993] Cannot install under Win32 Perl
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (berkeley-unix)
Return-Path: <merlyn [...] stonehenge.com>
X-Spam-Check-BY: 16.mx.develooper.com
X-Original-To: cpan-bug+File-Finder [...] hipster.bestpractical.com
X-RT-Mail-Extension: file-finder
Date: Tue, 30 Mar 2010 11:53:20 -0700
X-Mayan-Date: Long count = 12.19.17.4.3; tzolkin = 8 Akbal; haab = 1 Uayeb
X-Spam-Level:
To: bug-File-Finder [...] rt.cpan.org
From: merlyn [...] stonehenge.com (Randal L. Schwartz)
RT-Message-ID: <rt-3.8.HEAD-26542-1269975228-310.13993-0-0 [...] rt.cpan.org>
Content-Length: 739
Download (untitled) / with headers
text/plain 739b
Show quoted text
>>>>> "Curtis" == Curtis Jewell via RT <bug-File-Finder@rt.cpan.org> writes:
Show quoted text
Curtis> This applies to Strawberry, too, btw, so bumping.
Show quoted text
Curtis> (File::Finder is used by Test::Fixme, which I would like to be able to Curtis> use in the Perl::Dist::* modules as a test without having to force Curtis> File::Finder's installation.)
Yeah, sorry. Haven't had time to look at this yet, and I don't have access to any windows machines. Patches welcome! -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 <merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/> Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc. See http://methodsandmessages.vox.com/ for Smalltalk and Seaside discussion
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-26542-1269975228-310.13993-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.427 (Entity 5.427)
References: <RT-Ticket-13993 [...] rt.cpan.org> <rt-3.8.HEAD-26544-1269970118-771.13993-5-0 [...] rt.cpan.org> <86ljd9zlnj.fsf [...] red.stonehenge.com> <rt-3.8.HEAD-26542-1269975228-310.13993-0-0 [...] rt.cpan.org>
Content-Type: multipart/mixed; boundary="----------=_1333133109-10811-485"
Message-ID: <rt-3.8.HEAD-10811-1333133109-800.13993-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 240
Download (untitled) / with headers
text/plain 240b
On Tue Mar 30 14:53:48 2010, merlyn@stonehenge.com wrote: Show quoted text
> Yeah, sorry. Haven't had time to look at this yet, and I don't > have access to any windows machines. Patches welcome!
Patch attached. -- Alexandr Ciornii, http://chorny.net
MIME-Version: 1.0
Subject: 05-steps.t.patch
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/x-patch; name="05-steps.t.patch"
Content-Disposition: inline; filename="05-steps.t.patch"
Content-Transfer-Encoding: binary
Content-Length: 643
Download 05-steps.t.patch
text/x-diff 643b
--- 05-steps.t.dist 2004-10-07 09:04:12.000000000 +0300 +++ 05-steps.t 2012-03-30 21:42:37.843750000 +0300 @@ -65,6 +65,8 @@ [fin(sub { -f }, '.')], 'all files even after messing with _ pseudo handle'); +SKIP: { +skip 'user/nouser/etc. not supported on Windows', 8 if $^O eq 'MSWin32'; is_deeply([File::Finder->user($<)->in(qw(.))], [fin(sub { -o }, '.')], 'owned'); @@ -96,6 +98,7 @@ is_deeply([File::Finder->not->nogroup->in(qw(.))], [fin(sub { defined getgrgid((stat)[5]) }, '.')], 'not nogroup'); +} is_deeply([File::Finder->links('-2')->in(qw(.))], [fin(sub { (stat)[3] < 2 }, '.')],
MIME-Version: 1.0
In-Reply-To: <rt-3.8.HEAD-10811-1333133109-800.13993-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-13993 [...] rt.cpan.org> <rt-3.8.HEAD-26544-1269970118-771.13993-5-0 [...] rt.cpan.org> <86ljd9zlnj.fsf [...] red.stonehenge.com> <rt-3.8.HEAD-26542-1269975228-310.13993-0-0 [...] rt.cpan.org> <rt-3.8.HEAD-10811-1333133109-800.13993-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-30853-1540494453-1338.13993-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 364
Download (untitled) / with headers
text/plain 364b
On Fri Mar 30 14:45:09 2012, CHORNY wrote: Show quoted text
> On Tue Mar 30 14:53:48 2010, merlyn@stonehenge.com wrote: >
> > Yeah, sorry. Haven't had time to look at this yet, and I don't > > have access to any windows machines. Patches welcome!
> > Patch attached. >
The patch provided by CHORNY looks good to me, how about a release? Please let me know if I can help out.
CC: undisclosed-recipients:;
MIME-Version: 1.0
X-Spam-Status: No, score=-4.56 tagged_above=-99.9 required=10 tests=[AWL=1.340, BAYES_00=-1.9, FROM_OUR_RT=-4] autolearn=ham
In-Reply-To: <rt-4.0.18-30853-1540494453-1796.13993-5-0 [...] rt.cpan.org> (Graham Ollis via's message of "Thu, 25 Oct 2018 15:07:33 -0400")
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-13993 [...] rt.cpan.org> <rt-3.8.HEAD-26544-1269970118-771.13993-5-0 [...] rt.cpan.org> <86ljd9zlnj.fsf [...] red.stonehenge.com> <rt-3.8.HEAD-26542-1269975228-310.13993-5-0 [...] rt.cpan.org> <rt-3.8.HEAD-10811-1333133109-800.13993-5-0 [...] rt.cpan.org> <rt-4.0.18-30853-1540494453-1796.13993-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Virus-Scanned: by MailRoute
Message-ID: <86tvl9h4cf.fsf [...] red.stonehenge.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -4.56
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 645A32402D2 for <cpan-bug+File-Finder [...] hipster.bestpractical.com>; Thu, 25 Oct 2018 21:45:30 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2hsPYi0xQYJI for <cpan-bug+File-Finder [...] hipster.bestpractical.com>; Thu, 25 Oct 2018 21:45:28 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 767B624020A for <bug-File-Finder [...] rt.cpan.org>; Thu, 25 Oct 2018 21:45:28 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id D85966701A for <bug-File-Finder [...] rt.cpan.org>; Thu, 25 Oct 2018 18:45:24 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 18D9D67019 for <bug-File-Finder [...] rt.cpan.org>; Thu, 25 Oct 2018 18:45:22 -0700 (PDT)
Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id BD1BE12365C for <bug-File-Finder [...] rt.cpan.org>; Thu, 25 Oct 2018 18:45:15 -0700 (PDT)
Received: from localhost (013.lax.mailroute.net [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 42h6Cy1sYzz2lHhn for <bug-File-Finder [...] rt.cpan.org>; Fri, 26 Oct 2018 01:41:34 +0000 (UTC)
Received: from 013.lax.mailroute.net ([199.89.1.16]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10026) with LMTP id vYNR3wgSl7jB for <bug-File-Finder [...] rt.cpan.org>; Fri, 26 Oct 2018 01:41:32 +0000 (UTC)
Received: from red.stonehenge.com (red.stonehenge.com [208.79.95.2]) by 013.lax.mailroute.net (Postfix) with ESMTP id 42h6Cw5xNdz2lHZc for <bug-File-Finder [...] rt.cpan.org>; Fri, 26 Oct 2018 01:41:32 +0000 (UTC)
Received: by red.stonehenge.com (Postfix, from userid 1001) id 67C621D08; Thu, 25 Oct 2018 18:41:20 -0700 (PDT)
Delivered-To: cpan-bug+File-Finder [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #13993] Cannot install under Win32 Perl (ActiveState)
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix)
Return-Path: <merlyn [...] stonehenge.com>
X-Original-To: cpan-bug+File-Finder [...] hipster.bestpractical.com
X-RT-Mail-Extension: file-finder
X-Mayan-Date: Long count = 13.0.5.16.14; tzolkin = 6 Ix; haab = 7 Zac
Date: Thu, 25 Oct 2018 18:41:20 -0700
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_500_599 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, SPF_NONE 0, URI_WITH_PATH_ONLY 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __C230066_P5 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_NEGATE 0, __SUBJ_REPLY 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0, __blackholes.mail-abuse.org_ERROR , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-Greylist: delayed 232 seconds by postgrey-1.34 at xx1.develooper.com; Thu, 25 Oct 2018 18:45:15 PDT
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2018.10.26.13316
To: "Graham Ollis via RT" <bug-File-Finder [...] rt.cpan.org>
From: merlyn [...] stonehenge.com (Randal L. Schwartz)
RT-Message-ID: <rt-4.0.18-23486-1540518331-925.13993-0-0 [...] rt.cpan.org>
Content-Length: 540
Download (untitled) / with headers
text/plain 540b
Show quoted text
>>>>> "Graham" == Graham Ollis via RT <bug-File-Finder@rt.cpan.org> writes:
Show quoted text
Graham> The patch provided by CHORNY looks good to me, how about a release? Please Graham> let me know if I can help out.
It's on Github... a pull request would be appreciated. -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 <merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/> Perl/Unix/Dart consulting, Technical writing, Comedy, etc. etc. Still trying to think of something clever for the fourth line of this .sig
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-23486-1540518331-925.13993-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-13993 [...] rt.cpan.org> <rt-3.8.HEAD-26544-1269970118-771.13993-5-0 [...] rt.cpan.org> <86ljd9zlnj.fsf [...] red.stonehenge.com> <rt-3.8.HEAD-26542-1269975228-310.13993-5-0 [...] rt.cpan.org> <rt-3.8.HEAD-10811-1333133109-800.13993-5-0 [...] rt.cpan.org> <rt-4.0.18-30853-1540494453-1796.13993-5-0 [...] rt.cpan.org> <86tvl9h4cf.fsf [...] red.stonehenge.com> <rt-4.0.18-23486-1540518331-925.13993-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-29992-1540554423-533.13993-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 913
Download (untitled) / with headers
text/plain 913b
On Thu Oct 25 21:45:31 2018, merlyn@stonehenge.com wrote: Show quoted text
> >>>>> "Graham" == Graham Ollis via RT <bug-File-Finder@rt.cpan.org> > >>>>> writes:
>
> Graham> The patch provided by CHORNY looks good to me, how about a > Graham> release? Please > Graham> let me know if I can help out.
> > It's on Github... a pull request would be appreciated.
Here is CHRONY's fix + an additional fix that I needed to get it working: https://github.com/RandalSchwartz/perl-module-file-finder/pull/3 Please also consider merging: https://github.com/RandalSchwartz/perl-module-file-finder/pull/1 I did actually do a search on github for this repository before my comment earlier but wasn't able to find it immediately. When you said it was on github I did a more extensive search, but if the metadata has the github repository then there will be links directly from metacpan which will make it much easier for others to find.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.