Skip Menu |
 

This queue is for tickets about the Linux-Inotify2 CPAN distribution.

Report information
The Basics
Id: 130646
Status: open
Priority: 0/
Queue: Linux-Inotify2

People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.1
Fixed in: (no value)



Subject: Handle IN_EXCL_UNLINK being unavailable on older kernels (centos 6)
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-26794-1570205236-1159.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 542
Download (untitled) / with headers
text/plain 542b
While the XS code has a conditional for not compiling in IN_EXCL_UNLINK, the export list in Inotify2.pm does not. This is causing tests to break for me on CentOS 6. Essentially I can't load the module. Possible fix: diff --git a/Inotify2.pm b/Inotify2.pm index 4b6ad8bc6..3ed81e6ec 100644 --- a/Inotify2.pm +++ b/Inotify2.pm @@ -428,6 +428,7 @@ sub fullname { } for my $name (@Linux::Inotify2::EXPORT) { + next unless Linux::Inotify2->can($name); my $mask = &{"Linux::Inotify2::$name"}; *$name = sub { $_[0]{mask} & $mask };
MIME-Version: 1.0
X-Spam-Status: No, score=-5.456 tagged_above=-99.9 required=10 tests=[AWL=-0.350, BAYES_00=-1.9, FROM_OUR_RT=-4, RDNS_NONE=0.793, SPF_FAIL=0.001] autolearn=ham
In-Reply-To: <rt-4.0.18-26794-1570205236-1983.130646-4-0 [...] rt.cpan.org>
Content-Disposition: inline
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-130646 [...] rt.cpan.org> <rt-4.0.18-26794-1570205236-1983.130646-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20191005063723.GA7016 [...] schmorp.de>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.456
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 3249324027D for <cpan-bug+Linux-Inotify2 [...] hipster.bestpractical.com>; Sat, 5 Oct 2019 02:52:45 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CprC2nNzKQmt for <cpan-bug+Linux-Inotify2 [...] hipster.bestpractical.com>; Sat, 5 Oct 2019 02:52:43 -0400 (EDT)
Received: from xx1.develooper.com (unknown [147.75.38.233]) by hipster.bestpractical.com (Postfix) with ESMTPS id 565D42400D2 for <bug-Linux-Inotify2 [...] rt.cpan.org>; Sat, 5 Oct 2019 02:52:43 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id D02F3C2157 for <bug-Linux-Inotify2 [...] rt.cpan.org>; Fri, 4 Oct 2019 23:52:42 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id A42CFC2159 for <bug-Linux-Inotify2 [...] rt.cpan.org>; Fri, 4 Oct 2019 23:52:40 -0700 (PDT)
Received: from mail.nethype.de (mail.nethype.de [5.9.56.24]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id AA758C2157 for <bug-Linux-Inotify2 [...] rt.cpan.org>; Fri, 4 Oct 2019 23:52:28 -0700 (PDT)
Received: from [10.0.0.5] (helo=doom.schmorp.de) by mail.nethype.de with esmtp (Exim 4.92) (envelope-from <schmorp [...] schmorp.de>) id 1iGdgy-002ZgS-IW for bug-Linux-Inotify2 [...] rt.cpan.org; Sat, 05 Oct 2019 06:37:24 +0000
Received: from [10.0.0.1] (helo=cerebro.laendle) by doom.schmorp.de with esmtp (Exim 4.92) (envelope-from <schmorp [...] schmorp.de>) id 1iGdgy-0000x0-2o for bug-Linux-Inotify2 [...] rt.cpan.org; Sat, 05 Oct 2019 06:37:24 +0000
Received: from root by cerebro.laendle with local (Exim 4.92) (envelope-from <root [...] schmorp.de>) id 1iGdgy-00025W-2P for bug-Linux-Inotify2 [...] rt.cpan.org; Sat, 05 Oct 2019 08:37:24 +0200
Delivered-To: cpan-bug+Linux-Inotify2 [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #130646] Handle IN_EXCL_UNLINK being unavailable on older kernels (centos 6)
Return-Path: <schmorp [...] schmorp.de>
X-Original-To: cpan-bug+Linux-Inotify2 [...] hipster.bestpractical.com
X-RT-Mail-Extension: linux-inotify2
Openpgp: id=904ad2f81fb16978e7536f726dea2ba30bc39eb6; url=http://pgp.schmorp.de/schmorp-pgpkey.txt; preference=signencrypt
Date: Sat, 5 Oct 2019 08:37:24 +0200
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, NO_URI_HTTPS 0, REFERENCES 0, SPF_PASS 0, __ANY_URI 0, __BODY_NO_MAILTO 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CANPHARM_UNSUB 0, __CD 0, __CT 0, __CT_TEXT_PLAIN 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FRAUD_BADTHINGS 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_REFERENCES 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __SUBJ_REPLY 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-Greylist: delayed 906 seconds by postgrey-1.34 at xx1.develooper.com; Fri, 04 Oct 2019 23:52:33 PDT
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2019.10.5.64217
To: Todd Rinaldo via RT <bug-Linux-Inotify2 [...] rt.cpan.org>
From: Marc Lehmann <schmorp [...] schmorp.de>
RT-Message-ID: <rt-4.0.18-18766-1570258365-285.130646-0-0 [...] rt.cpan.org>
Content-Length: 3083
Hi! Please send your bug report to the official contact/author address for the module in question (or send it to rt.cpan.org@schmorp.de, that's fine as well). What follows is the rationale for this request, you don't have to read it if you don't care. Why is this necessary? rt.cpan.org has many deficiencies which makes it tedious and hard to use, increasing the workload on the people who provide all the perl modules you probably appreciate (and that is really to be avoided - module authors should be able to invest all their time into improving their modules and not fighting with rt.cpan.org's bugs). Still, for some people, rt.cpan.org is useful to have, and some people even like it and really want to use it. That is fine, too. Unfortunately, the designers of rt.cpan.org didn't make their "service" optional - you can neither opt-in nor opt-out of rt.cpan.org as a module author. Just like a spammer, rt.cpan.org forces its "service" (whether wanted or unwanted) on everybody. Just like a spammer, they don't care for the people they actively hurt. Just like a spammer, they don't don't care to fix these issues and make their "service" ethically acceptable. You cannot even configure it to redirect tickets to somewhere else. Unfortunately, ignoring rt.cpan.org is not an option either: for people reporting possible bugs there is no indication that their report will be ignored, and for module authors it means they miss potentially vital bug reports such as yours (and of course it's a great impression if rt.cpan.org has lots of bug reports that are unanswered, making a module look unmaintained when in fact the opposite might be true). I am sorry that this wasted a bit of your time, but please understand that I am just as much a victim as you are - the problem is the unethical stance of the rt.cpan.org providers who force their "service" on everybody. Please redirect your bug report as stated in the beginning of this mail, and please consider petitioning the rt.cpan.org providers to stop their unethical behaviour and allow opt-in, opt-out, or some redirect option. One last issue: many people mail me that this can be "fixed" by including the bugtracker element in my module meta file. This is not true: 1. This field only affects search.cpan.org and maybe similar services. (Many people confuse rt.cpan.org with search.cpan.org for some reason). 2. It doesn't even work (there are still links to rt.cpan.org displayed). 3. Even if search.cpan.org does no longer display the link, it doesn't actually affect rt.cpan.org (and tests have shown that people go to rt.cpan.org regardless) Even *iff* rt.cpan.org would start listening on the bugtracker field, however, it's still wrong. I have a lot of modules, and each time a service like rt.cpan.org comes out, I would have to make dummy releases for all my modules. This not only creates a lot of extra work for me (I take releases very seriously) but also users, who would wonder why there is a new release. Thanks a lot, Marc Lehmann <rt.cpan.org@schmorp.de> Last updated: 2012-04-22
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-26794-1570205236-1159.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-26794-1570205236-1159.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-996-1575221659-1504.130646-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
RT-Send-CC: schmorp [...] schmorp.de
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 778
Download (untitled) / with headers
text/plain 778b
On 2019-10-04 12:07:16, TODDR wrote: Show quoted text
> While the XS code has a conditional for not compiling in > IN_EXCL_UNLINK, the export list in Inotify2.pm does not. This is > causing tests to break for me on CentOS 6. Essentially I can't load > the module. > > Possible fix: > > diff --git a/Inotify2.pm b/Inotify2.pm > index 4b6ad8bc6..3ed81e6ec 100644 > --- a/Inotify2.pm > +++ b/Inotify2.pm > @@ -428,6 +428,7 @@ sub fullname { > } > > for my $name (@Linux::Inotify2::EXPORT) { > + next unless Linux::Inotify2->can($name); > my $mask = &{"Linux::Inotify2::$name"}; > > *$name = sub { $_[0]{mask} & $mask };
Patch works also for me. Now available as a distroprefs file for CPAN.pm users: https://github.com/eserte/srezic-cpan-distroprefs/blob/master/Linux-Inotify2.yml


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.