Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 128724
Status: open
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Allow generated modules from Files in MANIFEST.SKIP
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-6282-1551859210-1546.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 524
Download (untitled) / with headers
text/plain 524b
Files generated in Makefile.PL such as Storable.pm are generated on the fly. But many Kwalitee tests will fail when in the main module is skipped, such as -has_license_in_source_file -has_abstract_in_pod Turning off $Module::CPANTS::Kwalitee::Files::RespectManiskip in Test::Kwalitee does not help either, as this will report no_files_to_be_skipped errors. Unfortunately I need a MANIFEST.SKIP file to detect skipped files for Test::CheckManifest, and MANIFEST.SKIP must contain the generated modules. -- Reini Urban
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-6282-1551859210-1546.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-6282-1551859210-1546.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-2348-1551859265-1115.128724-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 105
Download (untitled) / with headers
text/plain 105b
This directly conflicts with the feature request in #126918 and is already broken in the latest release.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-2348-1551859265-1115.128724-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-6282-1551859210-1546.0-0-0 [...] rt.cpan.org> <rt-4.0.18-2348-1551859265-1115.128724-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-7269-1551859846-1330.128724-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 340
Download (untitled) / with headers
text/plain 340b
On Wed Mar 06 17:01:05 2019, RURBAN wrote: Show quoted text
> This directly conflicts with the feature request in #126918 > and is already broken in the latest release.
Would it help if I introduce a new variable ($IgnoreManiskip) to skip this block? https://github.com/cpants/Module-CPANTS-Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
MIME-Version: 1.0
X-Spam-Status: No, score=-5.333 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.18-7269-1551859846-549.128724-6-0 [...] rt.cpan.org>
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-128724 [...] rt.cpan.org> <rt-4.0.18-6282-1551859210-1546.128724-6-0 [...] rt.cpan.org> <rt-4.0.18-2348-1551859265-1115.128724-6-0 [...] rt.cpan.org> <rt-4.0.18-7269-1551859846-549.128724-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 2002:a9d:6090:: with SMTP id m16mr4443454otj.285.1551881216328; Wed, 06 Mar 2019 06:06:56 -0800 (PST)
Message-ID: <CAHiT=DF+3SQzWNesUOzK4DwY7+UhffB2uP=SHM_Sxg6AD0qHMg [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="000000000000a2084c05836d80ca"
X-Spam-Score: -5.333
X-Google-SMTP-Source: APXvYqztflP2rhUnih32KgYZr2V9RMGOtipem/CLot60zp/MKeKhRjG+zXhNIE7Wf/hliQimoz+HLwOCkoelfu4AkBg=
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 27B49240305 for <cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com>; Wed, 6 Mar 2019 09:07:03 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qr4S+KVtnKef for <cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com>; Wed, 6 Mar 2019 09:07:01 -0500 (EST)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 4AA672401C0 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Wed, 6 Mar 2019 09:07:01 -0500 (EST)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 334907C196 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Wed, 6 Mar 2019 06:07:00 -0800 (PST)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 8299F7CF89 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Wed, 6 Mar 2019 06:06:58 -0800 (PST)
Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 27ED77C196 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Wed, 6 Mar 2019 06:06:57 -0800 (PST)
Received: by mail-ot1-f43.google.com with SMTP id v20so10823190otk.7 for <bug-Module-CPANTS-Analyse [...] rt.cpan.org>; Wed, 06 Mar 2019 06:06:57 -0800 (PST)
Delivered-To: cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #128724] Allow generated modules from Files in MANIFEST.SKIP
Return-Path: <reini.urban [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=A2uqlegXyOHrOyukHKjhBjnoLndaqSZByN9xaOmsb4c=; b=d1QyYYtZF7gRFk99DdIZJ8Erxia9rnOGrMj8m9hdsyVN3hWkX6U4UJQNkogrJbLMZs HIUaCMsP41tS7UTMGm4zHT9q5ZaklbOgpkZ6vDvAvhSMrup4PHMCv4oWUqwuKigDVKmE xq0uJtV1tox9M/Ym+0qDkmK+7Omjk+oYEHV60cNjhlJd+c8Lt+lRYe/ap0qbK577fpKu zO+VhtWTezWTNf0SuVJBQWDYhWd+XvW1sR8uud6Io9v1H4yZGxGVYZ6EGyamJniENsJG I3efg7jG7Z5D2XEalRdra9ra2BR6kMpFrFLADe4LX3J8ssRp7B6KqLsjSEh1B9x6G8C6 chHA==
X-Original-To: cpan-bug+Module-CPANTS-Analyse [...] hipster.bestpractical.com
X-RT-Mail-Extension: module-cpants-analyse
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=A2uqlegXyOHrOyukHKjhBjnoLndaqSZByN9xaOmsb4c=; b=azKwFz8t6Sr0cgEHTij9V/4gi7gy4v4UF5bEyTgeqNB5oGFbCKswl8pHBTqKXDB4iJ W+LGCYIJtTeZBQYZCrzJiRSLzeI5Fze5OEiZDAEEgkty3TlgQGODCvHdmoJtyBUaDquH ZbHiTiXZrAMaLSZ4jTFTg0DWz10PpAMT20Ta+UIDN0s651ykj2W2Bmypr51ZEe7+NIA5 3jgI4blVP+xygZLP8jPpKcR/y4NCjvxEQA8Yf9QkiEtucCvjx5hYZqkLP7OF7uK6mlQF /kAsCypfklJeizWOVT3/6EfDg1dJuV7N0sxUmUIpjXGLv7K1cMniU0U+yd3VGxL6pF9G iT+g==
Date: Wed, 6 Mar 2019 15:06:44 +0100
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_50_70 0.1, BODYTEXTH_SIZE_10000_LESS 0, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_ALIGNS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_PASS 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_ALT 0, __DKIM_ALIGNS_1 0, __DKIM_ALIGNS_2 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FORWARDED_MSG 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __FUR_RDNS_GMAIL 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HELO_GMAIL 0, __HEX28_LC_BOUNDARY 0, __HTML_AHREF_TAG 0, __HTML_TAG_DIV 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_HTML 0, __MIME_TEXT_H 0, __MIME_TEXT_H1 0, __MIME_TEXT_H2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_URI_HTML 0, __MULTIPLE_URI_TEXT 0, __RATWARE_SIGNATURE_3_N1 0, __RDNS_WEBMAIL 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __SUBJ_REPLY 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __X_GOOGLE_DKIM_SIGNATURE 0, __YOUTUBE_RCVD 0, __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2019.3.6.135717
To: bug-Module-CPANTS-Analyse [...] rt.cpan.org
X-GM-Message-State: APjAAAUvWSi+YQ/1uIekXX/Nho+YbTjW2ZEK3SDR5Rvc19rum0M+pAOZ f2d7JT22KjhA6MTGFAJUmCv8RxJbPJ+UBTO9fJrznA==
From: Reini Urban <reini.urban [...] gmail.com>
RT-Message-ID: <rt-4.0.18-30543-1551881224-407.128724-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 720
Download (untitled) / with headers
text/plain 720b
Kenichi Ishigaki via RT <bug-Module-CPANTS-Analyse@rt.cpan.org> schrieb am Mi., 6. März 2019, 09:10: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=128724 > > > On Wed Mar 06 17:01:05 2019, RURBAN wrote:
> > This directly conflicts with the feature request in #126918 > > and is already broken in the latest release.
> > > Would it help if I introduce a new variable ($IgnoreManiskip) to skip this > block? > > > https://github.com/cpants/Module-CPANTS-Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
But then it would clash with hmbrand's test case. It really should know about all configure-time and build-time expanded files and accept these. esp. scripts and modules. no idea how, yet. Show quoted text
> >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1556
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-7269-1551859846-1330.128724-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-6282-1551859210-1546.0-0-0 [...] rt.cpan.org> <rt-4.0.18-2348-1551859265-1115.128724-0-0 [...] rt.cpan.org> <rt-4.0.18-7269-1551859846-1330.128724-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-10276-1551895387-439.128724-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 750
Download (untitled) / with headers
text/plain 750b
On Wed Mar 06 17:10:46 2019, ISHIGAKI wrote: Show quoted text
> On Wed Mar 06 17:01:05 2019, RURBAN wrote:
> > This directly conflicts with the feature request in #126918 > > and is already broken in the latest release.
> > > Would it help if I introduce a new variable ($IgnoreManiskip) to skip > this block? > > https://github.com/cpants/Module-CPANTS- > Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
I think I find what is a real issue: MANIFEST.SKIP for Storable is written in a .gitignore style, but each line of it is actually treated as a regular expression. So you need to add "$"s (and maybe "\") to "Makefile" and "Storable.pm" lines if you don't want to skip "Makefile.PL" nor "Storable_pm.PL" (see ExtUtils::Manifest for details).
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-10276-1551895387-439.128724-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-6282-1551859210-1546.0-0-0 [...] rt.cpan.org> <rt-4.0.18-2348-1551859265-1115.128724-0-0 [...] rt.cpan.org> <rt-4.0.18-7269-1551859846-1330.128724-0-0 [...] rt.cpan.org> <rt-4.0.18-10276-1551895387-439.128724-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-15240-1551896460-673.128724-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1000
Download (untitled) / with headers
text/plain 1000b
On Thu Mar 07 03:03:07 2019, ISHIGAKI wrote: Show quoted text
> On Wed Mar 06 17:10:46 2019, ISHIGAKI wrote:
> > On Wed Mar 06 17:01:05 2019, RURBAN wrote:
> > > This directly conflicts with the feature request in #126918 > > > and is already broken in the latest release.
> > > > > > Would it help if I introduce a new variable ($IgnoreManiskip) to skip > > this block? > > > > https://github.com/cpants/Module-CPANTS- > > Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
> > > I think I find what is a real issue: MANIFEST.SKIP for Storable is > written in a .gitignore style, but each line of it is actually treated > as a regular expression. So you need to add "$"s (and maybe "\") to > "Makefile" and "Storable.pm" lines if you don't want to skip > "Makefile.PL" nor "Storable_pm.PL" (see ExtUtils::Manifest for > details).
Also, https://github.com/cpants/Module-CPANTS-Analyse/commit/f8a8d2e87b3229247e879a18b171729fe777ab22 should fix the has_license_in_source_file issue. (not released yet)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.