Skip Menu |
 

This queue is for tickets about the Log-Handler CPAN distribution.

Report information
The Basics
Id: 125842
Status: open
Priority: 0/
Queue: Log-Handler

People
Owner: Nobody in particular
Requestors: gregoa [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
From: gregoa [...] cpan.org
Subject: warning: "hostname() doesn't accept any arguments"
X-RT-Interface: REST
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 1002
Download (untitled) / with headers
text/plain 1002b
We have the following bug reported to the Debian package of Log-Handler (https://bugs.debian.org/903741): It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks! ------8<-----------8<-----------8<-----------8<-----------8<----- Package: liblog-handler-perl Version: 0.88-1 User: debian-perl@lists.debian.org Usertags: perl-5.28-transition While test rebuilding the archive against Perl 5.28 (currently in experimental), we noticed this warning in the build log of this package: hostname() doesn't accept any arguments. This will become fatal in Perl 5.32 at /<<PKGBUILDDIR>>/blib/lib/Log/Handler/Output.pm line 67. A full build log can be found at http://perl.debian.net/rebuild-logs/perl-5.28-throwaway/liblog-handler-perl_0.88-1/liblog-handler-perl_0.88-1_amd64-2018-06-05T14%3A42%3A03Z.build -- Niko Tyni ntyni@debian.org ------8<-----------8<-----------8<-----------8<-----------8<----- Thanks for considering, gregor herrmann, Debian Perl Group
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-14314-1561513295-1346.125842-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 207
Download (untitled) / with headers
text/plain 207b
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Content-Type: multipart/mixed; boundary="----------=_1563306297-21384-2"
Message-ID: <rt-4.0.18-21384-1563306297-1132.125842-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
Content-Length: 995
Download (untitled) / with headers
text/plain 995b
On Fri Jul 13 16:51:47 2018, GREGOA wrote: Show quoted text
> We have the following bug reported to the Debian package of > Log-Handler (https://bugs.debian.org/903741): > > It doesn't seem to be a bug in the packaging, so you may want to take > a look. Thanks! > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > Package: liblog-handler-perl > Version: 0.88-1 > User: debian-perl@lists.debian.org > Usertags: perl-5.28-transition > > While test rebuilding the archive against Perl 5.28 (currently in > experimental), we noticed this warning in the build log of this > package: > > hostname() doesn't accept any arguments. This will become fatal in > Perl 5.32 at /<<PKGBUILDDIR>>/blib/lib/Log/Handler/Output.pm line 67. > > A full build log can be found at > > http://perl.debian.net/rebuild-logs/perl-5.28-throwaway/liblog- > handler-perl_0.88-1/liblog-handler-perl_0.88-1_amd64-2018-06- > 05T14%3A42%3A03Z.build
Please review the patch attached. Thank you very much. Jim Keenan
MIME-Version: 1.0
Subject: Log-Handler.diff
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Type: text/x-patch; name="Log-Handler.diff"
Content-Disposition: inline; filename="Log-Handler.diff"
Content-Transfer-Encoding: binary
Content-Length: 1615
Download Log-Handler.diff
text/x-diff 1.5k
diff -u -r ./lib/Log/Handler/Output.pm /home/jkeenan/Downloads/Log-Handler-0.88/lib/Log/Handler/Output.pm --- ./lib/Log/Handler/Output.pm 2015-06-15 22:15:10.000000000 -0400 +++ /home/jkeenan/Downloads/Log-Handler-0.88/lib/Log/Handler/Output.pm 2019-07-16 15:33:43.199901580 -0400 @@ -64,7 +64,12 @@ # is that each output can have their own time/date format # and the code which is executed can return another value. foreach my $r (@{$self->{wanted_pattern}}) { - $wanted->{$r->{name}} = &{$r->{code}}($self, $level); + unless ($r->{name} eq 'hostname') { + $wanted->{$r->{name}} = &{$r->{code}}($self, $level); + } + else { + $wanted->{$r->{name}} = $r->{code}(); + } } if ($self->{message_pattern}) { diff -u -r ./t/012-handler-message-pattern.t /home/jkeenan/Downloads/Log-Handler-0.88/t/012-handler-message-pattern.t --- ./t/012-handler-message-pattern.t 2013-11-03 14:27:58.000000000 -0500 +++ /home/jkeenan/Downloads/Log-Handler-0.88/t/012-handler-message-pattern.t 2019-07-16 15:30:13.203358617 -0400 @@ -1,6 +1,6 @@ use strict; use warnings; -use Test::More tests => 15; +use Test::More tests => 17; use Log::Handler; my $CHECKED = 0; @@ -34,7 +34,10 @@ my $log = Log::Handler->new(); -$log->add( +ok(defined $log, "new() returned defined object"); +isa_ok($log, 'Log::Handler'); + +my $rv = $log->add( forward => { forward_to => \&check_struct, maxlevel => 'debug', @@ -44,7 +47,7 @@ } ); -ok(1, 'new'); +ok($rv, "add() returned true value"); $log->debug('foo');
MIME-Version: 1.0
X-Spam-Status: No, score=-5.107 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, FROM_OUR_RT=-4, RDNS_NONE=0.793] autolearn=ham
In-Reply-To: <rt-4.0.18-21384-1563306298-400.125842-6-0 [...] rt.cpan.org>
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-125842 [...] rt.cpan.org> <rt-4.0.18-21384-1563306298-400.125842-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20190719193537.GC7314 [...] jadzia.comodo.priv.at>
Content-Type: multipart/signed; boundary="----------=_1563564946-8737-95"; micalg="pgp-sha512"; protocol="application/pgp-signature"
X-Face: -kg'V!M2hYTiiEt:oj$rToa+c^7N.t}]V^j}|%+]%3J&tOm^9mc^1-#9o=\8VJpV7b~nxIM!qu>r_:w\EtWQA01;$jp>,cgp9EWV:i9B]LCgiNn\jA=un9d-ZcRzyq~9vYUf*tx9B}de^fH5Q(d(_N"0WXs%Jh!~.*g.iC=bSTqL:/EE0Y~\g_QCvwS6=cv]$tB7z<Xh[Wxa.2d"m?]^f
X-Spam-Score: -5.107
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 19606240290 for <cpan-bug+log-handler [...] hipster.bestpractical.com>; Fri, 19 Jul 2019 15:35:59 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G4k-ho52n0E0 for <cpan-bug+log-handler [...] hipster.bestpractical.com>; Fri, 19 Jul 2019 15:35:57 -0400 (EDT)
Received: from xx1.develooper.com (unknown [147.75.38.233]) by hipster.bestpractical.com (Postfix) with ESMTPS id 602F5240172 for <bug-log-handler [...] rt.cpan.org>; Fri, 19 Jul 2019 15:35:57 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 106B1C214C for <bug-log-handler [...] rt.cpan.org>; Fri, 19 Jul 2019 12:35:57 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 4E015C214D for <bug-log-handler [...] rt.cpan.org>; Fri, 19 Jul 2019 12:35:51 -0700 (PDT)
Received: from colleen.colgarra.priv.at (colleen.colgarra.priv.at [82.150.197.101]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 85256C214C for <bug-log-handler [...] rt.cpan.org>; Fri, 19 Jul 2019 12:35:50 -0700 (PDT)
Received: from [170.82.202.216] (helo=jadzia.comodo.priv.at) by colleen.colgarra.priv.at with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <gregoa [...] debian.org>) id 1hoYfU-0004Zl-RH for bug-log-handler [...] rt.cpan.org; Fri, 19 Jul 2019 21:35:48 +0200
Received: from gregoa by jadzia.comodo.priv.at with local (Exim 4.92) (envelope-from <gregoa [...] debian.org>) id 1hoYfS-0003yz-OA for bug-log-handler [...] rt.cpan.org; Fri, 19 Jul 2019 16:35:46 -0300
Delivered-To: cpan-bug+log-handler [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #125842] warning: "hostname() doesn't accept any arguments"
User-Agent: Mutt/1.10.1 (2018-07-13)
Return-Path: <gregoa [...] debian.org>
X-Original-To: cpan-bug+log-handler [...] hipster.bestpractical.com
X-RT-Mail-Extension: log-handler
Date: Fri, 19 Jul 2019 16:35:37 -0300
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' AT_TLD 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1700_1799 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_NONE 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __BAT_BOUNDARY 0, __BODY_NO_MAILTO 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_REFERENCES 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_URI_TEXT 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_SUBJ_ALERT 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __SUBJ_REPLY 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_MAILTO 0, __URI_NO_PATH 0, __URI_NS , __URI_WITHOUT_PATH 0, __USER_AGENT 0, __blackholes.mail-abuse.org_ERROR , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2019.7.19.192417
To: James E Keenan via RT <bug-Log-Handler [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
X-Temperature-Innsbruck: 27 C (2019-07-19 12:41:02 -03)
RT-Message-ID: <rt-4.0.18-4551-1563564959-1644.125842-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Disposition: inline
X-RT-Original-Encoding: utf-8
Content-Length: 397
Download (untitled) / with headers
text/plain 397b
On Tue, 16 Jul 2019 15:44:58 -0400, James E Keenan via RT wrote: Show quoted text
> Please review the patch attached.
Looks good to me, thanks. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `-
Content-Description: Digital Signature
Content-Type: application/pgp-signature; name="signature.asc"
Content-Disposition: inline; filename="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Length: 963
Download signature.asc
application/pgp-signature 963b

Message body not shown because it is not plain text.

MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-21384-1563306297-1132.125842-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-21384-1563306297-1132.125842-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-12794-1569763854-1541.125842-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1271
Download (untitled) / with headers
text/plain 1.2k
On 2019-07-16 15:44:57, JKEENAN wrote: Show quoted text
> On Fri Jul 13 16:51:47 2018, GREGOA wrote:
> > We have the following bug reported to the Debian package of > > Log-Handler (https://bugs.debian.org/903741): > > > > It doesn't seem to be a bug in the packaging, so you may want to take > > a look. Thanks! > > > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > > > Package: liblog-handler-perl > > Version: 0.88-1 > > User: debian-perl@lists.debian.org > > Usertags: perl-5.28-transition > > > > While test rebuilding the archive against Perl 5.28 (currently in > > experimental), we noticed this warning in the build log of this > > package: > > > > hostname() doesn't accept any arguments. This will become fatal in > > Perl 5.32 at /<<PKGBUILDDIR>>/blib/lib/Log/Handler/Output.pm line 67. > > > > A full build log can be found at > > > > http://perl.debian.net/rebuild-logs/perl-5.28-throwaway/liblog- > > handler-perl_0.88-1/liblog-handler-perl_0.88-1_amd64-2018-06- > > 05T14%3A42%3A03Z.build
> > Please review the patch attached. > > Thank you very much. > Jim Keenan
CPAN.pm users may use the following distropref file for automatic patching (using Jim's patch): https://github.com/eserte/srezic-cpan-distroprefs/blob/master/Log-Handler.yml


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.