Skip Menu |
 

This queue is for tickets about the Perl-Critic-Pulp CPAN distribution.

Report information
The Basics
Id: 125823
Status: open
Priority: 0/
Queue: Perl-Critic-Pulp

People
Owner: Nobody in particular
Requestors: PETDANCE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Make ValuesAndExpressions::ProhibitFiletest_f not complain if -f isn't the only operator
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-4726-1531343842-507.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 467
Download (untitled) / with headers
text/plain 467b
I have tests where I'm doing, for example: ok( -f -r $filename, "$filename exists and is readable" ); I specifically want to check -f because I don't want directories, and the file I'm looking for better not be a pipe or device file or whatever. The -r tells me at least that it's readable. It would be nice if the policy didn't complain in this case. P.S. Big thumbs up on the depth of information in the explanation behind the reasoning behind this policy.
X-Ymail-Osg: ESFm0.kVM1mM_R12K2V6Ul22Sl3LIT40mvE.jC6M_GuTGIGQZ_gfyy6Rq.eP70b gI31mbTu8Iqfv2pUn_LbsrSliwRS761iM.YuxtMVHh6s6lUCtmJtg3JX_NGmgqcsE8UcTDjIGHG0 _e6lth3KeY9jBLXnjAUfHGhF_DXbU_hgedOS9ZxszK5DqjAhcBuBe9qN_mHlAGaNbO7E4T23Kzwo Ve8bCRBcH8HPFmdZIPBQwdy_4jBjXXBMyW0g_HT1cg5xJjsnufBzWtkTJLiMoM_QapsbCs6wCv10 qe4Aplq3KZ5TQj5atY8A42qRCfk8c0Ya.Zl6zuOL_KzGRnojOTGLGoEkAgT9r4bufx694bBLLML0 o8owG17tEaLO0d_tIJl9_ubmDIU4oqwFRvMmPaizAGseL6U2vUGCUjiMoXfcg2I.fVrrm0T1l6Yy VXzZzTE85rhBgoKohRnQBFJ.2TdF9yAWAYSxeAai7pm9V.PhGeYhYx_fC9iWnHHwy7_hjt_AoSPU 5T5drMweVNw2ef10lEf2a5CirhCl0Vj40BNQlsJ2lZfgdsyayq4hfoU3PKacFVD5NKxCLDe5SoGA miky93Admh6JjQ__atJmreHt_uKIQfTEWES.LDEsRntoKMToxqFpoJiycHyLK_FkL1ApRx9HUp9C pZhkPbENotHXcZdu7eifsvk9lUjgcJSM_NBaAACTp.5Jgym85W25Yb8yYwzoqKr2cIHMPprcFr9L SnoW1SBqk43Av.ejip2XINUEYClnGaNtKuevYy_hTQ8HuwGA.9vBkHVcVGem0d1Sc3GmyVt.yiDB f5eGtEMUFNe6Gi_vbYrDJEzwrsAEl90OvVsrEpTNvqS9YFPB_jCCDWx9Z.0W1eYaMJLSlUSWBf.4 YZk5xFPdVnlCZC.4ooVWFvJoaTUEGqaqLwnsv7ftYZSDhwMIXsBQGmyKWnw9HJfe8X0g7v0cn9GV 1oU4Nx_iakwQhG72zyu8DXILajbfw78EaN78kBA--
MIME-Version: 1.0
X-Spam-Status: No, score=-5.22 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-4.0.18-4726-1531343843-1873.125823-4-0 [...] rt.cpan.org> (Andy Lester via's message of "Wed, 11 Jul 2018 17:17:23 -0400")
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-125823 [...] rt.cpan.org> <rt-4.0.18-4726-1531343843-1873.125823-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <87wotx2ghe.fsf [...] blah.blah>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.22
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yahoo.com.au
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id EC76C240106 for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Sun, 15 Jul 2018 01:55:00 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y+PxxF2lMBQa for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Sun, 15 Jul 2018 01:54:59 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 60BD42400C0 for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Sun, 15 Jul 2018 01:54:59 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 592A112021E for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Sat, 14 Jul 2018 22:54:58 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id C6544120220 for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Sat, 14 Jul 2018 22:54:56 -0700 (PDT)
Received: from sonic315-10.consmr.mail.gq1.yahoo.com (sonic315-10.consmr.mail.gq1.yahoo.com [98.137.65.34]) by xx1.develooper.com (Postfix) with ESMTP id 453B612021E for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Sat, 14 Jul 2018 22:54:44 -0700 (PDT)
Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sun, 15 Jul 2018 05:54:43 +0000
Received: from 64.38.149.122.sta.dodo.net.au (EHLO blah.blah) ([122.149.38.64]) by smtp427.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 9676ed9ee7460c78266db5014b83e726 for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Sun, 15 Jul 2018 05:54:40 +0000 (UTC)
Delivered-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #125823] Make ValuesAndExpressions::ProhibitFiletest_f not complain if -f isn't the only operator
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Return-Path: <user42_kevin [...] yahoo.com.au>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1531634083; bh=FxccoAQCaeRcYvhV/C3zZ50Z1qp4RDg8OeNmuciKITc=; h=From:To:Subject:References:Date:In-Reply-To:From:Subject; b=Mtu3UQ0/IGjHSPYWs80kzWTvC5bs11fJ89ayZQW5bbA4AqBOwHqVHKpbcrTVmAzJDNKEEgz3va6ouYtx+uCZGKNlX+9LLzA44CqSEwXWIFMI0Qa63lB8STIrtVhCax6lh8XqqBORLlQF37j988fIPo9JRmOUh4FKR3T+6meM2WydmbGjVW4CCm5PT5iienPpOJFkem2xCbY51bWOYLLzpjSlrNwCgJEIzQ73t4dFTbxnwkBZR5at2injdYv2Aq36QDJLGnH4AbXlA7SZ4goNk0v1NBohZcW8ygKk5Al6dXr+nNlJCsnOw0R3CuaxqsP0YMtlROhtIWq+8hSEJxNiVA==
X-Original-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic-pulp
Date: Sun, 15 Jul 2018 15:52:13 +1000
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, NO_URI_HTTPS 0, REFERENCES 0, SPF_PASS 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CT 0, __CT_TEXT_PLAIN 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FORWARDED_MSG 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_YAHOO 0, __FUR_RDNS_YAHOO 0, __HAS_FROM 0, __HAS_MSGID 0, __HELO_YAHOO 0, __INVOICE_MULTILINGUAL 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __RDNS_WEBMAIL 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __SUBJ_REPLY 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2018.7.15.54516
To: "Andy Lester via RT" <bug-Perl-Critic-Pulp [...] rt.cpan.org>
From: Kevin Ryde <user42_kevin [...] yahoo.com.au>
RT-Message-ID: <rt-4.0.18-30523-1531634101-94.125823-0-0 [...] rt.cpan.org>
Content-Length: 1210
Download (untitled) / with headers
text/plain 1.1k
"Andy Lester via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text
> > ok( -f -r $filename, "$filename exists and is readable" ); > > I specifically want to check -f because I don't want directories, and > the file I'm looking for better not be a pipe or device file or > whatever.
Are you sure? If so then my concept may too strict, and having thought and decided you're ok, then disable/skip/etc. I had trouble thinking of much besides a backup or archiver which would genuinely care about device vs ordinary. Show quoted text
> The -r tells me at least that it's readable. It would be > nice if the policy didn't complain in this case.
Ah, of a doubled operator. Hmm. I think I would still apply it there, unless I misunderstand. Show quoted text
> P.S. Big thumbs up on the depth of information in the explanation > behind the reasoning behind this policy.
:-) I struck a couple of module authors with preemptive -f so couldn't pass say /dev/null. Can't remember now exactly where, but I collected the rationale against. You're a test script is it? I can understand being more relaxed there since you're in complete control. I have in mind mostly module or program code, though there could be argument for still keeping up.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-30523-1531634101-94.125823-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-125823 [...] rt.cpan.org> <rt-4.0.18-4726-1531343843-1873.125823-4-0 [...] rt.cpan.org> <87wotx2ghe.fsf [...] blah.blah> <rt-4.0.18-30523-1531634101-94.125823-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-12791-1531680282-103.125823-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 212
Download (untitled) / with headers
text/plain 212b
I don't have particularly strong feelings. It just seems to me that the core of the policy is "-f is not enough on its own", and my case of "-f -r" (or "-f -x" or "-f -w" or whatever) doesn't violate that ideal.
X-Ymail-Osg: vWfJ6dgVM1kla_msTWsPjt0xeEAom3PRnOqrDvr3T84_tr99tF3A9KC5oMXcegR ASVcj0fAUYYD2RsKD6mlHp5jDj7WWaXIcHEsHYK_u0cUxdx7ReBf7IplkuX2tEV5.8OE_5KEStwk _IWQcpixaNznjXHTD5Dkp19Mv7QEmhbuRvsCm44qel6DN5JaAu70sXIXsGP2xpwp7YbI0zZZd7PS Uo6FD4u07vcmbRQZ7B6PTfkezLcvZBojjMsi4UCWI0hu65ORHHbKhjLQUMn48NkMHATGI8V1Dmbp 2aOEYImjKwSCNXMV6uu5LDziJZP0TmZtslbmKn1Q2z5nPmL6yfNA9q.0Cs_D.wwSzTECcqBVlhKF evJSVULL11fKfSZTiKSeBx9KB9VYIJT978ewlWixEpoXmUyr.50iKggi1u0w4E4gcqnEYCGxjWZ_ pQOteXdTiiCvIz2aJ_j.8zkQsks.kP6JSFKZFmiVdgRAJtrzWm9njdL2CVh9yfcnSKSEMTOxobdl fCzOYP2uatcJB03lAhVey.kky816fzQjQD52EFZegAB0ZtOGvA75AMi2oMJ615aBQT9AHoycrebW dZ3Mgsyw_whFxqNwtT43s80aetAuIitdnt1xxAZpsFP8qlHV0yAY7fCUDAByO.nHHg4adrM8K8bL x2BO0A2S0qi3qHfptn_WwD17UDIFHRO3zSUn60805sJyWh8NessueuGAqClZVPbvLDXd.yCGjscZ W96jGSLWzAqElbLpVmtHm9NT2iFHzO2laX.tmg0_jb3cLbdRps9FGXYcORsuuAcOSDgwwYDFgXHK B54tPKl22YCjp3.OZm9J9CapXUFUP7.scYTxUvJbrgaSb4eAepboLp7LEPThBG8C3IyklD5kzUc1 .yUAGNenUzXYCVdvw7i2lD0oUNCfTHKO1YJfrfBaFY4djfyhEZXSYZORZgXZoy5WAHR6M0oipyn4 bLK2qjTwpuHT8JcOCqcFCQW_a6tTCIfSKXurOFAMs
MIME-Version: 1.0
X-Spam-Status: No, score=-5.22 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, SPF_NEUTRAL=0.779] autolearn=ham
In-Reply-To: <rt-4.0.18-12791-1531680282-1958.125823-5-0 [...] rt.cpan.org> (Andy Lester via's message of "Sun, 15 Jul 2018 14:44:43 -0400")
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-125823 [...] rt.cpan.org> <rt-4.0.18-4726-1531343843-1873.125823-4-0 [...] rt.cpan.org> <87wotx2ghe.fsf [...] blah.blah> <rt-4.0.18-30523-1531634101-94.125823-5-0 [...] rt.cpan.org> <rt-4.0.18-12791-1531680282-1958.125823-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <87efg1osv5.fsf [...] blah.blah>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.22
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yahoo.com.au
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id CBFE324032A for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Wed, 18 Jul 2018 04:26:32 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n0PsBHHNb5ww for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Wed, 18 Jul 2018 04:26:31 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 99164240301 for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Wed, 18 Jul 2018 04:26:31 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 807236700E for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Wed, 18 Jul 2018 01:26:30 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id BF27A67010 for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Wed, 18 Jul 2018 01:26:28 -0700 (PDT)
Received: from sonic304-10.consmr.mail.bf2.yahoo.com (sonic304-10.consmr.mail.bf2.yahoo.com [74.6.128.33]) by xx1.develooper.com (Postfix) with ESMTP id 0F2E46700E for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Wed, 18 Jul 2018 01:26:17 -0700 (PDT)
Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Wed, 18 Jul 2018 08:26:16 +0000
Received: from 166.66.149.122.sta.dodo.net.au (EHLO blah.blah) ([122.149.66.166]) by smtp418.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 59ac96b27fcfc2d5876a9d630631ad4d for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Wed, 18 Jul 2018 08:26:12 +0000 (UTC)
Delivered-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #125823] Make ValuesAndExpressions::ProhibitFiletest_f not complain if -f isn't the only operator
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Return-Path: <user42_kevin [...] yahoo.com.au>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1531902376; bh=bSXC8Mwq2WnkgZbyJhRgXVHqn75nqD+yOi8YkoTQHLQ=; h=From:To:Subject:References:Date:In-Reply-To:From:Subject; b=B3Q8RoNRl8O/Gg1m/JJR4Ydouz/CLafp5ZgZNDwwrHG7HE0a6XLDGlW5BRxKJXVJMcol/cK3Jnp5apUk3kY8lSmHd8LPcag4lR+SW9Lmqb2aQTVyqSd6vMvBtraI/GuRWRj4y7h+zm6G1LviscpqvIz8zfwX4r4TTBfm8DKUnONLH6p5oX6AluOVwfx/6HezyOj8vP1NK+5xHRLrD5y3MAtrq2R4vdegWlqn3HrSSmWTkxlj9Aa6ygUMOMiEdF30BwaJ4RwUBaCPyYEjZmolXehY0pM+AXgDuu1g/cLlJt9zNlGemdMFAoZcya6h9R4pCzBba4dlhSHMLBv9vXZe8w==
X-Original-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic-pulp
Date: Wed, 18 Jul 2018 18:22:54 +1000
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_500_599 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, NO_URI_HTTPS 0, REFERENCES 0, SPF_PASS 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CT 0, __CT_TEXT_PLAIN 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_YAHOO 0, __FUR_RDNS_YAHOO 0, __HAS_FROM 0, __HAS_MSGID 0, __HELO_YAHOO 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __RDNS_WEBMAIL 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __SUBJ_REPLY 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2018.7.18.81816
To: "Andy Lester via RT" <bug-Perl-Critic-Pulp [...] rt.cpan.org>
From: Kevin Ryde <user42_kevin [...] yahoo.com.au>
RT-Message-ID: <rt-4.0.18-15672-1531902393-205.125823-0-0 [...] rt.cpan.org>
Content-Length: 550
Download (untitled) / with headers
text/plain 550b
"Andy Lester via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text
> > It just seems to me that the core of the policy is "-f is not enough > on its own", ...
Oh, :-), I'm harsher than that. I'm more like "never use -f". I'll see if I can massage the words a little, to either make that intention clearer or justify it yet further. Incidentally recent perlfunc "-X" has a note on permissions -r and friends being a race condition, so I can cross reference that. There too of course if you're in full control of a directory then can be more relaxed.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.