| MIME-Version: | 1.0 |
| X-Cpan.org: | This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings. |
| X-Spam-Flag: | NO |
| content-type: | text/plain; charset="utf-8" |
| X-Virus-Scanned: | Debian amavisd-new at bestpractical.com |
| X-CTCH-Vod: | Unknown |
| X-Spam-Score: | -1.235 |
| Received: | from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 7F15F2400F4 for <cpan-bug+Unicode-LineBreak [...] hipster.bestpractical.com>; Sat, 23 Jun 2018 23:40:46 -0400 (EDT) |
| Received: | from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4uzif5ww-LJ8 for <cpan-bug+Unicode-LineBreak [...] hipster.bestpractical.com>; Sat, 23 Jun 2018 23:40:44 -0400 (EDT) |
| Received: | from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 6A80B2400C0 for <bug-Unicode-LineBreak [...] rt.cpan.org>; Sat, 23 Jun 2018 23:40:44 -0400 (EDT) |
| Received: | from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id D955D66FFA for <bug-Unicode-LineBreak [...] rt.cpan.org>; Sat, 23 Jun 2018 20:40:42 -0700 (PDT) |
| Received: | from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 3BA8866FFE for <bug-Unicode-LineBreak [...] rt.cpan.org>; Sat, 23 Jun 2018 20:40:40 -0700 (PDT) |
| Received: | from mail6c40.carrierzone.com (mail6c40.carrierzone.com [209.235.156.146]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 055D166FFA for <bug-Unicode-LineBreak [...] rt.cpan.org>; Sat, 23 Jun 2018 20:40:32 -0700 (PDT) |
| Received: | from [192.168.1.4] (pool-108-15-38-6.bltmmd.fios.verizon.net [108.15.38.6]) (authenticated bits=0) by mail6c40.carrierzone.com (8.14.9/8.14.9) with ESMTP id w5O3Jj8l005925 for <bug-Unicode-LineBreak [...] rt.cpan.org>; Sun, 24 Jun 2018 03:19:47 +0000 |
| X-CTCH-Refid: | str=0001.0A09020D.5B2F0DD3.0012,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 |
| Delivered-To: | cpan-bug+Unicode-LineBreak [...] hipster.bestpractical.com |
| Subject: | Cleaner Makefile recipe for downloading test datasets |
| X-PMX-Spam: | Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, SUPERLONG_LINE 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DATE_TZ_NA 0, NO_URI_HTTPS 0, SPF_PASS 0, __ANY_URI 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MSGID_APPLEMAIL 0, __NO_HTML_TAG_RAW 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_MAILTO 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR ' |
| Date: | Sat, 23 Jun 2018 23:19:43 -0400 |
| X-Spam-Level: | |
| X-CSC: | 0 |
| X-PMX-Version: | 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2018.4.8.232716 |
| X-Cha: | v=2.3 cv=BuKzP7f5 c=1 sm=1 tr=0 a=rFnL0955gElK8Y1Xr2lpiQ==:117 a=rFnL0955gElK8Y1Xr2lpiQ==:17 a=IkcTkHD0fZMA:10 a=te1EGT4yAAAA:8 a=PYXZQklhmmrdgmiRS8YA:9 a=QEXdDO2ut3YA:10 a=RRElR4r2U1jGY2dU47NL:22 |
| To: | <bug-Unicode-LineBreak [...] rt.cpan.org> |
| Content-Transfer-Encoding: | 7bit |
| X-Spam-Status: | No, score=-1.235 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, SPF_SOFTFAIL=0.665] autolearn=no |
| X-CTCH-Flags: | 0 |
| X-CTCH-Spam: | Unknown |
| Message-ID: | <9AABBCAF-A971-417A-BFF0-D63AE2F27D1A [...] netspace.org> |
| X-CTCH-Rules: | |
| X-CTCH-Score: | 0.000 |
| User-Agent: | Microsoft-MacOutlook/10.c.0.180318 |
| Return-Path: | <dmacks [...] netspace.org> |
| X-Original-To: | cpan-bug+Unicode-LineBreak [...] hipster.bestpractical.com |
| X-RT-Mail-Extension: | unicode-linebreak |
| X-CTCH-Scorecust: | 0.000 |
| X-Authenticated-User: | dmacks [...] netspace.org |
| X-Greylist: | delayed 1243 seconds by postgrey-1.34 at xx1.develooper.com; Sat, 23 Jun 2018 20:40:34 PDT |
| Thread-Topic: | Cleaner Makefile recipe for downloading test datasets |
| From: | Daniel Macks <dmacks [...] netspace.org> |
| X-RT-Original-Encoding: | utf-8 |
| X-RT-Interface: | |
| Content-Length: | 1410 |
The downloading of test datasets seems overly complicated. From Unicode-LineBreak-2018.003 on OS X 10.13 using Apple's perl-5.18.2, Makefile.PL generates Makefile that contains:
copy_unidata :
cd test-data; \
[ -f LineBreakTest.txt ] || \
wget -q -N -O LineBreakTest.txt \
ftp://unicode.org/Public/8.0.0/ucd/auxiliary/LineBreakTest*.txt \
|| $(NOOP)
cd test-data; \
[ -f GraphemeBreakTest.txt ] || \
wget -q -N -O GraphemeBreakTest.txt \
ftp://unicode.org/Public/8.0.0/ucd/auxiliary/GraphemeBreakTest*.txt \
|| $(NOOP)
The concept is that each file needs to exist, and if it doesn't, a command should be executed to create it. That suggests that each file could have its own recipe and use standard Makefile dependencies rather than a monolithic set of shell file tests. For example:
copy_unidata : test-data/LineBreakTest.txt test-data/GraphemeBreakTest.txt
test-data/LineBreakTest.txt:
wget -q -N -O $@ ftp://unicode.org/Public/8.0.0/ucd/auxiliary/LineBreakTest*.txt
test-data/GraphemeTest.txt:
wget -q -N -O $@ ftp://unicode.org/Public/8.0.0/ucd/auxiliary/GraphemeBreakTest*.txt
It's now also self-documenting what needs what and how it comes to exist. I'm not sure why the "|| $(NOOP)" was used, but it seems like that would mask failures of wget, leaving things in a poor state and triggering harder-to-diagnose failures later.
dan