Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the libnet CPAN distribution.

Report information
The Basics
Id: 124534
Status: resolved
Priority: 0/
Queue: libnet

People
Owner: Nobody in particular
Requestors: perlbugbmw [...] lsmod.de
Cc: jkeenan [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 3.12



CC: jkeenan [...] cpan.org
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-24053-1519310389-209.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1276
Download (untitled) / with headers
text/plain 1.2k
Some items originally reported in the Perl 5 bug tracker: ##### 1. https://rt.perl.org/Ticket/Display.html?id=132896 #132896: timegm should be called with 4-digit year This is a bug report for perl from perlbugbmw@lsmod.de, generated with the help of perlbug 1.39 running under perl 5.18.2. timegm should be called with 4-digit year to avoid ambiguities in Time::Local with 2-digit years please review/test/merge this fix: --- perl-5.26.1.orig/cpan/libnet/lib/Net/NNTP.pm +++ perl-5.26.1/cpan/libnet/lib/Net/NNTP.pm @@ -601 +601 @@ sub date { - ? timegm($6, $5, $4, $3, $2 - 1, $1 - 1900) + ? timegm($6, $5, $4, $3, $2 - 1, $1) ##### ##### 2. https://rt.perl.org/Ticket/Display.html?id=132898 #132898: timegm should be called with 4-digit year This is a bug report for perl from perlbugbmw@lsmod.de, generated with the help of perlbug 1.39 running under perl 5.18.2. timegm should be called with 4-digit year to avoid ambiguities in Time::Local with 2-digit years please review/test/merge this fix: --- perl-5.26.1.orig/cpan/libnet/lib/Net/FTP.pm +++ perl-5.26.1/cpan/libnet/lib/Net/FTP.pm @@ -267 +267 @@ sub mdtm { - ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? $3 : ($1 - 1900)) + ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? ($3 + 1900) : $1) #####
MIME-Version: 1.0
Subject: timegm should be called with 4-digit year
In-Reply-To: <rt-4.0.18-24053-1519310389-209.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-24053-1519310389-209.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-24053-1519310514-1291.124534-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1400
Download (untitled) / with headers
text/plain 1.3k
On Thu Feb 22 09:39:49 2018, JKEENAN wrote: Show quoted text
> Some items originally reported in the Perl 5 bug tracker: > > ##### > 1. https://rt.perl.org/Ticket/Display.html?id=132896 > #132896: timegm should be called with 4-digit year > > This is a bug report for perl from perlbugbmw@lsmod.de, > generated with the help of perlbug 1.39 running under perl 5.18.2. > > timegm should be called with 4-digit year > to avoid ambiguities in Time::Local with 2-digit years > > please review/test/merge this fix: > > --- perl-5.26.1.orig/cpan/libnet/lib/Net/NNTP.pm > +++ perl-5.26.1/cpan/libnet/lib/Net/NNTP.pm > @@ -601 +601 @@ sub date { > - ? timegm($6, $5, $4, $3, $2 - 1, $1 - 1900) > + ? timegm($6, $5, $4, $3, $2 - 1, $1) > ##### > > ##### > 2. https://rt.perl.org/Ticket/Display.html?id=132898 > #132898: timegm should be called with 4-digit year > > This is a bug report for perl from perlbugbmw@lsmod.de, > generated with the help of perlbug 1.39 running under perl 5.18.2. > > timegm should be called with 4-digit year > to avoid ambiguities in Time::Local with 2-digit years > > please review/test/merge this fix: > > --- perl-5.26.1.orig/cpan/libnet/lib/Net/FTP.pm > +++ perl-5.26.1/cpan/libnet/lib/Net/FTP.pm > @@ -267 +267 @@ sub mdtm { > - ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? $3 : ($1 - 1900)) > + ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? ($3 + 1900) : $1) > #####
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-24053-1519310389-209.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-24053-1519310389-209.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-8096-1606828584-1341.124534-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 139
Download (untitled) / with headers
text/plain 139b
Thanks for the patches (and apologies for the slow response). These are now in commit 04a931cd6b and will be released soon in version 3.12.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-24053-1519310389-209.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-24053-1519310389-209.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-26623-1607606889-370.124534-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 68
Thanks again. This is now fixed in version 3.12, released yesterday.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.