Skip Menu |
 

This queue is for tickets about the CPANPLUS-Dist-Arch CPAN distribution.

Report information
The Basics
Id: 123153
Status: new
Priority: 0/
Queue: CPANPLUS-Dist-Arch

People
Owner: Nobody in particular
Requestors: moritz [...] bunkus.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Spam-Status: No, score=-1.999 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_FAIL=0.001] autolearn=no
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
content-type: text/plain; charset="utf-8"
Message-ID: <871smqmxph.fsf [...] bunkus.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -1.999
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 7C1422402C6 for <cpan-bug+cpanplus-dist-arch [...] hipster.bestpractical.com>; Thu, 28 Sep 2017 15:29:16 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r3senVxJaG-E for <cpan-bug+cpanplus-dist-arch [...] hipster.bestpractical.com>; Thu, 28 Sep 2017 15:29:15 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 1E814240265 for <bug-cpanplus-dist-arch [...] rt.cpan.org>; Thu, 28 Sep 2017 15:29:15 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id C06B41219CD for <bug-cpanplus-dist-arch [...] rt.cpan.org>; Thu, 28 Sep 2017 12:29:13 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id D932A66FF8 for <bug-cpanplus-dist-arch [...] rt.cpan.org>; Thu, 28 Sep 2017 12:29:09 -0700 (PDT)
Received: from adara.bunkus.org (adara.bunkus.org [144.76.6.84]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 4523F1219BF for <bug-cpanplus-dist-arch [...] rt.cpan.org>; Thu, 28 Sep 2017 12:29:01 -0700 (PDT)
Received: from liselle.bunkus.org ([2a01:4f8:190:8147::105:1]:33546) by adara.bunkus.org with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82_1-5b7a7c0-XX) (envelope-from <moritz [...] bunkus.org>) id 1dxeRv-0000oL-2P for bug-CPANPLUS-Dist-Arch [...] rt.cpan.org; Thu, 28 Sep 2017 21:26:19 +0200
Received: from sweet-chili.local (unknown [192.168.191.4]) by liselle.bunkus.org (Postfix) with ESMTPS id 8E3146540002 for <bug-CPANPLUS-Dist-Arch [...] rt.cpan.org>; Thu, 28 Sep 2017 21:26:19 +0200 (CEST)
Received: from sweet-chili (localhost [IPv6:::1]) by sweet-chili.local (Postfix) with ESMTPS id C3C7820330C1 for <bug-CPANPLUS-Dist-Arch [...] rt.cpan.org>; Thu, 28 Sep 2017 21:26:18 +0200 (CEST)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] bunkus.org
Delivered-To: cpan-bug+cpanplus-dist-arch [...] hipster.bestpractical.com
X-CTCH-Refid: str=0001.0A0B0201.59CD4CDB.0124,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0
Subject: cpan2aur generates wrong "find" command leaving .packlist in place
User-Agent: mu4e 0.9.18; emacs 25.3.1
Return-Path: <moritz [...] bunkus.org>
X-RT-Mail-Extension: cpanplus-dist-arch
X-Original-To: cpan-bug+cpanplus-dist-arch [...] hipster.bestpractical.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bunkus.org; s=mail2017070101; t=1506626779; bh=XpoBLwDI+/XH4ihZRsv45bD8swW1gtsqwijFWKxFbJo=; h=From:To:Subject:Date:From; b=pXLTvGfd4AXhL1s8hY23MTHJG5dPIoBSluZ0EYVbtjt+6n7vbJnrbtC2YTodZ+DDr gYtDifn6bSOZ0Vpxw4Hbq9ntWou442WEHBWXDT3OYRXdbZgMmqc5sT/NdNqZmAmLAT dJYE7yNAzWjdwm2xQiNg844Czbh/3zf8af2BFCt/J5xtc6De0Ql5I6NAXrAFlHxARN 45+kxui04a2D3YLCtCZOpy0sAIvD5P/av8uqegUK/yWNcP+zv9XDm7RQS6YbsN3dQ/ kt8M18dTdZTp/W+TJhUi68SHPhSIBD8FrGKrbKf+PJDT95NU2z80MRgSeFY1GikyTW hVyIPglBEOYBxMJYq9HhBxJzqL0e9CgN55//W2mmGk9uBMXLVxdsj2Egc5Di6ZLz3q MYqvhQs06/HvrLYZ/zx6nraiLTvA1K+4j3Mi7j9XsBF9eao6ab5lfOaeq/ccJMgAT/ /xu0zSuX5+GSFYpl3lAv0h+rYTDboOLQniUEiz8suOKlfRjzIvef8WovdUt72dQqTO T8wBAfXmotbTmZX97OkaRoFAxeAWo8JBY11+uFxyMtjcatWFYvYAG1bj0EdX6RfvVU UZoKCBj5EKk9t9KjRveXT+GoO6zLlgrGLjR2h2aZFXYwIHCzaG4Z8J1CAuA5HlQTcj +X+zN48i6fwH6Mziwmf90OdI=
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, NO_CTA_URI_FOUND 0, NO_URI_FOUND 0, NO_URI_HTTPS 0, SPF_PASS 0, __CT 0, __CT_TEXT_PLAIN 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_START 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __USER_AGENT 0, __zen.spamhaus.org_ERROR '
Date: Thu, 28 Sep 2017 21:26:18 +0200
X-Spam-Level:
X-Greylist: delayed 149 seconds by postgrey-1.34 at xx1.develooper.com; Thu, 28 Sep 2017 12:29:02 PDT
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.9.28.192116
To: bug-CPANPLUS-Dist-Arch [...] rt.cpan.org
From: Moritz Bunkus <moritz [...] bunkus.org>
X-RT-Original-Encoding: ascii
X-RT-Interface: Email
Content-Length: 1355
Download (untitled) / with headers
text/plain 1.3k
Hey, the "find" line that's supposed to delete both ".packlist" and "perllocal.pod" is wrong. Here's the generated one: find "$pkgdir" -name .packlist -o -name perllocal.pod -delete For clarity this is equivalent to the following: find "$pkgdir" -name .packlist -o -name perllocal.pod -a -delete Now we have to remember that "-a = and" has precedence over "-o = or". Therefore this is equivalent to: find "$pkgdir" "(" -name .packlist ")" -o "(" -name perllocal.pod -a -delete ")" Effectively this means that nothing is done for files named ".packlist", and deletion is only carried out for files named "perllocal.pod". Small proof of concept: touch a b find -name a -o -name b -delete ls You'll see 'a' still existing. The fix is easy; group the two "-name" checks like this: find "$pkgdir" "(" -name .packlist -o -name perllocal.pod ")" -delete Proof of this working: rm -f a b touch a b find "(" -name a -o -name b ")" -delete ls Both files are now gone. The effective result of this bug is: 1. Files named ".packlist" remain in "$srcdir" during makepkg. 2. Therefore "options=(!emptydirs)" does not apply to the corresponding directory. 3. Files whose name starts with a . aren't packaged by makepkg. 4. But the directory is. Now the package contains an empty directory. "namcap" complains about that. Kind regards, mosu


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.