Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 122571
Status: rejected
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: KES [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.082840
Fixed in: (no value)



Subject: select: can not indicate which columns should be selected from the storage.
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-10750-1500810418-1187.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 350
Download (untitled) / with headers
text/plain 350b
I come with a question: https://stackoverflow.com/questions/45258128/why-select-does-not-replace-existing-columns But finally I have discovered that `prefetch` does not work as documented Here is details: https://stackoverflow.com/a/45264653/4632019 In short: When I use `prefetch` it selects all columns from table despite on `select` attribute.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-10750-1500810418-1187.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-10750-1500810418-1187.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-7389-1500826757-1806.122571-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 849
Download (untitled) / with headers
text/plain 849b
On Sun Jul 23 07:46:58 2017, KES wrote: Show quoted text
> I come with a question: > https://stackoverflow.com/questions/45258128/why-select-does-not- > replace-existing-columns > > But finally I have discovered that `prefetch` does not work as > documented
This is merely a lack of documentation clarity - "It can be thought of as a rough superset of the "join" attribute." does say *rough* superset. If you want to select custom columns, you want to use join+select yourself. While I would appreciate a doc patch, I'm marking this rejected because (1) the bug title is a lie (2) a slightly unclear piece of documentation is not a 'critical' bug (3) the last time you claimed a document was unclear it was because it had "too many words" so you hadn't read it. Please feel free to supply a patch that rephrases it if you can think of a better phrasing, though.
MIME-Version: 1.0
X-Spam-Status: No, score=-6.017 tagged_above=-99.9 required=10 tests=[AWL=-0.683, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.18-7389-1500826758-1647.122571-6-0 [...] rt.cpan.org>
X-Mailer: Yamail [ http://yandex.ru ] 5.0
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
Envelope-From: kes-kes [...] yandex.com
References: <RT-Ticket-122571 [...] rt.cpan.org> <rt-4.0.18-10750-1500810418-1187.122571-6-0 [...] rt.cpan.org> <rt-4.0.18-7389-1500826758-1647.122571-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <344511500997565 [...] web33j.yandex.ru>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.017
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yandex.ru
Authentication-Results: mxback10o.mail.yandex.net; dkim=pass header.i= [...] yandex.ru
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id B4B2C24037E for <cpan-bug+dbix-class [...] hipster.bestpractical.com>; Tue, 25 Jul 2017 11:47:42 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aMYpE-AcdApr for <cpan-bug+dbix-class [...] hipster.bestpractical.com>; Tue, 25 Jul 2017 11:47:40 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id A39FF24026F for <bug-dbix-class [...] rt.cpan.org>; Tue, 25 Jul 2017 11:47:40 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 8648911D8BE for <bug-dbix-class [...] rt.cpan.org>; Tue, 25 Jul 2017 08:47:39 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id C9B9611F079 for <bug-dbix-class [...] rt.cpan.org>; Tue, 25 Jul 2017 08:47:36 -0700 (PDT)
Received: from forward5p.cmail.yandex.net (forward5p.cmail.yandex.net [77.88.31.20]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 2CB4A11F06A for <bug-dbix-class [...] rt.cpan.org>; Tue, 25 Jul 2017 08:47:22 -0700 (PDT)
Received: from mxback10o.mail.yandex.net (mxback10o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::24]) by forward5p.cmail.yandex.net (Yandex) with ESMTP id 89F8620EFC; Tue, 25 Jul 2017 18:46:06 +0300 (MSK)
Received: from web33j.yandex.ru (web33j.yandex.ru [5.45.198.136]) by mxback10o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id HnPNcLYZGW-k5pSu7kU; Tue, 25 Jul 2017 18:46:05 +0300
Received: by web33j.yandex.ru with HTTP; Tue, 25 Jul 2017 18:46:05 +0300
Delivered-To: cpan-bug+dbix-class [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #122571] select: can not indicate which columns should be selected from the storage.
Return-Path: <kes-kes [...] yandex.ru>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1500997565; bh=yztAT48/alcu3r6dT1iZVzd9KCkztWJ2exUtvdKvFhw=; h=From:To:In-Reply-To:References:Subject:Message-Id:Date; b=L9D2AoUi1ofoIpc5KTb2NnBREJSLD9N8SZAhIzYmLAzr42nvmJnunWDM0XB7rjPLF qUCKp9p1pEq2ArB0QyeurwWxC/Z2Y7Xmgfv2dek/OR8S4mBt9QcM2Bbo66VtsMPGiZ 0V8oDKFb+9uyN+P5VfiSjhhj2ghOLNckCad0fY1Q=
X-Original-To: cpan-bug+dbix-class [...] hipster.bestpractical.com
X-RT-Mail-Extension: dbix-class
Date: Tue, 25 Jul 2017 18:46:05 +0300
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FROM_NAME_ONE_WORD 0.05, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_500_599 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, NO_URI_HTTPS 0, REFERENCES 0, SPF_PASS 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __DATE_TZ_RU 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __REFERENCES 0, __RUS_WEBMAIL_FROM 0, __RUS_WEBMAIL_RCVD 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_NO_NAME 0, __TO_REAL_NAMES 0, __URI_NO_MAILTO 0, __URI_NO_WWW 0, __URI_NS , __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-Greylist: delayed 78 seconds by postgrey-1.34 at xx1.develooper.com; Tue, 25 Jul 2017 08:47:32 PDT
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.7.25.153916
To: "bug-DBIx-Class [...] rt.cpan.org" <bug-dbix-class [...] rt.cpan.org>, "KES [...] cpan.org" <kes [...] cpan.org>
Content-Transfer-Encoding: 7bit
From: KES <kes-kes [...] yandex.ru>
RT-Message-ID: <rt-4.0.18-32357-1500997663-26.122571-0-0 [...] rt.cpan.org>
Content-Length: 521
Download (untitled) / with headers
text/plain 521b
Show quoted text
>you want to use join+select yourself
I can not: because I should patch parent class which use `prefetch` If I patch I broke all other classes which inherit that one. Also at the point when I want to specify columns to select I do not know what parent/preceding code did. I just got ResultSet and want to specify the columns Yeah, I should rewrite each `prefetch` in project by `join`+`select` to be sure that at some point it did not return not requested columns. If DOC will be batched it will be great. Thank you.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.