Skip Menu |
 

This queue is for tickets about the Filter-Simple CPAN distribution.

Report information
The Basics
Id: 122044
Status: open
Priority: 0/
Queue: Filter-Simple

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.92_01
Fixed in: (no value)



Subject: With 0.92_01 installed, the testsuite of POWERMAN/Text-MiniTmpl-v2.0.0.tar.gz fails
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 506
Download (untitled) / with headers
text/plain 506b
As per subject. It's the t/filter.t test that fails now with: Missing right curly or square bracket at ./t/tmpl/filter.txt line 4, at end of line syntax error at ./t/tmpl/filter.txt line 4, at EOF at t/filter.t line 9. # Looks like your test exited with 2 before it could output anything. t/filter.t ................ Dubious, test returned 2 (wstat 512, 0x200) Failed 1/1 subtests I just reproduced this with perl 5.22.3 and 5.24.1. Both had a working Text::MiniTmpl with Simple::Filter 0.92. Thanks,
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-21578-1496944469-1756.122044-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
RT-Send-CC: corion [...] cpan.org
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 297
Download (untitled) / with headers
text/plain 297b
I just reproduced this also with a perl 5.26.0 which had Filter::Simple 0.93 and a working Text-MiniTmpl-v2.0.0. I downgraded this to CORION/Filter-Simple-0.92_01.tar.gz and then tested again POWERMAN/Text-MiniTmpl-v2.0.0.tar.gz and it failed the test with the same diagnostics as described above.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-21578-1496944469-1756.122044-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org> <rt-4.0.18-21578-1496944469-1756.122044-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-24566-1496945774-1035.122044-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 433
Download (untitled) / with headers
text/plain 433b
On Thu Jun 08 13:54:29 2017, ANDK wrote: Show quoted text
> I just reproduced this also with a perl 5.26.0 which had > Filter::Simple 0.93 and a working Text-MiniTmpl-v2.0.0. I downgraded > this to CORION/Filter-Simple-0.92_01.tar.gz and then tested again > POWERMAN/Text-MiniTmpl-v2.0.0.tar.gz and it failed the test with the > same diagnostics as described above.
Are you saying that 0.93 is working fine and that we just need a new CPAN release?
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-12159-1496946876-365.122044-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 203
Download (untitled) / with headers
text/plain 203b
I fear it's more complicated. In the last year failing reports have increased. There seems to be some other disturbing influence that can cause fails on raise.t, smoke.t, errline.t, unicode.t, caller.t.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-12428-1496950496-1952.122044-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 686
Download (untitled) / with headers
text/plain 686b
Thanks for reporting this bug. Filter::Simple 0.92_1 is my beta "release" that fixes the line numbers for here-documents, but it seems while implementing that I broke something that Text::MiniTmpl relies on. It uses one interesting trick to apply source filters to arbitrary code, namely do() instead of eval(). I guess that this is at least part of the puzzle because I can reproduce the failure on Windows with Filter::Simple 0.92_1, but not with 0.91. But that feature in isolation is not enough so I have to investigate further what causes that breakage. open my $fhe, '<', \$template or die "open: $!"; local @INC = ( sub {shift @INC; $fhe}, @INC ); my $code = do '[eval]'; -max
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-333-1496902645-1065.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-6864-1498074554-1813.122044-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 333
Download (untitled) / with headers
text/plain 333b
Hello Andreas, thank you very much for reporting this bug. The bug was an error in Filter::Simple, which did not process the last line of filter input if the last line did not end with a newline. I've added a new test that tests for that situation and released 0.93_01 to CPAN. Hopefully the smoke test works out with that version.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.