Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Moo-Google CPAN distribution.

Report information
The Basics
Id:
121515
Status:
open
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
DROLSKY [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Subject: The name is very confusing
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-606-1493829788-1840.0-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 373
Calling this "Moo::Google" when it is built on _Moose_ instead of _Moo_ is very confusing. That said, naming things after what they're built on is not a good practice. It's much better if the name describes what it does rather than what it is made of. So with that in mind maybe it's best to call it something like "WebService::Google::Base" or something along those lines.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-606-1493829788-1840.0-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-606-1493829788-1840.0-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-4946-1495619283-1154.121515-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 627
On Wed May 03 12:43:09 2017, DROLSKY wrote:
Show quoted text
> Calling this "Moo::Google" when it is built on _Moose_ instead of > _Moo_ is very confusing. That said, naming things after what they're > built on is not a good practice. It's much better if the name > describes what it does rather than what it is made of. So with that in > mind maybe it's best to call it something like > "WebService::Google::Base" or something along those lines.
I second this! Unrelated, I think in a similar ticket, you (Pavel) announced you were going to share the code on github. Have you? I'd love to take a poke at it. Thanks and best regards, Steffen
MIME-Version: 1.0
X-Spam-Status: No, score=-4.833 tagged_above=-99.9 required=10 tests=[AWL=0.500, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, HTML_MESSAGE=0.001, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.18-4946-1495619284-834.121515-5-0@rt.cpan.org>
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-121515@rt.cpan.org> <rt-4.0.18-606-1493829788-1840.121515-5-0@rt.cpan.org> <rt-4.0.18-4946-1495619284-834.121515-5-0@rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.157.31.54 with SMTP id x51mr8672271otd.108.1495755082005; Thu, 25 May 2017 16:31:22 -0700 (PDT)
Message-ID: <CAP=61Fdu1EFrKahYTR+ny6_MiCawkY_9=wbo0bHsZ1onAsYdnQ@mail.gmail.com>
Content-Type: multipart/alternative; boundary="001a113e38cc55854b0550619ebc"
X-Spam-Score: -4.833
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i=@gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 656F4240403 for <cpan-bug+Moo-Google@hipster.bestpractical.com>; Thu, 25 May 2017 19:31:29 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YmX6FWP9-1pA for <cpan-bug+Moo-Google@hipster.bestpractical.com>; Thu, 25 May 2017 19:31:27 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id A53022402D0 for <bug-Moo-Google@rt.cpan.org>; Thu, 25 May 2017 19:31:27 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 7FFD211FA73 for <bug-Moo-Google@rt.cpan.org>; Thu, 25 May 2017 16:31:26 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 814FA11FA7C for <bug-Moo-Google@rt.cpan.org>; Thu, 25 May 2017 16:31:24 -0700 (PDT)
Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id BB36411FA73 for <bug-Moo-Google@rt.cpan.org>; Thu, 25 May 2017 16:31:22 -0700 (PDT)
Received: by mail-oi0-f50.google.com with SMTP id b204so299160226oii.1 for <bug-Moo-Google@rt.cpan.org>; Thu, 25 May 2017 16:31:22 -0700 (PDT)
Received: by 10.157.24.10 with HTTP; Thu, 25 May 2017 16:31:21 -0700 (PDT)
Delivered-To: cpan-bug+Moo-Google@hipster.bestpractical.com
Subject: Re: [rt.cpan.org #121515] The name is very confusing
Return-Path: <pavel.p.serikov@gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Y3KuuqFeUJWjo9BnWYmtcWte657Y6TBA9660TL/OJVQ=; b=I8AC/pKmdk/BLDjHcM0PCWWFEiqdzN3Kh5WCnhXc9yl1cg++UdHauNuQoRBDocjKOd XvGTdS/QDQLBGC8axW4vRj1yr1U5PWQR4tzoLuWz7Ab9w9UFQtEAfRy4gAO3rAuIYuYk HbUsmswzM2bC/kiw4I5XHSzq4GkNh0DkIKfxy4Ya+AP1DEKL0TnIYKifmz85BVFzmxf4 Tct/bVLuuFzWqZC45Tpd8kaL44XPCSnH/PorixbyJ7mAuHKmoU3ncJ58l+jxebQmIKcw Uqvp4t8SKk7BLcON9fcHtPOPI3GqFfzo1l9ysfdTpx+FjjSko+1TyaAgIGv5dSLK5I+L 3ORw==
X-Original-To: cpan-bug+Moo-Google@hipster.bestpractical.com
X-RT-Mail-Extension: moo-google
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Y3KuuqFeUJWjo9BnWYmtcWte657Y6TBA9660TL/OJVQ=; b=qIcQEn/6zfVOZmaFlKtGeIXzp++wTJmcMB2kvORB6ob/yt/aCM62O/fO6qC+DxiHMn 6e8MkWU7BJMz21mM46hxqaPJJolq5ZQfiYFcatMhlmGdvaB55ucVSIxLVP7idmkHN3cn I/+E4Xv4Lnxxr+RiIg3ohm2WRGF113QrWy1mzlMkEsAS6MToEgFIRZd7EsJxSo8T37/L PVsRHXWLnmuNF3fVbi0rM2RNh3l1EUuqQPGQEIwo+UPobtxMofKryGcWaQiWZ9ppaAJf mFiEpr7raN/CLQCN6F/bHt16jv8BfyUDfOQC6T1fH+ltMtMnwMQeTaeChAmSnWTzjcuB 5gwA==
Date: Fri, 26 May 2017 02:31:21 +0300
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_FONT_INVISIBLE 0.1, BODYTEXTH_SIZE_10000_LESS 0, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_4000_4999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_PASS 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_ALT 0, __DATE_TZ_RU 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FORWARDED_MSG 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HELO_GMAIL 0, __HEX28_LC_BOUNDARY 0, __HIGHBITS 0, __HTML_AHREF_TAG 0, __HTML_TAG_DIV 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_HTML 0, __MIME_TEXT_H 0, __MIME_TEXT_H1 0, __MIME_TEXT_H2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_URI_HTML 0, __MULTIPLE_URI_TEXT 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __RDNS_GMAIL 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_WWW 0, __URI_NS , __URI_WITHOUT_PATH 0, __URI_WITH_PATH 0, __YOUTUBE_RCVD 0, __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.5.25.232416
To: bug-Moo-Google@rt.cpan.org
X-GM-Message-State: AODbwcA3bAf56ZQSG9kxkgk9DfCJWwat9YQXkQ1F90Gwj+Zvt4vszit5 ns7688mxXCUje4NXLhE8nEAffMQHxNnJpQA=
From: Pavel Serikov <pavel.p.serikov@gmail.com>
RT-Message-ID: <rt-4.0.18-22707-1495755090-69.121515-0-0@rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 1577
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 2694
Hi Steffen and Dave,

Sorry for delay in reply, I was busy with other projects.

Now source code is published on Github, you are welcome to take a look and make a pull request ;)

According module name complain - I'm sorry, but I hadn't invented better name.
Thought that almost all Perl developers use Metacpan and will easily check that my module depends on Moose too.
And also I had plans for future to migrate module to clean Moo or even to Mojo::Base to make module lightweight.

Anyway, if you know better name - you are welcome to suggest it, I will make a refactoring, no problem.

2017-05-24 12:48 GMT+03:00 Steffen Mueller via RT <bug-Moo-Google@rt.cpan.org>:
Show quoted text
       Queue: Moo-Google
 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121515 >

On Wed May 03 12:43:09 2017, DROLSKY wrote:
> Calling this "Moo::Google" when it is built on _Moose_ instead of
> _Moo_ is very confusing. That said, naming things after what they're
> built on is not a good practice. It's much better if the name
> describes what it does rather than what it is made of. So with that in
> mind maybe it's best to call it something like
> "WebService::Google::Base" or something along those lines.

I second this!

Unrelated, I think in a similar ticket, you (Pavel) announced you were going to share the code on github. Have you? I'd love to take a poke at it.

Thanks and best regards,
Steffen



--
Best regards,
Pavel Serikov

+7 (988) 585-19-00
pavel.p.serikov@gmail.com (E-mail/Gtalk/G+)
skype: rus_61
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-22707-1495755090-69.121515-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-121515@rt.cpan.org> <rt-4.0.18-606-1493829788-1840.121515-5-0@rt.cpan.org> <rt-4.0.18-4946-1495619284-834.121515-5-0@rt.cpan.org> <CAP=61Fdu1EFrKahYTR+ny6_MiCawkY_9=wbo0bHsZ1onAsYdnQ@mail.gmail.com> <rt-4.0.18-22707-1495755090-69.121515-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-3497-1495757119-1735.121515-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 937
On 2017-05-25 18:31:30, pavel.p.serikov@gmail.com wrote:
Show quoted text
> Hi Steffen and Dave, > > Sorry for delay in reply, I was busy with other projects. > > Now source code is published on Github, you are welcome to take a look > and > make a pull request ;) > https://github.com/pavelsr/moo-google > > According module name complain - I'm sorry, but I hadn't invented > better > name. > Thought that almost all Perl developers use Metacpan and will easily > check > that my module depends on Moose too. > And also I had plans for future to migrate module to clean Moo or even > to > Mojo::Base to make module lightweight. > > Anyway, if you know better name - you are welcome to suggest it, I > will > make a refactoring, no problem.
As I suggested originally, I think WebService::Google::Base would be okay. Alternatively maybe WebService::Google::Framework or WebService::Google::Toolkit or something else starting with WebService::Google::
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-22707-1495755090-69.121515-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-121515@rt.cpan.org> <rt-4.0.18-606-1493829788-1840.121515-5-0@rt.cpan.org> <rt-4.0.18-4946-1495619284-834.121515-5-0@rt.cpan.org> <CAP=61Fdu1EFrKahYTR+ny6_MiCawkY_9=wbo0bHsZ1onAsYdnQ@mail.gmail.com> <rt-4.0.18-22707-1495755090-69.121515-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-14705-1495757344-1145.121515-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 433
On 2017-05-25 18:31:30, pavel.p.serikov@gmail.com wrote:
Show quoted text
> Hi Steffen and Dave, > > Sorry for delay in reply, I was busy with other projects. > > Now source code is published on Github, you are welcome to take a look > and > make a pull request ;) > https://github.com/pavelsr/moo-google
If you want to use GitHub issues (which according to your META.json you do), you might find https://metacpan.org/release/RTx-ToGitHub handy.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.