Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 121084
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: chrisn [...] cpan.org
Requestors: JDDPAUSE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.81
Fixed in: 1.86_05



Subject: Search of openssl libraries on Windows
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.18-22434-1491995621-1773.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1491995621-22434-2"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 218
Download (untitled) / with headers
text/plain 218b
With openssl-1.1.0e, compiled in VC-WIN32 mode, link libraries are installed by default as libcrypto.lib and libssl.lib. In addition the code checking for Windows libraries has a bug (missing $). Patch in attachement.
Subject: SSLeay.pm.diff
MIME-Version: 1.0
Content-Type: application/octet-stream; name="SSLeay.pm.diff"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="SSLeay.pm.diff"
Content-Transfer-Encoding: base64
Content-Length: 1371
Download SSLeay.pm.diff
text/x-diff 1.3k
diff -Naur Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm --- Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-01-08 04:34:51.000000000 +0100 +++ Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-04-12 13:09:27.207003700 +0200 @@ -92,11 +92,11 @@ my @pairs = (); # Library names depend on the compiler @pairs = (['eay32','ssl32'],['crypto.dll','ssl.dll'],['crypto','ssl']) if $Config{cc} =~ /gcc/; - @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT']) if $Config{cc} =~ /cl/; + @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT'],['libcrypto','libssl']) if $Config{cc} =~ /cl/; for my $dir (@{$opts->{lib_paths}}) { for my $p (@pairs) { $found = 1 if ($Config{cc} =~ /gcc/ && -f "$dir/lib$p->[0].a" && -f "$dir/lib$p->[1].a"); - $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/p->[1].lib"); + $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/$p->[1].lib"); if ($found) { $opts->{lib_links} = [$p->[0], $p->[1], 'crypt32']; # Some systems need this system lib crypt32 too $opts->{lib_paths} = [$dir];
MIME-Version: 1.0 (1.0)
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
X-Source-Sender: 94.197.120.107.threembb.co.uk ([10.91.21.193]) [94.197.120.107]:37250
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.121
X-Source-Cap: bWlrZW07bWlrZW07Z2F0b3I0MTI5Lmhvc3RnYXRvci5jb20=
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 55DB5240374 for <cpan-bug+Net-SSLeay [...] hipster.bestpractical.com>; Wed, 12 Apr 2017 16:18:28 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GSO+Yb7VQ4mM for <cpan-bug+Net-SSLeay [...] hipster.bestpractical.com>; Wed, 12 Apr 2017 16:18:26 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 8617C24035B for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 12 Apr 2017 16:18:26 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 8E13467243 for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 12 Apr 2017 13:18:25 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id DF1DB67245 for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 12 Apr 2017 13:18:18 -0700 (PDT)
Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.46.107]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 77DE867243 for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 12 Apr 2017 13:18:07 -0700 (PDT)
Received: from cm3.websitewelcome.com (unknown [108.167.139.23]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 01744400D1C81 for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 12 Apr 2017 14:57:03 -0500 (CDT)
Received: from gator4129.hostgator.com ([192.185.4.141]) by cm3.websitewelcome.com with id 7Xx01v01C32ZDfC01Xx2Vq; Wed, 12 Apr 2017 14:57:02 -0500
Received: from 94.197.120.107.threembb.co.uk ([94.197.120.107]:37250 helo=[10.91.21.193]) by gator4129.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <mikem [...] airspayce.com>) id 1cyONw-000IgI-GF for bug-Net-SSLeay [...] rt.cpan.org; Wed, 12 Apr 2017 14:57:00 -0500
Delivered-To: cpan-bug+Net-SSLeay [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #121084] Search of openssl libraries on Windows
Date: Wed, 12 Apr 2017 20:56:56 +0100
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, SUPERLONG_LINE 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, SPF_NEUTRAL 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __FRAUD_ANTIABUSE 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MSGID_APPLEMAIL 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.4.12.200620
X-Bwhitelist: no
To: bug-Net-SSLeay [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
X-Source:
X-Source-Args:
In-Reply-To: <rt-4.0.18-22434-1491995621-747.121084-4-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-5.121 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, FROM_OUR_RT=-4, SPF_NEUTRAL=0.779] autolearn=ham
X-Mailer: iPhone Mail (14C92)
X-Source-Dir:
X-RT-Interface: API
References: <RT-Ticket-121084 [...] rt.cpan.org> <rt-4.0.18-22434-1491995621-747.121084-4-0 [...] rt.cpan.org>
Message-ID: <57B88619-5DE3-4DE3-93F8-F3A58A2C55EF [...] airspayce.com>
X-Source-Auth: mikem [...] airspayce.com
X-Antiabuse: This header was added to track abuse, please include it with any abuse report
X-Antiabuse: Primary Hostname - gator4129.hostgator.com
X-Antiabuse: Original Domain - rt.cpan.org
X-Antiabuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse: Sender Address Domain - airspayce.com
X-Source-Ip: 94.197.120.107
Return-Path: <mikem [...] airspayce.com>
X-RT-Mail-Extension: net-ssleay
X-Original-To: cpan-bug+Net-SSLeay [...] hipster.bestpractical.com
X-Exim-ID: 1cyONw-000IgI-GF
X-Greylist: delayed 1262 seconds by postgrey-1.34 at xx1.develooper.com; Wed, 12 Apr 2017 13:18:08 PDT
X-Email-Count: 3
From: Mike McCauley <mikem [...] airspayce.com>
RT-Message-ID: <rt-4.0.18-28872-1492028309-1359.121084-0-0 [...] rt.cpan.org>
Content-Length: 2074
Hello. I won't be able to look into this for at least 6 weeks. Perhaps you can send a patch in the meantime Cheers Sent from my iPhone Show quoted text
> On 12 Apr 2017, at 12:13 pm, Jean-Damien Durand via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Wed Apr 12 07:13:41 2017: Request 121084 was acted upon. > Transaction: Ticket created by JDDPAUSE > Queue: Net-SSLeay > Subject: Search of openssl libraries on Windows > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: JDDPAUSE@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121084 > > > > With openssl-1.1.0e, compiled in VC-WIN32 mode, link libraries are installed by default as libcrypto.lib and libssl.lib. In addition the code checking for Windows libraries has a bug (missing $). > > Patch in attachement. > diff -Naur Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm --- Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-01-08 04:34:51.000000000 +0100 +++ Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-04-12 13:09:27.207003700 +0200 @@ -92,11 +92,11 @@ my @pairs = (); # Library names depend on the compiler @pairs = (['eay32','ssl32'],['crypto.dll','ssl.dll'],['crypto','ssl']) if $Config{cc} =~ /gcc/; - @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT']) if $Config{cc} =~ /cl/; + @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT'],['libcrypto','libssl']) if $Config{cc} =~ /cl/; for my $dir (@{$opts->{lib_paths}}) { for my $p (@pairs) { $found = 1 if ($Config{cc} =~ /gcc/ && -f "$dir/lib$p->[0].a" && -f "$dir/lib$p->[1].a"); - $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/p->[1].lib"); + $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/$p->[1].lib"); if ($found) { $opts->{lib_links} = [$p->[0], $p->[1], 'crypt32']; # Some systems need this system lib crypt32 too $opts->{lib_paths} = [$dir];
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-22434-1491995621-1773.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-22434-1491995621-1773.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-27179-1533209316-1072.121084-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 555
Download (untitled) / with headers
text/plain 555b
On Wed Apr 12 12:13:41 2017, JDDPAUSE wrote: Show quoted text
> With openssl-1.1.0e, compiled in VC-WIN32 mode, link libraries are > installed by default as libcrypto.lib and libssl.lib. In addition the > code checking for Windows libraries has a bug (missing $). > > Patch in attachement.
Thanks, Jean-Damien - patch applied (across two separate commits), with minor modifications to credit you in Changes: https://github.com/radiator-software/p5-net-ssleay/pull/29 This will be included in the next developer release (1.86_05) and the next stable release after that.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.