Skip Menu |
 

This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id: 120557
Status: resolved
Priority: 0/
Queue: File-Path

People
Owner: jkeenan [...] cpan.org
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.12
Fixed in: (no value)



X-RT-Interface: Web
MIME-Version: 1.0
Message-ID: <rt-4.0.18-11933-1488989869-548.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1488989869-11933-2"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Length: 526
Download (untitled) / with headers
text/plain 526b
In t/Path_root.t -- a test file which runs only when the tester is root -- there is a SKIP block with the following condition: ##### SKIP: { skip('Skip until RT 85878 is fixed', 1); ##### https://rt.cpan.org/Ticket/Display.html?id=85878 was marked Resolved on Oct 11 2015. Hence, the stated rationale for one SKIP block in t/Path_root.t no longer pertains. However, when we remove the SKIP and run the file as root, we get test failures. See attachment. Not yet diagnosed further. Thank you very much. Jim Keenan
Subject: unskipped-test-failure.txt
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; name="unskipped-test-failure.txt"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="unskipped-test-failure.txt"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: ascii
Content-Length: 1295
root@localhost:/home/jkeenan/gitwork/File-Path # prove -vb t/Path_root.t t/Path_root.t .. 1..8 ok 1 - created a directory owned by nobody... ok 2 - ... owned by 65534 ok 3 - created a directory owned by group nobody... ok 4 - ... owned by group 65534 ok 5 - created a directory owned by nobody:nobody... ok 6 - ... owned by 65534 ok 7 - ... owned by group 65534 not ok 8 - created a directory not owned by nobodz:nobodz... # Failed test 'created a directory not owned by nobodz:nobodz...' # at t/Path_root.t line 72. # 'unable to map nobodz to a uid, ownership not changed: No such file or directory at t/Path_root.t line 69. # unable to map nobodz to a gid, group ownership not changed: No such file or directory at t/Path_root.t line 69. # ' # doesn't match '(?^:\Aunable to map nobodz to a uid, ownership not changed: .* at \S+ line \d+ # unable to map nobodz to a gid, group ownership not changed: .* at \S+ line \d+\b)' # Looks like you failed 1 test of 8. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests Test Summary Report ------------------- t/Path_root.t (Wstat: 256 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=8, 0 wallclock secs ( 0.01 usr 0.03 sys + 0.03 cusr 0.02 csys = 0.09 CPU) Result: FAIL
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-11933-1488989869-548.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-11933-1488989869-548.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-1151-1489007132-1939.120557-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 865
Download (untitled) / with headers
text/plain 865b
Please see: https://github.com/rpcme/File-Path/pull/40 I think we can get by with 2 'like' tests, each of which matches the warning against part of the overall expected result. When run as 'root', I now get: ##### root@localhost:/home/jkeenan/gitwork/File-Path # prove -vb t/Path_root.t t/Path_root.t .. 1..9 ok 1 - created a directory owned by nobody... ok 2 - ... owned by 65534 ok 3 - created a directory owned by group nobody... ok 4 - ... owned by group 65534 ok 5 - created a directory owned by nobody:nobody... ok 6 - ... owned by 65534 ok 7 - ... owned by group 65534 ok 8 - created a directory not owned by nobodz:nobodz... ok 9 - created a directory not owned by nobodz:nobodz... ok All tests successful. Files=1, Tests=9, 0 wallclock secs ( 0.00 usr 0.02 sys + 0.02 cusr 0.02 csys = 0.07 CPU) Result: PASS ##### Thank you very much. Jim Keenan
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-1151-1489007132-1939.120557-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-11933-1488989869-548.0-0-0 [...] rt.cpan.org> <rt-4.0.18-1151-1489007132-1939.120557-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-12059-1496277949-717.120557-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1139
Download (untitled) / with headers
text/plain 1.1k
On Wed Mar 08 16:05:32 2017, JKEENAN wrote: Show quoted text
> Please see: > > https://github.com/rpcme/File-Path/pull/40 > > I think we can get by with 2 'like' tests, each of which matches the > warning against part of the overall expected result. > > When run as 'root', I now get: > > ##### > root@localhost:/home/jkeenan/gitwork/File-Path # prove -vb > t/Path_root.t > t/Path_root.t .. > 1..9 > ok 1 - created a directory owned by nobody... > ok 2 - ... owned by 65534 > ok 3 - created a directory owned by group nobody... > ok 4 - ... owned by group 65534 > ok 5 - created a directory owned by nobody:nobody... > ok 6 - ... owned by 65534 > ok 7 - ... owned by group 65534 > ok 8 - created a directory not owned by nobodz:nobodz... > ok 9 - created a directory not owned by nobodz:nobodz... > ok > All tests successful. > Files=1, Tests=9, 0 wallclock secs ( 0.00 usr 0.02 sys + 0.02 cusr > 0.02 csys = 0.07 CPU) > Result: PASS > ##### > > Thank you very much. > Jim Keenan
These changes have been incorporated in t/Path_root.t. File-Path version 2.13 has been released to CPAN. Marking ticket Resolved. Thank you very much. Jim Keenan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.