Skip Menu |
 

This queue is for tickets about the Net-Async-WebSocket CPAN distribution.

Report information
The Basics
Id: 120504
Status: open
Priority: 0/
Queue: Net-Async-WebSocket

People
Owner: Nobody in particular
Requestors: chohag [...] jtan.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Spam-Status: No, score=-1.899 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, SPF_FAIL=0.001] autolearn=no
X-Jtan-Received: punctual.borderer.volia.net [93.74.58.89]
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
Content-ID: <23004.1488657512.1 [...] owl.gone.datum>
X-Spam-Flag: NO
content-type: text/plain; charset="utf-8"
Message-ID: <201703041958.v24JwcZV002322 [...] zeus.jtan.com>
X-Jtan-Recipient: <bug-Net-Async-WebSocket [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -1.899
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id EFCDD240307 for <cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com>; Sat, 4 Mar 2017 15:06:51 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 70QqmCnlnQmP for <cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com>; Sat, 4 Mar 2017 15:06:51 -0500 (EST)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 0AB1D2401EC for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Sat, 4 Mar 2017 15:06:51 -0500 (EST)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 30A7311D3C6 for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Sat, 4 Mar 2017 12:06:50 -0800 (PST)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id A752011DBD5 for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Sat, 4 Mar 2017 12:06:48 -0800 (PST)
Received: from mailout.jtan.com (mailout.jtan.com [216.104.47.134]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 562B011D3C6 for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Sat, 4 Mar 2017 12:06:47 -0800 (PST)
Received: from localhost (unknown [127.0.0.1]) by mailout.jtan.com (Postfix) with ESMTP id 25661BA4003 for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Sat, 4 Mar 2017 19:58:42 +0000 (UTC)
Received: from zeus.jtan.com (smtp.jtan.com [69.175.9.136]) by mailout.jtan.com (Postfix) with ESMTPS id D2B74BA4002 for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Sat, 4 Mar 2017 19:58:40 +0000 (UTC)
Received: from owl.gone.datum (punctual.borderer.volia.net [93.74.58.89]) by zeus.jtan.com with ESMTP id v24JwcZV002322 for <bug-Net-Async-WebSocket [...] rt.cpan.org>; Sat, 4 Mar 2017 19:58:40 GMT
Delivered-To: cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com
Subject: [Wishlist [but easy]] Handshake result in on_client callback
Return-Path: <chohag [...] jtan.com>
X-RT-Mail-Extension: net-async-websocket
X-Original-To: cpan-bug+Net-Async-WebSocket [...] hipster.bestpractical.com
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_600_699 0, BODY_SIZE_7000_LESS 0, NO_CTA_URI_FOUND 0, NO_REAL_NAME 0, NO_URI_FOUND 0, NO_URI_HTTPS 0, SPF_PASS 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __blackholes.mail-abuse.org_ERROR , __zen.spamhaus.org_ERROR '
Date: Sat, 04 Mar 2017 21:58:32 +0200
X-Spam-Level:
X-Greylist: delayed 483 seconds by postgrey-1.34 at xx1.develooper.com; Sat, 04 Mar 2017 12:06:48 PST
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.3.4.200016
X-Virus-Spam-Scanned: JTAN Spam and Virus Filtering
To: bug-Net-Async-WebSocket [...] rt.cpan.org
From: chohag [...] jtan.com
X-RT-Original-Encoding: ascii
X-RT-Interface: Email
Content-Length: 624
Download (untitled) / with headers
text/plain 624b
It would be nice to pass information from the http/websockets handshake which can deal with session handling, AAA, etc, to the on_client callback. This can be achieved easlily by including @_ in the invoke_event/on_client call in on_accept (line 97). The handshake result can still be a boolean and ignored, or as it's now passed to the on_client event it can be associated with whatever the user wishes. An alternative would be to store it somehow in the object created for the client session but I couldn't find a way to do that which fits well in my app, and this seemed a straightforward and sane workaround. Matthew
MIME-Version: 1.0
In-Reply-To: <201703041958.v24JwcZV002322 [...] zeus.jtan.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <201703041958.v24JwcZV002322 [...] zeus.jtan.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-27031-1512782885-1210.120504-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 476
Download (untitled) / with headers
text/plain 476b
On Sat Mar 04 15:06:52 2017, chohag@jtan.com wrote: Show quoted text
> It would be nice to pass information from the http/websockets > handshake which can deal with session handling, AAA, etc, to the > on_client callback. This can be achieved easlily by including @_ > in the invoke_event/on_client call in on_accept (line 97).
Server has had the 'on_handshake' event since 0.06 https://metacpan.org/pod/Net::Async::WebSocket::Server#on_handshake Will this be sufficient? -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.