Skip Menu |
 

This queue is for tickets about the IO-Async CPAN distribution.

Report information
The Basics
Id: 120503
Status: new
Priority: 0/
Queue: IO-Async

People
Owner: Nobody in particular
Requestors: chohag [...] jtan.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



MIME-Version: 1.0
X-Spam-Status: No, score=-1.899 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, SPF_FAIL=0.001] autolearn=no
X-Jtan-Received: punctual.borderer.volia.net [93.74.58.89]
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
Content-ID: <30943.1488656910.1 [...] owl.gone.datum>
X-Spam-Flag: NO
content-type: text/plain; charset="utf-8"
Message-ID: <201703041948.v24JmbpB001242 [...] zeus.jtan.com>
X-Jtan-Recipient: <bug-IO-Async [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -1.899
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 77CD1240307 for <cpan-bug+IO-Async [...] hipster.bestpractical.com>; Sat, 4 Mar 2017 14:57:01 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ScYzqOoE+QJc for <cpan-bug+IO-Async [...] hipster.bestpractical.com>; Sat, 4 Mar 2017 14:56:59 -0500 (EST)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id BBF352401EC for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 14:56:59 -0500 (EST)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 467CF11F9BC for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 11:56:58 -0800 (PST)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 7494811F9EB for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 11:56:54 -0800 (PST)
Received: from mailout.jtan.com (mailout.jtan.com [216.104.47.134]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 860CB11F9BC for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 11:56:46 -0800 (PST)
Received: from localhost (unknown [127.0.0.1]) by mailout.jtan.com (Postfix) with ESMTP id D667FBA4002 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 19:48:44 +0000 (UTC)
Received: from zeus.jtan.com (smtp.jtan.com [69.175.9.136]) by mailout.jtan.com (Postfix) with ESMTPS id 8A03D33A003 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 19:48:39 +0000 (UTC)
Received: from owl.gone.datum (punctual.borderer.volia.net [93.74.58.89]) by zeus.jtan.com with ESMTP id v24JmbpB001242 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 19:48:38 GMT
Delivered-To: cpan-bug+IO-Async [...] hipster.bestpractical.com
Subject: Incorrect use of maybe_invoke_event in IO::Async::Listener::on_read_ready()
Return-Path: <chohag [...] jtan.com>
X-RT-Mail-Extension: io-async
X-Original-To: cpan-bug+IO-Async [...] hipster.bestpractical.com
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_400_499 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, NO_CTA_URI_FOUND 0, NO_REAL_NAME 0, NO_URI_FOUND 0, NO_URI_HTTPS 0, SPF_PASS 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __HAS_FROM 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __blackholes.mail-abuse.org_ERROR , __zen.spamhaus.org_ERROR '
Date: Sat, 04 Mar 2017 21:48:30 +0200
X-Spam-Level:
X-Greylist: delayed 478 seconds by postgrey-1.34 at xx1.develooper.com; Sat, 04 Mar 2017 11:56:48 PST
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.3.4.195117
X-Virus-Spam-Scanned: JTAN Spam and Virus Filtering
To: bug-IO-Async [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
From: chohag [...] jtan.com
X-RT-Original-Encoding: ascii
X-RT-Interface: Email
Content-Length: 447
Download (untitled) / with headers
text/plain 447b
This looks like a natural language diff to me... The catch block at the end of on_read_ready() is expected to return a Future but maybe_invoke_event() wraps its arguments up an an arrayref. Replace the last double-line of the catch block with: my $maybe = $self->maybe_invoke_event( on_accept_error => $socket, $dollarbang ); $maybe ? @$maybe : $self->invoke_error( "accept() failed - $dollarbang", accept => $socket, $dollarbang ); Matthew
Comments: In-reply-to "Bugs in IO-Async via RT" <bug-IO-Async [...] rt.cpan.org> message dated "Sat, 04 Mar 2017 14:57:03 -0500."
MIME-Version: 1.0
X-Spam-Status: No, score=-3.899 tagged_above=-99.9 required=10 tests=[AWL=2.000, BAYES_00=-1.9, FROM_OUR_RT=-4, SPF_FAIL=0.001] autolearn=ham
In-Reply-To: <rt-4.0.18-18811-1488657423-1081.120503-3-0 [...] rt.cpan.org>
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Jtan-Received: punctual.borderer.volia.net [93.74.58.89]
X-Spam-Flag: NO
Content-ID: <23548.1488658235.1 [...] owl.gone.datum>
X-RT-Interface: API
References: <RT-Ticket-120503 [...] rt.cpan.org> <201703041948.v24JmbpB001242 [...] zeus.jtan.com> <rt-4.0.18-18811-1488657423-1081.120503-3-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Jtan-Recipient: <bug-IO-Async [...] rt.cpan.org>
Message-ID: <201703042010.v24KAfAB004213 [...] zeus.jtan.com>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -3.899
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id D48EF240307 for <cpan-bug+IO-Async [...] hipster.bestpractical.com>; Sat, 4 Mar 2017 15:10:56 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c+MN9Ztnb6ZR for <cpan-bug+IO-Async [...] hipster.bestpractical.com>; Sat, 4 Mar 2017 15:10:55 -0500 (EST)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 97D452401EC for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 15:10:55 -0500 (EST)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id E35A511D9C8 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 12:10:54 -0800 (PST)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 6074A11FA2D for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 12:10:50 -0800 (PST)
Received: from mailout.jtan.com (mailout.jtan.com [216.104.47.134]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 0F0D511DED4 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 12:10:45 -0800 (PST)
Received: from localhost (unknown [127.0.0.1]) by mailout.jtan.com (Postfix) with ESMTP id EA52333A004 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 20:10:44 +0000 (UTC)
Received: from zeus.jtan.com (smtp.jtan.com [69.175.9.136]) by mailout.jtan.com (Postfix) with ESMTPS id A406B33A003 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 20:10:43 +0000 (UTC)
Received: from owl.gone.datum (punctual.borderer.volia.net [93.74.58.89]) by zeus.jtan.com with ESMTP id v24KAfAB004213 for <bug-IO-Async [...] rt.cpan.org>; Sat, 4 Mar 2017 20:10:42 GMT
Delivered-To: cpan-bug+IO-Async [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #120503] AutoReply: Incorrect use of maybe_invoke_event in IO::Async::Listener::on_read_ready()
Return-Path: <chohag [...] jtan.com>
X-Original-To: cpan-bug+IO-Async [...] hipster.bestpractical.com
X-RT-Mail-Extension: io-async
Date: Sat, 04 Mar 2017 22:10:35 +0200
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODYTEXTP_SIZE_400_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_100_199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BOUNCE_AUTORESP 0, BOUNCE_GENERIC 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, NO_REAL_NAME 0, NO_URI_HTTPS 0, REFERENCES 0, SMALL_BODY 0, SPF_PASS 0, __ANY_URI 0, __BOUNCE_AUTORESP_SUBJ 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CT 0, __CT_TEXT_PLAIN 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __HAS_FROM 0, __HAS_MSGID 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_MAILTO 0, __URI_NO_WWW 0, __URI_NS , __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-Virus-Spam-Scanned: JTAN Spam and Virus Filtering
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.3.4.200317
To: bug-IO-Async [...] rt.cpan.org
From: chohag [...] jtan.com
RT-Message-ID: <rt-4.0.18-7011-1488658257-591.120503-0-0 [...] rt.cpan.org>
Content-Length: 160
Download (untitled) / with headers
text/plain 160b
Further testing suggests that this function is called (all the time?) in scalar context so although @$maybe looks "right", $maybe->[0] actually works. Matthew


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.