Skip Menu |
 

This queue is for tickets about the SQL-Statement CPAN distribution.

Report information
The Basics
Id: 120163
Status: open
Priority: 0/
Queue: SQL-Statement

People
Owner: Nobody in particular
Requestors: jleu [...] mindspring.com
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.410
Fixed in: (no value)



Subject: Support OR in JOIN clause - patch
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Mobile
Message-ID: <rt-4.0.18-11046-1486677992-1790.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1486677992-11046-2"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 242
Download (untitled) / with headers
text/plain 242b
I'm including a patch that has two changes: - Add support for LIMIT d OFFSET d - Add support for OR in JOIN clause - this required addition of < > to term split - required stripping of ()'s from ids Please email me with any questions
Subject: diff
MIME-Version: 1.0
Content-Type: application/octet-stream; name="diff"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="diff"
Content-Transfer-Encoding: base64
Content-Length: 1971
Download diff
application/octet-stream 1.9k

Message body not shown because it is not plain text.

MIME-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Spam-Status: No, score=-5.334 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.18-11046-1486677993-311.120163-4-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.3124)
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-120163 [...] rt.cpan.org> <rt-4.0.18-11046-1486677993-311.120163-4-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.223.147.225 with SMTP id 88mr4835687wrp.44.1486678872166; Thu, 09 Feb 2017 14:21:12 -0800 (PST)
Content-Type: multipart/signed; boundary="Apple-Mail=_3B68B783-5C32-4F36-8386-514A9C0BD1F0"; micalg="pgp-sha512"; protocol="application/pgp-signature"
Message-ID: <1643495A-79EF-40F1-A7C3-EF71E7FCA82F [...] gmail.com>
X-Spam-Score: -5.334
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 58AAE2403D3 for <cpan-bug+SQL-Statement [...] hipster.bestpractical.com>; Thu, 9 Feb 2017 17:21:36 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EZxbUi23dOmR for <cpan-bug+SQL-Statement [...] hipster.bestpractical.com>; Thu, 9 Feb 2017 17:21:33 -0500 (EST)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 860642403D0 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 17:21:32 -0500 (EST)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 17C1411D87C for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:21:31 -0800 (PST)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id 074BC11D8A3 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:21:29 -0800 (PST)
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 5321311D87C for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:21:13 -0800 (PST)
Received: by mail-wr0-f175.google.com with SMTP id k90so93967769wrc.3 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 09 Feb 2017 14:21:13 -0800 (PST)
Received: from ernie.muppets.liwing.de (b2b-78-94-80-58.unitymedia.biz. [78.94.80.58]) by smtp.gmail.com with ESMTPSA id w204sm73789wmd.17.2017.02.09.14.21.11 for <bug-SQL-Statement [...] rt.cpan.org> (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Feb 2017 14:21:11 -0800 (PST)
Delivered-To: cpan-bug+SQL-Statement [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #120163] Support OR in JOIN clause - patch
Return-Path: <rehsack [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:references:to:in-reply-to; bh=VdSX7sbf1Jl9EaVoqhS0+YjrOYetmyXmT6oRA6ulKUE=; b=GvN4z2z/usFmrhEOQ4MSgIuVOEkbM7nI3emtEiErDwMKqz/+l7GpRRThWWmt2UPBrJ 9SadhO3Afer1IGxmUXqsp0idooKim7nN6B12afzivhwD+tqxQR/N5KS0ahJgp3pFrEH0 fRzJIQmZH5WCbei7sVPFo+yHDjuYlNH3C1y3WcRg1mQJw7mTldBk86YLkr922JXiRsmW v4NHHeU9M/2UJXxdhIAtVikERzbTbN9dNXx7MK7SBqKIkGT7ppJPAHHmEUIMVx02VGR4 FMKwaq7LQvGSl2pml7n9J3imAbqWhPEuHIGopOTnZb4QwoUxWgqXpav1pd8NVUjAQD12 E8Rw==
X-Original-To: cpan-bug+SQL-Statement [...] hipster.bestpractical.com
X-RT-Mail-Extension: sql-statement
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :references:to:in-reply-to; bh=VdSX7sbf1Jl9EaVoqhS0+YjrOYetmyXmT6oRA6ulKUE=; b=Kxv5Bsb0M4w8Ltuda5QW0s8ct7w1/WWXOhYLcqPHxVqWqyGZ9C4+SU+XLOCI6pTKbf laQWi84D5+t9DnYLgdEeoLbD8eePPyUyytCcZUCpG7fDlUSpX2fL0gy3Gisg13zjdzLB wmILjfC7UvhC9pWsOHCjtSsF4WJLQvUVKftdcjRNLNyKCVmImRS65gJ/honii5AWUbem 95JMLes5J+CQkdE/r+HFtcR1Rsl1IuLF1jJbE04GQGfnUz72Jen6zDTJ9/ssgngUyg9K 0TLPw8JxIFXU+7B3r+0h+3DinhDLkXB8I3740siDfOeclqbuNYM/u9osJpCwuPfOB9/9 Eetw==
Date: Thu, 9 Feb 2017 23:21:10 +0100
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_PASS 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __C230066_P3_4 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FORWARDED_MSG 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HELO_GMAIL 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MSGID_APPLEMAIL 0, __RDNS_GMAIL 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT_APPLEMAIL 0, __X_MAILER_APPLEMAIL 0, __YOUTUBE_RCVD 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.2.9.221517
To: bug-SQL-Statement [...] rt.cpan.org
X-GM-Message-State: AMke39mhHNY4oqkqTUIrZ5FI/1eH+H0RhQJx9+fJIPwrFLs+8deXodidtNRPjyLEV7drAQ==
From: Jens Rehsack <rehsack [...] gmail.com>
RT-Message-ID: <rt-4.0.18-6651-1486678898-1893.120163-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1099
Show quoted text
> Am 09.02.2017 um 23:06 schrieb jleu@mindspring.com via RT <bug-SQL-Statement@rt.cpan.org>: > > Thu Feb 09 17:06:33 2017: Request 120163 was acted upon. > Transaction: Ticket created by jleu@mindspring.com > Queue: SQL-Statement > Subject: Support OR in JOIN clause - patch > Broken in: 1.410 > Severity: Wishlist > Owner: Nobody > Requestors: jleu@mindspring.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > > > I'm including a patch that has two changes: > - Add support for LIMIT d OFFSET d > - Add support for OR in JOIN clause > - this required addition of < > to term split > - required stripping of ()'s from ids > > Please email me with any questions > <diff>
I didn't review the patch at all, but I miss definitively some tests proving that it works and ensure future patches don't add new regressions. Would you please so kind and add some? I expect that no of existing tests fail with that patch. I will surely prove, but for now - expecting everything is fine :) Cheers -- Jens Rehsack - rehsack@gmail.com
Content-Description: Message signed with OpenPGP using GPGMail
Content-Type: application/pgp-signature; name="signature.asc"
Content-Disposition: attachment; filename="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Length: 842
Download signature.asc
application/pgp-signature 842b

Message body not shown because it is not plain text.

MIME-Version: 1.0
X-Spam-Status: No, score=-5.999 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_OUR_RT=-4, HTML_MESSAGE=0.001] autolearn=ham
In-Reply-To: <rt-4.0.18-6651-1486678898-1637.120163-6-0 [...] rt.cpan.org>
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-120163 [...] rt.cpan.org> <rt-4.0.18-11046-1486677993-311.120163-4-0 [...] rt.cpan.org> <1643495A-79EF-40F1-A7C3-EF71E7FCA82F [...] gmail.com> <rt-4.0.18-6651-1486678898-1637.120163-6-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.157.35.26 with SMTP id j26mr3005274otb.135.1486679103235; Thu, 09 Feb 2017 14:25:03 -0800 (PST)
Message-ID: <CAA2rGQGm-3j_=WQvJZD95Khrdy4sCBvxNXgHhDaFB385XCtaaA [...] mail.gmail.com>
Content-Type: multipart/alternative; boundary="001a113dc146d7f23305482073fb"
X-Spam-Score: -5.999
Authentication-Results: hipster.bestpractical.com (amavisd-new); domainkeys=pass header.from=jleu [...] mindspring.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 2663A2403D0 for <cpan-bug+SQL-Statement [...] hipster.bestpractical.com>; Thu, 9 Feb 2017 17:25:43 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w7optErHAWF0 for <cpan-bug+SQL-Statement [...] hipster.bestpractical.com>; Thu, 9 Feb 2017 17:25:39 -0500 (EST)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id 2C7012402C2 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 17:25:38 -0500 (EST)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 30FA511D87C for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:25:37 -0800 (PST)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id B1F6011DEC3 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:25:32 -0800 (PST)
Received: from elasmtp-galgo.atl.sa.earthlink.net (elasmtp-galgo.atl.sa.earthlink.net [209.86.89.61]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 23CC111DE78 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:25:26 -0800 (PST)
Received: from [74.125.82.180] (helo=mail-ot0-f180.google.com) by elasmtp-galgo.atl.sa.earthlink.net with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.67) (envelope-from <jleu [...] mindspring.com>) id 1cbx9D-00086k-KR for bug-SQL-Statement [...] rt.cpan.org; Thu, 09 Feb 2017 17:25:03 -0500
Received: by mail-ot0-f180.google.com with SMTP id 65so14634706otq.2 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 09 Feb 2017 14:25:03 -0800 (PST)
Received: by 10.202.49.15 with HTTP; Thu, 9 Feb 2017 14:25:02 -0800 (PST)
Received: by 10.202.49.15 with HTTP; Thu, 9 Feb 2017 14:25:02 -0800 (PST)
Delivered-To: cpan-bug+SQL-Statement [...] hipster.bestpractical.com
X-Elnk-Trace: 1696e6edb7425549f402879cecb40bd594638abec8d5c2414970bfdc29ea8fb2b1b13c73c5357a2a350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c
Subject: Re: [rt.cpan.org #120163] Support OR in JOIN clause - patch
Domainkey-Signature: a=rsa-sha1; q=dns; c=nofws; s=dk20050327; d=mindspring.com; b=ZYuoIKzfjC/ShzoI5ActTez5vU8E6MOE//H0A0nUZzHg4PeZ3XBfRKCNI36AkaD6; h=X-Gm-Message-State:X-Received:MIME-Version:In-Reply-To:References:From:Date:X-Gmail-Original-Message-ID:Message-ID:Subject:To:Content-Type:X-ELNK-Trace:X-Originating-IP;
Return-Path: <jleu [...] mindspring.com>
X-Original-To: cpan-bug+SQL-Statement [...] hipster.bestpractical.com
X-RT-Mail-Extension: sql-statement
Date: Thu, 9 Feb 2017 16:25:02 -0600
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' BODYTEXTH_SIZE_10000_LESS 0, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_4000_4999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CTYPE_MULTIPART_NO_QUOTE 0, DATE_TZ_NA 0, DOMAINKEY_SIG 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_NONE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, WEBMAIL_XOIP 0, WEBMAIL_X_IP_HDR 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __C230066_P3_4 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_ALT 0, __FORWARDED_MSG 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HIGHBITS 0, __HTML_AHREF_TAG 0, __HTML_TAG_DIV 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_HTML 0, __MIME_TEXT_H 0, __MIME_TEXT_H1 0, __MIME_TEXT_H2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_URI_HTML 0, __MULTIPLE_URI_TEXT 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __RATWARE_SIGNATURE_3_N1 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-Gmail-Original-Message-ID: <CAA2rGQGm-3j_=WQvJZD95Khrdy4sCBvxNXgHhDaFB385XCtaaA [...] mail.gmail.com>
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.2.9.221817
X-Originating-Ip: 74.125.82.180
To: bug-SQL-Statement [...] rt.cpan.org
X-GM-Message-State: AMke39nCgx7ctKh5KElQ083rV+KtapGttnfLpl/ixOYUtjWCuuQrKia1C731fYJWOipG8wMx4HbGI2BRpBQXmw==
From: "James R. Leu" <jleu [...] mindspring.com>
RT-Message-ID: <rt-4.0.18-6664-1486679144-389.120163-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
Content-Length: 1404
Download (untitled) / with headers
text/plain 1.3k
Sorry, I was thinking small :-) I will create some test cases and submit an updated patch On Feb 9, 2017 16:21, "Jens Rehsack via RT" <bug-SQL-Statement@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > >
> > Am 09.02.2017 um 23:06 schrieb jleu@mindspring.com via RT <
> bug-SQL-Statement@rt.cpan.org>:
> > > > Thu Feb 09 17:06:33 2017: Request 120163 was acted upon. > > Transaction: Ticket created by jleu@mindspring.com > > Queue: SQL-Statement > > Subject: Support OR in JOIN clause - patch > > Broken in: 1.410 > > Severity: Wishlist > > Owner: Nobody > > Requestors: jleu@mindspring.com > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > > > > > > I'm including a patch that has two changes: > > - Add support for LIMIT d OFFSET d > > - Add support for OR in JOIN clause > > - this required addition of < > to term split > > - required stripping of ()'s from ids > > > > Please email me with any questions > > <diff>
> > I didn't review the patch at all, but I miss definitively some tests > proving that it works and ensure future patches don't add new regressions. > Would you please so kind and add some? > > I expect that no of existing tests fail with that patch. I will surely > prove, but for now - expecting everything is fine :) > > Cheers > -- > Jens Rehsack - rehsack@gmail.com > > >
content-type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 2342
MIME-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Spam-Status: No, score=-5.334 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, SPF_SOFTFAIL=0.665] autolearn=ham
In-Reply-To: <rt-4.0.18-6664-1486679145-3.120163-5-0 [...] rt.cpan.org>
X-Mailer: Apple Mail (2.3124)
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-120163 [...] rt.cpan.org> <rt-4.0.18-11046-1486677993-311.120163-4-0 [...] rt.cpan.org> <1643495A-79EF-40F1-A7C3-EF71E7FCA82F [...] gmail.com> <rt-4.0.18-6651-1486678898-1637.120163-6-0 [...] rt.cpan.org> <CAA2rGQGm-3j_=WQvJZD95Khrdy4sCBvxNXgHhDaFB385XCtaaA [...] mail.gmail.com> <rt-4.0.18-6664-1486679145-3.120163-5-0 [...] rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Received: by 10.223.176.210 with SMTP id j18mr5369971wra.8.1486679336855; Thu, 09 Feb 2017 14:28:56 -0800 (PST)
Content-Type: multipart/signed; boundary="Apple-Mail=_299992FB-285A-4891-A3B8-A7E5EB119EC8"; micalg="pgp-sha512"; protocol="application/pgp-signature"
Message-ID: <200E098F-B3BF-4CE2-BA23-E860FCB58008 [...] gmail.com>
X-Spam-Score: -5.334
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] gmail.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 5EFAC2403D0 for <cpan-bug+SQL-Statement [...] hipster.bestpractical.com>; Thu, 9 Feb 2017 17:29:09 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qvDQxT1OJL8Y for <cpan-bug+SQL-Statement [...] hipster.bestpractical.com>; Thu, 9 Feb 2017 17:29:07 -0500 (EST)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id D68AE2402C2 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 17:29:06 -0500 (EST)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 10DC411E007 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:29:06 -0800 (PST)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id CEA3E11E00F for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:29:03 -0800 (PST)
Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id F41C711E007 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 9 Feb 2017 14:28:58 -0800 (PST)
Received: by mail-wr0-f172.google.com with SMTP id 89so94338130wrr.2 for <bug-SQL-Statement [...] rt.cpan.org>; Thu, 09 Feb 2017 14:28:58 -0800 (PST)
Received: from ernie.muppets.liwing.de (b2b-78-94-80-58.unitymedia.biz. [78.94.80.58]) by smtp.gmail.com with ESMTPSA id c202sm621338wmd.10.2017.02.09.14.28.55 for <bug-SQL-Statement [...] rt.cpan.org> (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Feb 2017 14:28:56 -0800 (PST)
Delivered-To: cpan-bug+SQL-Statement [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #120163] Support OR in JOIN clause - patch
Return-Path: <rehsack [...] gmail.com>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:references:to:in-reply-to; bh=qLLKj55IT6cqTWXw1SN2pZ2204P3agTvYr3ikgGLQtA=; b=Bw6TN6sigoeGwgR4qhrfFu3b6JhFe0rPKqHWOltqaFb5zEQ6Gj7HRpzHIMF/5SKxhL 3dDmrBSUQfLalxc+eRJJ0m3Z54N7Boz6qKuIcmcPQbycDWqLHLrSxpOGmmHe83YSUsYE aR0hYp4F4RCUNpP1MfIXIeFJYejiNrt3NDdjEIQRWdRGbuYoU6ggCy1Jc3rjKQAdzZY3 xme36BJrXJxeYVO67chJE2D0tsC2dK3FFsSSaogbcLlO4qtp/pqNZmR9Gg0l+irHuwIu VVGTR6K9yGZcHPxjWPg2YcTmg14AJvlX4D/ylkycTlhilK1N9rOAzfgY6A7+V2GsvjoG Sj/A==
X-Original-To: cpan-bug+SQL-Statement [...] hipster.bestpractical.com
X-RT-Mail-Extension: sql-statement
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :references:to:in-reply-to; bh=qLLKj55IT6cqTWXw1SN2pZ2204P3agTvYr3ikgGLQtA=; b=E42breJNYichjeYgIjqkKAe/8XaLpdJIT5a4BF8ngD5+2Yz0Ka9wpvwS3NHZlhQGkL CkMGq1gJ5yD9QSFavcz7OyqDlYsNfGdhKpvBWI0+fMJfi+dNEfcHQe1OzA1YsvHDj5tl WNCkYRMl/AFsxDv6S5rZg+0QbcuysklE5MA0QjWGcHSNluzceOdxPVwECkCiSaSX444k IjwALc+ZWpPD3O07QHuhhodj1n7hoGrSkZMUS2ZKbvXGcvXI1f/pQjV1F+1xMlTsObv3 GLbJWcsJ7sAW2GYc4fU3GkXVIDwfP1F/QLS2JyLeaNB96FP4kweB9k8m74vhnsSbuvN8 x6aQ==
Date: Thu, 9 Feb 2017 23:28:55 +0100
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_PASS 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __C230066_P3_4 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FORWARDED_MSG 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HELO_GMAIL 0, __HTTPS_URI 0, __IN_REP_TO 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MSGID_APPLEMAIL 0, __MULTIPLE_URI_TEXT 0, __RDNS_GMAIL 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT_APPLEMAIL 0, __X_MAILER_APPLEMAIL 0, __YOUTUBE_RCVD 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.2.9.221817
To: bug-SQL-Statement [...] rt.cpan.org
X-GM-Message-State: AMke39mOvtMj6ydB5wfsIvv49gHUriFrdYjLJwgmb5QP92kHdt2d4Qg9cRaNdjTJyn6+Ww==
From: Jens Rehsack <rehsack [...] gmail.com>
RT-Message-ID: <rt-4.0.18-6664-1486679350-767.120163-0-0 [...] rt.cpan.org>
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-RT-Original-Encoding: utf-8
Content-Length: 1964
Download (untitled) / with headers
text/plain 1.9k
Show quoted text
> Am 09.02.2017 um 23:25 schrieb jleu@mindspring.com via RT <bug-SQL-Statement@rt.cpan.org>: > > Queue: SQL-Statement > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > > Sorry, I was thinking small :-)
Do lot's of tiny patches create an impressive result. No worries :) Please also try some combinations (ON foo AND bar OR baz) and stacks (foo AND bar OR fom AND baz) Show quoted text
> I will create some test cases and submit an updated patch
You can also submit pull-requests on Github which will lead to Travis will run all tests against your patches. Cheers, Jens Show quoted text
> On Feb 9, 2017 16:21, "Jens Rehsack via RT" <bug-SQL-Statement@rt.cpan.org> > wrote: >
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > >> >>
>>> Am 09.02.2017 um 23:06 schrieb jleu@mindspring.com via RT <
>> bug-SQL-Statement@rt.cpan.org>:
>>> >>> Thu Feb 09 17:06:33 2017: Request 120163 was acted upon. >>> Transaction: Ticket created by jleu@mindspring.com >>> Queue: SQL-Statement >>> Subject: Support OR in JOIN clause - patch >>> Broken in: 1.410 >>> Severity: Wishlist >>> Owner: Nobody >>> Requestors: jleu@mindspring.com >>> Status: new >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > >>> >>> >>> I'm including a patch that has two changes: >>> - Add support for LIMIT d OFFSET d >>> - Add support for OR in JOIN clause >>> - this required addition of < > to term split >>> - required stripping of ()'s from ids >>> >>> Please email me with any questions >>> <diff>
>> >> I didn't review the patch at all, but I miss definitively some tests >> proving that it works and ensure future patches don't add new regressions. >> Would you please so kind and add some? >> >> I expect that no of existing tests fail with that patch. I will surely >> prove, but for now - expecting everything is fine :) >> >> Cheers >> -- >> Jens Rehsack - rehsack@gmail.com >> >> >>
-- Jens Rehsack - rehsack@gmail.com
Content-Description: Message signed with OpenPGP using GPGMail
Content-Type: application/pgp-signature; name="signature.asc"
Content-Disposition: attachment; filename="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Length: 842
Download signature.asc
application/pgp-signature 842b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.