Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 119914
Status: new
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: skaji [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: c_source is compiled even if --pureperl-only is set
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-9570-1484841384-185.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1013
Download (untitled) / with headers
text/plain 1013b
Currently, even if --pureperl-only is set, c_source is compiled. An example is here: https://github.com/skaji/perl-mb-issue ``` $ perl Build.PL --pureperl-only Created MYMETA.yml and MYMETA.json Creating new 'Build' script for 'Foo' version '0.001' $ ./Build Building Foo cc -Isrc -I/Users/skaji/env/plenv/versions/01.18-v5.25.8-272/lib/perl5/5.25.9/darwin-2level/CORE -c -fno-common -DPERL_DARWIN -mmacosx-version-min=10.12 -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -DPERL_USE_SAFE_PUTENV -O3 -g -o src/add.o src/add.c ``` I think the following patch solves this issue. ``` diff --git lib/Module/Build/Base.pm lib/Module/Build/Base.pm index 26735da..baa37b0 100644 --- lib/Module/Build/Base.pm +++ lib/Module/Build/Base.pm @@ -2859,6 +2859,7 @@ sub process_support_files { my $self = shift; my $p = $self->{properties}; return unless $p->{c_source}; + return if $self->pureperl_only && $self->allow_pureperl; my $files; if (ref($p->{c_source}) eq "ARRAY") { ```
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-9570-1484841384-185.0-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-9570-1484841384-185.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-7909-1484841872-654.119914-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 23
s/even if/even though/g


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.