Skip Menu |
 

This queue is for tickets about the Perl-Critic-Pulp CPAN distribution.

Report information
The Basics
Id: 118722
Status: open
Priority: 0/
Queue: Perl-Critic-Pulp

People
Owner: Nobody in particular
Requestors: PETDANCE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 90
Fixed in: (no value)



Subject: RequireFinalCut fires if =cut isn't preceded by a blank line
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
Message-ID: <rt-4.0.18-15976-1478886484-528.0-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 487
Download (untitled) / with headers
text/plain 487b
This code executes correctly: my $x = 199; =pod blah blah =cut print "$x\n"; There should be a blank line before the =cut, and pod2text complains properly: $ pod2text pod.pl pod.pl around line 2: =pod directives shouldn't be over one line long! Ignoring all 2 lines of content However, RequireFinalCut complains that there isn't a final =cut. I understand that there should be a blank line before the =cut, but the message should say that instead of saying that there isn't a =cut.
X-Ymail-Osg: l35uGYcVM1mJF.tPQk.ruFJFdQR6yjDS6UW2XeXN4Vi0pl. TxGRgbHdBQL84i36y36FHOe94eS0RaZ5U9ZS1Op5y3tv7E_rz8fnbEkr4lDj 3fTuh.n_G9H4.YsTEVsniwWrEC.3gnDHGRqnzFGUNjNa9mrGS2unkd3T3z32 RePSX5EU3qR1QO6ZjOC9UvBOhSjbgFSMFyQn_xH560N6XhOEjYcAVN.YGHSW Ow.FbsLPmLs3cgEUzAR0WLVYnTx.LSLwhq56LIkWV_uvVywzEdNigw33QfmP NNbSPyRWfwVkfhxxiJSBlO3YXl5Mpa7P9yLPh0qLftrPcEWFSU.TMVBzB8UC Zd1uYZIfFHqcfb9m__Z9RQezQv5CcibLGWRhfQ9SKyTEVxsgC.ZXBsL5XLyA anSymfBzLG7.hbPvM6h5g_IEaohl13Q7iCVY7gPhofRNCeoMBc1pdWW47XmT JBKUlf0_RqeEeUS1J9Vr.TjcyyVFY8ABsYb2BL1TUJTMs8so67y2evSh_WE6 offuFgqrlrFgl7ppKJ6rGjHqd0aopVmGKDQfo1gxHSv394i4Wpc6F5RhR70o -
MIME-Version: 1.0
X-Spam-Status: No, score=-6.349 tagged_above=-99.9 required=10 tests=[AWL=-0.350, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
X-Spam-Flag: NO
X-Yahoo-Newman-ID: 464230.81501.bm [...] smtp210.mail.gq1.yahoo.com
X-RT-Interface: API
References: <RT-Ticket-118722 [...] rt.cpan.org> <rt-4.0.18-15976-1478886485-883.118722-4-0 [...] rt.cpan.org>
X-Yahoo-SMTP: U8NKAo6swBAxDIMUovTitGGHebxdYQBZ5A--
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Yahoo-Newman-Property: ymail-3
Message-ID: <87y40pf8eg.fsf [...] blah.blah>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.349
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yahoo.com.au
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 8DBE62403A5 for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Sat, 12 Nov 2016 02:46:52 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iL6PJoLR+T7U for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Sat, 12 Nov 2016 02:46:50 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id BEB6024016D for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Sat, 12 Nov 2016 02:46:49 -0500 (EST)
Received: (qmail 3215 invoked by alias); 12 Nov 2016 07:46:48 -0000
Received: from nm8-vm1.bullet.mail.gq1.yahoo.com (HELO nm8-vm1.bullet.mail.gq1.yahoo.com) (98.136.218.224) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 11 Nov 2016 23:46:47 -0800
Received: from [98.137.12.190] by nm8.bullet.mail.gq1.yahoo.com with NNFMP; 12 Nov 2016 07:46:37 -0000
Received: from [208.71.42.199] by tm11.bullet.mail.gq1.yahoo.com with NNFMP; 12 Nov 2016 07:46:37 -0000
Received: from [127.0.0.1] by smtp210.mail.gq1.yahoo.com with NNFMP; 12 Nov 2016 07:46:37 -0000
Delivered-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #118722] RequireFinalCut fires if =cut isn't preceded by a blank line
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Return-Path: <user42_kevin [...] yahoo.com.au>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1478936797; bh=pQFGlp2ThCOHkdSz7lJxVMYzEIsSQUgLQ5mmLPsZuQY=; h=From:To:Subject:References:Date:From:Subject; b=fBj1uf0Ga54Kn7Fco+gBax24Md4RHBKxudHIwV5/WJVeN9OQVRZI1ilnplHcQPbAUB5D5fG90JbU/+rbIcIfsT9ZTgYSsgQQf6Nxp0oKNZDts+3JIoVlkXNahHz/etoCl+Wii5NwL50mwuXoEBlEulko+bypZTe/lhjK+T6RRdAw3lxiBp0lm/fvo2mqNqhFZFgHkg1xHMfWifOAeyticL5csxv16b9WAis+18YWM6zoFl/BNy9qYLULSsndp9S0/Wb/uPhek+ofqTKMZVz4IKqNFgSq3OX6/D6rb+pXWV4S6oSVkNrSba36j2jcoF/s7huDINHeph9r7JaXL6+KNw==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic-pulp
Date: Sat, 12 Nov 2016 18:45:59 +1100
X-Spam-Level:
To: "Andy Lester via RT" <bug-Perl-Critic-Pulp [...] rt.cpan.org>
From: Kevin Ryde <user42_kevin [...] yahoo.com.au>
RT-Message-ID: <rt-4.0.18-20269-1478936813-1880.118722-0-0 [...] rt.cpan.org>
Content-Length: 845
Download (untitled) / with headers
text/plain 845b
"Andy Lester via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text
> > I understand that there should be a blank line before the =cut,
Yes. Show quoted text
> but the message should say that instead of saying that there > isn't a =cut.
Hmm. I use Pod::Parser and it doesn't present such a =cut as a "cut without blank", rather gives text "blah blah =cut" arguments to the =pod command (which doesn't take arguments, per the warning message you saw). I'm not sure if it's a good idea for me to try to notice a cut which has not parsed. What do you think? I had intended letting podchecker cover parse problems (even possibly in a perlcritic policy if wanted within that framework). But maybe I should output parse error messages anyway so as not to silently let badness go by, even if they might be repeated a few times when successive policies parse. Hmm.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-20269-1478936813-1880.118722-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-118722 [...] rt.cpan.org> <rt-4.0.18-15976-1478886485-883.118722-4-0 [...] rt.cpan.org> <87y40pf8eg.fsf [...] blah.blah> <rt-4.0.18-20269-1478936813-1880.118722-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-31777-1479013139-898.118722-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 313
Download (untitled) / with headers
text/plain 313b
Not sure what to do. Not sure it's worth putting out two different error messages. Maybe modify the existing one to cover the cause of "=cut without a preceding newline"? All I know is that when I first got the error I was a little confused because clearly there's that =cut and so what's it complaining about?
X-Ymail-Osg: mTYy6R0VM1mzu8HNW_3oL5QNQ0pIhTzojgkRKFj8dRlPgS3 .IwE2W70YKNZS4hOV78Jqa16Whp3pojRuxZlwd7.fthV_wmrsT_h.bC1tFzg Boxtf7h2ASDUhVi2aiUmxbVpljqynp352HTtAl8CRV.U.O4hW9my9WV1WM3h V3jka01.Q92Etydx3neo39gaiesQ50.Mz5EuuIXKWDECG4r_hfWa6TOXHwJl 48R.2d41hSp_pM1qUBxGsf1jmEsafiUNUzbI3tI7pb5yoYF2sVxqjVc8pCyV uFaPZ_GL3Jjp17Tz.0Ki1vjdm5UEyn6IjJ8JmuSd_IUep5erNNMXVzqAsxa7 o0tXeWUW0ZLYHBECtB1MpESBcoXiyJeJXOUfACJWQCeub6IOHTr81jdN24dJ fc_UAzizMaPwjjHEfmb1EGhlurbOl4il.wproECrHkK.htmQxZYqrph3UmVc yfo_IanArx6QyUV.OpughrXkn7kFGhTklCY0pkQxGrzckz1GV24mFgkj2oip 1.FguC01GYIhN_6QbzBFRuHe38vEk0ObLboZ3ohYAYj2TUeIT0ptoGA--
MIME-Version: 1.0
X-Spam-Status: No, score=-6.699 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FROM_OUR_RT=-4, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
X-Spam-Flag: NO
X-Yahoo-Newman-ID: 647197.63641.bm [...] smtp240.mail.gq1.yahoo.com
X-RT-Interface: API
References: <RT-Ticket-118722 [...] rt.cpan.org> <rt-4.0.18-15976-1478886485-883.118722-4-0 [...] rt.cpan.org> <87y40pf8eg.fsf [...] blah.blah> <rt-4.0.18-20269-1478936813-1880.118722-5-0 [...] rt.cpan.org> <rt-4.0.18-31777-1479013139-526.118722-5-0 [...] rt.cpan.org>
X-Yahoo-SMTP: U8NKAo6swBAxDIMUovTitGGHebxdYQBZ5A--
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Yahoo-Newman-Property: ymail-3
Message-ID: <877f7t9mbj.fsf [...] blah.blah>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -6.699
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] yahoo.com.au
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 64639240331 for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Thu, 24 Nov 2016 05:59:59 -0500 (EST)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hM5vqeyWbitp for <cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com>; Thu, 24 Nov 2016 05:59:58 -0500 (EST)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id D372D2400DC for <bug-Perl-Critic-Pulp [...] rt.cpan.org>; Thu, 24 Nov 2016 05:59:57 -0500 (EST)
Received: (qmail 14769 invoked by alias); 24 Nov 2016 10:59:57 -0000
Received: from nm9-vm7.bullet.mail.gq1.yahoo.com (HELO nm9-vm7.bullet.mail.gq1.yahoo.com) (98.136.218.246) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 24 Nov 2016 02:59:55 -0800
Received: from [216.39.60.180] by nm9.bullet.mail.gq1.yahoo.com with NNFMP; 24 Nov 2016 10:59:51 -0000
Received: from [98.136.164.78] by tm16.bullet.mail.gq1.yahoo.com with NNFMP; 24 Nov 2016 10:59:51 -0000
Received: from [127.0.0.1] by smtp240.mail.gq1.yahoo.com with NNFMP; 24 Nov 2016 10:59:51 -0000
Delivered-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #118722] RequireFinalCut fires if =cut isn't preceded by a blank line
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Return-Path: <user42_kevin [...] yahoo.com.au>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1479985191; bh=TFlL/z42zkRYeeVkyw7aB00yCNCmpPSQT/awRunTIcg=; h=From:To:Subject:References:Date:From:Subject; b=A6d4w9fdkER2a29oLcZ4rmzE0VmnGjXYI2w3nf6+Gw2jl49ZRBie/8UAwnTkoG4dX/ssFuiFF5KJCHTaoepOBN4AWY72usQcPrCdv0KQ6CQjJBCTNeSl+BS26bcI0vUuxgwQQKn0k/vme0ezccHOs68aO7k2ToAgyzaOdnYhgt17kDqy3MeQwfvbfzviZ/BXdGHclIpsm3vFsSl5U+lGNQdApZue0dE3LmkD1B0em2qsX0m4hlr7tkF8C99uHyY9K1IYh2hCQXnopC+OezK5TTcxCr04azJ+jZj3erOOnLKAFPmbp8pFFEr9S9euCL54D6D5EA/1KeQ1Mcm4rcjzvA==
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+Perl-Critic-Pulp [...] hipster.bestpractical.com
X-RT-Mail-Extension: perl-critic-pulp
Date: Thu, 24 Nov 2016 21:58:08 +1100
X-Spam-Level:
To: "Andy Lester via RT" <bug-Perl-Critic-Pulp [...] rt.cpan.org>
From: Kevin Ryde <user42_kevin [...] yahoo.com.au>
RT-Message-ID: <rt-4.0.18-4445-1479985200-1000.118722-0-0 [...] rt.cpan.org>
Content-Length: 673
Download (untitled) / with headers
text/plain 673b
"Andy Lester via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text
> > All I know is that when I first got the error I was a little confused > because clearly there's that =cut and so what's it complaining about?
On balance, yep. I uploaded a version 91 allowing for no blank line. As you say, that's how it looks, and how perl executes. podchecker or another policy can report whether pod without blanks is in fact a good idea. -- I played a country and western song backwards to listen for evil messages. It sounded just the same except it was about a fella whose wife stood by him while he brought in a successful harvest and his dog recovered from a long illness.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.