Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the Net-SSH-Perl CPAN distribution.

Report information
The Basics
Id: 118335
Status: resolved
Priority: 0/
Queue: Net-SSH-Perl

People
Owner: Nobody in particular
Requestors: allan [...] oepping.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: allan-cpan [...] oepping.com
MIME-Version: 1.0
X-Google-Original-From: Allan Oepping <allan-cpan [...] oepping.com>
X-Spam-Status: No, score=-2.7 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
X-Spam-Flag: NO
Content-Type: multipart/mixed; boundary="------------D14E4066414EC82E0F861F66"
Message-ID: <051ad417-ac22-cafc-8009-fb31d7097c78 [...] oepping.com>
X-Received: by 10.107.18.27 with SMTP id a27mr247824ioj.126.1476223402946; Tue, 11 Oct 2016 15:03:22 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
X-Spam-Score: -2.7
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 549A32403C2 for <cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com>; Tue, 11 Oct 2016 18:03:33 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fygbEbY+qxev for <cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com>; Tue, 11 Oct 2016 18:03:32 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id A64872403A7 for <bug-Net-SSH-Perl [...] rt.cpan.org>; Tue, 11 Oct 2016 18:03:31 -0400 (EDT)
Received: (qmail 23611 invoked by alias); 11 Oct 2016 22:03:30 -0000
Received: from mail-it0-f53.google.com (HELO mail-it0-f53.google.com) (209.85.214.53) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Tue, 11 Oct 2016 15:03:26 -0700
Received: by mail-it0-f53.google.com with SMTP id l13so121737979itl.1 for <bug-Net-SSH-Perl [...] rt.cpan.org>; Tue, 11 Oct 2016 15:03:26 -0700 (PDT)
Received: from [10.1.10.210] ([63.226.98.35]) by smtp.gmail.com with ESMTPSA id c36sm2364559itd.2.2016.10.11.15.03.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Oct 2016 15:03:22 -0700 (PDT)
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] oepping.com
Delivered-To: cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
Subject: Net::SSH::Perl 2.01 - available length miscalculation in Packet.pm - patch included
Return-Path: <allan [...] oepping.com>
X-RT-Mail-Extension: net-ssh-perl
X-Original-To: cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com
X-Spam-Check-BY: la.mx.develooper.com
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oepping.com; s=google; h=from:to:subject:cc:message-id:date:user-agent:mime-version; bh=lYh7ra3XCMpM/iEMKEkmPzw153kSMVEKRIjgMKAwdcQ=; b=fWNCYJuzX3wLRCS+HHGV2L7Da+haPFnvhlPbld1cqY+7/jOyOMS07hzbAEjIIco9p6 wZb076E+Vucr7/72U+nVmGv42XdFeGIu8cQtxK5LkkHw1nllPZjiUU+sCC5n/w69qLut /2WAMsJdGLX+5VdM5+SVF1K0XNqyDPMpN3meI=
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:cc:message-id:date:user-agent :mime-version; bh=lYh7ra3XCMpM/iEMKEkmPzw153kSMVEKRIjgMKAwdcQ=; b=O2gydq0oe22RC4seGu1ImrFa/yI3nS4paN81iv2I/RRPSPV/nD6j5TOl38kB4rEScQ ooNtPGVHviOQBRmzpwFtUXOAqH8aDYdb4fOfJ+HS+7ECsoxI4hjORO6cNM5jqHcbDDNU hqgm+kFWBcgxlsvPQLkM0RPJlioLhHgzjjeCGYM7H/krbS1O9q56Ft1rJFIBNpz+E1Te OR5k7k4RBiZTG0xEMfT7tMqZT5usT82QP0maoqAYXO6LNLilUqK/XdE+Eqo5oB0x0k3v JwWtpUQgvaZcknTyl5HXXcA+PLaNlZgqn2RaofkaKbRzyJKX5+PEHEybakrEwigOqlTv EyWg==
Date: Tue, 11 Oct 2016 16:03:21 -0600
X-Spam-Level:
To: bug-Net-SSH-Perl [...] rt.cpan.org
From: Allan Oepping <allan [...] oepping.com>
X-GM-Message-State: AA6/9Rk/YpbGFD9Sz6YfX0tUFEH86wxr2kTa6gGlIHNePWDeecEA5yLgVOhDzPAgeN1bvH9L
X-RT-Interface: Email
Content-Length: 0
content-type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-RT-Original-Encoding: utf-8
Content-Length: 1155
Download (untitled) / with headers
text/plain 1.1k
Version string in Packet.pm: Packet.pm,v 1.25 2008/09/24 19:21:20 turnstep Exp In Packet.pm in fuction read_poll_ssh2 if $mac && $mac->enabled but not $mac->etm then $block_size bytes are also read from the $incoming buffer but the $incoming->length may not be large enough to include a full read of $stored_mac later in the code. I added the a return if the length including block_size is not available (Line after the comment "RETURN IF INSUFFICIENT BUF") and that seems to fix the issue. if ($mac && $mac->enabled) { if ($mac->etm) { $p_str = $incoming->bytes(0, $aadlen + $need, ''); $macbuf = $mac->hmac(pack("N", $seqnr) . $p_str); # remove packet length bytes substr($p_str,0,$aadlen,''); } else { #RETURN IF INSUFFICIENT BUF return if $incoming->length < $aadlen + $need + $authlen + $maclen + $block_size; # not etm mac, append bytes already decrypted above $buffer->append( $incoming->bytes(0, $block_size, '') ); $p_str = $incoming->bytes(0, $need, ''); } Unified diff/patch attached. Thanks, Allan Oepping
Content-Type: text/x-patch; name="packet-pm.patch"
Content-Disposition: attachment; filename="packet-pm.patch"
Content-Transfer-Encoding: quoted-printable
Content-Length: 606
Download packet-pm.patch
text/x-diff 606b

Message body is not shown because sender requested not to inline it.

MIME-Version: 1.0
In-Reply-To: <051ad417-ac22-cafc-8009-fb31d7097c78 [...] oepping.com>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <051ad417-ac22-cafc-8009-fb31d7097c78 [...] oepping.com>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-1500-1476356674-1046.118335-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 1808
Download (untitled) / with headers
text/plain 1.7k
Thanks! If by any chance you are able to try your patch against lkinley's github repository and send him a pull request, that would be great. lkinley is currently doing the actual work on this lib and I plan to merge and upload his new version soon. His repo is https://github.com/lkinley/Net-SSH-Perl This would help because I'm just co-maintaining the CPAN release but don't really know the internals. Thanks and kind regards, Steffen On Tue Oct 11 18:03:34 2016, allan@oepping.com wrote: Show quoted text
> Version string in Packet.pm: Packet.pm,v 1.25 2008/09/24 19:21:20 > turnstep Exp > > In Packet.pm in fuction read_poll_ssh2 if $mac && $mac->enabled but not > $mac->etm then $block_size bytes are also read from the $incoming buffer > but the $incoming->length may not be large enough to include a full read > of $stored_mac later in the code. > > I added the a return if the length including block_size is not available > (Line after the comment "RETURN IF INSUFFICIENT BUF") and that seems to > fix the issue. > > > if ($mac && $mac->enabled) { > if ($mac->etm) { > $p_str = $incoming->bytes(0, $aadlen + $need, ''); > $macbuf = $mac->hmac(pack("N", $seqnr) . $p_str); > # remove packet length bytes > substr($p_str,0,$aadlen,''); > } else { > #RETURN IF INSUFFICIENT BUF > return if $incoming->length < $aadlen + $need + $authlen > + $maclen + $block_size; > # not etm mac, append bytes already decrypted above > $buffer->append( $incoming->bytes(0, $block_size, '') ); > $p_str = $incoming->bytes(0, $need, ''); > } > > Unified diff/patch attached. > > Thanks, > > Allan Oepping
-- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/>
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-1500-1476356674-1046.118335-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <051ad417-ac22-cafc-8009-fb31d7097c78 [...] oepping.com> <rt-4.0.18-1500-1476356674-1046.118335-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-5769-1497249209-1427.118335-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 2046
Download (untitled) / with headers
text/plain 1.9k
Hi, is this still an issue with the v2.12 that I just uploaded to CPAN? Thanks for checking. Kind regards, Steffen On Thu Oct 13 07:04:34 2016, SCHWIGON wrote: Show quoted text
> Thanks! > > If by any chance you are able to try your patch against lkinley's > github > repository and send him a pull request, that would be great. lkinley > is currently > doing the actual work on this lib and I plan to merge and upload his > new version soon. > > His repo is https://github.com/lkinley/Net-SSH-Perl > > This would help because I'm just co-maintaining the CPAN release but > don't really know the internals. > > Thanks and kind regards, > Steffen > > On Tue Oct 11 18:03:34 2016, allan@oepping.com wrote:
> > Version string in Packet.pm: Packet.pm,v 1.25 2008/09/24 19:21:20 > > turnstep Exp > > > > In Packet.pm in fuction read_poll_ssh2 if $mac && $mac->enabled but > > not > > $mac->etm then $block_size bytes are also read from the $incoming > > buffer > > but the $incoming->length may not be large enough to include a full > > read > > of $stored_mac later in the code. > > > > I added the a return if the length including block_size is not > > available > > (Line after the comment "RETURN IF INSUFFICIENT BUF") and that seems > > to > > fix the issue. > > > > > > if ($mac && $mac->enabled) { > > if ($mac->etm) { > > $p_str = $incoming->bytes(0, $aadlen + $need, ''); > > $macbuf = $mac->hmac(pack("N", $seqnr) . $p_str); > > # remove packet length bytes > > substr($p_str,0,$aadlen,''); > > } else { > > #RETURN IF INSUFFICIENT BUF > > return if $incoming->length < $aadlen + $need + $authlen > > + $maclen + $block_size; > > # not etm mac, append bytes already decrypted above > > $buffer->append( $incoming->bytes(0, $block_size, '') ); > > $p_str = $incoming->bytes(0, $need, ''); > > } > > > > Unified diff/patch attached. > > > > Thanks, > > > > Allan Oepping
-- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/>
MIME-Version: 1.0
X-Cpan.org: This message routed through the cpan.org mail forwarding service. Please use PAUSE pause.perl.org to configure your delivery settings.
X-Spam-Flag: NO
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.335
Authentication-Results: hipster.bestpractical.com (amavisd-new); dkim=pass header.i= [...] oepping.com
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id DB15F2401F0 for <cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com>; Mon, 12 Jun 2017 13:18:54 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LL9+uTipFIvN for <cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com>; Mon, 12 Jun 2017 13:18:52 -0400 (EDT)
Received: from xx1.develooper.com (xx1.develooper.com [207.171.7.115]) by hipster.bestpractical.com (Postfix) with ESMTPS id B30D12401BB for <bug-Net-SSH-Perl [...] rt.cpan.org>; Mon, 12 Jun 2017 13:18:52 -0400 (EDT)
Received: from localhost (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with ESMTP id 71A1211EBC5 for <bug-Net-SSH-Perl [...] rt.cpan.org>; Mon, 12 Jun 2017 10:18:51 -0700 (PDT)
Received: from xx1.develooper.com (xx1.develooper.com [127.0.0.1]) by localhost (Postfix) with SMTP id AC49111EC12 for <bug-Net-SSH-Perl [...] rt.cpan.org>; Mon, 12 Jun 2017 10:18:48 -0700 (PDT)
Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by xx1.develooper.com (Postfix) with ESMTPS id 63E9911EBC5 for <bug-Net-SSH-Perl [...] rt.cpan.org>; Mon, 12 Jun 2017 10:18:37 -0700 (PDT)
Received: by mail-io0-f182.google.com with SMTP id t87so38795849ioe.0 for <bug-Net-SSH-Perl [...] rt.cpan.org>; Mon, 12 Jun 2017 10:18:37 -0700 (PDT)
Received: from [10.1.10.210] (c-24-10-175-209.hsd1.ut.comcast.net. [24.10.175.209]) by smtp.gmail.com with ESMTPSA id j21sm302823itb.15.2017.06.12.10.18.35 for <bug-Net-SSH-Perl [...] rt.cpan.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jun 2017 10:18:36 -0700 (PDT)
Delivered-To: cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #118335] Net::SSH::Perl 2.01 - available length miscalculation in Packet.pm - patch included
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oepping.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=6Ss+RjQArc+cHcQ7zJzLMKri5f1ty8MyocXazZqL/s8=; b=cBQmm3yVI+AnkCaVrnB77NHT14FKdRQUeXAoIQj+K4qR7kQ9yzZSVrUWUhMc6lDVMY HZu413QPvSW5dKuSoUj4noCSCWiEnFAOnKz4jfE4DnQCxyzO7/bcvO7MqFsejnfC9TEF 6aEapJ9qTyT8jIHMjeENEZv4A+OpsIQBSll/M=
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6Ss+RjQArc+cHcQ7zJzLMKri5f1ty8MyocXazZqL/s8=; b=RSOrDKF5EmANeq7vfjPzrTqPAHlmi1pUm16mX5Oca5qcWxy/+qgElvY2e8nvhJIY/M 0wYK1Z4FtBgQBRB9UVV+YMuPGnre9HZtRzSOXSnfujem7bsCq4Vl3UK99fwt8Nj5PcNy z22iMZQlWWYCmoR0oJHD2fafhRIcHOZmYzjBlg9+eLOCPtd4GO1M9Cyq6ZbDTeFfb45q IJnMnAj+mggU5L6omgBKAMX8haSsC+d8aEPiJZmIQl26BNY7VJ5kU/CBC3hSfuOKOVZt n7fkLheAm+AcDV+DC7GHpSN1jTirtOhj1MvJEoKxo3Fwpc3B2AJpBDaiVwkqYlex+PUC I1dQ==
Date: Mon, 12 Jun 2017 11:18:35 -0600
X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, REFERENCES 0, SPF_PASS 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __DQ_NEG_HEUR 0, __DQ_NEG_IP 0, __FORWARDED_MSG 0, __FRAUD_MONEY_CURRENCY 0, __FRAUD_MONEY_CURRENCY_DOLLAR 0, __HAS_FROM 0, __HAS_MSGID 0, __HELO_GMAIL 0, __HTTPS_URI 0, __IN_REP_TO 0, __LINES_OF_YELLING 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MOZILLA_USER_AGENT 0, __MULTIPLE_URI_TEXT 0, __NO_HTML_TAG_RAW 0, __RDNS_GMAIL 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0, __YOUTUBE_RCVD 0, __blackholes.mail-abuse.org_TIMEOUT , __zen.spamhaus.org_ERROR '
X-Spam-Level:
X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2017.6.12.170916
To: bug-Net-SSH-Perl [...] rt.cpan.org
Content-Transfer-Encoding: 8bit
X-GM-Message-State: AODbwcCTQQQPFmG8JSVtP5GqSkZPLWCB1ZgU7uX8NRBamixZPLCY+y6L lZeM552PRD4txCWqeu6wAQ==
In-Reply-To: <rt-4.0.18-5769-1497249209-937.118335-6-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-5.335 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_OUR_RT=-4, SPF_SOFTFAIL=0.665] autolearn=ham
X-RT-Interface: API
Content-Language: en-US
References: <RT-Ticket-118335 [...] rt.cpan.org> <051ad417-ac22-cafc-8009-fb31d7097c78 [...] oepping.com> <rt-4.0.18-1500-1476356674-1046.118335-6-0 [...] rt.cpan.org> <rt-4.0.18-5769-1497249209-937.118335-6-0 [...] rt.cpan.org>
Message-ID: <3a7e17fd-cd67-2361-77e8-f695c48b12a2 [...] oepping.com>
X-Received: by 10.107.138.224 with SMTP id c93mr53284592ioj.32.1497287916750; Mon, 12 Jun 2017 10:18:36 -0700 (PDT)
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
Return-Path: <allan [...] oepping.com>
X-RT-Mail-Extension: net-ssh-perl
X-Original-To: cpan-bug+Net-SSH-Perl [...] hipster.bestpractical.com
From: Allan Oepping <allan [...] oepping.com>
RT-Message-ID: <rt-4.0.18-27920-1497287935-623.118335-0-0 [...] rt.cpan.org>
Content-Length: 2722
Download (untitled) / with headers
text/plain 2.6k
A connection worked, but the conditions of the original problem are no longer there, and running the original modules also did not present the problem. We are using it with the Net::SFTP module and one intermittent issue is fixed "Key verification failed for server host key" no longer occurs. But Net::SFTP depends on Net::SSH::Perl::Util SSH2MP.pm mp2bin and bin2mp and v2.12 no longer contains that module, so I had to modify Net::SFTP in order to test. It looks like you are also the maintainer for that package. I will run it in rotation and see if the problem presents itself again. Thanks, Allan On 06/12/2017 12:33 AM, Steffen Schwigon via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=118335 > > > Hi, > > is this still an issue with the v2.12 that I just uploaded to CPAN? > > Thanks for checking. > > Kind regards, > Steffen > > On Thu Oct 13 07:04:34 2016, SCHWIGON wrote:
>> Thanks! >> >> If by any chance you are able to try your patch against lkinley's >> github >> repository and send him a pull request, that would be great. lkinley >> is currently >> doing the actual work on this lib and I plan to merge and upload his >> new version soon. >> >> His repo is https://github.com/lkinley/Net-SSH-Perl >> >> This would help because I'm just co-maintaining the CPAN release but >> don't really know the internals. >> >> Thanks and kind regards, >> Steffen >> >> On Tue Oct 11 18:03:34 2016, allan@oepping.com wrote:
>>> Version string in Packet.pm: Packet.pm,v 1.25 2008/09/24 19:21:20 >>> turnstep Exp >>> >>> In Packet.pm in fuction read_poll_ssh2 if $mac && $mac->enabled but >>> not >>> $mac->etm then $block_size bytes are also read from the $incoming >>> buffer >>> but the $incoming->length may not be large enough to include a full >>> read >>> of $stored_mac later in the code. >>> >>> I added the a return if the length including block_size is not >>> available >>> (Line after the comment "RETURN IF INSUFFICIENT BUF") and that seems >>> to >>> fix the issue. >>> >>> >>> if ($mac && $mac->enabled) { >>> if ($mac->etm) { >>> $p_str = $incoming->bytes(0, $aadlen + $need, ''); >>> $macbuf = $mac->hmac(pack("N", $seqnr) . $p_str); >>> # remove packet length bytes >>> substr($p_str,0,$aadlen,''); >>> } else { >>> #RETURN IF INSUFFICIENT BUF >>> return if $incoming->length < $aadlen + $need + $authlen >>> + $maclen + $block_size; >>> # not etm mac, append bytes already decrypted above >>> $buffer->append( $incoming->bytes(0, $block_size, '') ); >>> $p_str = $incoming->bytes(0, $need, ''); >>> } >>> >>> Unified diff/patch attached. >>> >>> Thanks, >>> >>> Allan Oepping
> >
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-27920-1497287935-623.118335-0-0 [...] rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <RT-Ticket-118335 [...] rt.cpan.org> <051ad417-ac22-cafc-8009-fb31d7097c78 [...] oepping.com> <rt-4.0.18-1500-1476356674-1046.118335-6-0 [...] rt.cpan.org> <rt-4.0.18-5769-1497249209-937.118335-6-0 [...] rt.cpan.org> <3a7e17fd-cd67-2361-77e8-f695c48b12a2 [...] oepping.com> <rt-4.0.18-27920-1497287935-623.118335-0-0 [...] rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-19830-1503555771-1154.118335-0-0 [...] rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 244
Download (untitled) / with headers
text/plain 244b
I think the trouble with SFTP got sorted out in the meantime, so I'm closing this ticket. If I'm wrong please re-open it. Thanks for your report. Steffen -- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/>


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.