Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 117735
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: AGRUNDMA [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in:
  • 1.75
  • 1.76
  • 1.77
  • 1.78
Fixed in: 1.79

Attachments


Subject: [PATCH] Fix inline variable declarations
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.18-2313-1473499731-1481.0-0-0 [...] rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1473499731-2313-3"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 215
Download (untitled) / with headers
text/plain 215b
One of the recent versions added a few inline variable declarations that cause errors for older compilers. Apologies if the patch looks weird, I tried to match the odd tab/space mix going on in this bit of the code.
Subject: Net-SSLeay-1.78-inline-variables.patch
MIME-Version: 1.0
Content-Type: application/octet-stream; name="Net-SSLeay-1.78-inline-variables.patch"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="Net-SSLeay-1.78-inline-variables.patch"
Content-Transfer-Encoding: base64
Content-Length: 1394
From 67263d02ed713003572370931f3d3cc8a773600d Mon Sep 17 00:00:00 2001 From: Andy Grundman <andyg@activestate.com> Date: Fri, 9 Sep 2016 16:54:04 -0400 Subject: [PATCH] Fix inline variable declarations to make MSVC happy --- SSLeay.xs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/SSLeay.xs b/SSLeay.xs index abd7f42..8404d68 100644 --- a/SSLeay.xs +++ b/SSLeay.xs @@ -6043,6 +6043,8 @@ OCSP_response_results(rsp,...) OCSP_SINGLERESP *sir = NULL; OCSP_CERTID *certid = NULL; SV *idsv = NULL; + int first, status, revocationReason; + ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if(getall) { sir = OCSP_resp_get0(bsr,i); @@ -6057,13 +6059,11 @@ OCSP_response_results(rsp,...) error = "failed to get OCSP certid from string"; goto end; } - int first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ - if (first >= 0) - sir = OCSP_resp_get0(bsr,first); + first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ + if (first >= 0) + sir = OCSP_resp_get0(bsr,first); } - int status, revocationReason; - ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if (sir) { #if OPENSSL_VERSION_NUMBER >= 0x10100000L -- 2.8.1
MIME-Version: 1.0 (1.0)
X-Spam-Flag: NO
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
X-Source-Sender: ([192.168.16.127]) [185.6.105.106]:52395
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.899
X-Source-Cap: bWlrZW07bWlrZW07Z2F0b3I0MTI5Lmhvc3RnYXRvci5jb20=
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 6AEE924024F for <cpan-bug+Net-SSLeay [...] hipster.bestpractical.com>; Sat, 10 Sep 2016 07:07:37 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FT4YpUeeK8hl for <cpan-bug+Net-SSLeay [...] hipster.bestpractical.com>; Sat, 10 Sep 2016 07:07:33 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id EBE232401BE for <bug-Net-SSLeay [...] rt.cpan.org>; Sat, 10 Sep 2016 07:07:32 -0400 (EDT)
Received: (qmail 23284 invoked by alias); 10 Sep 2016 11:07:31 -0000
Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.107) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Sat, 10 Sep 2016 04:07:29 -0700
Received: from cm6.websitewelcome.com (cm6.websitewelcome.com [108.167.139.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 9FB2285558966 for <bug-Net-SSLeay [...] rt.cpan.org>; Sat, 10 Sep 2016 06:07:25 -0500 (CDT)
Received: from gator4129.hostgator.com ([192.185.4.141]) by cm6.websitewelcome.com with id hn7Q1t00Y32ZDfC01n7RmP; Sat, 10 Sep 2016 06:07:25 -0500
Received: from [185.6.105.106] (port=52395 helo=[192.168.16.127]) by gator4129.hostgator.com with esmtpsa (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim 4.86_1) (envelope-from <mikem [...] airspayce.com>) id 1big84-0005A0-Bc for bug-Net-SSLeay [...] rt.cpan.org; Sat, 10 Sep 2016 06:07:24 -0500
Delivered-To: cpan-bug+Net-SSLeay [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #117735] [PATCH] Fix inline variable declarations
X-Spam-Check-BY: la.mx.develooper.com
Date: Sat, 10 Sep 2016 13:07:22 +0200
X-Spam-Level:
X-Bwhitelist: no
To: bug-Net-SSLeay [...] rt.cpan.org
Content-Transfer-Encoding: quoted-printable
X-Source:
X-Source-Args:
In-Reply-To: <rt-4.0.18-2313-1473499732-1664.117735-4-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-5.899 tagged_above=-99.9 required=10 tests=[BAYES_00=-1.9, FROM_OUR_RT=-4, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
X-Mailer: iPhone Mail (13G35)
X-Source-Dir:
X-RT-Interface: API
References: <RT-Ticket-117735 [...] rt.cpan.org> <rt-4.0.18-2313-1473499732-1664.117735-4-0 [...] rt.cpan.org>
Message-ID: <7D4BE172-60E0-43D4-BEFD-B5838D663A78 [...] airspayce.com>
X-Source-Auth: mikem [...] airspayce.com
X-Antiabuse: This header was added to track abuse, please include it with any abuse report
X-Antiabuse: Primary Hostname - gator4129.hostgator.com
X-Antiabuse: Original Domain - rt.cpan.org
X-Antiabuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse: Sender Address Domain - airspayce.com
X-Source-Ip: 185.6.105.106
Return-Path: <mikem [...] airspayce.com>
X-RT-Mail-Extension: net-ssleay
X-Original-To: cpan-bug+Net-SSLeay [...] hipster.bestpractical.com
X-Exim-ID: 1big84-0005A0-Bc
X-Email-Count: 2
From: Mike McCauley <mikem [...] airspayce.com>
RT-Message-ID: <rt-4.0.18-7352-1473505660-1207.117735-0-0 [...] rt.cpan.org>
Content-Length: 2025
Download (untitled) / with headers
text/plain 1.9k
Thanks for the patch I'm travelling at the moment and won't get a chance to look closely until mid October Cheers Sent from my iPhone Show quoted text
> On 10 Sep 2016, at 11:28 AM, Andy Grundman via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Sat Sep 10 05:28:52 2016: Request 117735 was acted upon. > Transaction: Ticket created by AGRUNDMA > Queue: Net-SSLeay > Subject: [PATCH] Fix inline variable declarations > Broken in: 1.75, 1.76, 1.77, 1.78 > Severity: Unimportant > Owner: Nobody > Requestors: AGRUNDMA@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=117735 > > > > One of the recent versions added a few inline variable declarations that cause errors for older compilers. Apologies if the patch looks weird, I tried to match the odd tab/space mix going on in this bit of the code. > From 67263d02ed713003572370931f3d3cc8a773600d Mon Sep 17 00:00:00 2001 From: Andy Grundman Date: Fri, 9 Sep 2016 16:54:04 -0400 Subject: [PATCH] Fix inline variable declarations to make MSVC happy --- SSLeay.xs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/SSLeay.xs b/SSLeay.xs index abd7f42..8404d68 100644 --- a/SSLeay.xs +++ b/SSLeay.xs @@ -6043,6 +6043,8 @@ OCSP_response_results(rsp,...) OCSP_SINGLERESP *sir = NULL; OCSP_CERTID *certid = NULL; SV *idsv = NULL; + int first, status, revocationReason; + ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if(getall) { sir = OCSP_resp_get0(bsr,i); @@ -6057,13 +6059,11 @@ OCSP_response_results(rsp,...) error = "failed to get OCSP certid from string"; goto end; } - int first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ - if (first >= 0) - sir = OCSP_resp_get0(bsr,first); + first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ + if (first >= 0) + sir = OCSP_resp_get0(bsr,first); } - int status, revocationReason; - ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if (sir) { #if OPENSSL_VERSION_NUMBER >= 0x10100000L -- 2.8.1
MIME-Version: 1.0
X-Spam-Flag: NO
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
content-type: text/plain; charset="utf-8"
X-Source-Sender: 135.35.96.58.static.exetel.com.au (zulu.localnet) [58.96.35.135]:48850
X-RT-Original-Encoding: utf-8
X-Spam-Score: -5.332
X-Source-Cap: bWlrZW07bWlrZW07Z2F0b3I0MTI5Lmhvc3RnYXRvci5jb20=
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id A826E240379 for <cpan-bug+Net-SSLeay [...] hipster.bestpractical.com>; Wed, 19 Oct 2016 20:58:02 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1v1AAzV2SNey for <cpan-bug+Net-SSLeay [...] hipster.bestpractical.com>; Wed, 19 Oct 2016 20:58:01 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id DD96A2402E0 for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 19 Oct 2016 20:58:00 -0400 (EDT)
Received: (qmail 1775 invoked by alias); 20 Oct 2016 00:57:59 -0000
Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.60) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Wed, 19 Oct 2016 17:57:57 -0700
Received: from cm3.websitewelcome.com (unknown [108.167.139.23]) by gateway23.websitewelcome.com (Postfix) with ESMTP id EEE6BD6F8026B for <bug-Net-SSLeay [...] rt.cpan.org>; Wed, 19 Oct 2016 19:57:49 -0500 (CDT)
Received: from gator4129.hostgator.com ([192.185.4.141]) by cm3.websitewelcome.com with id xcxo1t00v32ZDfC01cxpe5; Wed, 19 Oct 2016 19:57:49 -0500
Received: from 135.35.96.58.static.exetel.com.au ([58.96.35.135]:48850 helo=zulu.localnet) by gator4129.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from <mikem [...] airspayce.com>) id 1bx1g4-000Si9-F6 for bug-Net-SSLeay [...] rt.cpan.org; Wed, 19 Oct 2016 19:57:48 -0500
Delivered-To: cpan-bug+Net-SSLeay [...] hipster.bestpractical.com
Subject: Re: [rt.cpan.org #117735] [PATCH] Fix inline variable declarations
X-Spam-Check-BY: la.mx.develooper.com
Date: Thu, 20 Oct 2016 10:57:46 +1000
X-Spam-Level:
X-Bwhitelist: no
To: bug-Net-SSLeay [...] rt.cpan.org
Content-Transfer-Encoding: 7Bit
X-Source:
X-Source-Args:
In-Reply-To: <rt-4.0.18-2313-1473499732-1664.117735-4-0 [...] rt.cpan.org>
X-Spam-Status: No, score=-5.332 tagged_above=-99.9 required=10 tests=[AWL=0.568, BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
X-Source-Dir:
X-RT-Interface: API
References: <RT-Ticket-117735 [...] rt.cpan.org> <rt-4.0.18-2313-1473499732-1664.117735-4-0 [...] rt.cpan.org>
Message-ID: <2849067.7ljvgjgDDU [...] zulu>
X-Source-Auth: mikem [...] airspayce.com
X-Antiabuse: This header was added to track abuse, please include it with any abuse report
X-Antiabuse: Primary Hostname - gator4129.hostgator.com
X-Antiabuse: Original Domain - rt.cpan.org
X-Antiabuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse: Sender Address Domain - airspayce.com
Organization: AirSpayce Pty Ltd
X-Source-Ip: 58.96.35.135
User-Agent: KMail/4.14.10 (Linux/3.16.7-35-desktop; KDE/4.14.9; i686; ; )
Return-Path: <mikem [...] airspayce.com>
X-RT-Mail-Extension: net-ssleay
X-Original-To: cpan-bug+Net-SSLeay [...] hipster.bestpractical.com
X-Exim-ID: 1bx1g4-000Si9-F6
X-Email-Count: 16
From: Mike McCauley <mikem [...] airspayce.com>
RT-Message-ID: <rt-4.0.18-4631-1476925083-1634.117735-0-0 [...] rt.cpan.org>
Content-Length: 1009
Download (untitled) / with headers
text/plain 1009b
Hi Andy, Thanks for this patch and your previous one. Thery are now both in SVN 479 Sorry for the delay. Cheers. On Saturday, September 10, 2016 05:28:53 AM Andy Grundman via RT wrote: Show quoted text
> Sat Sep 10 05:28:52 2016: Request 117735 was acted upon. > Transaction: Ticket created by AGRUNDMA > Queue: Net-SSLeay > Subject: [PATCH] Fix inline variable declarations > Broken in: 1.75, 1.76, 1.77, 1.78 > Severity: Unimportant > Owner: Nobody > Requestors: AGRUNDMA@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=117735 > > > > One of the recent versions added a few inline variable declarations that > cause errors for older compilers. Apologies if the patch looks weird, I > tried to match the odd tab/space mix going on in this bit of the code.
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.