This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id:
117620
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
jkeenan [...] cpan.org
Requestors:
dom [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
2.12
Fixed in:
(no value)



Subject: [PATCH] Don't hardcode ENOENT
MIME-Version: 1.0
X-Mailer: MIME-tools 5.504 (Entity 5.504)
X-RT-Interface: Web
Message-ID: <rt-4.0.18-4190-1473326481-751.0-0-0@rt.cpan.org>
X-RT-Original-Encoding: utf-8
Content-Type: multipart/mixed; boundary="----------=_1473326481-4190-3"
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 0
Content-Disposition: inline
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
Content-Length: 190
The attached patch, provided by Pino Toscano of the Debian project, fixes a test failure on GNU/Hurd because on that platform, ENOENT is not 2. This fixes a regression between 2.11 and 2.12.
Subject: file-path-errno.diff
MIME-Version: 1.0
Content-Type: text/x-patch; name="file-path-errno.diff"
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline; filename="file-path-errno.diff"
Content-Transfer-Encoding: binary
Content-Length: 399
--- a/t/Path.t +++ b/t/Path.t @@ -8,6 +8,7 @@ use Config; use Fcntl ':mode'; use lib 't/'; use FilePathTest; +use Errno qw(:POSIX); BEGIN { use_ok('Cwd'); @@ -656,7 +657,7 @@ is( { my ($x, $message, $object, $expect, $rv, $arg, $error); my ($k, $v, $second_error, $third_error); - local $! = 2; + local $! = ENOENT; $x = $!; $message = 'message in a bottle';
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-4190-1473326481-751.0-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4190-1473326481-751.0-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-20310-1473338175-1223.117620-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 355
On Thu Sep 08 05:21:21 2016, DOM wrote:
Show quoted text
> The attached patch, provided by Pino Toscano of the Debian project, > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > not 2. This fixes a regression between 2.11 and 2.12.
Is there a Debian bug ticket or mailing list thread that we can reference for this? Thank you very much. Jim Keenan
MIME-Version: 1.0
X-Spam-Status: No, score=-7.155 tagged_above=-99.9 required=10 tests=[AWL=1.046, BAYES_00=-1.9, FROM_OUR_RT=-4, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001] autolearn=ham
In-Reply-To: <rt-4.0.18-20310-1473338176-1604.117620-6-0@rt.cpan.org>
Content-Disposition: inline
X-Spam-Flag: NO
X-RT-Interface: API
References: <RT-Ticket-117620@rt.cpan.org> <rt-4.0.18-4190-1473326481-751.117620-6-0@rt.cpan.org> <rt-4.0.18-20310-1473338176-1604.117620-6-0@rt.cpan.org>
X-Virus-Scanned: Debian amavisd-new at bestpractical.com
Message-ID: <20160908124019.GX16907@urchin.earth.li>
content-type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Spam-Score: -7.155
Received: from localhost (localhost [127.0.0.1]) by hipster.bestpractical.com (Postfix) with ESMTP id 6F6E52402CD for <cpan-bug+File-Path@hipster.bestpractical.com>; Thu, 8 Sep 2016 08:40:32 -0400 (EDT)
Received: from hipster.bestpractical.com ([127.0.0.1]) by localhost (hipster.bestpractical.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c9tVENf28rLq for <cpan-bug+File-Path@hipster.bestpractical.com>; Thu, 8 Sep 2016 08:40:30 -0400 (EDT)
Received: from la.mx.develooper.com (x1.develooper.com [207.171.7.70]) by hipster.bestpractical.com (Postfix) with SMTP id A53E724007A for <bug-File-Path@rt.cpan.org>; Thu, 8 Sep 2016 08:40:29 -0400 (EDT)
Received: (qmail 7873 invoked by alias); 8 Sep 2016 12:40:28 -0000
Received: from urchin.earth.li (HELO urchin.earth.li) (212.13.204.73) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Thu, 08 Sep 2016 05:40:26 -0700
Received: from dom by urchin.earth.li with local (Exim 4.84_2) (envelope-from <dom@urchin.earth.li>) id 1bhyct-0006mE-BV for bug-File-Path@rt.cpan.org; Thu, 08 Sep 2016 13:40:19 +0100
Delivered-To: cpan-bug+File-Path@hipster.bestpractical.com
Subject: Re: [rt.cpan.org #117620] [PATCH] Don't hardcode ENOENT
User-Agent: Mutt/1.5.23 (2014-03-12)
Return-Path: <dom@urchin.earth.li>
X-Spam-Check-BY: la.mx.develooper.com
X-Original-To: cpan-bug+File-Path@hipster.bestpractical.com
X-RT-Mail-Extension: file-path
Date: Thu, 8 Sep 2016 13:40:19 +0100
X-Spam-Level:
To: James E Keenan via RT <bug-File-Path@rt.cpan.org>
From: Dominic Hargreaves <dom@earth.li>
RT-Message-ID: <rt-4.0.18-26767-1473338433-699.117620-0-0@rt.cpan.org>
Content-Length: 613
On Thu, Sep 08, 2016 at 08:36:16AM -0400, James E Keenan via RT wrote:
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=117620 > > > On Thu Sep 08 05:21:21 2016, DOM wrote:
> > The attached patch, provided by Pino Toscano of the Debian project, > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > not 2. This fixes a regression between 2.11 and 2.12.
> > > Is there a Debian bug ticket or mailing list thread that we can reference for this?
There is a passing reference in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836892 but that's mainly about another issue. Dominic.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-4190-1473326481-751.0-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4190-1473326481-751.0-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-23335-1473820209-1580.117620-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 293
On Thu Sep 08 05:21:21 2016, DOM wrote:
Show quoted text
> The attached patch, provided by Pino Toscano of the Debian project, > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > not 2. This fixes a regression between 2.11 and 2.12.
Reference: https://github.com/rpcme/File-Path/pull/36
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-23335-1473820209-1580.117620-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4190-1473326481-751.0-0-0@rt.cpan.org> <rt-4.0.18-23335-1473820209-1580.117620-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-31870-1489007390-1093.117620-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 415
On Tue Sep 13 22:30:09 2016, JKEENAN wrote:
Show quoted text
> On Thu Sep 08 05:21:21 2016, DOM wrote:
> > The attached patch, provided by Pino Toscano of the Debian project, > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > not 2. This fixes a regression between 2.11 and 2.12.
> > > Reference: https://github.com/rpcme/File-Path/pull/36
Merged into rpcme/master Sep 16 2016, but awaits CPAN release.
MIME-Version: 1.0
In-Reply-To: <rt-4.0.18-31870-1489007390-1093.117620-0-0@rt.cpan.org>
X-Mailer: MIME-tools 5.504 (Entity 5.504)
Content-Disposition: inline
X-RT-Interface: Web
References: <rt-4.0.18-4190-1473326481-751.0-0-0@rt.cpan.org> <rt-4.0.18-23335-1473820209-1580.117620-0-0@rt.cpan.org> <rt-4.0.18-31870-1489007390-1093.117620-0-0@rt.cpan.org>
Content-Type: text/plain; charset="utf-8"
Message-ID: <rt-4.0.18-12057-1496278054-691.117620-0-0@rt.cpan.org>
Content-Transfer-Encoding: binary
X-RT-Original-Encoding: utf-8
X-RT-Encrypt: 0
X-RT-Sign: 0
Content-Length: 626
On Wed Mar 08 16:09:51 2017, JKEENAN wrote:
Show quoted text
> On Tue Sep 13 22:30:09 2016, JKEENAN wrote:
> > On Thu Sep 08 05:21:21 2016, DOM wrote:
> > > The attached patch, provided by Pino Toscano of the Debian project, > > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > > not 2. This fixes a regression between 2.11 and 2.12.
> > > > > > Reference: https://github.com/rpcme/File-Path/pull/36
> > Merged into rpcme/master Sep 16 2016, but awaits CPAN release.
This change has been released to CPAN as part of the release of File-Path 2.13 today. Marking ticket Resolved. Thank you very much. Jim Keenan


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.